190351 2018-10-08 09:32:11 -0700 REGRESSION (Safari 12): Download of Blob URL fails 2021-08-19 06:18:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Mac macOS 10.13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190408 https://bugs.webkit.org/show_bug.cgi?id=197441 InRadar, Regression P2 Critical --- 1 iain cdumez 673609957 achristensen Andy_Schmidt ashley bfulgham cdumez chris commit-queue dbates ews-watchlist felek.000 ggaren ihar.suvorau japhet rollofone webkit-bug-importer youennf zmyaro oldest_to_newest 1467061 0 351778 iain 2018-10-08 09:32:11 -0700 Created attachment 351778 Download methods Overview: In our webapp construct 3 users can download a copy of their project. When saving projects are serialized into a blob ( zip format ) on the client side. To download the file we create a Blob URL, attach it to a new HTMLAnchorElement, specify the "download" attribute as the file name ( "myproject.c3p" ) and use the HTMLElement.prototype.click function. This method works correctly in Safari 11 and in chrome. However, now it opens a new tab displaying a WebKitBlobResource error 1 and no further information. I think this may be related to the content blocker. On the first attempt to repeat this a "popup blocked" error will appear in the address bar and allowing it will download and unzip the project into a folder called "unknown" ( which I consider broken also ). Subsequent attempts will display the WebkitBlobResource error. I have attempted to create a simple replication for this, but even when copying the exact code into a new document and calling in the same fashion ( the development tools REPL ) it only repeats in the actual web application. I have included the download methods, but it's fairly standard stuff. Steps to reproduce: 1. Visit https://editor.construct.net 2. Select "new project" 3. Select "menu > project > save as > download a copy" 4. Select "ok" ( uses default name ) 5. Allow popup 6. Observe "unknown" folder appearing in downloads folder 7. Repeat steps 2 - 4 8. Observe error tab Actual results: A new tab displaying the error: Safari can't open the page "blob:https://editor.construct.net/[ blob id ]". The error is: "The operation couldn't be completed. (WebkitBlobResource error 1.)" (WebkitBlobResource:1) Expected Results: A new file in the downloads folder called "New project.c3p" 1467080 1 webkit-bug-importer 2018-10-08 09:56:20 -0700 <rdar://problem/45091181> 1467420 2 cdumez 2018-10-09 09:43:43 -0700 Issue seems to come from the fact that target=_blank is used: 1. This triggers Safari's popup blocker. If you allow the popup later on, the filename is wrong because Safari does not know about the download attribute. 2. If popups are allowed, WebKit tries to *load* the blob instead of *downloading* it, thus the network error. This is due to a bug in our createNewWindow code path which I will fix. 1467424 3 351882 cdumez 2018-10-09 09:52:35 -0700 Created attachment 351882 Patch 1467432 4 cdumez 2018-10-09 10:00:25 -0700 In a follow-up, I will look into ignoring the target when the download attribute is present. The HTML spec says to download the hyperlink instead of following the hyperlink. Only the "following the hyperlink" algorithm checks the frame name. 1467433 5 351882 ggaren 2018-10-09 10:01:38 -0700 Comment on attachment 351882 Patch r=me 1467446 6 ashley 2018-10-09 10:20:45 -0700 Ah, thanks for the tip about target=_blank - setting target=_self on any download attribute links seems to work around it. We'll ship this workaround soon so to continue reproducing the issue use the following link which will use a specific version of our PWA: https://editor.construct.net/r121/ 1467460 7 351891 cdumez 2018-10-09 10:42:55 -0700 Created attachment 351891 Patch 1467466 8 cdumez 2018-10-09 10:45:05 -0700 (In reply to Ashley Gullen from comment #6) > Ah, thanks for the tip about target=_blank - setting target=_self on any > download attribute links seems to work around it. We'll ship this workaround > soon so to continue reproducing the issue use the following link which will > use a specific version of our PWA: https://editor.construct.net/r121/ Great, thanks. 1467489 9 351891 commit-queue 2018-10-09 11:25:39 -0700 Comment on attachment 351891 Patch Clearing flags on attachment: 351891 Committed r236970: <https://trac.webkit.org/changeset/236970> 1467490 10 commit-queue 2018-10-09 11:25:41 -0700 All reviewed patches have been landed. Closing bug. 1467520 11 cdumez 2018-10-09 12:37:43 -0700 Follow-up to avoid Safari's popup blocking at Bug 190408. 1531573 12 rollofone 2019-04-30 10:39:01 -0700 Unfortunately - it's not fixed. We are running into the same problem. A blob is assembled in Javascript, it's set into a download-URL with download attribute and it can be downloaded with Chrome, Firefox and Epiphany (webkit2gtk-4.0). We are not using frames, there's no difference with target="_self" or no target attribute, the error appears regardless of Content-Security-Settings and there is no warning or error on the console. Safari just opens a new tab and displays the "WebKitBlobResource error 1.). It worked fine in previous versions of Safari (on MacOS). Copying the generated BLOB:url into safari's URL bar allows the download of the data. Safari Version 12.1 (14607.1.40.1.4) 1531592 13 ashley 2019-04-30 11:08:36 -0700 You should probably file a new issue for that, it sounds different to this one if the target doesn't affect it. 1531594 14 rollofone 2019-04-30 11:12:50 -0700 It seems to be related as it behaves exactly like the original bug as posted. Only difference: We are not using iframe and target attributes. We tried with target="_self" but that didn't influence the bug. Safari just opens a new tab and displays the error. 1531616 15 rollofone 2019-04-30 11:54:36 -0700 Here's an update to the bug: Test on Image in blob. I can .. right click open the context-menu for a blob URL and .. Open in new tab: Displays Image .. Open in new page: Displays Image .. Download: Downloads the image The *only* bug is that Safari opens a new tab after clicking the "a href" and displays the WebKitBlobResource error 1. It completely ignores the download attribute (for this blob) and it opens a new tab for now reason. 1531641 16 ashley 2019-04-30 12:53:17 -0700 I really think you should file a new issue. This is a closed issue and people tend to stop looking at them once they're marked fixed. And it's entirely possible there are two separate problems with similar looking symptoms. 1531703 17 cdumez 2019-04-30 14:13:20 -0700 (In reply to Ashley Gullen from comment #16) > I really think you should file a new issue. This is a closed issue and > people tend to stop looking at them once they're marked fixed. And it's > entirely possible there are two separate problems with similar looking > symptoms. Yes, please file a new bug with your repro steps and cc me. 1647928 18 Andy_Schmidt 2020-05-01 11:03:58 -0700 New bug created for the never-fixed additional circumstances: https://bugs.webkit.org/show_bug.cgi?id=211234 Still happening as recent as Safari 13.1 on iOS 13.4. 1647929 19 Andy_Schmidt 2020-05-01 11:04:48 -0700 (In reply to Chris Dumez from comment #17) > (In reply to Ashley Gullen from comment #16) > > I really think you should file a new issue. This is a closed issue and > > people tend to stop looking at them once they're marked fixed. And it's > > entirely possible there are two separate problems with similar looking > > symptoms. > > Yes, please file a new bug with your repro steps and cc me. New bug created for the never-fixed additional circumstances: https://bugs.webkit.org/show_bug.cgi?id=211234 Still happening as recent as Safari 13.1 on iOS 13.4. 1773070 20 ihar.suvorau 2021-06-28 08:03:51 -0700 The issues is still relevant in Safari 14.2, WebKit 16612.1.17.10.5 and Version 14.1.1 (16611.2.7.1.4) on macOS 11.4 (20F71). The workaround to create a workable link was to add the "download" attribute to a-tag: <a href=blobURL download=file.name>text</a> In that way Safari downloads a file without following the link. 351778 2018-10-08 09:32:11 -0700 2018-10-08 09:32:11 -0700 Download methods test.js text/javascript 1512 iain d2luZG93LkMzID0ge307DQoJCQkNCkMzLkRvd25sb2FkID0gZnVuY3Rpb24gRG93bmxvYWQoZmls ZW5hbWUsIHVybCkNCnsNCglDMy5SZXF1aXJlU3RyaW5nKGZpbGVuYW1lKTsNCglDMy5SZXF1aXJl U3RyaW5nKHVybCk7DQoNCglyZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUsIHJlamVjdCkgPT4N Cgl7DQoJCWNvbnN0IGEgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJhIik7DQoJCWEudGV4dENv bnRlbnQgPSBmaWxlbmFtZTsNCgkJYS5ocmVmID0gdXJsOw0KCQlhLmRvd25sb2FkID0gZmlsZW5h bWU7DQoJCWRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoYSk7DQoJCWEuY2xpY2soKTsNCgkJZG9j dW1lbnQuYm9keS5yZW1vdmVDaGlsZChhKTsNCg0KCQkvLyByZXNvbHZlIG5leHQgdGljaw0KCQl3 aW5kb3cuc2V0VGltZW91dChyZXNvbHZlLCAxNik7DQoJfSk7DQp9Ow0KDQpDMy5Jc1N0cmluZyA9 IGZ1bmN0aW9uIElzU3RyaW5nKHgpDQp7DQoJcmV0dXJuIHR5cGVvZiB4ID09PSAic3RyaW5nIjsN Cn07DQoNCkMzLlJlcXVpcmVTdHJpbmcgPSBmdW5jdGlvbiBSZXF1aXJlU3RyaW5nKHgpDQp7DQoJ aWYgKCFDMy5Jc1N0cmluZyh4KSkNCgkJdGhyb3cgbmV3IFR5cGVFcnJvcigiZXhwZWN0ZWQgc3Ry aW5nIik7DQp9Ow0KDQpDMy5Jc0luc3RhbmNlT2YgPSBmdW5jdGlvbiBJc0luc3RhbmNlT2YoeCwg dCkNCnsNCglyZXR1cm4gKHggaW5zdGFuY2VvZiB0KTsNCn0NCg0KQzMuUmVxdWlyZUluc3RhbmNl T2YgPSBmdW5jdGlvbiBSZXF1aXJlSW5zdGFuY2VPZih4LCB0KQ0Kew0KCWlmICghQzMuSXNJbnN0 YW5jZU9mKHgsIHQpKQ0KCQl0aHJvdyBuZXcgVHlwZUVycm9yKCJ1bmV4cGVjdGVkIHR5cGUiKTsN Cn07DQoNCi8vIEludm9rZSBhIGRvd25sb2FkIG9mIGEgYmxvYiB3aXRoIGEgZ2l2ZW4gZmlsZW5h bWUuDQpDMy5Eb3dubG9hZEJsb2IgPSBmdW5jdGlvbiBEb3dubG9hZEJsb2IoZmlsZW5hbWUsIGJs b2IpDQp7DQoJQzMuUmVxdWlyZVN0cmluZyhmaWxlbmFtZSk7DQoJQzMuUmVxdWlyZUluc3RhbmNl T2YoYmxvYiwgQmxvYik7DQoNCglsZXQgYmxvYlVybCA9IFVSTC5jcmVhdGVPYmplY3RVUkwoYmxv Yik7DQoNCgkvLyBUaGVyZSdzIG5vIGdvb2Qgd2F5IHRvIHRlbGwgd2hlbiB0aGUgZG93bmxvYWQg aGFzIGZpbmlzaGVkIGFuZCB0aGUgYmxvYiBVUkwgY2FuIGJlIHJldm9rZWQuDQoJLy8gU2luY2Ug dGhlIGJsb2IgaXMgbG9jYWwgaXQgaXMgbGlrZWx5IHRvIGRvd25sb2FkIGFsbW9zdCBpbnN0YW50 bHksIGJ1dCB0byBiZSBhYnNvbHV0ZWx5IHN1cmUgaXQNCgkvLyBjYW4gZmluaXNoIGRvd25sb2Fk aW5nIHdoaWxlIGFsc28gbm90IGxlYWtpbmcgYmxvYiBVUkxzIGluIHRoZSBsb25nIHRlcm0sIHJl dm9rZSB0aGUgYmxvYiBVUkwNCgkvLyBhZnRlciA2MCBzZWNvbmRzLg0KCXNldFRpbWVvdXQoKCkg PT4gVVJMLnJldm9rZU9iamVjdFVSTChibG9iVXJsKSwgNjAwMDApOw0KDQoJcmV0dXJuIEMzLkRv d25sb2FkKGZpbGVuYW1lLCBibG9iVXJsKTsNCn07 351882 2018-10-09 09:52:35 -0700 2018-10-09 10:42:53 -0700 Patch bug-190351-20181009095235.patch text/plain 4847 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGIyZTQyNDcwNzUyYmVj ODlkZGMyNjk2ZTNmYjNiODcxZDYzMGY0NS4uZjhmZGVmNmE0YzQ5MWQ2OGIzYjA4Njg0NGU0MzJl MzljMTA0YTU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEwLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoU2FmYXJp IDEyKTogRG93bmxvYWQgb2YgQmxvYiBVUkwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDM1MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDUwOTExODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiB1c2luZyBib3RoIHRoZSBkb3dubG9hZCBhdHRyaWJ1dGUgYW5kIHRhcmdldD0iX2Js YW5rIiBvbiBhbiBhbmNob3IgZWxlbWVudCwgd2Ugd291bGQKKyAgICAgICAgbWlzdGFrZW5seSBk cm9wIHRoZSBkb3dubG9hZCBhdHRyaWJ1dGUgYWZ0ZXIgdGhlICJuZXcgd2luZG93IiBwb2xpY3kg ZGVjaXNpb24gaGFzIGJlZW4gbWFkZS4KKyAgICAgICAgQXMgYSByZXN1bHQsIHdlIHdvdWxkIHRy eSB0byBsb2FkIHRoZSBibG9iIGluc3RlYWQgb2YgZG93bmxvYWRpbmcgaXQuCisKKyAgICAgICAg VGVzdDogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9h ZC1ibGFuay10YXJnZXQuaHRtbAorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjb250aW51ZUxvYWRBZnRlck5ld1dpbmRv d1BvbGljeSk6CisKIDIwMTgtMTAtMDkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBJY2VDYW5kaWRhdGUgc3RhdHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGY4MmE2NzcxMDY5OTZlNWIzZmExOTk0NjNi MDU4ZDQ4NmRkOGM4M2QuLmRmMzJkN2QzYzYwMjM1NjAwYzNiMGZjZTUyNDM1NTgxMTZmNjNjYmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzM5Niw3ICszMzk2LDcg QEAgdm9pZCBGcmFtZUxvYWRlcjo6Y29udGludWVMb2FkQWZ0ZXJOZXdXaW5kb3dQb2xpY3koY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXMKICAgICAgICAgbWFpbkZyYW1lLT5kb2N1bWVudCgp LT5zZXRSZWZlcnJlclBvbGljeShmcmFtZS0+ZG9jdW1lbnQoKS0+cmVmZXJyZXJQb2xpY3koKSk7 CiAgICAgfQogCi0gICAgTmF2aWdhdGlvbkFjdGlvbiBuZXdBY3Rpb24geyAqZnJhbWUtPmRvY3Vt ZW50KCksIHJlcXVlc3QsIEluaXRpYXRlZEJ5TWFpbkZyYW1lOjpVbmtub3duLCBOYXZpZ2F0aW9u VHlwZTo6T3RoZXIsIGFjdGlvbi5zaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5KCkgfTsKKyAg ICBOYXZpZ2F0aW9uQWN0aW9uIG5ld0FjdGlvbiB7ICpmcmFtZS0+ZG9jdW1lbnQoKSwgcmVxdWVz dCwgSW5pdGlhdGVkQnlNYWluRnJhbWU6OlVua25vd24sIE5hdmlnYXRpb25UeXBlOjpPdGhlciwg YWN0aW9uLnNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3koKSwgbnVsbHB0ciwgYWN0aW9uLmRv d25sb2FkQXR0cmlidXRlKCkgfTsKICAgICBtYWluRnJhbWUtPmxvYWRlcigpLmxvYWRXaXRoTmF2 aWdhdGlvbkFjdGlvbihyZXF1ZXN0LCBXVEZNb3ZlKG5ld0FjdGlvbiksIExvY2tIaXN0b3J5OjpO bywgRnJhbWVMb2FkVHlwZTo6U3RhbmRhcmQsIGZvcm1TdGF0ZSwgYWxsb3dOYXZpZ2F0aW9uVG9J bnZhbGlkVVJMKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg2ZWY0ZmRmYjdmZjM4OGY0NzI3MDc3OTMyNzM0ZDIz MTUyYjE2NTguLmM3MTAwMzQxNWVjYTY0ZmNhZWUwODNmNzM1ZTgwNTA1Mzc1MmMwNTggMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMC0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKFNhZmFyaSAxMik6IERvd25sb2FkIG9mIEJsb2Ig VVJMIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTAzNTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1MDkxMTgxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3Zl cmFnZS4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxl LWJsb2ItZG93bmxvYWQtYmxhbmstdGFyZ2V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9hZC1i bGFuay10YXJnZXQuaHRtbDogQWRkZWQuCisKIDIwMTgtMTAtMDkgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBJY2VDYW5kaWRhdGUg c3RhdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50 L2FuY2hvci1maWxlLWJsb2ItZG93bmxvYWQtYmxhbmstdGFyZ2V0LWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2ItZG93 bmxvYWQtYmxhbmstdGFyZ2V0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44YTBlNWZmYzBjZmY3 NDUyNmZiNDEyNjIwMTFiMjA5MDk0NjlkODU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9hZC1i bGFuay10YXJnZXQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorRG93bmxvYWQgc3RhcnRl ZC4KK0Rvd25sb2FkaW5nIFVSTCB3aXRoIHN1Z2dlc3RlZCBmaWxlbmFtZSAiYWJlLnBuZyIKK0Rv d25sb2FkIGNvbXBsZXRlZC4KK1RoZSBzdWdnZXN0ZWQgZmlsZW5hbWUgYWJvdmUgc2hvdWxkIGJl ICJhYmUucG5nIiBhbmQgdGhlIGRvd25sb2FkIHNob3VsZCBzdWNjZWVkLgorCitGaWxlIGJhY2tl ZCBibG9iIFVSTApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVs ZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9hZC1ibGFuay10YXJnZXQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2ItZG93bmxv YWQtYmxhbmstdGFyZ2V0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmQxN2RlNmZhYWNiZmEyZWFjOTBiMGJi YjNhYzlkYmY2NzA4OTc1NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2ItZG93bmxvYWQtYmxhbmstdGFyZ2V0 Lmh0bWwKQEAgLTAsMCArMSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKyAgdGVzdFJ1bm5lci5zZXRDYW5PcGVuV2luZG93cygpOworICB0ZXN0UnVubmVyLnNl dFNob3VsZExvZ0Rvd25sb2FkQ2FsbGJhY2tzKHRydWUpOworICB0ZXN0UnVubmVyLndhaXRVbnRp bERvd25sb2FkRmluaXNoZWQoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5U aGUgc3VnZ2VzdGVkIGZpbGVuYW1lIGFib3ZlIHNob3VsZCBiZSAiYWJlLnBuZyIgYW5kIHRoZSBk b3dubG9hZCBzaG91bGQgc3VjY2VlZC48L3A+Cis8YSBpZD0iYmxvYi11cmwiIGRvd25sb2FkPSJh YmUucG5nIiB0YXJnZXQ9Il9ibGFuayI+RmlsZSBiYWNrZWQgYmxvYiBVUkw8L2E+Cis8c2NyaXB0 PgorZnVuY3Rpb24gY2xpY2soZWxtdCkKK3sKKyAgICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikg eworICAgICAgICBhbGVydCgnQ2xpY2sgdGhlIGxpbmsgdG8gcnVuIHRoZSB0ZXN0LicpOworICAg ICAgICByZXR1cm47CisgICAgfQorICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGVsbXQub2Zm c2V0TGVmdCArIDUsIGVsbXQub2Zmc2V0VG9wICsgNSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VE b3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworfQorCitmdW5jdGlvbiBydW5UZXN0 KCkKK3sKKyAgICBmaWxlID0gaW50ZXJuYWxzLmNyZWF0ZUZpbGUoIi4uL3Jlc291cmNlcy9hYmUu cG5nIik7CisgICAgdmFyIGxpbmsgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYmxvYi11cmwi KTsKKyAgICBsaW5rLmhyZWYgPSB3aW5kb3cuVVJMLmNyZWF0ZU9iamVjdFVSTChmaWxlKTsKKyAg ICBjbGljayhsaW5rKTsKK30KK3J1blRlc3QoKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo= 351891 2018-10-09 10:42:55 -0700 2018-10-09 11:25:39 -0700 Patch bug-190351-20181009104252.patch text/plain 6924 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYxODdkMGE2OTFmMmRh MGFmM2QwNzg5YmMzMWMwMDJhZTRlZTAyNi4uODI0MTUyZjc2MzRiNGE0ZGU1ZTlkOGRiZmFmN2Nm NGEyNDAyM2I2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEwLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoU2FmYXJp IDEyKTogRG93bmxvYWQgb2YgQmxvYiBVUkwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDM1MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDUwOTExODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCisKKyAgICAg ICAgV2hlbiB1c2luZyBib3RoIHRoZSBkb3dubG9hZCBhdHRyaWJ1dGUgYW5kIHRhcmdldD0iX2Js YW5rIiBvbiBhbiBhbmNob3IgZWxlbWVudCwgd2Ugd291bGQKKyAgICAgICAgbWlzdGFrZW5seSBk cm9wIHRoZSBkb3dubG9hZCBhdHRyaWJ1dGUgYWZ0ZXIgdGhlICJuZXcgd2luZG93IiBwb2xpY3kg ZGVjaXNpb24gaGFzIGJlZW4gbWFkZS4KKyAgICAgICAgQXMgYSByZXN1bHQsIHdlIHdvdWxkIHRy eSB0byBsb2FkIHRoZSBibG9iIGluc3RlYWQgb2YgZG93bmxvYWRpbmcgaXQuCisKKyAgICAgICAg VGVzdDogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9h ZC1ibGFuay10YXJnZXQuaHRtbAorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjb250aW51ZUxvYWRBZnRlck5ld1dpbmRv d1BvbGljeSk6CisKIDIwMTgtMTAtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBIYXZlIERPTVdpbmRvdyBnZXQgaXRzIGZyYW1lIGZyb20gaXRzIGRvY3VtZW50 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBmODJhNjc3MTA2OTk2ZTVi M2ZhMTk5NDYzYjA1OGQ0ODZkZDhjODNkLi5kZjMyZDdkM2M2MDIzNTYwMGMzYjBmY2U1MjQzNTU4 MTE2ZjYzY2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTMzOTYs NyArMzM5Niw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbnRpbnVlTG9hZEFmdGVyTmV3V2luZG93 UG9saWN5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzCiAgICAgICAgIG1haW5GcmFtZS0+ ZG9jdW1lbnQoKS0+c2V0UmVmZXJyZXJQb2xpY3koZnJhbWUtPmRvY3VtZW50KCktPnJlZmVycmVy UG9saWN5KCkpOwogICAgIH0KIAotICAgIE5hdmlnYXRpb25BY3Rpb24gbmV3QWN0aW9uIHsgKmZy YW1lLT5kb2N1bWVudCgpLCByZXF1ZXN0LCBJbml0aWF0ZWRCeU1haW5GcmFtZTo6VW5rbm93biwg TmF2aWdhdGlvblR5cGU6Ok90aGVyLCBhY3Rpb24uc2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGlj eSgpIH07CisgICAgTmF2aWdhdGlvbkFjdGlvbiBuZXdBY3Rpb24geyAqZnJhbWUtPmRvY3VtZW50 KCksIHJlcXVlc3QsIEluaXRpYXRlZEJ5TWFpbkZyYW1lOjpVbmtub3duLCBOYXZpZ2F0aW9uVHlw ZTo6T3RoZXIsIGFjdGlvbi5zaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5KCksIG51bGxwdHIs IGFjdGlvbi5kb3dubG9hZEF0dHJpYnV0ZSgpIH07CiAgICAgbWFpbkZyYW1lLT5sb2FkZXIoKS5s b2FkV2l0aE5hdmlnYXRpb25BY3Rpb24ocmVxdWVzdCwgV1RGTW92ZShuZXdBY3Rpb24pLCBMb2Nr SGlzdG9yeTo6Tm8sIEZyYW1lTG9hZFR5cGU6OlN0YW5kYXJkLCBmb3JtU3RhdGUsIGFsbG93TmF2 aWdhdGlvblRvSW52YWxpZFVSTCk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4NmVmNGZkZmI3ZmYzODhmNDcyNzA3 NzkzMjczNGQyMzE1MmIxNjU4Li4xMTRiZDZlMmVkYjczZGQ4OTU2ZmFjNzBiN2NmMTRjYzliYmMz YWY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTAtMDkgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChTYWZhcmkgMTIpOiBEb3dubG9h ZCBvZiBCbG9iIFVSTCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkwMzUxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTA5MTE4MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KKworICAgICAgICBBZGQgbGF5b3V0 IHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9h bmNob3ItZmlsZS1ibG9iLWRvd25sb2FkLWJsYW5rLXRhcmdldC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2It ZG93bmxvYWQtYmxhbmstdGFyZ2V0Lmh0bWw6IEFkZGVkLgorCiAyMDE4LTEwLTA5ICBZb3Vlbm4g RmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgSWNl Q2FuZGlkYXRlIHN0YXRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9hbmNob3ItZmlsZS1ibG9iLWRvd25sb2FkLWJsYW5rLXRhcmdldC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZmls ZS1ibG9iLWRvd25sb2FkLWJsYW5rLXRhcmdldC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGEw ZTVmZmMwY2ZmNzQ1MjZmYjQxMjYyMDExYjIwOTA5NDY5ZDg1NAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2It ZG93bmxvYWQtYmxhbmstdGFyZ2V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAKK0Rvd25s b2FkIHN0YXJ0ZWQuCitEb3dubG9hZGluZyBVUkwgd2l0aCBzdWdnZXN0ZWQgZmlsZW5hbWUgImFi ZS5wbmciCitEb3dubG9hZCBjb21wbGV0ZWQuCitUaGUgc3VnZ2VzdGVkIGZpbGVuYW1lIGFib3Zl IHNob3VsZCBiZSAiYWJlLnBuZyIgYW5kIHRoZSBkb3dubG9hZCBzaG91bGQgc3VjY2VlZC4KKwor RmlsZSBiYWNrZWQgYmxvYiBVUkwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hU TUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2ItZG93bmxvYWQtYmxhbmstdGFyZ2V0Lmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZmlsZS1i bG9iLWRvd25sb2FkLWJsYW5rLXRhcmdldC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZkMTdkZTZmYWFjYmZh MmVhYzkwYjBiYmIzYWM5ZGJmNjcwODk3NTUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZmlsZS1ibG9iLWRvd25sb2FkLWJs YW5rLXRhcmdldC5odG1sCkBAIC0wLDAgKzEsMzggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7CisgIHRlc3RSdW5uZXIuc2V0Q2FuT3BlbldpbmRvd3MoKTsKKyAgdGVz dFJ1bm5lci5zZXRTaG91bGRMb2dEb3dubG9hZENhbGxiYWNrcyh0cnVlKTsKKyAgdGVzdFJ1bm5l ci53YWl0VW50aWxEb3dubG9hZEZpbmlzaGVkKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorPHA+VGhlIHN1Z2dlc3RlZCBmaWxlbmFtZSBhYm92ZSBzaG91bGQgYmUgImFiZS5wbmci IGFuZCB0aGUgZG93bmxvYWQgc2hvdWxkIHN1Y2NlZWQuPC9wPgorPGEgaWQ9ImJsb2ItdXJsIiBk b3dubG9hZD0iYWJlLnBuZyIgdGFyZ2V0PSJfYmxhbmsiPkZpbGUgYmFja2VkIGJsb2IgVVJMPC9h PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGNsaWNrKGVsbXQpCit7CisgICAgaWYgKCF3aW5kb3cuZXZl bnRTZW5kZXIpIHsKKyAgICAgICAgYWxlcnQoJ0NsaWNrIHRoZSBsaW5rIHRvIHJ1biB0aGUgdGVz dC4nKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVU byhlbG10Lm9mZnNldExlZnQgKyA1LCBlbG10Lm9mZnNldFRvcCArIDUpOworICAgIGV2ZW50U2Vu ZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KKworZnVuY3Rp b24gcnVuVGVzdCgpCit7CisgICAgZmlsZSA9IGludGVybmFscy5jcmVhdGVGaWxlKCIuLi9yZXNv dXJjZXMvYWJlLnBuZyIpOworICAgIHZhciBsaW5rID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImJsb2ItdXJsIik7CisgICAgbGluay5ocmVmID0gd2luZG93LlVSTC5jcmVhdGVPYmplY3RVUkwo ZmlsZSk7CisgICAgY2xpY2sobGluayk7Cit9CitydW5UZXN0KCk7Cis8L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCA4M2VkNmU1OTYxNWFmYjk5ZDBkZDgwNmIzMzM1ZDY1ZGU4N2Y0YmJmLi44Nzgy ZDQyZjc3OWM4ODE4NzQ0YzY0ZDhhZjM0YzJlYzBiNmUyYjNkIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMDcsNiArMzA3LDcgQEAgd2Vi a2l0Lm9yZy9iLzE1NjA2OSBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZG93bmxv YWQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE1NjA2OSBmYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9hbmNob3ItZG93bmxvYWQtc3ludGhldGljLWNsaWNrLmh0bWwgWyBTa2lwIF0K IHdlYmtpdC5vcmcvYi8xNTYwNjkgZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWRv d25sb2FkLXVzZXItdHJpZ2dlcmVkLXN5bnRoZXRpYy1jbGljay5odG1sIFsgU2tpcCBdCiB3ZWJr aXQub3JnL2IvMTU2MDY5IGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJs b2ItZG93bmxvYWQuaHRtbCBbIFNraXAgXQord2Via2l0Lm9yZy9iLzE1NjA2OSBmYXN0L2RvbS9I VE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZmlsZS1ibG9iLWRvd25sb2FkLWJsYW5rLXRhcmdldC5o dG1sIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTU2MDY5IGZhc3QvZG9tL0hUTUxBbmNob3JFbGVt ZW50L2FuY2hvci1maWxlLWJsb2ItZG93bmxvYWQtaW5jbHVkZXMtYmFja3NsYXNoLmh0bWwgWyBT a2lwIF0KIHdlYmtpdC5vcmcvYi8xNTYwNjkgZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5j aG9yLWZpbGUtYmxvYi1kb3dubG9hZC1pbmNsdWRlcy1kb3VibGVxdW90ZS5odG1sIFsgU2tpcCBd CiB3ZWJraXQub3JnL2IvMTU2MDY5IGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1m aWxlLWJsb2ItZG93bmxvYWQtaW5jbHVkZXMtc2xhc2hlcy5odG1sIFsgU2tpcCBdCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDc2M2UwNzNkMmVhYzM4MWI3 MGFkNDY5ZTg3ZTE1N2ExMDcyZTQ5MmQuLjBjY2YxYTU1MTg1MjkwNjhkYWY1MTcwMWMzN2Q5OGEz Y2M3MTY3OWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCkBA IC00NTUsNiArNDU1LDcgQEAgZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWRvd25s b2FkLXVuc2V0Lmh0bWwgWyBTa2lwIF0KIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hv ci1kb3dubG9hZC1zeW50aGV0aWMtY2xpY2suaHRtbCBbIFNraXAgXQogZmFzdC9kb20vSFRNTEFu Y2hvckVsZW1lbnQvYW5jaG9yLWRvd25sb2FkLXVzZXItdHJpZ2dlcmVkLXN5bnRoZXRpYy1jbGlj ay5odG1sIFsgU2tpcCBdCiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZmlsZS1i bG9iLWRvd25sb2FkLmh0bWwgWyBTa2lwIF0KK2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2Fu Y2hvci1maWxlLWJsb2ItZG93bmxvYWQtYmxhbmstdGFyZ2V0Lmh0bWwgWyBTa2lwIF0KIGZhc3Qv ZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1maWxlLWJsb2ItZG93bmxvYWQtaW5jbHVkZXMt YmFja3NsYXNoLmh0bWwgWyBTa2lwIF0KIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hv ci1maWxlLWJsb2ItZG93bmxvYWQtaW5jbHVkZXMtZG91YmxlcXVvdGUuaHRtbCBbIFNraXAgXQog ZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWZpbGUtYmxvYi1kb3dubG9hZC1pbmNs dWRlcy1zbGFzaGVzLmh0bWwgWyBTa2lwIF0K