190330 2018-10-06 10:43:43 -0700 Web Inspector: detail view is not re-shown after sorting the Network table 2018-10-11 12:26:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190362 1 hi hi bburg commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1466882 0 hi 2018-10-06 10:43:43 -0700 * STEPS TO REPRODUCE 1. Inspect <https://apple.com> 2. Select the Network tab 3. Refresh the page 4. Select any resource to show it's detail view 5. Click the "Name" column header to change the sort => The same resource is still selected after re-sorting, but the detail view disappears, showing the Table selection 1467050 1 webkit-bug-importer 2018-10-08 08:57:19 -0700 <rdar://problem/45089607> 1467782 2 351978 hi 2018-10-10 11:38:48 -0700 Created attachment 351978 Patch 1467792 3 351978 mattbaker 2018-10-10 12:10:18 -0700 Comment on attachment 351978 Patch r-, as applying the patch causes an uncaught exception. Steps to Reproduce: 1. Goto daringfireball.bnet 2. Network tab > select the first row 3. Sort the Name column => Uncaught exception: TypeError:​ this._showDetailView is not a function. (In 'this._showDetailView(this._selectedObject)​', 'this._showDetailView' is undefined)​ (at NetworkTableContentView.js:​1681:​29)​ _restoreSelectedRow @ NetworkTableContentView.js:​1681:​29 _updateFilteredEntries @ NetworkTableContentView.js:​1552:​33 tableSortChanged @ NetworkTableContentView.js:​337:​36 sortOrder @ Table.js:​160:​50 _handleHeaderCellClicked @ Table.js:​1308:​13 _handleHeaderCellClicked @ [native code]​ 1467793 4 mattbaker 2018-10-10 12:10:51 -0700 (In reply to Matt Baker from comment #3) > Comment on attachment 351978 [details] > Patch > > r-, as applying the patch causes an uncaught exception. > > Steps to Reproduce: > 1. Goto daringfireball.bnet Or even daringfireball.net 1467814 5 hi 2018-10-10 13:37:15 -0700 Whoops. I uploaded a version of this that used changes from <https://webkit.org/b/189773>. I'll reupload. 1467967 6 352019 hi 2018-10-10 22:34:26 -0700 Created attachment 352019 Patch Rebase 1468104 7 352019 mattbaker 2018-10-11 12:00:10 -0700 Comment on attachment 352019 Patch r=me 1468109 8 352019 commit-queue 2018-10-11 12:26:35 -0700 Comment on attachment 352019 Patch Clearing flags on attachment: 352019 Committed r237043: <https://trac.webkit.org/changeset/237043> 1468110 9 commit-queue 2018-10-11 12:26:37 -0700 All reviewed patches have been landed. Closing bug. 351978 2018-10-10 11:38:48 -0700 2018-10-10 22:34:24 -0700 Patch 190330.diff text/plain 1334 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkZDdhNDdkNDk1Li4zZWQ0MDNkOWM3NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMTAgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGRl dGFpbCB2aWV3IGlzIG5vdCByZS1zaG93biBhZnRlciBzb3J0aW5nIHRoZSBOZXR3b3JrIHRhYmxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAzMzAK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1MDg5NjA3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3Jr VGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3 LnByb3RvdHlwZS5fcmVzdG9yZVNlbGVjdGVkUm93KToKKwogMjAxOC0xMC0xMCAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTjogc2VsZWN0aW9uIGluIG5ldHdvcmsgdGFibGUgaXMgbG9zdCB3aGVuIG5ldyBlbnRyaWVz IGFyZSBhZGRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCBh YTk3NDI2NThlNC4uNGQ0ZTJiNDE5Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRl bnRWaWV3LmpzCkBAIC0xNzk5LDYgKzE3OTksNyBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50Vmll dyA9IGNsYXNzIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQog ICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fdGFibGUuc2VsZWN0Um93KHJvd0luZGV4KTsKKyAg ICAgICAgdGhpcy5fc2hvd0RldGFpbFZpZXcodGhpcy5fc2VsZWN0ZWRPYmplY3QpOwogICAgIH0K IAogICAgIF9IQVJSZXNvdXJjZXMoKQo= 352019 2018-10-10 22:34:26 -0700 2018-10-11 12:26:35 -0700 Patch bug-190330-20181010223425.patch text/plain 1426 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM2NzE4YTdmNDgxZjRhM2NmNTQ5MjNhOTNlYzJh YmFiNzViY2QzOTcuLmZmYTBlZGE4MThkYWQyNmU0MDBkNDM5YTdhNTIyZmY5NzFhMmIzZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEwLTEwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBk ZXRhaWwgdmlldyBpcyBub3QgcmUtc2hvd24gYWZ0ZXIgc29ydGluZyB0aGUgTmV0d29yayB0YWJs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMzMw CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTA4OTYwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29y a1RhYmxlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmll dy5wcm90b3R5cGUuX3Jlc3RvcmVTZWxlY3RlZFJvdyk6CisKIDIwMTgtMTAtMTAgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNyZWF0 ZSBzcGVjaWFsIE5ldHdvcmsgd2F0ZXJmYWxsIGZvciBtZWRpYSBldmVudHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggMDg3MDNjYTdiODAwOTEwNDZmMmE2MmE0 YjZkOGFmMDUyYTFkODFkZi4uMzI5MTQ0MDRjZTdkN2ZlOTA5NTBmOGYxOWRmYWY2OWQyNTc3YjQ4 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKQEAgLTE3NzUsNiAr MTc3NSw3IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya1RhYmxl Q29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAgICAgICAgIH0KIAogICAgICAgICB0 aGlzLl90YWJsZS5zZWxlY3RSb3cocm93SW5kZXgpOworICAgICAgICB0aGlzLl9zaG93RGV0YWls Vmlldyh0aGlzLl9zZWxlY3RlZE9iamVjdCk7CiAgICAgfQogCiAgICAgX0hBUlJlc291cmNlcygp Cg==