190241 2018-10-03 02:42:07 -0700 [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment 2019-01-01 10:26:24 -0800 1 1 1 Unclassified WebKit Tools / Tests Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 191196 1 mcatanzaro mcatanzaro aperez bugs-noreply cgarcia commit-queue lforschler mcatanzaro ross.kirsling tsaunier webkit-bug-importer oldest_to_newest 1465975 0 mcatanzaro 2018-10-03 02:42:07 -0700 I'm using a jhbuild environment, NOT webkit-flatpak. Every time I run run-minibrowser it prints this: $ run-minibrowser --gtk You need to install flatpak-builder >= 0.10.0 to be able to use the '/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkit-flatpak' script. You can find some informations about how to install it for your distribution at: * http://flatpak.org/ And it creates GTK/ and UserFlatpak/ subdirectories under my build directory. If I delete them, they are created again the next time I run run-minibrowser. 1466008 1 tsaunier 2018-10-03 04:06:36 -0700 You somehow have a trailling flatpak env? 1466049 2 mcatanzaro 2018-10-03 07:17:16 -0700 No, I delete it before running run-minibrowser. run-minibrowser is creating it. 1474513 3 mcatanzaro 2018-11-02 09:24:19 -0700 Thibault, can you look into this please? 1486457 4 mcatanzaro 2018-12-09 15:06:33 -0800 Problem is flatpakutils.py unconditionally creates the directories, but should do so only when called with --available. 1486458 5 356930 mcatanzaro 2018-12-09 15:09:39 -0800 Created attachment 356930 Patch 1486459 6 ross.kirsling 2018-12-09 15:13:16 -0800 Nice! I noticed this happening for WinCairo too but hadn't looked into why. 1486547 7 356930 commit-queue 2018-12-10 06:58:39 -0800 Comment on attachment 356930 Patch Clearing flags on attachment: 356930 Committed r239028: <https://trac.webkit.org/changeset/239028> 1486548 8 commit-queue 2018-12-10 06:58:41 -0800 All reviewed patches have been landed. Closing bug. 1486549 9 webkit-bug-importer 2018-12-10 06:59:26 -0800 <rdar://problem/46594304> 1486785 10 aperez 2018-12-10 16:00:15 -0800 This broke all the Flatpak machinery, any tool that tries to use the utility module will complain with: Traceback (most recent call last): File "/home/aperez/devel/WebKit-ContentBlocking/Tools/Scripts/update-webkitwpe-flatpak", line 28, in <module> WebkitFlatpak.load_from_args(["--wpe", "--update"] + sys.argv[1:]).run() File "/home/aperez/devel/WebKit-ContentBlocking/Tools/flatpak/flatpakutils.py", line 761, in run if not self.clean_args(): File "/home/aperez/devel/WebKit-ContentBlocking/Tools/flatpak/flatpakutils.py", line 574, in clean_args _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"]) File "/home/aperez/.virtualenvs/webkit/lib/python2.7/UserDict.py", line 40, in __getitem__ raise KeyError(key) KeyError: 'FLATPAK_USER_DIR' 1486786 11 357010 aperez 2018-12-10 16:01:20 -0800 Created attachment 357010 Patch for landing 1486787 12 357011 aperez 2018-12-10 16:05:02 -0800 Created attachment 357011 Patch for landing 1486796 13 357011 mcatanzaro 2018-12-10 16:20:27 -0800 Comment on attachment 357011 Patch for landing This will bring back the original bug. The flatpak directory will be created if flatpak is not in use, and even for ports that don't use flatpak. If it's not enough to move this up to the top of the function, then we'll need to find another way. 1486800 14 mcatanzaro 2018-12-10 16:23:23 -0800 Yeah it looks like this is only used in clean_args, so I would just move it up to the top of clean_args. 1488297 15 mcatanzaro 2018-12-15 09:55:39 -0800 Ping, isn't webkit-flatpak unusable until this lands? 1491102 16 mcatanzaro 2019-01-01 10:26:24 -0800 I guess I'm going to close this, since the original issue is fixed. I know this has broken the flatpak environment, but the fix is quite trivial, as explained in comment #14. Anyone who is actually using the flatpak environment should feel free to test and land that follow-up fix. In the meantime, it's clear nobody besides Adrian has attempted to use the flatpak environment since December 10, at least.... 356930 2018-12-09 15:09:39 -0800 2018-12-10 16:01:15 -0800 Patch bug-190241-20181209170938.patch text/plain 2657 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWNkZDc2MWYxYThkZTQ2NzdjNjMzY2E4MmUxYThkNDk1 N2QwZWIyOS4uODdjNjFmZGQ3YjVhMTUwZGY3YjBkZWY5MTlhYzE2OWM1ZjQzNDBiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTEyLTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXVtHVEtdIHJ1bi1taW5pYnJvd3NlciBpbXByb3Blcmx5IGNyZWF0 ZXMgd2Via2l0LWZsYXRwYWsgZW52aXJvbm1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHJ1bi1taW5pYnJvd3NlciBjYWxscyBpbnRvIHdlYmtpdC1m bGF0cGFrIHRvIGNoZWNrIGlmIGEgZmxhdHBhayBlbnZpcm9ubWVudCBpcyBhdmFpbGFibGUuCisg ICAgICAgIEN1cnJlbnRseSB0aGlzIGFjdHVhbGx5IGNyZWF0ZXMgdGhlIGRpcmVjdG9yaWVzIG5l ZWRlZCBmb3IgdGhlIGZsYXRwYWsgZW52aXJvbm1lbnQuIEZpeCBpdC4KKworICAgICAgICAqIGZs YXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Via2l0RmxhdHBhay5jbGVhbl9hcmdz KToKKyAgICAgICAgKFdlYmtpdEZsYXRwYWsucnVuKToKKwogMjAxOC0xMi0wOCAgRGFuaWVsIEJh dGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGxsZGJfd2Via2l0LnB5IGZv bGxvd2luZyByMjM4NzcxCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5w eSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IDZhOGVkNTRlMGQxNDk0Mjc5 NjJiODA4OGUwOWY5Nzk0MTEzNWI0ZDIuLjcxNWEzN2EwM2YyNmIyNDRmODE3MGM0ZDQzN2I5Mzk1 NTlhZWRiZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CisrKyBi L1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC01NSwxMiArNTUsNiBAQCBGTEFUUEFL X1JFUSA9IFsKIHNjcmlwdGRpciA9IG9zLnBhdGguYWJzcGF0aChvcy5wYXRoLmRpcm5hbWUoX19m aWxlX18pKQogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCi1vcy5lbnZpcm9u WyJGTEFUUEFLX1VTRVJfRElSIl0gPSBvcy5lbnZpcm9uLmdldCgiV0VCS0lUX0ZMQVRQQUtfVVNF Ul9ESVIiLCBvcy5wYXRoLnJlYWxwYXRoKG9zLnBhdGguam9pbihzY3JpcHRkaXIsICIuLi8uLi9X ZWJLaXRCdWlsZCIsICJVc2VyRmxhdHBhayIpKSkKLXRyeToKLSAgICBvcy5tYWtlZGlycyhvcy5l bnZpcm9uWyJGTEFUUEFLX1VTRVJfRElSIl0pCi1leGNlcHQgT1NFcnJvciBhcyBlOgotICAgIHBh c3MKLQogCiBjbGFzcyBDb2xvcnM6CiAgICAgSEVBREVSID0gIlwwMzNbOTVtIgpAQCAtNTk5LDYg KzU5MywxMiBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgogICAgICAgICBzZWxmLm1hbmlmZXN0X3Bh dGggPSBvcy5wYXRoLmFic3BhdGgob3MucGF0aC5qb2luKHNjcmlwdGRpciwgJy4uL2ZsYXRwYWsv b3JnLndlYmtpdC5XZWJLaXQueWFtbCcpKQogICAgICAgICBzZWxmLmJ1aWxkX25hbWUgPSBzZWxm Lm5hbWUgKyAiLWdlbmVyYXRlZCIKIAorICAgICAgICBvcy5lbnZpcm9uWyJGTEFUUEFLX1VTRVJf RElSIl0gPSBvcy5lbnZpcm9uLmdldCgiV0VCS0lUX0ZMQVRQQUtfVVNFUl9ESVIiLCBvcy5wYXRo LnJlYWxwYXRoKG9zLnBhdGguam9pbihzY3JpcHRkaXIsICIuLi8uLi9XZWJLaXRCdWlsZCIsICJV c2VyRmxhdHBhayIpKSkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgb3MubWFrZWRpcnMob3Mu ZW52aXJvblsiRkxBVFBBS19VU0VSX0RJUiJdKQorICAgICAgICBleGNlcHQgT1NFcnJvciBhcyBl OgorICAgICAgICAgICAgcGFzcworCiAgICAgICAgIGJ1aWxkX3Jvb3QgPSBvcy5wYXRoLmpvaW4o c2VsZi5zb3VyY2Vfcm9vdCwgJ1dlYktpdEJ1aWxkJykKICAgICAgICAgc2VsZi5mbGF0cGFrX2J1 aWxkX3BhdGggPSBvcy5wYXRoLmpvaW4oYnVpbGRfcm9vdCwgc2VsZi5wbGF0Zm9ybSwgIkZsYXRw YWtUcmVlIiArIHNlbGYuYnVpbGRfdHlwZSkKICAgICAgICAgc2VsZi5jYWNoZV9wYXRoID0gb3Mu cGF0aC5qb2luKGJ1aWxkX3Jvb3QsICJGbGF0cGFrQ2FjaGUiKQpAQCAtNzU1LDEyICs3NTUsMTIg QEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAgICAgcmV0dXJuIDAKIAogICAgIGRlZiBydW4o c2VsZik6Ci0gICAgICAgIGlmIG5vdCBzZWxmLmNsZWFuX2FyZ3MoKToKLSAgICAgICAgICAgIHJl dHVybiAxCi0KICAgICAgICAgaWYgc2VsZi5jaGVja19hdmFpbGFibGU6CiAgICAgICAgICAgICBy ZXR1cm4gMAogCisgICAgICAgIGlmIG5vdCBzZWxmLmNsZWFuX2FyZ3MoKToKKyAgICAgICAgICAg IHJldHVybiAxCisKICAgICAgICAgaWYgc2VsZi5jbGVhbjoKICAgICAgICAgICAgIGlmIG9zLnBh dGguZXhpc3RzKHNlbGYuZmxhdHBha19idWlsZF9wYXRoKToKICAgICAgICAgICAgICAgICBzaHV0 aWwucm10cmVlKHNlbGYuZmxhdHBha19idWlsZF9wYXRoKQo= 357010 2018-12-10 16:01:20 -0800 2018-12-10 16:04:57 -0800 Patch for landing bug-190241-20181211020119.patch text/plain 1065 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDU2CmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL2Zs YXRwYWt1dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IDcxNWEz N2EwM2YyNmIyNDRmODE3MGM0ZDQzN2I5Mzk1NTlhZWRiZjUuLmI0ZDFhNDBhNWFjYmQ1MzA0Nzhm ZjdiNWIxZDA5YzVkOTViNWMwNGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0 aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC01NSw2ICs1NSw4 IEBAIEZMQVRQQUtfUkVRID0gWwogc2NyaXB0ZGlyID0gb3MucGF0aC5hYnNwYXRoKG9zLnBhdGgu ZGlybmFtZShfX2ZpbGVfXykpCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAK K29zLmVudmlyb25bIkZMQVRQQUtfVVNFUl9ESVIiXSA9IG9zLmVudmlyb24uZ2V0KCJXRUJLSVRf RkxBVFBBS19VU0VSX0RJUiIsIG9zLnBhdGgucmVhbHBhdGgob3MucGF0aC5qb2luKHNjcmlwdGRp ciwgIi4uLy4uL1dlYktpdEJ1aWxkIiwgIlVzZXJGbGF0cGFrIikpKQorCiAKIGNsYXNzIENvbG9y czoKICAgICBIRUFERVIgPSAiXDAzM1s5NW0iCkBAIC01OTMsNyArNTk1LDYgQEAgY2xhc3MgV2Vi a2l0RmxhdHBhazoKICAgICAgICAgc2VsZi5tYW5pZmVzdF9wYXRoID0gb3MucGF0aC5hYnNwYXRo KG9zLnBhdGguam9pbihzY3JpcHRkaXIsICcuLi9mbGF0cGFrL29yZy53ZWJraXQuV2ViS2l0Lnlh bWwnKSkKICAgICAgICAgc2VsZi5idWlsZF9uYW1lID0gc2VsZi5uYW1lICsgIi1nZW5lcmF0ZWQi CiAKLSAgICAgICAgb3MuZW52aXJvblsiRkxBVFBBS19VU0VSX0RJUiJdID0gb3MuZW52aXJvbi5n ZXQoIldFQktJVF9GTEFUUEFLX1VTRVJfRElSIiwgb3MucGF0aC5yZWFscGF0aChvcy5wYXRoLmpv aW4oc2NyaXB0ZGlyLCAiLi4vLi4vV2ViS2l0QnVpbGQiLCAiVXNlckZsYXRwYWsiKSkpCiAgICAg ICAgIHRyeToKICAgICAgICAgICAgIG9zLm1ha2VkaXJzKG9zLmVudmlyb25bIkZMQVRQQUtfVVNF Ul9ESVIiXSkKICAgICAgICAgZXhjZXB0IE9TRXJyb3IgYXMgZToK 357011 2018-12-10 16:05:02 -0800 2018-12-10 16:20:27 -0800 Patch for landing bug-190241-20181211020501.patch text/plain 1827 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg1NWIwZDgwYTg5MGE1MTgwNTNlZjQyZWI4Y2I4MWRh OTRmNTI0Mi4uNTU3M2IyZDEzYmY2MzFhNGMyNWQyYTM1NzkzYjE0N2FmZjNjYTliOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTEyLTEwICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgVW5yZXZpZXdlZCBmaXggYWZ0ZXIgcjIzOTAyOC4gW1dQRV1bR1RLXSBy dW4tbWluaWJyb3dzZXIgaW1wcm9wZXJseSBjcmVhdGVzIHdlYmtpdC1mbGF0cGFrIGVudmlyb25t ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAy NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NTk0MzA0PgorCisgICAgICAgICogZmxhdHBh ay9mbGF0cGFrdXRpbHMucHk6CisgICAgICAgIChXZWJraXRGbGF0cGFrLmNsZWFuX2FyZ3MpOiBN YWtlIHN1cmUgdGhhdCB0aGUgRkxBVFBBS19VU0VSX0RJUiBlbnZpcm9ubWVudCB2YXJpYWJsZSBp cyBhbHdheXMgc2V0LgorCiAyMDE4LTEyLTEwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFVuYWJsZSB0byB1cGxvYWQgZGF0YSB0aGF0IGNv bmZvcm1zIHRvICJwdWJsaWMuaXRlbSIgYnV0IG5vdCAicHVibGljLmNvbnRlbnQiCmRpZmYgLS1n aXQgYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBh a3V0aWxzLnB5CmluZGV4IDcxNWEzN2EwM2YyNmIyNDRmODE3MGM0ZDQzN2I5Mzk1NTlhZWRiZjUu LmI0ZDFhNDBhNWFjYmQ1MzA0NzhmZjdiNWIxZDA5YzVkOTViNWMwNGEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0 aWxzLnB5CkBAIC01NSw2ICs1NSw4IEBAIEZMQVRQQUtfUkVRID0gWwogc2NyaXB0ZGlyID0gb3Mu cGF0aC5hYnNwYXRoKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXykpCiBfbG9nID0gbG9nZ2luZy5n ZXRMb2dnZXIoX19uYW1lX18pCiAKK29zLmVudmlyb25bIkZMQVRQQUtfVVNFUl9ESVIiXSA9IG9z LmVudmlyb24uZ2V0KCJXRUJLSVRfRkxBVFBBS19VU0VSX0RJUiIsIG9zLnBhdGgucmVhbHBhdGgo b3MucGF0aC5qb2luKHNjcmlwdGRpciwgIi4uLy4uL1dlYktpdEJ1aWxkIiwgIlVzZXJGbGF0cGFr IikpKQorCiAKIGNsYXNzIENvbG9yczoKICAgICBIRUFERVIgPSAiXDAzM1s5NW0iCkBAIC01OTMs NyArNTk1LDYgQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAgICAgc2VsZi5tYW5pZmVzdF9w YXRoID0gb3MucGF0aC5hYnNwYXRoKG9zLnBhdGguam9pbihzY3JpcHRkaXIsICcuLi9mbGF0cGFr L29yZy53ZWJraXQuV2ViS2l0LnlhbWwnKSkKICAgICAgICAgc2VsZi5idWlsZF9uYW1lID0gc2Vs Zi5uYW1lICsgIi1nZW5lcmF0ZWQiCiAKLSAgICAgICAgb3MuZW52aXJvblsiRkxBVFBBS19VU0VS X0RJUiJdID0gb3MuZW52aXJvbi5nZXQoIldFQktJVF9GTEFUUEFLX1VTRVJfRElSIiwgb3MucGF0 aC5yZWFscGF0aChvcy5wYXRoLmpvaW4oc2NyaXB0ZGlyLCAiLi4vLi4vV2ViS2l0QnVpbGQiLCAi VXNlckZsYXRwYWsiKSkpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIG9zLm1ha2VkaXJzKG9z LmVudmlyb25bIkZMQVRQQUtfVVNFUl9ESVIiXSkKICAgICAgICAgZXhjZXB0IE9TRXJyb3IgYXMg ZToK