190183 2018-10-01 20:00:38 -0700 [Win][Ninja] incremental build failure of WebKit due to not triggering recompilations by modifying WebCore forwarding header 2025-01-13 22:58:36 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned don.olmstead oldest_to_newest 1465374 0 fujii 2018-10-01 20:00:38 -0700 [Win][Ninja] incremental build failure of WebKit due to not triggering recompilations by modifying WebCore forwarding header Applying Bug 190154 Comment 3 causes incremental build failure of WebKit. 1465377 1 fujii 2018-10-01 20:16:46 -0700 > C:\webkit\ga\WebKitBuild\Release>ninja -t deps Source\WebKit\CMakeFiles\WebKit.dir\Shared\curl\WebCoreArgumentCodersCurl.cpp.obj | findstr ResourceRequest > derivedsources/forwardingheaders/webcore/ResourceRequest.h > derivedsources/forwardingheaders/webcore/ResourceRequestBase.h > > C:\webkit\ga\WebKitBuild\Release>ninja -t query DerivedSources\ForwardingHeaders\WebCore\ResourceRequestBase.h > DerivedSources/ForwardingHeaders/WebCore/ResourceRequestBase.h: > input: CUSTOM_COMMAND > ../../Source/WebCore/platform/network/ResourceRequestBase.h > outputs: > Source/WebCore/WebCoreForwardingHeaders > Source/WebCore/CMakeFiles/WebCoreForwardingHeaders case sensitive issue? 1465381 2 fujii 2018-10-01 20:41:24 -0700 By googling, https://chromium.googlesource.com/external/martine/ninja/+/02d51b3f3d3058411a06bb08d5b773f60848fec4 https://bugs.chromium.org/p/chromium/issues/detail?id=242397 But, I don't understand. 1467737 3 don.olmstead 2018-10-10 09:46:14 -0700 Won't this just be fixed if we move to copying all files and enumerating them? We're still doing groups in our copying. 1467925 4 fujii 2018-10-10 19:15:53 -0700 I don't understand this issue yet. Hopefully, it will be fixed by switching to Clang (Bug 171618). There is a ticket in Ninja issue tracker. Make path matching case insensitive on Windows by moroten · Pull Request #1393 · ninja-build/ninja https://github.com/ninja-build/ninja/pull/1393 Stop `-t msvc -o` from lowercasing paths from /showIncludes output. by nico · Pull Request #589 · ninja-build/ninja https://github.com/ninja-build/ninja/pull/589 1468337 5 fujii 2018-10-11 20:09:46 -0700 Finally, I think maybe I understand this issue. This is a problem because the output directory DerivedSources/ForwardingHeaders/WebCore has uppercase. while Chromium uses lowercase for directory names of generated headers. Possible solutions are: * Downcase output directory names for generated headers * Use MSBuild instead of Ninja * Fix Ninja 1468349 6 fujii 2018-10-11 20:53:33 -0700 I have confirmed 'clang-cl /showIncludes' seems to preserve original casing, and it recompiles fine in this case. > C:\webkit\gb\WebKitBuild\Release>ninja -t deps Source\WebKit\CMakeFiles\WebKit.dir\Shared\curl\WebCoreArgumentCodersCurl.cpp.obj | findstr ResourceRequest > DerivedSources/ForwardingHeaders/WebCore/ResourceRequest.h > DerivedSources/ForwardingHeaders/WebCore/ResourceRequestBase.h This becomes another reason WinCairo port should switch to Clang (Bug 171618). 2086976 7 fujii 2025-01-13 22:58:36 -0800 WinCairo port has switched to clang-cl. I think this problem is no longer happenning. Closed.