190100 2018-09-28 17:04:26 -0700 Web Inspector: Table with no selection should select the first/last row on down/up arrow key 2018-11-13 11:41:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P4 Normal --- 189718 190993 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1464619 0 mattbaker 2018-09-28 17:04:26 -0700 Summary: Table with no selected row should select the first/last row on down/up arrow key. This improves behavior parity with macOS tables (Finder, Instruments, AppKit's NSTableView, etc). Steps to Reproduce: 1. Open Network tab 2. Focus the table without selecting a row (click past the last row) 3. Press down (or up) arrow key Actual: => Nothing happens Expected: => First (or last) row is selected 1464623 1 webkit-bug-importer 2018-09-28 17:04:48 -0700 <rdar://problem/44879243> 1464629 2 351147 mattbaker 2018-09-28 17:12:22 -0700 Created attachment 351147 WIP 1464631 3 mattbaker 2018-09-28 17:13:30 -0700 (In reply to Matt Baker from comment #2) > Created attachment 351147 [details] > WIP Lacks support for when the first or last row is not in the cache. 1476624 4 354264 mattbaker 2018-11-08 12:39:33 -0800 Created attachment 354264 Patch 1478001 5 354672 mattbaker 2018-11-13 08:46:42 -0800 Created attachment 354672 Patch 1478036 6 354672 hi 2018-11-13 09:54:10 -0800 Comment on attachment 354672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354672&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Table.js:454 > + this.needsLayout(); If we wait for a layout rAF, we'll end up flashing content as we will scroll before the new content is visible. I think this should be `updateLayout` if the row isn't currently visible, but it can stay as is for rows that are. > Source/WebInspectorUI/UserInterface/Views/Table.js:1304 > + if (event.metaKey || event.ctrlKey) > return; Duplicate of next line. Please remove. 1478072 7 354682 mattbaker 2018-11-13 11:04:10 -0800 Created attachment 354682 Patch for landing 1478085 8 354682 commit-queue 2018-11-13 11:41:46 -0800 Comment on attachment 354682 Patch for landing Clearing flags on attachment: 354682 Committed r238139: <https://trac.webkit.org/changeset/238139> 1478086 9 commit-queue 2018-11-13 11:41:48 -0800 All reviewed patches have been landed. Closing bug. 351147 2018-09-28 17:12:22 -0700 2018-11-08 12:39:32 -0800 WIP bug-190100-20180928171220.patch text/plain 2297 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj OGEyMDhiNDY5YjMyZTc2NjUxY2NjOGJhZWJmOWZjNDhlYWQxZWQzLi5mZmFiZjU3OTQ4OTEzOWRm MDI4NDJjN2VmNDcyNTYyY2Q2NGMwYjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wOS0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFibGUgd2l0aCBubyBzZWxlY3Rpb24gc2hvdWxk IHNlbGVjdCB0aGUgZmlyc3QvbGFzdCByb3cgb24gZG93bi91cCBhcnJvdyBrZXkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEwMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDQ4NzkyNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzOgorICAgICAg ICAoV0kuVGFibGUucHJvdG90eXBlLl9oYW5kbGVLZXlEb3duKToKKwogMjAxOC0wOS0yOCAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog aW1hZ2UgcmVzb3VyY2VzIHdpdGhvdXQgY29udGVudCBhcmUgc3RpbGwgc2hvd24gd2hlbiB0aGUg SW1hZ2VzIGZvbGRlciBpcyBzZWxlY3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCA4MzljMDZjN2YxNThkODU1MGNkNWVj NjZmYzliM2QzNjViMmIzOTA0Li40OGU3NDU4MTBkMmZhOTMwZWNjMWU0MWJjMzRmYzMwN2JjMzZk ZTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UYWJsZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UYWJsZS5qcwpAQCAtMTE1MSw3ICsxMTUxLDExIEBAIFdJLlRhYmxlID0gY2xhc3MgVGFibGUg ZXh0ZW5kcyBXSS5WaWV3CiAKICAgICBfaGFuZGxlS2V5RG93bihldmVudCkKICAgICB7Ci0gICAg ICAgIGlmICghdGhpcy5faXNSb3dWaXNpYmxlKHRoaXMuX3NlbGVjdGVkUm93SW5kZXgpKQorICAg ICAgICBpZiAodGhpcy5fc2VsZWN0ZWRSb3dJbmRleCAmJiAhdGhpcy5faXNSb3dWaXNpYmxlKHRo aXMuX3NlbGVjdGVkUm93SW5kZXgpKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGxl dCBudW1iZXJPZlJvd3MgPSB0aGlzLl9kYXRhU291cmNlLnRhYmxlTnVtYmVyT2ZSb3dzKHRoaXMp OworICAgICAgICBpZiAoIW51bWJlck9mUm93cykKICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICBpZiAoZXZlbnQuc2hpZnRLZXkgfHwgZXZlbnQubWV0YUtleSB8fCBldmVudC5jdHJsS2V5 KQpAQCAtMTE2MiwxMCArMTE2NiwxMyBAQCBXSS5UYWJsZSA9IGNsYXNzIFRhYmxlIGV4dGVuZHMg V0kuVmlldwogICAgICAgICBpZiAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlVwIikgewogICAg ICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkUm93SW5kZXggPiAwKQogICAgICAgICAgICAgICAg IHJvd1RvU2VsZWN0ID0gdGhpcy5fc2VsZWN0ZWRSb3dJbmRleCAtIDE7CisgICAgICAgICAgICBl bHNlIGlmIChpc05hTih0aGlzLl9zZWxlY3RlZFJvd0luZGV4KSkKKyAgICAgICAgICAgICAgICBy b3dUb1NlbGVjdCA9IG51bWJlck9mUm93cyAtIDE7CiAgICAgICAgIH0gZWxzZSBpZiAoZXZlbnQu a2V5SWRlbnRpZmllciA9PT0gIkRvd24iKSB7Ci0gICAgICAgICAgICBsZXQgbnVtYmVyT2ZSb3dz ID0gdGhpcy5fZGF0YVNvdXJjZS50YWJsZU51bWJlck9mUm93cyh0aGlzKTsKICAgICAgICAgICAg IGlmICh0aGlzLl9zZWxlY3RlZFJvd0luZGV4IDwgKG51bWJlck9mUm93cyAtIDEpKQogICAgICAg ICAgICAgICAgIHJvd1RvU2VsZWN0ID0gdGhpcy5fc2VsZWN0ZWRSb3dJbmRleCArIDE7CisgICAg ICAgICAgICBlbHNlIGlmIChpc05hTih0aGlzLl9zZWxlY3RlZFJvd0luZGV4KSkKKyAgICAgICAg ICAgICAgICByb3dUb1NlbGVjdCA9IDA7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIWlzTmFO KHJvd1RvU2VsZWN0KSkgewo= 354264 2018-11-08 12:39:33 -0800 2018-11-13 08:46:41 -0800 Patch bug-190100-20181108123932.patch text/plain 3785 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm OWFiZWViZTAwYWMyZDRkZTBiMzg5NDk1ZGFiYzI0NzE3ZTIwYTBhLi4xMGQ5NzUxODRkMGNkMDIz MzQ0MDJlYjZjNzg0YmNkNWEwYmZlNjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0xMS0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFibGUgd2l0aCBubyBzZWxlY3Rpb24gc2hvdWxk IHNlbGVjdCB0aGUgZmlyc3QvbGFzdCByb3cgb24gZG93bi91cCBhcnJvdyBrZXkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEwMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDQ4NzkyNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHJlc3NpbmcgdGhlIHVwIG9yIGRvd24gYXJyb3cga2V5IHdoZW4g bm90aGluZyBpcyBzZWxlY3RlZCBzaG91bGQgc2VsZWN0CisgICAgICAgIHRoZSBsYXN0IG9yIGZp cnN0IHJvdywgcmVzcGVjdGl2ZWx5LiBBZnRlciBzZWxlY3RpbmcgdGhlIHJvdyBtYWtlIHN1cmUK KyAgICAgICAgaXQgaXMgdmlzaWJsZSBieSBjYWxsaW5nIHRoZSBuZXcgVGFibGUgbWV0aG9kIGBy ZXZlYWxSb3dgLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qczoKKyAg ICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5yZXZlYWxSb3cpOgorICAgICAgICAoV0kuVGFibGUu cHJvdG90eXBlLl9oYW5kbGVLZXlEb3duKToKKyAgICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5f c2VsZWN0Um93c0Zyb21BcnJvd0tleSk6CisKIDIwMTgtMTEtMDggIE1hdHQgQmFrZXIgIDxtYXR0 YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRhYmxlIHNob3VsZCBz dXBwb3J0IHNoaWZ0LWV4dGVuZGluZyB0aGUgcm93IHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCAwMjAxMmM2 ZWQ2ZGU5NTMzNmFhMDdjM2E4MTVhY2E5MTYzN2ZjMTRiLi44ZjEwODUxYjllNjhjZTIyY2MxODVk NGI2MDRmZDE4ODk3NWFhNTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwpAQCAtNDQwLDYgKzQ0MCwyNSBAQCBXSS5UYWJsZSA9 IGNsYXNzIFRhYmxlIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB0aGlzLl9yZW1vdmVSb3dzKG9s ZFNlbGVjdGVkUm93cyk7CiAgICAgfQogCisgICAgcmV2ZWFsUm93KHJvd0luZGV4KQorICAgIHsK KyAgICAgICAgY29uc29sZS5hc3NlcnQocm93SW5kZXggPj0gMCAmJiByb3dJbmRleCA8IHRoaXMu bnVtYmVyT2ZSb3dzKTsKKyAgICAgICAgaWYgKHJvd0luZGV4IDwgMCB8fCByb3dJbmRleCA+PSB0 aGlzLm51bWJlck9mUm93cykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBpZiAodGhp cy5faXNSb3dWaXNpYmxlKHJvd0luZGV4KSkgeworICAgICAgICAgICAgbGV0IHJvdyA9IHRoaXMu X2NhY2hlZFJvd3MuZ2V0KHJvd0luZGV4KTsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJv dywgIlZpc2libGUgcm93cyBzaG91bGQgYWx3YXlzIGJlIGluIHRoZSBjYWNoZS4iKTsKKyAgICAg ICAgICAgIGlmIChyb3cpCisgICAgICAgICAgICAgICAgcm93LnNjcm9sbEludG9WaWV3SWZOZWVk ZWQoZmFsc2UpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHRoaXMuX3Njcm9sbENvbnRh aW5lckVsZW1lbnQuc2Nyb2xsVG9wID0gcm93SW5kZXggKiB0aGlzLl9yb3dIZWlnaHQ7CisKKyAg ICAgICAgLy8gRm9yY2Ugb3VyIG93biBzY3JvbGwgdXBkYXRlIGJlY2F1c2Ugd2UgbWF5IGhhdmUg c2Nyb2xsZWQuCisgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbFRvcCA9IE5hTjsKKyAgICAgICAg dGhpcy5uZWVkc0xheW91dCgpOworICAgIH0KKwogICAgIGNvbHVtbldpdGhJZGVudGlmaWVyKGlk ZW50aWZpZXIpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fY29sdW1uU3BlY3MuZ2V0KGlk ZW50aWZpZXIpOwpAQCAtMTI4NiwyMiArMTMwNSwxMyBAQCBXSS5UYWJsZSA9IGNsYXNzIFRhYmxl IGV4dGVuZHMgV0kuVmlldwogICAgICAgICBpZiAoIXRoaXMubnVtYmVyT2ZSb3dzKQogICAgICAg ICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICghdGhpcy5faXNSb3dWaXNpYmxlKHRoaXMuX3Nl bGVjdGVkUm93SW5kZXgpKQotICAgICAgICAgICAgcmV0dXJuOwotCiAgICAgICAgIGlmIChldmVu dC5tZXRhS2V5IHx8IGV2ZW50LmN0cmxLZXkpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAg ICAgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCIgfHwgZXZlbnQua2V5SWRlbnRpZmll ciA9PT0gIkRvd24iKSB7CiAgICAgICAgICAgICB0aGlzLl9zZWxlY3RSb3dzRnJvbUFycm93S2V5 KGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCIsIGV2ZW50LnNoaWZ0S2V5KTsKIAotICAgICAg ICAgICAgbGV0IHJvdyA9IHRoaXMuX2NhY2hlZFJvd3MuZ2V0KHRoaXMuX3NlbGVjdGVkUm93SW5k ZXgpOwotICAgICAgICAgICAgY29uc29sZS5hc3NlcnQocm93LCAiTW92aW5nIHVwIG9yIGRvd24g Ynkgb25lIHNob3VsZCBhbHdheXMgZmluZCBhIGNhY2hlZCByb3cgc2luY2UgaXQgaXMgd2l0aGlu IHRoZSBvdmVyZmxvdyBib3VuZHMuIik7Ci0gICAgICAgICAgICByb3cuc2Nyb2xsSW50b1ZpZXdJ Zk5lZWRlZChmYWxzZSk7Ci0KLSAgICAgICAgICAgIC8vIEZvcmNlIG91ciBvd24gc2Nyb2xsIHVw ZGF0ZSBiZWNhdXNlIHdlIG1heSBoYXZlIHNjcm9sbGVkLgotICAgICAgICAgICAgdGhpcy5fY2Fj aGVkU2Nyb2xsVG9wID0gTmFOOwotICAgICAgICAgICAgdGhpcy5uZWVkc0xheW91dCgpOworICAg ICAgICAgICAgdGhpcy5yZXZlYWxSb3codGhpcy5fc2VsZWN0ZWRSb3dJbmRleCk7CiAKICAgICAg ICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICBldmVudC5zdG9wUHJv cGFnYXRpb24oKTsKQEAgLTEzMTAsNiArMTMyMCwxMiBAQCBXSS5UYWJsZSA9IGNsYXNzIFRhYmxl IGV4dGVuZHMgV0kuVmlldwogCiAgICAgX3NlbGVjdFJvd3NGcm9tQXJyb3dLZXkoZ29pbmdVcCwg c2hpZnRLZXkpCiAgICAgeworICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGVkUm93cy5zaXplKSB7 CisgICAgICAgICAgICBsZXQgcm93SW5kZXggPSBnb2luZ1VwID8gdGhpcy5udW1iZXJPZlJvd3Mg LSAxIDogMDsKKyAgICAgICAgICAgIHRoaXMuc2VsZWN0Um93KHJvd0luZGV4KTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIGxldCByb3dJbmNyZW1lbnQgPSBnb2lu Z1VwID8gLTEgOiAxOwogICAgICAgICBsZXQgcm93SW5kZXggPSB0aGlzLl9zZWxlY3RlZFJvd0lu ZGV4ICsgcm93SW5jcmVtZW50OwogICAgICAgICBpZiAocm93SW5kZXggPCAwIHx8IHJvd0luZGV4 ID49IHRoaXMubnVtYmVyT2ZSb3dzKQo= 354672 2018-11-13 08:46:42 -0800 2018-11-13 11:04:09 -0800 Patch bug-190100-20181113084641.patch text/plain 3867 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 ZDg0OWE5ZTQwZTE3ZGE2NDdjYmE2ODk0MjlhYTZhNmEwNDYzYTU5Li42OGU2ODBlNGEwYTRmYzQw MmNmZmM4YWM4MGM0ZTg4MDg1ODRiMTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0xMS0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFibGUgd2l0aCBubyBzZWxlY3Rpb24gc2hvdWxk IHNlbGVjdCB0aGUgZmlyc3QvbGFzdCByb3cgb24gZG93bi91cCBhcnJvdyBrZXkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEwMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDQ4NzkyNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHJlc3NpbmcgdGhlIHVwIG9yIGRvd24gYXJyb3cga2V5IHdoZW4g bm90aGluZyBpcyBzZWxlY3RlZCBzaG91bGQgc2VsZWN0CisgICAgICAgIHRoZSBsYXN0IG9yIGZp cnN0IHJvdywgcmVzcGVjdGl2ZWx5LiBBZnRlciBzZWxlY3RpbmcgdGhlIHJvdyBtYWtlIHN1cmUK KyAgICAgICAgaXQgaXMgdmlzaWJsZSBieSBjYWxsaW5nIHRoZSBuZXcgVGFibGUgbWV0aG9kIGBy ZXZlYWxSb3dgLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qczoKKyAg ICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5yZXZlYWxSb3cpOgorICAgICAgICAoV0kuVGFibGUu cHJvdG90eXBlLl9oYW5kbGVLZXlEb3duKToKKyAgICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5f c2VsZWN0Um93c0Zyb21BcnJvd0tleSk6CisKIDIwMTgtMTEtMTIgIE1hdHQgQmFrZXIgIDxtYXR0 YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRhYmxlIHNob3VsZCBz dXBwb3J0IHNoaWZ0LWV4dGVuZGluZyB0aGUgcm93IHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCAyZjAyNGYw ZjkwMzEwNWE4OTVhNDNiZjQ4OTdmNGQ3NTQyNzExNTI1Li4xMzA0N2NmNWZmY2VmMzFkY2ZmYjli ODE1NjRmOWNiNTdjZTBhYTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwpAQCAtNDM1LDYgKzQzNSwyNSBAQCBXSS5UYWJsZSA9 IGNsYXNzIFRhYmxlIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB0aGlzLl9yZW1vdmVSb3dzKG9s ZFNlbGVjdGVkUm93cyk7CiAgICAgfQogCisgICAgcmV2ZWFsUm93KHJvd0luZGV4KQorICAgIHsK KyAgICAgICAgY29uc29sZS5hc3NlcnQocm93SW5kZXggPj0gMCAmJiByb3dJbmRleCA8IHRoaXMu bnVtYmVyT2ZSb3dzKTsKKyAgICAgICAgaWYgKHJvd0luZGV4IDwgMCB8fCByb3dJbmRleCA+PSB0 aGlzLm51bWJlck9mUm93cykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBpZiAodGhp cy5faXNSb3dWaXNpYmxlKHJvd0luZGV4KSkgeworICAgICAgICAgICAgbGV0IHJvdyA9IHRoaXMu X2NhY2hlZFJvd3MuZ2V0KHJvd0luZGV4KTsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJv dywgIlZpc2libGUgcm93cyBzaG91bGQgYWx3YXlzIGJlIGluIHRoZSBjYWNoZS4iKTsKKyAgICAg ICAgICAgIGlmIChyb3cpCisgICAgICAgICAgICAgICAgcm93LnNjcm9sbEludG9WaWV3SWZOZWVk ZWQoZmFsc2UpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHRoaXMuX3Njcm9sbENvbnRh aW5lckVsZW1lbnQuc2Nyb2xsVG9wID0gcm93SW5kZXggKiB0aGlzLl9yb3dIZWlnaHQ7CisKKyAg ICAgICAgLy8gRm9yY2Ugb3VyIG93biBzY3JvbGwgdXBkYXRlIGJlY2F1c2Ugd2UgbWF5IGhhdmUg c2Nyb2xsZWQuCisgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbFRvcCA9IE5hTjsKKyAgICAgICAg dGhpcy5uZWVkc0xheW91dCgpOworICAgIH0KKwogICAgIGNvbHVtbldpdGhJZGVudGlmaWVyKGlk ZW50aWZpZXIpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fY29sdW1uU3BlY3MuZ2V0KGlk ZW50aWZpZXIpOwpAQCAtMTI4MSw3ICsxMzAwLDcgQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBl eHRlbmRzIFdJLlZpZXcKICAgICAgICAgaWYgKCF0aGlzLm51bWJlck9mUm93cykKICAgICAgICAg ICAgIHJldHVybjsKIAotICAgICAgICBpZiAoIXRoaXMuX2lzUm93VmlzaWJsZSh0aGlzLl9zZWxl Y3RlZFJvd0luZGV4KSkKKyAgICAgICAgaWYgKGV2ZW50Lm1ldGFLZXkgfHwgZXZlbnQuY3RybEtl eSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBpZiAoZXZlbnQubWV0YUtleSB8fCBl dmVudC5jdHJsS2V5KQpAQCAtMTI5MCwxMyArMTMwOSw3IEBAIFdJLlRhYmxlID0gY2xhc3MgVGFi bGUgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGlmIChldmVudC5rZXlJZGVudGlmaWVyID09PSAi VXAiIHx8IGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJEb3duIikgewogICAgICAgICAgICAgdGhp cy5fc2VsZWN0Um93c0Zyb21BcnJvd0tleShldmVudC5rZXlJZGVudGlmaWVyID09PSAiVXAiLCBl dmVudC5zaGlmdEtleSk7CiAKLSAgICAgICAgICAgIGxldCByb3cgPSB0aGlzLl9jYWNoZWRSb3dz LmdldCh0aGlzLl9zZWxlY3RlZFJvd0luZGV4KTsKLSAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0 KHJvdywgIk1vdmluZyB1cCBvciBkb3duIGJ5IG9uZSBzaG91bGQgYWx3YXlzIGZpbmQgYSBjYWNo ZWQgcm93IHNpbmNlIGl0IGlzIHdpdGhpbiB0aGUgb3ZlcmZsb3cgYm91bmRzLiIpOwotICAgICAg ICAgICAgcm93LnNjcm9sbEludG9WaWV3SWZOZWVkZWQoZmFsc2UpOwotCi0gICAgICAgICAgICAv LyBGb3JjZSBvdXIgb3duIHNjcm9sbCB1cGRhdGUgYmVjYXVzZSB3ZSBtYXkgaGF2ZSBzY3JvbGxl ZC4KLSAgICAgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbFRvcCA9IE5hTjsKLSAgICAgICAgICAg IHRoaXMubmVlZHNMYXlvdXQoKTsKKyAgICAgICAgICAgIHRoaXMucmV2ZWFsUm93KHRoaXMuX3Nl bGVjdGVkUm93SW5kZXgpOwogCiAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwog ICAgICAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7CkBAIC0xMzA1LDYgKzEzMTgsMTIg QEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKIAogICAgIF9zZWxlY3RS b3dzRnJvbUFycm93S2V5KGdvaW5nVXAsIHNoaWZ0S2V5KQogICAgIHsKKyAgICAgICAgaWYgKCF0 aGlzLl9zZWxlY3RlZFJvd3Muc2l6ZSkgeworICAgICAgICAgICAgbGV0IHJvd0luZGV4ID0gZ29p bmdVcCA/IHRoaXMubnVtYmVyT2ZSb3dzIC0gMSA6IDA7CisgICAgICAgICAgICB0aGlzLnNlbGVj dFJvdyhyb3dJbmRleCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAg ICBsZXQgcm93SW5jcmVtZW50ID0gZ29pbmdVcCA/IC0xIDogMTsKICAgICAgICAgbGV0IHJvd0lu ZGV4ID0gdGhpcy5fc2VsZWN0ZWRSb3dJbmRleCArIHJvd0luY3JlbWVudDsKICAgICAgICAgaWYg KHJvd0luZGV4IDwgMCB8fCByb3dJbmRleCA+PSB0aGlzLm51bWJlck9mUm93cykK 354682 2018-11-13 11:04:10 -0800 2018-11-13 11:41:46 -0800 Patch for landing bug-190100-20181113110410.patch text/plain 3834 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 ZDg0OWE5ZTQwZTE3ZGE2NDdjYmE2ODk0MjlhYTZhNmEwNDYzYTU5Li4yZTliODI4ZTJhNDU2NjFh ODE4YzJhNWIwM2JhZmNmNGM2MjU0MGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0xMS0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFibGUgd2l0aCBubyBzZWxlY3Rpb24gc2hvdWxk IHNlbGVjdCB0aGUgZmlyc3QvbGFzdCByb3cgb24gZG93bi91cCBhcnJvdyBrZXkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEwMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDQ4NzkyNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91 c3NvLgorCisgICAgICAgIFByZXNzaW5nIHRoZSB1cCBvciBkb3duIGFycm93IGtleSB3aGVuIG5v dGhpbmcgaXMgc2VsZWN0ZWQgc2hvdWxkIHNlbGVjdAorICAgICAgICB0aGUgbGFzdCBvciBmaXJz dCByb3csIHJlc3BlY3RpdmVseS4gQWZ0ZXIgc2VsZWN0aW5nIHRoZSByb3cgbWFrZSBzdXJlCisg ICAgICAgIGl0IGlzIHZpc2libGUgYnkgY2FsbGluZyB0aGUgbmV3IFRhYmxlIG1ldGhvZCBgcmV2 ZWFsUm93YC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanM6CisgICAg ICAgIChXSS5UYWJsZS5wcm90b3R5cGUucmV2ZWFsUm93KToKKyAgICAgICAgKFdJLlRhYmxlLnBy b3RvdHlwZS5faGFuZGxlS2V5RG93bik6CisgICAgICAgIChXSS5UYWJsZS5wcm90b3R5cGUuX3Nl bGVjdFJvd3NGcm9tQXJyb3dLZXkpOgorCiAyMDE4LTExLTEyICBNYXR0IEJha2VyICA8bWF0dGJh a2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBUYWJsZSBzaG91bGQgc3Vw cG9ydCBzaGlmdC1leHRlbmRpbmcgdGhlIHJvdyBzZWxlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMKaW5kZXggMmYwMjRmMGY5 MDMxMDVhODk1YTQzYmY0ODk3ZjRkNzU0MjcxMTUyNS4uNGQ3NGIyMTliNmRiYTY0MDYwOGU0MzEx N2ZiY2Q0ZGZjNmVmMDFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGFibGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGFibGUuanMKQEAgLTQzNSw2ICs0MzUsMjcgQEAgV0kuVGFibGUgPSBj bGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgdGhpcy5fcmVtb3ZlUm93cyhvbGRT ZWxlY3RlZFJvd3MpOwogICAgIH0KIAorICAgIHJldmVhbFJvdyhyb3dJbmRleCkKKyAgICB7Cisg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJvd0luZGV4ID49IDAgJiYgcm93SW5kZXggPCB0aGlzLm51 bWJlck9mUm93cyk7CisgICAgICAgIGlmIChyb3dJbmRleCA8IDAgfHwgcm93SW5kZXggPj0gdGhp cy5udW1iZXJPZlJvd3MpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgLy8gRm9yY2Ug b3VyIG93biBzY3JvbGwgdXBkYXRlIGJlY2F1c2Ugd2UgbWF5IGhhdmUgc2Nyb2xsZWQuCisgICAg ICAgIHRoaXMuX2NhY2hlZFNjcm9sbFRvcCA9IE5hTjsKKworICAgICAgICBpZiAodGhpcy5faXNS b3dWaXNpYmxlKHJvd0luZGV4KSkgeworICAgICAgICAgICAgbGV0IHJvdyA9IHRoaXMuX2NhY2hl ZFJvd3MuZ2V0KHJvd0luZGV4KTsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJvdywgIlZp c2libGUgcm93cyBzaG91bGQgYWx3YXlzIGJlIGluIHRoZSBjYWNoZS4iKTsKKyAgICAgICAgICAg IGlmIChyb3cpCisgICAgICAgICAgICAgICAgcm93LnNjcm9sbEludG9WaWV3SWZOZWVkZWQoZmFs c2UpOworICAgICAgICAgICAgdGhpcy5uZWVkc0xheW91dCgpOworICAgICAgICB9IGVsc2Ugewor ICAgICAgICAgICAgdGhpcy5fc2Nyb2xsQ29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3AgPSByb3dJ bmRleCAqIHRoaXMuX3Jvd0hlaWdodDsKKyAgICAgICAgICAgIHRoaXMudXBkYXRlTGF5b3V0KCk7 CisgICAgICAgIH0KKyAgICB9CisKICAgICBjb2x1bW5XaXRoSWRlbnRpZmllcihpZGVudGlmaWVy KQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX2NvbHVtblNwZWNzLmdldChpZGVudGlmaWVy KTsKQEAgLTEyODEsMjIgKzEzMDIsMTMgQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRz IFdJLlZpZXcKICAgICAgICAgaWYgKCF0aGlzLm51bWJlck9mUm93cykKICAgICAgICAgICAgIHJl dHVybjsKIAotICAgICAgICBpZiAoIXRoaXMuX2lzUm93VmlzaWJsZSh0aGlzLl9zZWxlY3RlZFJv d0luZGV4KSkKLSAgICAgICAgICAgIHJldHVybjsKLQogICAgICAgICBpZiAoZXZlbnQubWV0YUtl eSB8fCBldmVudC5jdHJsS2V5KQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChl dmVudC5rZXlJZGVudGlmaWVyID09PSAiVXAiIHx8IGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJE b3duIikgewogICAgICAgICAgICAgdGhpcy5fc2VsZWN0Um93c0Zyb21BcnJvd0tleShldmVudC5r ZXlJZGVudGlmaWVyID09PSAiVXAiLCBldmVudC5zaGlmdEtleSk7CiAKLSAgICAgICAgICAgIGxl dCByb3cgPSB0aGlzLl9jYWNoZWRSb3dzLmdldCh0aGlzLl9zZWxlY3RlZFJvd0luZGV4KTsKLSAg ICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJvdywgIk1vdmluZyB1cCBvciBkb3duIGJ5IG9uZSBz aG91bGQgYWx3YXlzIGZpbmQgYSBjYWNoZWQgcm93IHNpbmNlIGl0IGlzIHdpdGhpbiB0aGUgb3Zl cmZsb3cgYm91bmRzLiIpOwotICAgICAgICAgICAgcm93LnNjcm9sbEludG9WaWV3SWZOZWVkZWQo ZmFsc2UpOwotCi0gICAgICAgICAgICAvLyBGb3JjZSBvdXIgb3duIHNjcm9sbCB1cGRhdGUgYmVj YXVzZSB3ZSBtYXkgaGF2ZSBzY3JvbGxlZC4KLSAgICAgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9s bFRvcCA9IE5hTjsKLSAgICAgICAgICAgIHRoaXMubmVlZHNMYXlvdXQoKTsKKyAgICAgICAgICAg IHRoaXMucmV2ZWFsUm93KHRoaXMuX3NlbGVjdGVkUm93SW5kZXgpOwogCiAgICAgICAgICAgICBl dmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9u KCk7CkBAIC0xMzA1LDYgKzEzMTcsMTIgQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRz IFdJLlZpZXcKIAogICAgIF9zZWxlY3RSb3dzRnJvbUFycm93S2V5KGdvaW5nVXAsIHNoaWZ0S2V5 KQogICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9zZWxlY3RlZFJvd3Muc2l6ZSkgeworICAgICAg ICAgICAgbGV0IHJvd0luZGV4ID0gZ29pbmdVcCA/IHRoaXMubnVtYmVyT2ZSb3dzIC0gMSA6IDA7 CisgICAgICAgICAgICB0aGlzLnNlbGVjdFJvdyhyb3dJbmRleCk7CisgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIH0KKwogICAgICAgICBsZXQgcm93SW5jcmVtZW50ID0gZ29pbmdVcCA/IC0x IDogMTsKICAgICAgICAgbGV0IHJvd0luZGV4ID0gdGhpcy5fc2VsZWN0ZWRSb3dJbmRleCArIHJv d0luY3JlbWVudDsKICAgICAgICAgaWYgKHJvd0luZGV4IDwgMCB8fCByb3dJbmRleCA+PSB0aGlz Lm51bWJlck9mUm93cykK