<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189961</bug_id>
          
          <creation_ts>2018-09-25 11:31:31 -0700</creation_ts>
          <short_desc>[WPE][GTK] Fix HTTP credentials in sandbox</short_desc>
          <delta_ts>2018-10-15 08:11:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>189956</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Griffis">pgriffis</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1463231</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2018-09-25 11:31:31 -0700</bug_when>
    <thetext>Currently the WebProcess talks to libsecret for HTTP credentials.

This is unacceptable and needs to be proxied through the UI layer which can
limit password access by origin.

See also how this was handled in Epiphany: https://gitlab.gnome.org/GNOME/epiphany/commit/68b0f85747a177047a7b49d839895aad54b05309</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464382</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-09-28 08:32:00 -0700</bug_when>
    <thetext>As part of this I want to rework how credentials are saved. Give the application a signal so it can save credentials in its own way. E.g. Epiphany should be able to put WebKitGTK+ passwords with all the user&apos;s Epiphany passwords. It doesn&apos;t make sense that just the few HTTP auth passwords are separated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469218</commentid>
    <comment_count>2</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2018-10-15 08:11:00 -0700</bug_when>
    <thetext>We&apos;ve decided to trust the NetworkProcess for now and not sandbox it so this no longer applies.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>