<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189936</bug_id>
          
          <creation_ts>2018-09-24 16:47:46 -0700</creation_ts>
          <short_desc>[WHLSL] Metal codegen needs to correctly handle all entry point arguments</short_desc>
          <delta_ts>2018-10-13 14:52:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>MOVED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=189955</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>176199</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Thomas Denney">tdenney</reporter>
          <assigned_to name="Thomas Denney">tdenney</assigned_to>
          <cc>dino</cc>
    
    <cc>mmaxfield</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1463008</commentid>
    <comment_count>0</comment_count>
    <who name="Thomas Denney">tdenney</who>
    <bug_when>2018-09-24 16:47:46 -0700</bug_when>
    <thetext>WHLSL and MSL shader parameter/return types may differ in their layout — the stage_in parameters need to be flattened into a single struct for example — so shader entry points should unpack their parameters into the expected layout and when they exit they should repack into this format.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1463069</commentid>
    <comment_count>1</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-09-24 19:00:41 -0700</bug_when>
    <thetext>It might be easier to implement the packing/unpacking if we make a new function that represents the entry point that just does the packing/unpacking, the global struct, and the trap statement bool</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468803</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-10-13 14:23:10 -0700</bug_when>
    <thetext>Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/26</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468847</commentid>
    <comment_count>3</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-10-13 14:52:17 -0700</bug_when>
    <thetext>https://github.com/gpuweb/WHLSL/issues/26</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>