189894 2018-09-23 09:22:44 -0700 Add missing includes in TextCodecReplacement.cpp 2018-09-23 13:53:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188043 1 fred.wang fred.wang commit-queue darin lforschler simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1462526 0 fred.wang 2018-09-23 09:22:44 -0700 Patch from bug 188043 exhibits a possible build error when with unifiedbuild source rotating: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:49:30: error: implicit instantiation of undefined template 'WTF::Function<std::__1::unique_ptr<WebCore::TextCodec, std::__1::default_delete<WebCore::TextCodec> > ()>' registrar("replacement", [] { ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:53:26: note: template is declared here template<typename> class Function; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:49:30: note: candidate function registrar("replacement", [] { ^ ./platform/text/TextCodecReplacement.cpp:54:30: error: incomplete result type 'WTF::String' in function definition String TextCodecReplacement::decode(const char*, size_t, bool, bool, bool& sawError) ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String' class String; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:58:16: error: use of undeclared identifier 'emptyString' return emptyString(); ^ ./platform/text/TextCodecReplacement.cpp:60:12: error: invalid use of incomplete type 'WTF::String' return String { &replacementCharacter, 1 }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String' class String; ^ 4 errors generated. 1462527 1 350570 fred.wang 2018-09-23 09:27:53 -0700 Created attachment 350570 Patch 1462564 2 350570 commit-queue 2018-09-23 13:52:33 -0700 Comment on attachment 350570 Patch Clearing flags on attachment: 350570 Committed r236393: <https://trac.webkit.org/changeset/236393> 1462565 3 commit-queue 2018-09-23 13:52:35 -0700 All reviewed patches have been landed. Closing bug. 1462566 4 webkit-bug-importer 2018-09-23 13:53:22 -0700 <rdar://problem/44715585> 350570 2018-09-23 09:27:53 -0700 2018-09-23 13:52:33 -0700 Patch 189894.patch text/plain 1105 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhOWU0M2Y5ZDFkNy4uYTgwMTQzZGUxOWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wOS0yMyAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+ CisKKyAgICAgICAgQWRkIG1pc3NpbmcgaW5jbHVkZXMgaW4gVGV4dENvZGVjUmVwbGFjZW1lbnQu Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk4 OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIGJlaGF2aW9yIHVuY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQv VGV4dENvZGVjUmVwbGFjZW1lbnQuY3BwOiBBZGQgbWlzc2luZyBoZWFkZXJzLgorCiAyMDE4LTA5 LTIwICBKdXN0aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbXBsZW1lbnQgQ1NTIEN1c3RvbSBQcm9wZXJ0aWVzIGFuZCBWYWx1ZXMgU2tlbGV0b24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENvZGVjUmVwbGFjZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNSZXBsYWNlbWVu dC5jcHAKaW5kZXggYmEyNjE0Y2ExNDguLjE3NjViZjc5MjE1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY1JlcGxhY2VtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY1JlcGxhY2VtZW50LmNwcApAQCAtMjYs NiArMjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRleHRDb2RlY1JlcGxh Y2VtZW50LmgiCiAKKyNpbmNsdWRlIDx3dGYvRnVuY3Rpb24uaD4KKyNpbmNsdWRlIDx3dGYvdGV4 dC9XVEZTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9DaGFyYWN0ZXJOYW1lcy5oPgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==