189828 2018-09-21 06:28:35 -0700 [libwebrtc] Allow IP mismatch for local connections on localhost 2018-09-21 07:38:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier alex commit-queue eric.carlson ews-watchlist webkit-bug-importer oldest_to_newest 1461812 0 tsaunier 2018-09-21 06:28:35 -0700 [libwebrtc] Allow IP mismatch for local connections on localhost (bis) 1461813 1 350353 tsaunier 2018-09-21 06:28:53 -0700 Created attachment 350353 Patch 1461815 2 alex 2018-09-21 06:35:12 -0700 Check bug #187302 for more information about a previous patch. 1461816 3 350353 alex 2018-09-21 06:36:53 -0700 Comment on attachment 350353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350353&action=review LGTM, hopefully we can merge upstream. I would remove the (bis) from the description of the bug. > Source/ThirdParty/libwebrtc/ChangeLog:4 > + Need the bug URL (OOPS!). You need the URL. 1461824 4 350356 tsaunier 2018-09-21 06:59:51 -0700 Created attachment 350356 Patch for landing 1461842 5 350356 commit-queue 2018-09-21 07:37:56 -0700 Comment on attachment 350356 Patch for landing Clearing flags on attachment: 350356 Committed r236316: <https://trac.webkit.org/changeset/236316> 1461843 6 commit-queue 2018-09-21 07:37:57 -0700 All reviewed patches have been landed. Closing bug. 1461844 7 webkit-bug-importer 2018-09-21 07:38:23 -0700 <rdar://problem/44679291> 350353 2018-09-21 06:28:53 -0700 2018-09-21 06:59:45 -0700 Patch bug-189828-20180921102852.patch text/plain 2258 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA2MDExNzZhNDU2NzUwNDA5NDNhMTc4NDIxYjdlMDg1M2U4NWRmYmYzLi44ODgy YTAxNjIyZDMxYzJkMzNkZTk1MjkzMDhjYTg1NjY5ZTAzNTI3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNy0wNCAgVGhpYmF1bHQg U2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2xpYndlYnJ0Y10gQWxs b3cgSVAgbWlzbWF0Y2ggZm9yIGxvY2FsIGNvbm5lY3Rpb25zIG9uIGxvY2FsaG9zdAorICAgICAg ICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIHJlc3Qgb2YgdGhlIGNvZGUgYWxsb3dzIGl0LCBidXQg dGhlcmUgd2FzIGFuIHVuZWNlc3NhcnkgYXNzZXJ0CisKKyAgICAgICAgU2VlIEJ1ZyAxODczMDIK KworICAgICAgICAqIFNvdXJjZS93ZWJydGMvcDJwL2Jhc2UvdGNwcG9ydC5jYzoKKwogMjAxOC0w OS0xOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVt ZW50IFJUQ1J0cFJlY2VpdmVyIGdldENvbnRyaWJ1dGluZ1NvdXJjZXMvZ2V0U3luY2hyb25pemF0 aW9uU291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvcDJwL2Jhc2UvdGNwcG9ydC5jYyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0 Yy9Tb3VyY2Uvd2VicnRjL3AycC9iYXNlL3RjcHBvcnQuY2MKaW5kZXggZDA3MGY2ZWNlZThkYTM0 N2IwOTE2YTkwMjlmMzk3NGQyOTY5ZmI4Ni4uMTFjZjEzNGE0ZjlkNzNmNTUzY2MxNDEwYzQyMWE1 ZmZiMDZmMWI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvcDJwL2Jhc2UvdGNwcG9ydC5jYworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvU291cmNlL3dlYnJ0Yy9wMnAvYmFzZS90Y3Bwb3J0LmNjCkBAIC0zNTEsMTEgKzM1MSwy MSBAQCBUQ1BDb25uZWN0aW9uOjpUQ1BDb25uZWN0aW9uKFRDUFBvcnQqIHBvcnQsCiAgICAgICAg ICAgICAgICAgICAgICAgICA8PCAiLCBwb3J0KCkgTmV0d29yazoiIDw8IHBvcnQtPk5ldHdvcmso KS0+VG9TdHJpbmcoKTsKICAgICBjb25zdCBzdGQ6OnZlY3RvcjxydGM6OkludGVyZmFjZUFkZHJl c3M+JiBkZXNpcmVkX2FkZHJlc3NlcyA9CiAgICAgICAgIHBvcnRfLT5OZXR3b3JrKCktPkdldElQ cygpOworCisjaWYgZGVmaW5lZChXRUJSVENfV0VCS0lUX0JVSUxEKQorICAgIFJUQ19EQ0hFQ0so c29ja2V0LT5HZXRMb2NhbEFkZHJlc3MoKS5Jc0xvb3BiYWNrSVAoKSB8fAorICAgICAgICAgICAg ICAgKHN0ZDo6ZmluZF9pZihkZXNpcmVkX2FkZHJlc3Nlcy5iZWdpbigpLCBkZXNpcmVkX2FkZHJl c3Nlcy5lbmQoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBbdGhpc10oY29uc3QgcnRj OjpJbnRlcmZhY2VBZGRyZXNzJiBhZGRyKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gc29ja2V0Xy0+R2V0TG9jYWxBZGRyZXNzKCkuaXBhZGRyKCkgPT0KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhZGRyOworICAgICAgICAgICAgICAgICAgICAg ICAgICAgIH0pICE9IGRlc2lyZWRfYWRkcmVzc2VzLmVuZCgpKSk7CisjZWxzZQogICAgIFJUQ19E Q0hFQ0soc3RkOjpmaW5kX2lmKGRlc2lyZWRfYWRkcmVzc2VzLmJlZ2luKCksIGRlc2lyZWRfYWRk cmVzc2VzLmVuZCgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIFt0aGlzXShjb25zdCBy dGM6OkludGVyZmFjZUFkZHJlc3MmIGFkZHIpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBzb2NrZXRfLT5HZXRMb2NhbEFkZHJlc3MoKS5pcGFkZHIoKSA9PQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFkZHI7CiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfSkgIT0gZGVzaXJlZF9hZGRyZXNzZXMuZW5kKCkpOworI2VuZGlmCiAgICAgQ29u bmVjdFNvY2tldFNpZ25hbHMoc29ja2V0KTsKICAgfQogfQo= 350356 2018-09-21 06:59:51 -0700 2018-09-21 07:37:56 -0700 Patch for landing bug-189828-20180921105949.patch text/plain 2284 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA2MDExNzZhNDU2NzUwNDA5NDNhMTc4NDIxYjdlMDg1M2U4NWRmYmYzLi5lMzgx NTRjNjI0NjRjMGJlNDRjYTIzODhmOGQ2NDhiZDU0NTExOTFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNy0wNCAgVGhpYmF1bHQg U2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2xpYndlYnJ0Y10gQWxs b3cgSVAgbWlzbWF0Y2ggZm9yIGxvY2FsIGNvbm5lY3Rpb25zIG9uIGxvY2FsaG9zdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5ODI4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQWxlamFuZHJvIEcuIENhc3Ryby4KKworICAgICAgICBUaGUgcmVzdCBv ZiB0aGUgY29kZSBhbGxvd3MgaXQsIGJ1dCB0aGVyZSB3YXMgYW4gdW5lY2Vzc2FyeSBhc3NlcnQK KworICAgICAgICBTZWUgQnVnIDE4NzMwMgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy9wMnAv YmFzZS90Y3Bwb3J0LmNjOgorCiAyMDE4LTA5LTE4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgUlRDUnRwUmVjZWl2ZXIgZ2V0Q29udHJpYnV0 aW5nU291cmNlcy9nZXRTeW5jaHJvbml6YXRpb25Tb3VyY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9wMnAvYmFzZS90Y3Bwb3J0LmNjIGIv U291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvcDJwL2Jhc2UvdGNwcG9y dC5jYwppbmRleCBkMDcwZjZlY2VlOGRhMzQ3YjA5MTZhOTAyOWYzOTc0ZDI5NjlmYjg2Li4xMWNm MTM0YTRmOWQ3M2Y1NTNjYzE0MTBjNDIxYTVmZmIwNmYxYjRjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9wMnAvYmFzZS90Y3Bwb3J0LmNjCisr KyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3AycC9iYXNlL3Rj cHBvcnQuY2MKQEAgLTM1MSwxMSArMzUxLDIxIEBAIFRDUENvbm5lY3Rpb246OlRDUENvbm5lY3Rp b24oVENQUG9ydCogcG9ydCwKICAgICAgICAgICAgICAgICAgICAgICAgIDw8ICIsIHBvcnQoKSBO ZXR3b3JrOiIgPDwgcG9ydC0+TmV0d29yaygpLT5Ub1N0cmluZygpOwogICAgIGNvbnN0IHN0ZDo6 dmVjdG9yPHJ0Yzo6SW50ZXJmYWNlQWRkcmVzcz4mIGRlc2lyZWRfYWRkcmVzc2VzID0KICAgICAg ICAgcG9ydF8tPk5ldHdvcmsoKS0+R2V0SVBzKCk7CisKKyNpZiBkZWZpbmVkKFdFQlJUQ19XRUJL SVRfQlVJTEQpCisgICAgUlRDX0RDSEVDSyhzb2NrZXQtPkdldExvY2FsQWRkcmVzcygpLklzTG9v cGJhY2tJUCgpIHx8CisgICAgICAgICAgICAgICAoc3RkOjpmaW5kX2lmKGRlc2lyZWRfYWRkcmVz c2VzLmJlZ2luKCksIGRlc2lyZWRfYWRkcmVzc2VzLmVuZCgpLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFt0aGlzXShjb25zdCBydGM6OkludGVyZmFjZUFkZHJlc3MmIGFkZHIpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBzb2NrZXRfLT5HZXRMb2NhbEFkZHJl c3MoKS5pcGFkZHIoKSA9PQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFk ZHI7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSkgIT0gZGVzaXJlZF9hZGRyZXNzZXMu ZW5kKCkpKTsKKyNlbHNlCiAgICAgUlRDX0RDSEVDSyhzdGQ6OmZpbmRfaWYoZGVzaXJlZF9hZGRy ZXNzZXMuYmVnaW4oKSwgZGVzaXJlZF9hZGRyZXNzZXMuZW5kKCksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgW3RoaXNdKGNvbnN0IHJ0Yzo6SW50ZXJmYWNlQWRkcmVzcyYgYWRkcikgewog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHNvY2tldF8tPkdldExvY2FsQWRk cmVzcygpLmlwYWRkcigpID09CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YWRkcjsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9KSAhPSBkZXNpcmVkX2FkZHJlc3Nl cy5lbmQoKSk7CisjZW5kaWYKICAgICBDb25uZWN0U29ja2V0U2lnbmFscyhzb2NrZXQpOwogICB9 CiB9Cg==