189774 2018-09-19 20:09:45 -0700 Adopt safe-area-inset on ImageDocument 2018-09-20 16:12:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim thorton webkit-bug-importer oldest_to_newest 1461215 0 benjamin 2018-09-19 20:09:45 -0700 Adopt safe-area-instead on ImageDocument 1461216 1 350166 benjamin 2018-09-19 20:13:15 -0700 Created attachment 350166 Patch 1461217 2 benjamin 2018-09-19 20:13:17 -0700 <rdar://problem/44624432> 1461218 3 benjamin 2018-09-19 20:15:53 -0700 Hopefully I am not too rusty for WebKit patches :) 1461219 4 350166 thorton 2018-09-19 20:36:17 -0700 Comment on attachment 350166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350166&action=review > Source/WebCore/ChangeLog:8 > + rdar://problem/44624432 People usually put this up on the line immediately below the bugzilla link. Unless you're being weird on purpose like Beth. > Source/WebCore/html/ImageDocument.cpp:236 > + imageElement->setAttribute(styleAttr, "-webkit-user-select:none; display:block; margin:auto; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)"); Trailing semicolons like we had before? Doesn't really matter. > Source/WebCore/html/ImageDocument.cpp:238 > + imageElement->setAttribute(styleAttr, "-webkit-user-select:none; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)"); I wish I had added a shorthand for this :P 1461529 5 350261 benjamin 2018-09-20 14:10:04 -0700 Created attachment 350261 Patch 1461530 6 benjamin 2018-09-20 14:10:39 -0700 (In reply to Tim Horton from comment #4) > Comment on attachment 350166 [details] > Patch > [...] Thank you for the quick review Tim! 1461584 7 350261 commit-queue 2018-09-20 16:12:07 -0700 Comment on attachment 350261 Patch Clearing flags on attachment: 350261 Committed r236290: <https://trac.webkit.org/changeset/236290> 1461585 8 commit-queue 2018-09-20 16:12:08 -0700 All reviewed patches have been landed. Closing bug. 350166 2018-09-19 20:13:15 -0700 2018-09-20 14:10:02 -0700 Patch bug-189774-20180919201314.patch text/plain 3350 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDljYjlmYmI2NmZmZDQ1 YzZhZWU4YTE4ZDdkZjVlYWE1YjBmOGNiMi4uNWY2ODA3MTAwYzZlZTBiYjEzN2FhYjllNmU1ZjYw NzY0YzcyOGEyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA5LTE5ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZG9wdCBzYWZl LWFyZWEtaW5zZXRzIG9uIEltYWdlRG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQ0NjI0NDMyCisKKyAgICAgICAg QnkgaGF2aW5nIHRoZSBzYWZlLWFyZWEgaW5zZXRzIG9uIHRoZSBpbWFnZSwgd2UgZW5zdXJlIHRo YXQgdGhleSBvbmx5CisgICAgICAgIGdyb3cgdGhlIGRvY3VtZW50IGlmIHRoZXJlIGlzIG5vdCBl bm91Z2ggc3BhY2UuIFRoaXMgYWxzbyBlbnN1cmVzIHRoZSBpbWFnZQorICAgICAgICBkb2VzIG5v dCBoYXZlIHBhcnRzIHVuZGVyIFVJIGVsZW1lbnRzLgorCisgICAgICAgICogaHRtbC9JbWFnZURv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmNyZWF0ZURvY3Vt ZW50U3RydWN0dXJlKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmltYWdlVXBk YXRlZCk6CisKIDIwMTgtMDktMTkgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzOiBBZGQgb3B0aW9uYWwgY2FwIG9u IHBhcnRpdGlvbmVkIGNhY2hlIG1heCBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW1hZ2VEb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlRG9jdW1lbnQu Y3BwCmluZGV4IDA1MThmZjg2N2RjMDA1ZDRmMzMxYTY5ZDVkNmZjMDkzZjdmMWQ1MjYuLjk3ZGI2 ZWUzMDdlODNiNWEwYWM4NGU3MDgzODhiMDUxZDBiNGJmMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSW1hZ2VEb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9J bWFnZURvY3VtZW50LmNwcApAQCAtMjMzLDkgKzIzMyw5IEBAIHZvaWQgSW1hZ2VEb2N1bWVudDo6 Y3JlYXRlRG9jdW1lbnRTdHJ1Y3R1cmUoKQogICAgIAogICAgIGF1dG8gaW1hZ2VFbGVtZW50ID0g SW1hZ2VEb2N1bWVudEVsZW1lbnQ6OmNyZWF0ZSgqdGhpcyk7CiAgICAgaWYgKG1fc2hvdWxkU2hy aW5rSW1hZ2UpCi0gICAgICAgIGltYWdlRWxlbWVudC0+c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwg Ii13ZWJraXQtdXNlci1zZWxlY3Q6bm9uZTsgZGlzcGxheTpibG9jazsgbWFyZ2luOmF1dG87Iik7 CisgICAgICAgIGltYWdlRWxlbWVudC0+c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwgIi13ZWJraXQt dXNlci1zZWxlY3Q6bm9uZTsgZGlzcGxheTpibG9jazsgbWFyZ2luOmF1dG87IHBhZGRpbmc6ZW52 KHNhZmUtYXJlYS1pbnNldC10b3ApIGVudihzYWZlLWFyZWEtaW5zZXQtcmlnaHQpIGVudihzYWZl LWFyZWEtaW5zZXQtYm90dG9tKSBlbnYoc2FmZS1hcmVhLWluc2V0LWxlZnQpIik7CiAgICAgZWxz ZQotICAgICAgICBpbWFnZUVsZW1lbnQtPnNldEF0dHJpYnV0ZShzdHlsZUF0dHIsICItd2Via2l0 LXVzZXItc2VsZWN0Om5vbmU7Iik7CisgICAgICAgIGltYWdlRWxlbWVudC0+c2V0QXR0cmlidXRl KHN0eWxlQXR0ciwgIi13ZWJraXQtdXNlci1zZWxlY3Q6bm9uZTsgcGFkZGluZzplbnYoc2FmZS1h cmVhLWluc2V0LXRvcCkgZW52KHNhZmUtYXJlYS1pbnNldC1yaWdodCkgZW52KHNhZmUtYXJlYS1p bnNldC1ib3R0b20pIGVudihzYWZlLWFyZWEtaW5zZXQtbGVmdCkiKTsKICAgICBpbWFnZUVsZW1l bnQtPnNldExvYWRNYW51YWxseSh0cnVlKTsKICAgICBpbWFnZUVsZW1lbnQtPnNldFNyYyh1cmwo KS5zdHJpbmcoKSk7CiAgICAgaW1hZ2VFbGVtZW50LT5jYWNoZWRJbWFnZSgpLT5zZXRSZXNwb25z ZShsb2FkZXIoKS0+cmVzcG9uc2UoKSk7CkBAIC0yNDQsNyArMjQ0LDcgQEAgdm9pZCBJbWFnZURv Y3VtZW50OjpjcmVhdGVEb2N1bWVudFN0cnVjdHVyZSgpCiAgICAgaWYgKG1fc2hvdWxkU2hyaW5r SW1hZ2UpIHsKICNpZiBQTEFURk9STShJT1MpCiAgICAgICAgIC8vIFNldCB0aGUgdmlld3BvcnQg dG8gYmUgaW4gZGV2aWNlIHBpeGVscyAocmF0aGVyIHRoYW4gdGhlIGRlZmF1bHQgb2YgOTgwKS4K LSAgICAgICAgcHJvY2Vzc1ZpZXdwb3J0KCJ3aWR0aD1kZXZpY2Utd2lkdGgiX3MsIFZpZXdwb3J0 QXJndW1lbnRzOjpJbWFnZURvY3VtZW50KTsKKyAgICAgICAgcHJvY2Vzc1ZpZXdwb3J0KCJ3aWR0 aD1kZXZpY2Utd2lkdGgsdmlld3BvcnQtZml0PWNvdmVyIl9zLCBWaWV3cG9ydEFyZ3VtZW50czo6 SW1hZ2VEb2N1bWVudCk7CiAjZWxzZQogICAgICAgICBhdXRvIGxpc3RlbmVyID0gSW1hZ2VFdmVu dExpc3RlbmVyOjpjcmVhdGUoKnRoaXMpOwogICAgICAgICBpZiAoUmVmUHRyPERPTVdpbmRvdz4g d2luZG93ID0gdGhpcy0+ZG9tV2luZG93KCkpCkBAIC0yNzMsNyArMjczLDggQEAgdm9pZCBJbWFn ZURvY3VtZW50OjppbWFnZVVwZGF0ZWQoKQogI2lmIFBMQVRGT1JNKElPUykKICAgICAgICAgRmxv YXRTaXplIHNjcmVlblNpemUgPSBwYWdlKCktPmNocm9tZSgpLnNjcmVlblNpemUoKTsKICAgICAg ICAgaWYgKGltYWdlU2l6ZS53aWR0aCgpID4gc2NyZWVuU2l6ZS53aWR0aCgpKQotICAgICAgICAg ICAgcHJvY2Vzc1ZpZXdwb3J0KFN0cmluZzo6Zm9ybWF0KCJ3aWR0aD0ldSIsIHN0YXRpY19jYXN0 PHVuc2lnbmVkPihpbWFnZVNpemUud2lkdGgoKS50b0ludCgpKSksIFZpZXdwb3J0QXJndW1lbnRz OjpJbWFnZURvY3VtZW50KTsKKyAgICAgICAgICAgIHByb2Nlc3NWaWV3cG9ydChTdHJpbmc6OmZv cm1hdCgid2lkdGg9JXUsdmlld3BvcnQtZml0PWNvdmVyIiwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KGltYWdlU2l6ZS53aWR0aCgpLnRvSW50KCkpKSwgVmlld3BvcnRBcmd1bWVudHM6OkltYWdlRG9j dW1lbnQpOworCiAgICAgICAgIGlmIChwYWdlKCkpCiAgICAgICAgICAgICBwYWdlKCktPmNocm9t ZSgpLmNsaWVudCgpLmltYWdlT3JNZWRpYURvY3VtZW50U2l6ZUNoYW5nZWQoSW50U2l6ZShpbWFn ZVNpemUud2lkdGgoKSwgaW1hZ2VTaXplLmhlaWdodCgpKSk7CiAjZWxzZQo= 350261 2018-09-20 14:10:04 -0700 2018-09-20 16:12:07 -0700 Patch bug-189774-20180920141003.patch text/plain 3337 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U0MmMyYmU1ODBmMWE2 ZDFiN2EwYzAzNWFhNWVmODdiMDllMWQ2OC4uMjZjYmE1MzRjZDAzMmE4MzQyMDAxODIwMzcyNThm M2Y0MWJiZTQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA5LTIwICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZG9wdCBzYWZl LWFyZWEtaW5zZXRzIG9uIEltYWdlRG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBI b3J0b24uCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQ0NjI0NDMyCisKKyAgICAgICAgQnkgaGF2 aW5nIHRoZSBzYWZlLWFyZWEgaW5zZXRzIG9uIHRoZSBpbWFnZSwgd2UgZW5zdXJlIHRoYXQgdGhl eSBvbmx5CisgICAgICAgIGdyb3cgdGhlIGRvY3VtZW50IGlmIHRoZXJlIGlzIG5vdCBlbm91Z2gg c3BhY2UuIFRoaXMgYWxzbyBlbnN1cmVzIHRoZSBpbWFnZQorICAgICAgICBkb2VzIG5vdCBoYXZl IHBhcnRzIHVuZGVyIFVJIGVsZW1lbnRzLgorCisgICAgICAgICogaHRtbC9JbWFnZURvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmNyZWF0ZURvY3VtZW50U3Ry dWN0dXJlKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmltYWdlVXBkYXRlZCk6 CisKIDIwMTgtMDktMjAgIE9yaW9sIEJydWZhdSAgPG9icnVmYXVAaWdhbGlhLmNvbT4KIAogICAg ICAgICBGaXggJ2JvcmRlcicgc2VyaWFsaXphdGlvbiB3aXRoIGJvdGggY29tbW9uIGFuZCB1bmNv bW1vbiB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VEb2N1bWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlRG9jdW1lbnQuY3BwCmluZGV4IDA1MThm Zjg2N2RjMDA1ZDRmMzMxYTY5ZDVkNmZjMDkzZjdmMWQ1MjYuLjM4NDFkZGU0NjU4ZjczNTliN2Jm ZjcyODQ5ZmE5OWY1ZjAxOGM5MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1h Z2VEb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURvY3VtZW50LmNw cApAQCAtMjMzLDkgKzIzMyw5IEBAIHZvaWQgSW1hZ2VEb2N1bWVudDo6Y3JlYXRlRG9jdW1lbnRT dHJ1Y3R1cmUoKQogICAgIAogICAgIGF1dG8gaW1hZ2VFbGVtZW50ID0gSW1hZ2VEb2N1bWVudEVs ZW1lbnQ6OmNyZWF0ZSgqdGhpcyk7CiAgICAgaWYgKG1fc2hvdWxkU2hyaW5rSW1hZ2UpCi0gICAg ICAgIGltYWdlRWxlbWVudC0+c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwgIi13ZWJraXQtdXNlci1z ZWxlY3Q6bm9uZTsgZGlzcGxheTpibG9jazsgbWFyZ2luOmF1dG87Iik7CisgICAgICAgIGltYWdl RWxlbWVudC0+c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwgIi13ZWJraXQtdXNlci1zZWxlY3Q6bm9u ZTsgZGlzcGxheTpibG9jazsgbWFyZ2luOmF1dG87IHBhZGRpbmc6ZW52KHNhZmUtYXJlYS1pbnNl dC10b3ApIGVudihzYWZlLWFyZWEtaW5zZXQtcmlnaHQpIGVudihzYWZlLWFyZWEtaW5zZXQtYm90 dG9tKSBlbnYoc2FmZS1hcmVhLWluc2V0LWxlZnQpOyIpOwogICAgIGVsc2UKLSAgICAgICAgaW1h Z2VFbGVtZW50LT5zZXRBdHRyaWJ1dGUoc3R5bGVBdHRyLCAiLXdlYmtpdC11c2VyLXNlbGVjdDpu b25lOyIpOworICAgICAgICBpbWFnZUVsZW1lbnQtPnNldEF0dHJpYnV0ZShzdHlsZUF0dHIsICIt d2Via2l0LXVzZXItc2VsZWN0Om5vbmU7IHBhZGRpbmc6ZW52KHNhZmUtYXJlYS1pbnNldC10b3Ap IGVudihzYWZlLWFyZWEtaW5zZXQtcmlnaHQpIGVudihzYWZlLWFyZWEtaW5zZXQtYm90dG9tKSBl bnYoc2FmZS1hcmVhLWluc2V0LWxlZnQpOyIpOwogICAgIGltYWdlRWxlbWVudC0+c2V0TG9hZE1h bnVhbGx5KHRydWUpOwogICAgIGltYWdlRWxlbWVudC0+c2V0U3JjKHVybCgpLnN0cmluZygpKTsK ICAgICBpbWFnZUVsZW1lbnQtPmNhY2hlZEltYWdlKCktPnNldFJlc3BvbnNlKGxvYWRlcigpLT5y ZXNwb25zZSgpKTsKQEAgLTI0NCw3ICsyNDQsNyBAQCB2b2lkIEltYWdlRG9jdW1lbnQ6OmNyZWF0 ZURvY3VtZW50U3RydWN0dXJlKCkKICAgICBpZiAobV9zaG91bGRTaHJpbmtJbWFnZSkgewogI2lm IFBMQVRGT1JNKElPUykKICAgICAgICAgLy8gU2V0IHRoZSB2aWV3cG9ydCB0byBiZSBpbiBkZXZp Y2UgcGl4ZWxzIChyYXRoZXIgdGhhbiB0aGUgZGVmYXVsdCBvZiA5ODApLgotICAgICAgICBwcm9j ZXNzVmlld3BvcnQoIndpZHRoPWRldmljZS13aWR0aCJfcywgVmlld3BvcnRBcmd1bWVudHM6Oklt YWdlRG9jdW1lbnQpOworICAgICAgICBwcm9jZXNzVmlld3BvcnQoIndpZHRoPWRldmljZS13aWR0 aCx2aWV3cG9ydC1maXQ9Y292ZXIiX3MsIFZpZXdwb3J0QXJndW1lbnRzOjpJbWFnZURvY3VtZW50 KTsKICNlbHNlCiAgICAgICAgIGF1dG8gbGlzdGVuZXIgPSBJbWFnZUV2ZW50TGlzdGVuZXI6OmNy ZWF0ZSgqdGhpcyk7CiAgICAgICAgIGlmIChSZWZQdHI8RE9NV2luZG93PiB3aW5kb3cgPSB0aGlz LT5kb21XaW5kb3coKSkKQEAgLTI3Myw3ICsyNzMsOCBAQCB2b2lkIEltYWdlRG9jdW1lbnQ6Omlt YWdlVXBkYXRlZCgpCiAjaWYgUExBVEZPUk0oSU9TKQogICAgICAgICBGbG9hdFNpemUgc2NyZWVu U2l6ZSA9IHBhZ2UoKS0+Y2hyb21lKCkuc2NyZWVuU2l6ZSgpOwogICAgICAgICBpZiAoaW1hZ2VT aXplLndpZHRoKCkgPiBzY3JlZW5TaXplLndpZHRoKCkpCi0gICAgICAgICAgICBwcm9jZXNzVmll d3BvcnQoU3RyaW5nOjpmb3JtYXQoIndpZHRoPSV1Iiwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGlt YWdlU2l6ZS53aWR0aCgpLnRvSW50KCkpKSwgVmlld3BvcnRBcmd1bWVudHM6OkltYWdlRG9jdW1l bnQpOworICAgICAgICAgICAgcHJvY2Vzc1ZpZXdwb3J0KFN0cmluZzo6Zm9ybWF0KCJ3aWR0aD0l dSx2aWV3cG9ydC1maXQ9Y292ZXIiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaW1hZ2VTaXplLndp ZHRoKCkudG9JbnQoKSkpLCBWaWV3cG9ydEFyZ3VtZW50czo6SW1hZ2VEb2N1bWVudCk7CisKICAg ICAgICAgaWYgKHBhZ2UoKSkKICAgICAgICAgICAgIHBhZ2UoKS0+Y2hyb21lKCkuY2xpZW50KCku aW1hZ2VPck1lZGlhRG9jdW1lbnRTaXplQ2hhbmdlZChJbnRTaXplKGltYWdlU2l6ZS53aWR0aCgp LCBpbWFnZVNpemUuaGVpZ2h0KCkpKTsKICNlbHNlCg==