189732 2018-09-18 21:18:29 -0700 [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type" 2018-09-20 19:51:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen benjamin bfulgham cdumez cmarcelo dbates ews-watchlist paroga pvollan webkit-bug-importer oldest_to_newest 1460850 0 fujii 2018-09-18 21:18:29 -0700 [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type" While doing Bug 171618, following compilation error is reported. > [16/31] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp.obj > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource22.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp > In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5: > ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(154,9): error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *' > UNUSED_PARAM(this); > ^ ~~~~ > DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38): note: expanded from macro 'UNUSED_PARAM' > #define UNUSED_PARAM(variable) (void)&variable > ^~~~~~~~~ > In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5: > ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(171,9): error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *' > UNUSED_PARAM(this); > ^ ~~~~ > DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38): note: expanded from macro 'UNUSED_PARAM' > #define UNUSED_PARAM(variable) (void)&variable > ^~~~~~~~~ > In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5: > ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(189,9): error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *' > UNUSED_PARAM(this); > ^ ~~~~ > DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38): note: expanded from macro 'UNUSED_PARAM' > #define UNUSED_PARAM(variable) (void)&variable > ^~~~~~~~~ > 3 errors generated. See Also: Bug 113440 – [WinCE] Add workaround for UNUSED_PARAM() Bug 115350 – [WIN] Add workaround for UNUSED_PARAM() 1460851 1 350092 fujii 2018-09-18 21:24:13 -0700 Created attachment 350092 Patch 1461573 2 fujii 2018-09-20 15:49:09 -0700 R? 1461668 3 350092 pvollan 2018-09-20 19:28:47 -0700 Comment on attachment 350092 Patch r=me 1461674 4 350092 fujii 2018-09-20 19:50:45 -0700 Comment on attachment 350092 Patch Clearing flags on attachment: 350092 Committed r236302: <https://trac.webkit.org/changeset/236302> 1461675 5 fujii 2018-09-20 19:50:48 -0700 All reviewed patches have been landed. Closing bug. 1461676 6 webkit-bug-importer 2018-09-20 19:51:36 -0700 <rdar://problem/44665709> 350092 2018-09-18 21:24:13 -0700 2018-09-20 19:50:45 -0700 Patch bug-189732-20180919132412.patch text/plain 1379 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQzMDhiZTE5MjgyYTlhMzEwZTg0MDRi MTA0NGQwNWNkZTQ5ZGFkY2UuLjU3OTkzYTc0MGYzMmRlMDI2Mjg0ZDNjODY4YWZlOTBiZGJmNzYx NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDktMTggIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bQ2xhbmddIFVOVVNFRF9QQVJB TSh0aGlzKSBjYXVzZXMgY29tcGlsYXRpb24gZXJyb3Igb2YgImNhbm5vdCB0YWtlIHRoZSBhZGRy ZXNzIG9mIGFuIHJ2YWx1ZSBvZiB0eXBlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ2xhbmcgZm9yIFdpbmRvd3MgY2FuJ3QgY29tcGlsZSB0aGUgTVNW QyB3b3JrYXJvdW5kIG9mCisgICAgICAgIFVOVVNFRF9QQVJBTSB3aGljaCBoYXMgYmVlbiBpbnRy b2R1Y2VkIGZvciBXaW5kb3dzIENFIGFuZCBWaXN1YWwKKyAgICAgICAgU3R1ZGlvIDEwLiBJIHRo aW5rIGl0J3Mgc2FmZSBqdXN0IHRvIHJlbW92ZSBpdC4KKworICAgICAgICAqIHd0Zi9Db21waWxl ci5oOiBSZW1vdmVkIHRoZSBjb2RlIGZvciBDT01QSUxFUihNU1ZDKS4KKwogMjAxOC0wOS0xNyAg WXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbV1RGXSBV c2UgU2VtYXBob3JlIGFuZCBCaW5hcnlTZW1hcGhvcmUgaW5zdGVhZCBvZiBkaXNwYXRjaF9zZW1h cGhvcmVfdApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaCBiL1NvdXJjZS9X VEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggNzFlNmI4ZTZhMDhlNTM3NTRlMTQ4YThlODM5MDc5NmQx YzlhYWMwYS4uOTBjZTQ4MjI5YzI1OWQ3YzhlZGU5YWM4MmMwMmQ3ZWM0ZjhmNmU3ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Db21w aWxlci5oCkBAIC0zNjMsMTAgKzM2Myw2IEBACiAKIC8qIFVOVVNFRF9QQVJBTSAqLwogCi0jaWYg IWRlZmluZWQoVU5VU0VEX1BBUkFNKSAmJiBDT01QSUxFUihNU1ZDKQotI2RlZmluZSBVTlVTRURf UEFSQU0odmFyaWFibGUpICh2b2lkKSZ2YXJpYWJsZQotI2VuZGlmCi0KICNpZiAhZGVmaW5lZChV TlVTRURfUEFSQU0pCiAjZGVmaW5lIFVOVVNFRF9QQVJBTSh2YXJpYWJsZSkgKHZvaWQpdmFyaWFi bGUKICNlbmRpZgo=