189730 2018-09-18 20:21:29 -0700 [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged' 2018-09-20 00:45:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen bfulgham ews-watchlist keith_miller mark.lam msaboff pvollan saam webkit-bug-importer oldest_to_newest 1460844 0 fujii 2018-09-18 20:21:29 -0700 [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged' While doing Bug 171618, following compilation error is reported. > [4/1360] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp.obj > FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource80.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp > In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp:1: > In file included from ..\..\Source\JavaScriptCore\jit/JITOpcodes.cpp:29: > ..\..\Source\JavaScriptCore\jit/JIT.h(745,31): warning: explicit specialization cannot have a storage class > static constexpr bool is64BitType<void>() { return true; } > ~~~~~~~ ^ > In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp:1: > In file included from ..\..\Source\JavaScriptCore\jit/JITOpcodes.cpp:29: > In file included from ..\..\Source\JavaScriptCore\jit/JIT.h:44: > ..\..\Source\JavaScriptCore\jit/JITMathIC.h(148,72): error: missing 'template' keyword prior to dependent template name 'retagged' > ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().retagged<JSInternalPtrTag>(), callReplacement); > ^ ~~~~~~~~~~~~~~~~~~ > 1 warning and 1 error generated. 1460845 1 350090 fujii 2018-09-18 20:38:42 -0700 Created attachment 350090 Patch 1461266 2 350090 fujii 2018-09-20 00:44:13 -0700 Comment on attachment 350090 Patch Clearing flags on attachment: 350090 Committed r236248: <https://trac.webkit.org/changeset/236248> 1461267 3 fujii 2018-09-20 00:44:16 -0700 All reviewed patches have been landed. Closing bug. 1461268 4 webkit-bug-importer 2018-09-20 00:45:27 -0700 <rdar://problem/44632168> 350090 2018-09-18 20:38:42 -0700 2018-09-20 00:44:13 -0700 Patch bug-189730-20180919123841.patch text/plain 1566 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 Y2U3YzMzOGZlZjMzNzJlNTZhYTI3NGU3NDk4Y2MwZmI4MTBjNmZjLi45MDM0YWI0NjQ5MDM5NTU1 NDk2YTY1YjU2OWVhNjVjODQwNmVhZDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wOS0xOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXVtDbGFuZ10gSklUTWF0aElDLmg6IGVycm9yOiBtaXNz aW5nICd0ZW1wbGF0ZScga2V5d29yZCBwcmlvciB0byBkZXBlbmRlbnQgdGVtcGxhdGUgbmFtZSAn cmV0YWdnZWQnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODk3MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDbGFuZyBmb3IgV2luZG93cyBjYW4ndCBjb21waWxlIHRoZSB3b3JrYXJvdW5kIGZvciBNU1ZD IHF1aXJrIGluIGdlbmVyYXRlT3V0T2ZMaW5lLgorCisgICAgICAgICogaml0L0pJVE1hdGhJQy5o OgorICAgICAgICAoZ2VuZXJhdGVPdXRPZkxpbmUpOiBBcHBlbmQgIiYmICFDT01QSUxFUihDTEFO RykiIHRvICIjaWYgQ09NUElMRVIoTVNWQykiLgorCiAyMDE4LTA5LTE3ICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBnZW5lcmF0ZSBD U1NLZXl3b3JkQ29tcGxldGlvbnMgZnJvbSBiYWNrZW5kIHZhbHVlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRNYXRoSUMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUTWF0aElDLmgKaW5kZXggNGUwMDk1OGQxOWY4ZjMwOGIzOTBmNmFiN2NiY2RlNDJk MDRjOWJhYS4uNjgxNjc5MjZmYmFlNzBjODY5MTRlOTk1NWNmZjBhYTkxZDA5MjA0YiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRNYXRoSUMuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVE1hdGhJQy5oCkBAIC0xNDQsNyArMTQ0LDcgQEAgcHVibGlj OgogICAgICAgICB9OwogCiAgICAgICAgIGF1dG8gcmVwbGFjZUNhbGwgPSBbJl0gKCkgewotI2lm IENPTVBJTEVSKE1TVkMpCisjaWYgQ09NUElMRVIoTVNWQykgJiYgIUNPTVBJTEVSKENMQU5HKQog ICAgICAgICAgICAgZnRsVGh1bmtBd2FyZVJlcGF0Y2hDYWxsKGNvZGVCbG9jaywgc2xvd1BhdGhD YWxsTG9jYXRpb24oKS5yZXRhZ2dlZDxKU0ludGVybmFsUHRyVGFnPigpLCBjYWxsUmVwbGFjZW1l bnQpOwogI2Vsc2UKICAgICAgICAgICAgIGZ0bFRodW5rQXdhcmVSZXBhdGNoQ2FsbChjb2RlQmxv Y2ssIHNsb3dQYXRoQ2FsbExvY2F0aW9uKCkudGVtcGxhdGUgcmV0YWdnZWQ8SlNJbnRlcm5hbFB0 clRhZz4oKSwgY2FsbFJlcGxhY2VtZW50KTsK