189688 2018-09-17 21:34:46 -0700 Update flakiness dashboard configuration for iOS 12 queues 2018-09-24 18:46:06 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189683 1 ryanhaddad ryanhaddad aakash_jain ap commit-queue don.olmstead fujii lforschler ross.kirsling webkit-bug-importer oldest_to_newest 1460498 0 ryanhaddad 2018-09-17 21:34:46 -0700 Update flakiness dashboard configuration for iOS 12 queues 1462266 1 350488 ryanhaddad 2018-09-21 21:04:52 -0700 Created attachment 350488 Patch 1462270 2 ryanhaddad 2018-09-21 21:12:01 -0700 CC'ing some Sony folks as an FYI since this incidentally adds WinCairo support to the flakiness dashboard. 1462300 3 ross.kirsling 2018-09-21 23:36:32 -0700 I think we might be missing some other pieces too though: https://bugs.webkit.org/show_bug.cgi?id=188345 Fujii-san, is your patch on that ticket ready for review? 1462497 4 fujii 2018-09-23 01:21:55 -0700 I hesitate to land the patch because WinCairo Debug buildbos are broken all the time. But, I didn’t know the script generate_builders_json.py. I should add WinCairo Realse and Debug bots. 1462714 5 ryanhaddad 2018-09-24 09:11:45 -0700 (In reply to Fujii Hironori from comment #4) > I hesitate to land the patch because WinCairo Debug buildbos are broken all > the time. But, I didn’t know the script generate_builders_json.py. I should > add WinCairo Realse and Debug bots. I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to remove WPE for now. You can add it with your change when you are ready. 1462716 6 350644 ryanhaddad 2018-09-24 09:16:51 -0700 Created attachment 350644 Patch 1462718 7 350644 ap 2018-09-24 09:18:45 -0700 Comment on attachment 350644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350644&action=review > Tools/TestResultServer/static-dashboards/builders.jsonp:26 > - "WPE Linux 64-bit Release (Tests)", > - "WPE Linux 64-bit Debug (Tests)" > + "WPE Linux 64-bit Debug (Tests)", > + "WPE Linux 64-bit Release (Tests)" What does this change? 1462719 8 ryanhaddad 2018-09-24 09:21:24 -0700 (In reply to Ryan Haddad from comment #5) > (In reply to Fujii Hironori from comment #4) > > I hesitate to land the patch because WinCairo Debug buildbos are broken all > > the time. But, I didn’t know the script generate_builders_json.py. I should > > add WinCairo Realse and Debug bots. > I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to > remove WPE for now. You can add it with your change when you are ready. s/WPE/WinCairo 1462720 9 ryanhaddad 2018-09-24 09:21:56 -0700 (In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 350644 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350644&action=review > > > Tools/TestResultServer/static-dashboards/builders.jsonp:26 > > - "WPE Linux 64-bit Release (Tests)", > > - "WPE Linux 64-bit Debug (Tests)" > > + "WPE Linux 64-bit Debug (Tests)", > > + "WPE Linux 64-bit Release (Tests)" > > What does this change? The generate_builders_json.py script alphabetized these automatically when I ran it. 1462723 10 ap 2018-09-24 09:29:22 -0700 And added trailing whitespace, it seems! 1462742 11 350644 commit-queue 2018-09-24 10:13:15 -0700 Comment on attachment 350644 Patch Clearing flags on attachment: 350644 Committed r236406: <https://trac.webkit.org/changeset/236406> 1462743 12 commit-queue 2018-09-24 10:13:17 -0700 All reviewed patches have been landed. Closing bug. 1462744 13 webkit-bug-importer 2018-09-24 10:14:23 -0700 <rdar://problem/44730039> 1463064 14 aakash_jain 2018-09-24 18:46:06 -0700 Deployed on webkit-test-results, it's live now. 350488 2018-09-21 21:04:52 -0700 2018-09-24 09:16:49 -0700 Patch bug-189688-20180921210451.patch text/plain 2118 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2ExZmEyMzljNDU1ODk5ZTY4OGMyMjNmZmJmZTlhZGQy OTliMTliNy4uODc3MGViMmNhMjVjMGMzNzU0OGI4ZjA5ZjU5MGZmZDU3Y2U4ZTUxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA5LTIxICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFVwZGF0ZSBmbGFraW5lc3MgZGFzaGJvYXJkIGNvbmZpZ3VyYXRpb24gZm9yIGlPUyAx MiBxdWV1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTY4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJ1biBnZW5lcmF0ZV9idWlsZGVyc19qc29uLnB5IHRvIHVwZGF0ZSB0aGUgYnVpbGRlcnMuanNv bnAgZmlsZSBmb3IgdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQuCisKKyAgICAgICAgKiBUZXN0UmVz dWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzb25wOgorCiAyMDE4LTA5LTIx ICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNMXSBM b2NhbCB2YXJpYWJsZXMgc2hvdWxkIGJlIHN0YXRpY2FsbHkgYWxsb2NhdGVkCmRpZmYgLS1naXQg YS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzb25w IGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qc29u cAppbmRleCA0NjdjOTljZDgzM2IyYzRhNDgzNzU5MWE5ZGEyODQ1NmUzMGIwOTVjLi45YzA4MjM1 MTdlOWI1Y2Y0YmQwMDc0MWUzNzg5YTlkZTgxNDk3NjBkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzb25wCisrKyBiL1Rvb2xz L1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanNvbnAKQEAgLTE3 LDEzICsxNywxNSBAQCBMT0FEX0JVSUxEQk9UX0RBVEEoWwogICAgICAgICAgICAgICAgICAgICAi QXBwbGUgU2llcnJhIFJlbGVhc2UgV0syIChUZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAg IkFwcGxlIFdpbiA3IERlYnVnIChUZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAgIkFwcGxl IFdpbiA3IFJlbGVhc2UgKFRlc3RzKSIsIAotICAgICAgICAgICAgICAgICAgICAiQXBwbGUgaU9T IDExIFNpbXVsYXRvciBEZWJ1ZyBXSzIgKFRlc3RzKSIsIAotICAgICAgICAgICAgICAgICAgICAi QXBwbGUgaU9TIDExIFNpbXVsYXRvciBSZWxlYXNlIFdLMiAoVGVzdHMpIiwgCisgICAgICAgICAg ICAgICAgICAgICJBcHBsZSBpT1MgMTIgU2ltdWxhdG9yIERlYnVnIFdLMiAoVGVzdHMpIiwgCisg ICAgICAgICAgICAgICAgICAgICJBcHBsZSBpT1MgMTIgU2ltdWxhdG9yIFJlbGVhc2UgV0syIChU ZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAgIkdUSyBMaW51eCA2NC1iaXQgRGVidWcgKFRl c3RzKSIsIAogICAgICAgICAgICAgICAgICAgICAiR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIChU ZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAgIkdUSyBMaW51eCA2NC1iaXQgUmVsZWFzZSBX YXlsYW5kIChUZXN0cykiLCAKLSAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQg UmVsZWFzZSAoVGVzdHMpIiwKLSAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQg RGVidWcgKFRlc3RzKSIKKyAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQgRGVi dWcgKFRlc3RzKSIsIAorICAgICAgICAgICAgICAgICAgICAiV1BFIExpbnV4IDY0LWJpdCBSZWxl YXNlIChUZXN0cykiLCAKKyAgICAgICAgICAgICAgICAgICAgIldpbkNhaXJvIDY0LWJpdCBXS0wg RGVidWcgKFRlc3RzKSIsIAorICAgICAgICAgICAgICAgICAgICAiV2luQ2Fpcm8gNjQtYml0IFdL TCBSZWxlYXNlIChUZXN0cykiCiAgICAgICAgICAgICAgICAgXQogICAgICAgICAgICAgfQogICAg ICAgICB9LCAK 350644 2018-09-24 09:16:51 -0700 2018-09-24 10:13:15 -0700 Patch bug-189688-20180924091650.patch text/plain 1878 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NDAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzQ3ZGQ1MWIyZGZlYzhkYmJiM2EyY2NhZWZhM2I2YjE2 OGM1MGZiNi4uYjU3MDc0MGM3NTA2YmEzMzNkOTM4OTllNjEzMzY1ZDQxYzFkODM4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTA5LTIxICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFVwZGF0ZSBmbGFraW5lc3MgZGFzaGJvYXJkIGNvbmZpZ3VyYXRpb24gZm9yIGlPUyAx MiBxdWV1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTY4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qc29ucDoKKwog MjAxOC0wOS0yNCAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dTdHJlYW1lcl0gVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzb25wIGIvVG9v bHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qc29ucAppbmRl eCA0NjdjOTljZDgzM2IyYzRhNDgzNzU5MWE5ZGEyODQ1NmUzMGIwOTVjLi43Nzk2ZDY0YjEzODIw Y2RkOTJjMzA3ZTBjOWMyYjA1YTQyYzQyZmQ2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzb25wCisrKyBiL1Rvb2xzL1Rlc3RS ZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanNvbnAKQEAgLTE3LDEzICsx NywxMyBAQCBMT0FEX0JVSUxEQk9UX0RBVEEoWwogICAgICAgICAgICAgICAgICAgICAiQXBwbGUg U2llcnJhIFJlbGVhc2UgV0syIChUZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAgIkFwcGxl IFdpbiA3IERlYnVnIChUZXN0cykiLCAKICAgICAgICAgICAgICAgICAgICAgIkFwcGxlIFdpbiA3 IFJlbGVhc2UgKFRlc3RzKSIsIAotICAgICAgICAgICAgICAgICAgICAiQXBwbGUgaU9TIDExIFNp bXVsYXRvciBEZWJ1ZyBXSzIgKFRlc3RzKSIsIAotICAgICAgICAgICAgICAgICAgICAiQXBwbGUg aU9TIDExIFNpbXVsYXRvciBSZWxlYXNlIFdLMiAoVGVzdHMpIiwgCisgICAgICAgICAgICAgICAg ICAgICJBcHBsZSBpT1MgMTIgU2ltdWxhdG9yIERlYnVnIFdLMiAoVGVzdHMpIiwgCisgICAgICAg ICAgICAgICAgICAgICJBcHBsZSBpT1MgMTIgU2ltdWxhdG9yIFJlbGVhc2UgV0syIChUZXN0cyki LCAKICAgICAgICAgICAgICAgICAgICAgIkdUSyBMaW51eCA2NC1iaXQgRGVidWcgKFRlc3RzKSIs IAogICAgICAgICAgICAgICAgICAgICAiR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIChUZXN0cyki LCAKICAgICAgICAgICAgICAgICAgICAgIkdUSyBMaW51eCA2NC1iaXQgUmVsZWFzZSBXYXlsYW5k IChUZXN0cykiLCAKLSAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQgUmVsZWFz ZSAoVGVzdHMpIiwKLSAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQgRGVidWcg KFRlc3RzKSIKKyAgICAgICAgICAgICAgICAgICAgIldQRSBMaW51eCA2NC1iaXQgRGVidWcgKFRl c3RzKSIsIAorICAgICAgICAgICAgICAgICAgICAiV1BFIExpbnV4IDY0LWJpdCBSZWxlYXNlIChU ZXN0cykiCiAgICAgICAgICAgICAgICAgXQogICAgICAgICAgICAgfQogICAgICAgICB9LCAK