189612 2018-09-13 20:19:44 -0700 [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function 2018-09-17 19:56:25 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen bfulgham pvollan webkit-bug-importer oldest_to_newest 1459646 0 fujii 2018-09-13 20:19:44 -0700 [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function While doing Bug 171618, the following compilation errors are reported. > [5/31] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\DefaultPolicyDelegate.cpp.obj > FAILED: Source/WebKitLegacy/CMakeFiles/WebKitLegacy.dir/win/DefaultPolicyDelegate.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c ..\..\Source\WebKitLegacy\win\DefaultPolicyDelegate.cpp > In file included from ..\..\Source\WebKitLegacy\win\DefaultPolicyDelegate.cpp:26: > ..\..\Source\WebKitLegacy\win/WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage] > extern HashCountedSet<WTF::String>& gClassNameCount(); > ^ > ..\..\Source\WebKitLegacy\win\DefaultPolicyDelegate.cpp(182,72): error: cannot pass object of non-trivial type 'WebCore::BString' through variadic function; call will abort at runtime [-Wnon-pod-varargs] > LOG_ERROR("called unableToImplementPolicyWithError:%S inFrame:%S", errorStr ? errorStr : TEXT(""), frameName ? frameName : TEXT("")); > ^ > ..\..\Source\WebKitLegacy\win\DefaultPolicyDelegate.cpp(182,104): error: cannot pass object of non-trivial type 'WebCore::BString' through variadic function; call will abort at runtime [-Wnon-pod-varargs] > LOG_ERROR("called unableToImplementPolicyWithError:%S inFrame:%S", errorStr ? errorStr : TEXT(""), frameName ? frameName : TEXT("")); > ^ > 1 warning and 2 errors generated. > [4/31] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebLocalizableStrings.cpp.obj > FAILED: Source/WebKitLegacy/CMakeFiles/WebKitLegacy.dir/win/WebLocalizableStrings.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c ..\..\Source\WebKitLegacy\win\WebLocalizableStrings.cpp > In file included from ..\..\Source\WebKitLegacy\win\WebLocalizableStrings.cpp:26: > ..\..\Source\WebKitLegacy\win/WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage] > extern HashCountedSet<WTF::String>& gClassNameCount(); > ^ > ..\..\Source\WebKitLegacy\win\WebLocalizableStrings.cpp(164,95): error: cannot pass object of non-trivial type 'const WTF::String' through variadic function; call will abort at runtime [-Wnon-pod-varargs] > ASSERT_WITH_MESSAGE(result != notFound, "could not find localizable string %s in bundle", key); > ^ > 1 warning and 1 error generated. > [5/31] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\DefaultPolicyDelegate.cpp.obj 1459647 1 fujii 2018-09-13 20:24:52 -0700 MSVC reports compilation warnings. > 1>------ Build started: Project: WebKitLegacy (WebKitLegacy\WebKitLegacy), Configuration: Debug x64 ------ > 1>DefaultPolicyDelegate.cpp > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): warning C4840: non-portable use of class 'WebCore::BString' as an argument to a variadic function > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): note: 'WebCore::BString::BString' is non-trivial > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\webcore\bstring.h(61): note: see declaration of 'WebCore::BString::BString' > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): note: the constructor and destructor will not be called; a bitwise copy of the class will be passed as the argument > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\webcore\bstring.h(45): note: see declaration of 'WebCore::BString' > 1>Done building project "WebKitLegacy.vcxproj". > ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== > 1>------ Build started: Project: WebKitLegacy (WebKitLegacy\WebKitLegacy), Configuration: Debug x64 ------ > 1>WebLocalizableStrings.cpp > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): warning C4840: non-portable use of class 'WTF::String' as an argument to a variadic function > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): note: 'WTF::String::String' is non-trivial > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\wtf\text\wtfstring.h(130): note: see declaration of 'WTF::String::String' > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): note: the constructor and destructor will not be called; a bitwise copy of the class will be passed as the argument > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\wtf\text\wtfstring.h(78): note: see declaration of 'WTF::String' > 1>Done building project "WebKitLegacy.vcxproj". > ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== 1459649 2 349729 fujii 2018-09-13 20:35:53 -0700 Created attachment 349729 Patch 1460474 3 349729 fujii 2018-09-17 19:55:34 -0700 Comment on attachment 349729 Patch Clearing flags on attachment: 349729 Committed r236099: <https://trac.webkit.org/changeset/236099> 1460475 4 fujii 2018-09-17 19:55:37 -0700 All reviewed patches have been landed. Closing bug. 1460476 5 webkit-bug-importer 2018-09-17 19:56:25 -0700 <rdar://problem/44543910> 349729 2018-09-13 20:35:53 -0700 2018-09-17 19:55:34 -0700 Patch bug-189612-20180914123552.patch text/plain 2688 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggNjVlMmFiMGM2ZjU1Mjg0Yzg5YWI3NTNhNTBhZDNjMjRhNjRmMjU1NC4uYTdkMmExY2FiOTZh NWFjMzU1Y2RhMzY3ODk4Yjc5MTFiMzBjZGZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA5LTEzICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW0NsYW5nXVtXZWJLaXRMZWdhY3ldIGVy cm9yOiBjYW5ub3QgcGFzcyBvYmplY3Qgb2Ygbm9uLXRyaXZpYWwgdHlwZSB0aHJvdWdoIHZhcmlh ZGljIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODk2MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOb24tdHJpdmlhbCB0eXBlcyBjYW4ndCBiZSB1c2VkIGFzIGFydWd1bWVudHMgb2YgTE9H X0VSUk9SIGFuZAorICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFLgorCisgICAgICAgICogRGVm YXVsdFBvbGljeURlbGVnYXRlLmNwcDoKKyAgICAgICAgKERlZmF1bHRQb2xpY3lEZWxlZ2F0ZTo6 dW5hYmxlVG9JbXBsZW1lbnRQb2xpY3lXaXRoRXJyb3IpOiBBcHBseQorICAgICAgICBzdGF0aWNf Y2FzdDxCU1RSPiB0byBjb252ZXJ0IEJTdHJpbmcuCisgICAgICAgICogV2ViTG9jYWxpemFibGVT dHJpbmdzLmNwcDoKKyAgICAgICAgKGNvcHlMb2NhbGl6ZWRTdHJpbmdGcm9tQnVuZGxlKTogQ29u dmVydCAna2V5JyBmcm9tIFdURjo6U3RyaW5nIHRvCisgICAgICAgIGNoYXIqIGJ5IHVzaW5nICdr ZXkudXRmOCgpLmRhdGEoKScuCisKIDIwMTgtMDktMTMgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRh ZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzNTk1My4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0RlZmF1bHRQb2xpY3lEZWxlZ2F0 ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9EZWZhdWx0UG9saWN5RGVsZWdhdGUuY3Bw CmluZGV4IDNiMDBmYjlkNzgxNGRjYTQ0NDkxYmRmYTg4YjAxNmVmZWEzNDQyZmIuLmU4ZTVmNWM0 Y2MxMWExMjA4M2JiZTRiNTE4YjJjNDg2ZWQ1NjhjODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvd2luL0RlZmF1bHRQb2xpY3lEZWxlZ2F0ZS5jcHAKKysrIGIvU291cmNlL1dlYktp dExlZ2FjeS93aW4vRGVmYXVsdFBvbGljeURlbGVnYXRlLmNwcApAQCAtMTc5LDcgKzE3OSw3IEBA IEhSRVNVTFQgRGVmYXVsdFBvbGljeURlbGVnYXRlOjp1bmFibGVUb0ltcGxlbWVudFBvbGljeVdp dGhFcnJvcihfSW5fb3B0XyBJV2ViVmllCiAgICAgQlN0cmluZyBmcmFtZU5hbWU7CiAgICAgZnJh bWUtPm5hbWUoJmZyYW1lTmFtZSk7CiAKLSAgICBMT0dfRVJST1IoImNhbGxlZCB1bmFibGVUb0lt cGxlbWVudFBvbGljeVdpdGhFcnJvcjolUyBpbkZyYW1lOiVTIiwgZXJyb3JTdHIgPyBlcnJvclN0 ciA6IFRFWFQoIiIpLCBmcmFtZU5hbWUgPyBmcmFtZU5hbWUgOiBURVhUKCIiKSk7CisgICAgTE9H X0VSUk9SKCJjYWxsZWQgdW5hYmxlVG9JbXBsZW1lbnRQb2xpY3lXaXRoRXJyb3I6JVMgaW5GcmFt ZTolUyIsIGVycm9yU3RyID8gc3RhdGljX2Nhc3Q8QlNUUj4oZXJyb3JTdHIpIDogVEVYVCgiIiks IGZyYW1lTmFtZSA/IHN0YXRpY19jYXN0PEJTVFI+KGZyYW1lTmFtZSkgOiBURVhUKCIiKSk7CiAK ICAgICByZXR1cm4gU19PSzsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu L1dlYkxvY2FsaXphYmxlU3RyaW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJM b2NhbGl6YWJsZVN0cmluZ3MuY3BwCmluZGV4IGM1NTYwN2Y2Mjc0YjlkNTZlNzgxMjlhNDM4MDJh ZDBhODgwY2MxNzguLmRlMDIyMWY1NDVmM2RmNGE2YWQxMGMwYWE5NmQzNmNiOGQ5MTYzZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYkxvY2FsaXphYmxlU3RyaW5ncy5j cHAKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViTG9jYWxpemFibGVTdHJpbmdzLmNw cApAQCAtMTYxLDcgKzE2MSw3IEBAIHN0YXRpYyBDRlN0cmluZ1JlZiBjb3B5TG9jYWxpemVkU3Ry aW5nRnJvbUJ1bmRsZShXZWJMb2NhbGl6YWJsZVN0cmluZ3NCdW5kbGUqIHN0CiAKICAgICBDRlN0 cmluZ1JlZiByZXN1bHQgPSBDRkNvcHlMb2NhbGl6ZWRTdHJpbmdXaXRoRGVmYXVsdFZhbHVlKGtl eS5jcmVhdGVDRlN0cmluZygpLmdldCgpLCAwLCBidW5kbGUsIG5vdEZvdW5kLCAwKTsKIAotICAg IEFTU0VSVF9XSVRIX01FU1NBR0UocmVzdWx0ICE9IG5vdEZvdW5kLCAiY291bGQgbm90IGZpbmQg bG9jYWxpemFibGUgc3RyaW5nICVzIGluIGJ1bmRsZSIsIGtleSk7CisgICAgQVNTRVJUX1dJVEhf TUVTU0FHRShyZXN1bHQgIT0gbm90Rm91bmQsICJjb3VsZCBub3QgZmluZCBsb2NhbGl6YWJsZSBz dHJpbmcgJXMgaW4gYnVuZGxlIiwga2V5LnV0ZjgoKS5kYXRhKCkpOwogICAgIHJldHVybiByZXN1 bHQ7CiB9CiAK