189608 2018-09-13 18:22:11 -0700 [iOS] ERROR: post-layout: dirty renderer(s) in WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker() 2019-01-04 16:08:40 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad zalan ap commit-queue dino jlewis3 rniwa simon.fraser tsavell webkit-bug-importer zalan oldest_to_newest 1459609 0 ryanhaddad 2018-09-13 18:22:11 -0700 The following is seen on iOS Simulator with layout test fast/frames/invalid-frameset.html ERROR: post-layout: dirty renderer(s) ./page/FrameViewLayoutContext.cpp(87) : auto WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()::(anonymous class)::operator()(const WebCore::RenderObject &) const (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout B---YGLC -- RenderView at (0,0) size 800x600 renderer->(0x130000d48) B-----L- -- HTML RenderBlock at (0,0) size 800x600 renderer->(0x13f0007e0) node->(0x130101728) B------- -- FRAMESET RenderFrameSet at (0,0) size 800x600 renderer->(0x164600310) node->(0x16cd00630) B------- -- FRAME RenderFrame at (0,0) size 800x600 renderer->(0x164500240) node->(0x163901710) B-----L- -- FRAMESET RenderFrameSet at (0,0) size 0x0 renderer->(0x164600498) node->(0x16cd006c0) B------- -+* FRAME RenderFrame at (0,0) size 0x0 renderer->(0x164500360) node->(0x1639017a0) layout->[self] SHOULD NEVER BE REACHED ./page/FrameViewLayoutContext.cpp(89) : auto WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()::(anonymous class)::operator()(const WebCore::RenderObject &) const 1 0x1117e29d9 WTFCrash 2 0x11518e23b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x117a6bfc5 WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()::'lambda'(WebCore::RenderObject const&)::operator()(WebCore::RenderObject const&) const 4 0x117a6bf12 WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker() 5 0x117a632f5 WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker() 6 0x117a43761 WebCore::FrameViewLayoutContext::layout() 7 0x117a62a6c WebCore::FrameViewLayoutContext::layoutTimerFired() 8 0x117a85e37 WTF::Function<void ()>::CallableWrapper<std::__1::__bind<void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*> >::call() 9 0x11518f6bd WTF::Function<void ()>::operator()() const 10 0x11521c8a9 WebCore::Timer::fired() 11 0x117c33b46 WebCore::ThreadTimers::sharedTimerFiredInternal() 12 0x117c4a811 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 13 0x117c4a7c9 WTF::Function<void ()>::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0>::call() 14 0x11518f6bd WTF::Function<void ()>::operator()() const 15 0x117c0aab7 WebCore::MainThreadSharedTimer::fired() 16 0x117cb2709 WebCore::timerFired(__CFRunLoopTimer*, void*) 17 0x107fb1e64 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 18 0x107fb1a52 __CFRunLoopDoTimer 19 0x107fb160a __CFRunLoopDoTimers 20 0x107fa8e4c __CFRunLoopRun 21 0x107fa830b CFRunLoopRunSpecific 22 0x1027d2b4a -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 23 0x1027d2a25 -[NSRunLoop(NSRunLoop) run] 24 0x109bd08c9 _xpc_objc_main 25 0x109bd2d73 xpc_main 26 0x102726bc4 WebKit::XPCServiceMain() 27 0x102726f0b main 28 0x109818955 start 29 0x1 LEAK: 1 WebPageProxy https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r235991%20(6431)/results.html 1459610 1 ryanhaddad 2018-09-13 18:23:38 -0700 Same assertion failure (with different output) also seen with imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests2.html on the same run: stderr: ERROR: post-layout: dirty renderer(s) ./page/FrameViewLayoutContext.cpp(87) : auto WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()::(anonymous class)::operator()(const WebCore::RenderObject &) const (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout B---YGL- -- RenderView at (0,0) size 0x0 renderer->(0x14a303278) B-----L- -- HTML RenderBlock at (0,0) size 0x0 renderer->(0x13b202400) node->(0x158e03bb8) B------- -- FRAMESET RenderFrameSet at (0,0) size 0x0 renderer->(0x171501570) node->(0x16ac00b40) B------- -- FRAME RenderFrame at (0,0) size 0x0 renderer->(0x177100120) node->(0x175300120) B------- -- FRAMESET RenderFrameSet at (0,0) size 0x0 renderer->(0x1715016f8) node->(0x16ac00bd0) B------- -+* FRAME RenderFrame at (0,0) size 0x0 renderer->(0x177100240) node->(0x1753001b0) layout->[self] 1459617 2 ryanhaddad 2018-09-13 18:44:19 -0700 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fframes%2Finvalid-frameset.html%20imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsyntax%2Fparsing%2Fhtml5lib_tests2.html 1459946 3 webkit-bug-importer 2018-09-14 16:28:59 -0700 <rdar://problem/44473299> 1460186 4 ryanhaddad 2018-09-17 09:50:14 -0700 fast/frames/invalid-frameset.html is hitting this consistently. The first occurrence blames: https://trac.webkit.org/log/webkit/?verbose=on&rev=235923&stop_rev=235920 imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests2.html is flaky, with the first occurrence blaming this range: https://trac.webkit.org/log/webkit/?verbose=on&rev=235939&stop_rev=235938 1460198 5 ryanhaddad 2018-09-17 10:12:35 -0700 I can reproduce the crash locally with fast/frames/invalid-frameset.html on r235921. I cannot reproduce with r235920. This seems to have regressed with https://trac.webkit.org/changeset/235921/webkit 1460208 6 ryanhaddad 2018-09-17 10:27:02 -0700 I haven't yet been able to reproduce the crash with imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests2.html, so this could be related to test order. 1462751 7 ryanhaddad 2018-09-24 10:28:45 -0700 Zalan, is this something you could take a look at? 1462752 8 zalan 2018-09-24 10:30:01 -0700 (In reply to Ryan Haddad from comment #7) > Zalan, is this something you could take a look at? Yes, unless it's a new test (or can be regressed to a certain commit). 1491898 9 358369 zalan 2019-01-04 14:22:40 -0800 Created attachment 358369 Patch 1491906 10 358369 simon.fraser 2019-01-04 14:31:14 -0800 Comment on attachment 358369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358369&action=review > Source/WebCore/rendering/RenderFrameSet.cpp:497 > +static void clearSiblingSubtrees(RenderBox* sibling, RenderFrameSet& frameSet) resetFrameRendererAndDescendents > Source/WebCore/rendering/RenderFrameSet.cpp:549 > // all the remaining frames are hidden to avoid ugly spurious unflowed frames Make this a full sentence. > Source/WebCore/rendering/RenderFrameSet.cpp:653 > // all the remaining frames are hidden to avoid ugly spurious unflowed frames Make this a full sentence. 1491907 11 358373 zalan 2019-01-04 14:36:49 -0800 Created attachment 358373 Patch 1491954 12 358373 commit-queue 2019-01-04 16:08:38 -0800 Comment on attachment 358373 Patch Clearing flags on attachment: 358373 Committed r239645: <https://trac.webkit.org/changeset/239645> 1491955 13 commit-queue 2019-01-04 16:08:40 -0800 All reviewed patches have been landed. Closing bug. 358369 2019-01-04 14:22:40 -0800 2019-01-04 14:36:48 -0800 Patch bug-189608-20190104142239.patch text/plain 2822 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdhMDk5MWM3YTQwNDYx MmZmYjRmM2U0Njc2NTJjYTdhM2ZmZjYwYi4uNTgyYTQ2MWQyODYyNTJhYTJiMzdkNDYwODNhYjhk MjdlODIyOTBmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAxLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRVJST1I6IHBvc3Qt bGF5b3V0OiBkaXJ0eSByZW5kZXJlcihzKSBpbiBXZWJDb3JlOjpSZW5kZXJUcmVlTmVlZHNMYXlv dXRDaGVja2VyOjp+UmVuZGVyVHJlZU5lZWRzTGF5b3V0Q2hlY2tlcigpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk2MDgKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQ0NDczMjk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gYSBmcmFtZXNldC9pZnJhbWUgaXMgaGlkZGVuIGFuZCB3ZSBza2lw IGxheW91dCwgY2xlYXIgdGhlIGRpcnR5IGZsYWcgb24gaXRzIHN1YnRyZWUgYXMgd2VsbC4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IGZhc3QvZnJhbWVzL2ludmFsaWQtZnJhbWVzZXQuaHRtbC4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpjbGVhclNpYmxpbmdTdWJ0cmVlcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNl dDo6cG9zaXRpb25GcmFtZXMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRnJhbWVTZXQ6OnBv c2l0aW9uRnJhbWVzV2l0aEZsYXR0ZW5pbmcpOgorCiAyMDE5LTAxLTAxICBKZWZmIE1pbGxlciAg PGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdXNlci12aXNpYmxlIGNvcHlyaWdo dCBzdHJpbmdzIHRvIGluY2x1ZGUgMjAxOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGcmFtZVNldC5jcHAKaW5kZXggMmQ0MTNiNjEwNGQzOTU5M2Q3ZmUwOGIwNmU4N2ZhYjFhNjdm Mzk4Ny4uY2I4MDU1ZjQ3NzJkOTAxOTQxYmRjZWNiNDkxNDg2ZTAyZDlhYjlhZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCkBAIC00OTQsNiArNDk0LDE4 IEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OmxheW91dCgpCiAgICAgY2xlYXJOZWVkc0xheW91dCgp OwogfQogCitzdGF0aWMgdm9pZCBjbGVhclNpYmxpbmdTdWJ0cmVlcyhSZW5kZXJCb3gqIHNpYmxp bmcsIFJlbmRlckZyYW1lU2V0JiBmcmFtZVNldCkKK3sKKyAgICBpZiAoIXNpYmxpbmcpCisgICAg ICAgIHJldHVybjsKKworICAgIGZvciAoYXV0byogZGVzY2VuZGFudCA9IHNpYmxpbmc7IGRlc2Nl bmRhbnQ7IGRlc2NlbmRhbnQgPSBkb3duY2FzdDxSZW5kZXJCb3g+KFJlbmRlck9iamVjdFRyYXZl cnNhbDo6bmV4dCgqZGVzY2VuZGFudCwgJmZyYW1lU2V0KSkpIHsKKyAgICAgICAgZGVzY2VuZGFu dC0+c2V0V2lkdGgoMCk7CisgICAgICAgIGRlc2NlbmRhbnQtPnNldEhlaWdodCgwKTsKKyAgICAg ICAgZGVzY2VuZGFudC0+Y2xlYXJOZWVkc0xheW91dCgpOworICAgIH0KK30KKwogdm9pZCBSZW5k ZXJGcmFtZVNldDo6cG9zaXRpb25GcmFtZXMoKQogewogICAgIFJlbmRlckJveCogY2hpbGQgPSBm aXJzdENoaWxkQm94KCk7CkBAIC01MzUsMTEgKzU0Nyw3IEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6 OnBvc2l0aW9uRnJhbWVzKCkKICAgICB9CiAKICAgICAvLyBhbGwgdGhlIHJlbWFpbmluZyBmcmFt ZXMgYXJlIGhpZGRlbiB0byBhdm9pZCB1Z2x5IHNwdXJpb3VzIHVuZmxvd2VkIGZyYW1lcwotICAg IGZvciAoYXV0byogZGVzY2VuZGFudCA9IGNoaWxkOyBkZXNjZW5kYW50OyBkZXNjZW5kYW50ID0g ZG93bmNhc3Q8UmVuZGVyQm94PihSZW5kZXJPYmplY3RUcmF2ZXJzYWw6Om5leHQoKmRlc2NlbmRh bnQsIHRoaXMpKSkgewotICAgICAgICBkZXNjZW5kYW50LT5zZXRXaWR0aCgwKTsKLSAgICAgICAg ZGVzY2VuZGFudC0+c2V0SGVpZ2h0KDApOwotICAgICAgICBkZXNjZW5kYW50LT5jbGVhck5lZWRz TGF5b3V0KCk7Ci0gICAgfQorICAgIGNsZWFyU2libGluZ1N1YnRyZWVzKGNoaWxkLCAqdGhpcyk7 CiB9CiAKIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OnBvc2l0aW9uRnJhbWVzV2l0aEZsYXR0ZW5pbmco KQpAQCAtNjQzLDExICs2NTEsNyBAQCB2b2lkIFJlbmRlckZyYW1lU2V0Ojpwb3NpdGlvbkZyYW1l c1dpdGhGbGF0dGVuaW5nKCkKICAgICAgICAgcmVwYWludCgpOwogCiAgICAgLy8gYWxsIHRoZSBy ZW1haW5pbmcgZnJhbWVzIGFyZSBoaWRkZW4gdG8gYXZvaWQgdWdseSBzcHVyaW91cyB1bmZsb3dl ZCBmcmFtZXMKLSAgICBmb3IgKDsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nQm94 KCkpIHsKLSAgICAgICAgY2hpbGQtPnNldFdpZHRoKDApOwotICAgICAgICBjaGlsZC0+c2V0SGVp Z2h0KDApOwotICAgICAgICBjaGlsZC0+Y2xlYXJOZWVkc0xheW91dCgpOwotICAgIH0KKyAgICBj bGVhclNpYmxpbmdTdWJ0cmVlcyhjaGlsZCwgKnRoaXMpOwogfQogCiBib29sIFJlbmRlckZyYW1l U2V0OjpmbGF0dGVuRnJhbWVTZXQoKSBjb25zdAo= 358373 2019-01-04 14:36:49 -0800 2019-01-04 16:08:38 -0800 Patch bug-189608-20190104143649.patch text/plain 2953 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdhMDk5MWM3YTQwNDYx MmZmYjRmM2U0Njc2NTJjYTdhM2ZmZjYwYi4uNDIzY2I2OTE4N2E2ZTcyZWYwY2E0NmE5MTU1NjM0 MDBlZjgxMGRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAxLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRVJST1I6IHBvc3Qt bGF5b3V0OiBkaXJ0eSByZW5kZXJlcihzKSBpbiBXZWJDb3JlOjpSZW5kZXJUcmVlTmVlZHNMYXlv dXRDaGVja2VyOjp+UmVuZGVyVHJlZU5lZWRzTGF5b3V0Q2hlY2tlcigpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk2MDgKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQ0NDczMjk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K KworICAgICAgICBXaGVuIGEgZnJhbWVzZXQvaWZyYW1lIGlzIGhpZGRlbiBhbmQgd2Ugc2tpcCBs YXlvdXQsIGNsZWFyIHRoZSBkaXJ0eSBmbGFnIG9uIGl0cyBzdWJ0cmVlIGFzIHdlbGwuCisKKyAg ICAgICAgQ292ZXJlZCBieSBmYXN0L2ZyYW1lcy9pbnZhbGlkLWZyYW1lc2V0Lmh0bWwuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Y2xlYXJTaWJsaW5nU3VidHJlZXMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRnJhbWVTZXQ6 OnBvc2l0aW9uRnJhbWVzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZyYW1lU2V0Ojpwb3Np dGlvbkZyYW1lc1dpdGhGbGF0dGVuaW5nKToKKwogMjAxOS0wMS0wMSAgSmVmZiBNaWxsZXIgIDxq ZWZmbUBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHVzZXItdmlzaWJsZSBjb3B5cmlnaHQg c3RyaW5ncyB0byBpbmNsdWRlIDIwMTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJGcmFtZVNldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RnJhbWVTZXQuY3BwCmluZGV4IDJkNDEzYjYxMDRkMzk1OTNkN2ZlMDhiMDZlODdmYWIxYTY3ZjM5 ODcuLjRjMzE2NzcwMTg3MDkxOWJmZDkxMWQzYWZmOGNjNTQxNzY0MTI2YTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcApAQCAtNDk0LDYgKzQ5NCwxOCBA QCB2b2lkIFJlbmRlckZyYW1lU2V0OjpsYXlvdXQoKQogICAgIGNsZWFyTmVlZHNMYXlvdXQoKTsK IH0KIAorc3RhdGljIHZvaWQgcmVzZXRGcmFtZVJlbmRlcmVyQW5kRGVzY2VuZGVudHMoUmVuZGVy Qm94KiBmcmFtZVNldENoaWxkLCBSZW5kZXJGcmFtZVNldCYgcGFyZW50RnJhbWVTZXQpCit7Cisg ICAgaWYgKCFmcmFtZVNldENoaWxkKQorICAgICAgICByZXR1cm47CisKKyAgICBmb3IgKGF1dG8q IGRlc2NlbmRhbnQgPSBmcmFtZVNldENoaWxkOyBkZXNjZW5kYW50OyBkZXNjZW5kYW50ID0gZG93 bmNhc3Q8UmVuZGVyQm94PihSZW5kZXJPYmplY3RUcmF2ZXJzYWw6Om5leHQoKmRlc2NlbmRhbnQs ICZwYXJlbnRGcmFtZVNldCkpKSB7CisgICAgICAgIGRlc2NlbmRhbnQtPnNldFdpZHRoKDApOwor ICAgICAgICBkZXNjZW5kYW50LT5zZXRIZWlnaHQoMCk7CisgICAgICAgIGRlc2NlbmRhbnQtPmNs ZWFyTmVlZHNMYXlvdXQoKTsKKyAgICB9Cit9CisKIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OnBvc2l0 aW9uRnJhbWVzKCkKIHsKICAgICBSZW5kZXJCb3gqIGNoaWxkID0gZmlyc3RDaGlsZEJveCgpOwpA QCAtNTM0LDEyICs1NDYsNyBAQCB2b2lkIFJlbmRlckZyYW1lU2V0Ojpwb3NpdGlvbkZyYW1lcygp CiAgICAgICAgIHlQb3MgKz0gaGVpZ2h0ICsgYm9yZGVyVGhpY2tuZXNzOwogICAgIH0KIAotICAg IC8vIGFsbCB0aGUgcmVtYWluaW5nIGZyYW1lcyBhcmUgaGlkZGVuIHRvIGF2b2lkIHVnbHkgc3B1 cmlvdXMgdW5mbG93ZWQgZnJhbWVzCi0gICAgZm9yIChhdXRvKiBkZXNjZW5kYW50ID0gY2hpbGQ7 IGRlc2NlbmRhbnQ7IGRlc2NlbmRhbnQgPSBkb3duY2FzdDxSZW5kZXJCb3g+KFJlbmRlck9iamVj dFRyYXZlcnNhbDo6bmV4dCgqZGVzY2VuZGFudCwgdGhpcykpKSB7Ci0gICAgICAgIGRlc2NlbmRh bnQtPnNldFdpZHRoKDApOwotICAgICAgICBkZXNjZW5kYW50LT5zZXRIZWlnaHQoMCk7Ci0gICAg ICAgIGRlc2NlbmRhbnQtPmNsZWFyTmVlZHNMYXlvdXQoKTsKLSAgICB9CisgICAgcmVzZXRGcmFt ZVJlbmRlcmVyQW5kRGVzY2VuZGVudHMoY2hpbGQsICp0aGlzKTsKIH0KIAogdm9pZCBSZW5kZXJG cmFtZVNldDo6cG9zaXRpb25GcmFtZXNXaXRoRmxhdHRlbmluZygpCkBAIC02NDIsMTIgKzY0OSw3 IEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OnBvc2l0aW9uRnJhbWVzV2l0aEZsYXR0ZW5pbmcoKQog ICAgIGlmIChyZXBhaW50TmVlZGVkKQogICAgICAgICByZXBhaW50KCk7CiAKLSAgICAvLyBhbGwg dGhlIHJlbWFpbmluZyBmcmFtZXMgYXJlIGhpZGRlbiB0byBhdm9pZCB1Z2x5IHNwdXJpb3VzIHVu Zmxvd2VkIGZyYW1lcwotICAgIGZvciAoOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxp bmdCb3goKSkgewotICAgICAgICBjaGlsZC0+c2V0V2lkdGgoMCk7Ci0gICAgICAgIGNoaWxkLT5z ZXRIZWlnaHQoMCk7Ci0gICAgICAgIGNoaWxkLT5jbGVhck5lZWRzTGF5b3V0KCk7Ci0gICAgfQor ICAgIHJlc2V0RnJhbWVSZW5kZXJlckFuZERlc2NlbmRlbnRzKGNoaWxkLCAqdGhpcyk7CiB9CiAK IGJvb2wgUmVuZGVyRnJhbWVTZXQ6OmZsYXR0ZW5GcmFtZVNldCgpIGNvbnN0Cg==