189588 2018-09-13 09:46:59 -0700 [WPE][GTK] Docs for WebKitWebView::load-failed do not tell which kind of errors are reported 2018-09-13 11:56:03 -0700 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified NEW P2 Normal --- 1 aperez aperez berto cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1459387 0 aperez 2018-09-13 09:46:59 -0700 As stated in the subject, the API documentation for the “WebKitWebView::load-failed” signal fail to mention which error domains may be set in the ”GError” instance passed to the signal handlers. Making people who want to use WebKit (GTK+/WPE) to dive into WebKit's source code to find out which kind of errors to handle is horrible, let's fix this. 1459400 1 349676 aperez 2018-09-13 10:10:44 -0700 Created attachment 349676 Patch 1459401 2 ews-watchlist 2018-09-13 10:13:14 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1459462 3 349676 mcatanzaro 2018-09-13 11:56:03 -0700 Comment on attachment 349676 Patch I'm pretty sure this is not exhaustive: * https://gitlab.gnome.org/GNOME/epiphany/issues/533 is caused by G_IO_ERROR, so we know that, at least, is also possible * Epiphany also checks for WEBKIT_POLICY_ERROR, so presumably that is possible too I'm quite nervous about documenting anything here unless we are really certain about the possible error domains. E.g. Epiphany doesn't expect SOUP_HTTP_ERROR or G_IO_ERROR. So we need to be more confident about what can really happen here. 349676 2018-09-13 10:10:44 -0700 2018-09-13 11:56:03 -0700 Patch bug-189588-20180913201043.patch text/plain 1679 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUwYjkwY2ViNzNmM2ZjNTZi MjQxMTI2MzJkNWYwNDc4YjhlM2U5ZTkuLmU4NjVhZjhjYzY2MzkzNGNjNzgwZTY4Yjc3Yjg4ZGMz ZjVlMmQzOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDktMTMgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IERvY3MgZm9yIFdlYktpdFdlYlZpZXc6OmxvYWQtZmFpbGVkIGRvIG5vdCB0ZWxsIHdoaWNoIGtp bmQgb2YgZXJyb3JzIGFyZSByZXBvcnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHA6 CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdCk6IEluZGljYXRlIGluIHRoZSBk b2N1bWVudGF0aW9uIHRoZSBwb3NzaWJsZSBlcnJvciBkb21haW5zLgorCiAyMDE4LTA5LTEzICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XVtXUEVdIEFsbG93IHRvIHJ1biBzY3JpcHQgZGlhbG9ncyBhc3luY2hyb25vdXNseSBpbiB0aGUg VUkgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRXZWJWaWV3LmNwcAppbmRleCAwZmE0YTE4Zjg5YzhjNTFhNDU0MDc3OGY1YWUyN2JlYTg3ZDdi NWYxLi4zMjA5MzUxYTM0MjkyMGMyMmRmMmYzYzI2NmU2ZWE0M2Q4ODExMTQyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcApAQCAt MTE4NCw2ICsxMTg0LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQo V2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiAgICAgICogQnkgZGVmYXVsdCwgaWYg dGhlIHNpZ25hbCBpcyBub3QgaGFuZGxlZCwgYSBzdG9jayBlcnJvciBwYWdlIHdpbGwgYmUgZGlz cGxheWVkLgogICAgICAqIFlvdSBuZWVkIHRvIGhhbmRsZSB0aGUgc2lnbmFsIGlmIHlvdSB3YW50 IHRvIHByb3ZpZGUgeW91ciBvd24gZXJyb3IgcGFnZS4KICAgICAgKgorICAgICAqIFRoZSBwb3Nz aWJsZSBkb21haW5zIGZvciB0aGUgQGVycm9yIGFyZSAjV0VCS0lUX05FVFdPUktfRVJST1IsCisg ICAgICogI1dFQktJVF9QTFVHSU5fRVJST1IsIGFuZCAjU09VUF9IVFRQX0VSUk9SLgorICAgICAq CiAgICAgICogUmV0dXJuczogJVRSVUUgdG8gc3RvcCBvdGhlciBoYW5kbGVycyBmcm9tIGJlaW5n IGludm9rZWQgZm9yIHRoZSBldmVudC4KICAgICAgKiAgICAlRkFMU0UgdG8gcHJvcGFnYXRlIHRo ZSBldmVudCBmdXJ0aGVyLgogICAgICAqLwo=