189575 2018-09-12 22:21:34 -0700 [Win][Clang] error: type 'float' cannot be narrowed to 'LONG' (aka 'long') in initializer list in WheelEventWin.cpp 2018-09-13 09:44:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1459260 0 fujii 2018-09-12 22:21:34 -0700 [Win][Clang] error: type 'float' cannot be narrowed to 'LONG' (aka 'long') in initializer list in WheelEventWin.cpp While doing Bug 171618, the following compilation errors are reported. > [5/664] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\win\WheelEventWin.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/win/WheelEventWin.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c ..\..\Source\WebCore\platform\win\WheelEventWin.cpp > ..\..\Source\WebCore\platform\win\WheelEventWin.cpp(86,20): error: type 'float' cannot be narrowed to 'LONG' (aka 'long') in initializer list [-Wc++11-narrowing] > POINT point = {location.x(), location.y()}; > ^~~~~~~~~~~~ > ..\..\Source\WebCore\platform\win\WheelEventWin.cpp(86,20): note: insert an explicit cast to silence this issue > POINT point = {location.x(), location.y()}; > ^~~~~~~~~~~~ > static_cast<LONG>( ) > ..\..\Source\WebCore\platform\win\WheelEventWin.cpp(86,34): error: type 'float' cannot be narrowed to 'LONG' (aka 'long') in initializer list [-Wc++11-narrowing] > POINT point = {location.x(), location.y()}; > ^~~~~~~~~~~~ > ..\..\Source\WebCore\platform\win\WheelEventWin.cpp(86,34): note: insert an explicit cast to silence this issue > POINT point = {location.x(), location.y()}; > ^~~~~~~~~~~~ > static_cast<LONG>( ) > 2 errors generated. 1459261 1 349628 fujii 2018-09-12 22:25:17 -0700 Created attachment 349628 Patch 1459382 2 349628 commit-queue 2018-09-13 09:43:53 -0700 Comment on attachment 349628 Patch Clearing flags on attachment: 349628 Committed r235975: <https://trac.webkit.org/changeset/235975> 1459383 3 commit-queue 2018-09-13 09:43:55 -0700 All reviewed patches have been landed. Closing bug. 1459384 4 webkit-bug-importer 2018-09-13 09:44:27 -0700 <rdar://problem/44420761> 349628 2018-09-12 22:25:17 -0700 2018-09-13 09:43:53 -0700 Patch bug-189575-20180913142516.patch text/plain 1863 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjAyNGY2YjczZjM3MWFi MzNkYjc4NmM3MTExMWM2YTQ3YTc3NGY0MC4uYWIwMTNjMzM5ZDQ0ZjVmNGJmZWQ4Nzc5ZTFjMjYw N2FkOTk1NWY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTEyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW0Ns YW5nXSBlcnJvcjogdHlwZSAnZmxvYXQnIGNhbm5vdCBiZSBuYXJyb3dlZCB0byAnTE9ORycgKGFr YSAnbG9uZycpIGluIGluaXRpYWxpemVyIGxpc3QgaW4gV2hlZWxFdmVudFdpbi5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU3NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAo Tm8gYmVoYXZpb3IgY2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9XaGVlbEV2ZW50 V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtV2hlZWxFdmVudDo6UGxhdGZvcm1X aGVlbEV2ZW50KTogVXNlIGZsb29yZWRJbnRQb2ludCB0byBjb252ZXJ0IEZsb2F0UG9pbnQgdG8g UE9JTlQuCisKIDIwMTgtMDktMTEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zaGFkb3ctZG9tL2Zvcm0t Y29udHJvbC1mb3JtLWF0dHJpYnV0ZS5odG1sIGhpdHMgYXNzZXJ0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vV2hlZWxFdmVudFdpbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS93aW4vV2hlZWxFdmVudFdpbi5jcHAKaW5kZXggYzI0YWVkMThlNTQzZTIw ZjEzZTQ2NjUxYzc4NzNjOGI2YzQ1YTI5Yy4uM2Q5MDQ2ZmE0ZGRiYTE5Zjc1NGQ3NGEyYmY2Y2Jk ZDM2MjNiYzRiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1doZWVs RXZlbnRXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9XaGVlbEV2ZW50 V2luLmNwcApAQCAtODMsMTIgKzgzLDEyIEBAIFBsYXRmb3JtV2hlZWxFdmVudDo6UGxhdGZvcm1X aGVlbEV2ZW50KEhXTkQgaFduZCwgY29uc3QgRmxvYXRTaXplJiBkZWx0YSwgY29uc3QKICAgICBt X3doZWVsVGlja3NZID0gbV9kZWx0YVk7CiAKICAgICAvLyBHbG9iYWwgUG9zaXRpb24gaXMganVz dCB4LCB5IGxvY2F0aW9uIG9mIGV2ZW50Ci0gICAgUE9JTlQgcG9pbnQgPSB7bG9jYXRpb24ueCgp LCBsb2NhdGlvbi55KCl9OwogICAgIGZsb2F0IGludmVyc2VTY2FsZUZhY3RvciA9IDEuMGYgLyBk ZXZpY2VTY2FsZUZhY3RvckZvcldpbmRvdyhoV25kKTsKLSAgICBtX2dsb2JhbFBvc2l0aW9uID0g cG9pbnQ7CisgICAgbV9nbG9iYWxQb3NpdGlvbiA9IGZsb29yZWRJbnRQb2ludChsb2NhdGlvbik7 CiAgICAgbV9nbG9iYWxQb3NpdGlvbi5zY2FsZShpbnZlcnNlU2NhbGVGYWN0b3IsIGludmVyc2VT Y2FsZUZhY3Rvcik7CiAKICAgICAvLyBQb3NpdGlvbiBuZWVkcyB0byBiZSB0cmFuc2xhdGVkIHRv IG91ciBjbGllbnQKKyAgICBQT0lOVCBwb2ludDsKICAgICBTY3JlZW5Ub0NsaWVudChoV25kLCAm cG9pbnQpOwogICAgIG1fcG9zaXRpb24gPSBwb2ludDsKICAgICBtX3Bvc2l0aW9uLnNjYWxlKGlu dmVyc2VTY2FsZUZhY3RvciwgaW52ZXJzZVNjYWxlRmFjdG9yKTsK