189556 2018-09-12 11:42:48 -0700 [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent' 2018-09-20 13:32:10 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Linux RESOLVED FIXED P2 Normal --- 1 bunnyapocalypse mcatanzaro annulen aperez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1459025 0 bunnyapocalypse 2018-09-12 11:42:48 -0700 WPEwebkit version 2.21.92 is currently failing to build on ARM architectures in Fedora, complaining about /builddir/build/BUILD/wpewebkit-2.21.92/Tools/wpe/backends/WindowViewBackend.cpp:610: undefined reference to `epoxy_eglMakeCurrent' and many other similar libepoxy things. Libepoxy is installed on the machines that WPE is building on, and the build succeeds on otherwise identical x86 and i686 machines. Here is the summary of the failed 64bit ARM build (see build.log under the "output" section for the compilation): https://koji.fedoraproject.org/koji/taskinfo?taskID=29607609 And here is the summary of the failed 32 bit ARM build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29607612 1459148 1 349591 mcatanzaro 2018-09-12 15:43:35 -0700 Created attachment 349591 Patch 1461455 2 mcatanzaro 2018-09-20 11:45:08 -0700 No reviews? Adrian: you want this before releasing WPE 2.20. 1461471 3 349591 aperez 2018-09-20 12:13:37 -0700 Comment on attachment 349591 Patch At any rate, linking to epoxy is the correct way to go because well, the library *is* used after all. With my informal reviewer hat I say “r+”. 1461477 4 bunnyapocalypse 2018-09-20 12:24:12 -0700 I don't know if you want this info, but the patch makes the package properly build for me. 1461478 5 aperez 2018-09-20 12:25:51 -0700 A quick theory on why this build failure happens in Fedora: it may have to do with compiler specs, or something that is put in LDFLAGS to avoid overlinking and/or lazy resolution (like “-Wl,--as-needed” or “-Wl,-z,now” — which is *good* practice). Something like that would explain why the library has to be explicitly listed. Like I wrote in my previous comment: the *correct* thing is to always list the library anyway, so I am very much favorable to landing the patch. 1461479 6 aperez 2018-09-20 12:27:50 -0700 (In reply to Chris King from comment #4) > I don't know if you want this info, but the patch makes the package properly > build for me. Yes, knowing that this fixes the build for you on Fedora is valuable information — thanks! 1461509 7 349591 commit-queue 2018-09-20 13:32:09 -0700 Comment on attachment 349591 Patch Clearing flags on attachment: 349591 Committed r236275: <https://trac.webkit.org/changeset/236275> 1461510 8 commit-queue 2018-09-20 13:32:10 -0700 All reviewed patches have been landed. Closing bug. 349591 2018-09-12 15:43:35 -0700 2018-09-20 13:32:09 -0700 Patch bug-189556-20180912174334.patch text/plain 1471 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTYwYWJlZTQxODlmMTQ0MmFmYzUyYzU5ODA5OTMwNWEy MDE3NWVkMS4uMGJlNDI4YzhjYTE4ZTBhMjk5N2E3MDdjODM0YzAxNGVhZGQzODE5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSArMSwxMyBA QAorMjAxOC0wOS0xMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW1dQRV0gZmFpbHMgdG8gYnVpbGQgb24gQVJNIGFyY2hlcyBjb21wbGFpbmlu ZyBhYm91dCB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBlcG94eV9lZ2xNYWtlQ3VycmVudCcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU1NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgb25s eSBhIHNwZWN1bGF0aXZlIGJ1aWxkIGZpeCBhcyBJIGRpZG4ndCBhdHRlbXB0IHRvIHJlcHJvZHVj ZS4gRXhwbGljaXRseSBsaW5rIHRvCisgICAgICAgIGxpYmVwb3h5LgorCisgICAgICAgICogd3Bl L2JhY2tlbmRzL0NNYWtlTGlzdHMudHh0OgorCiA9PSBSb2xsZWQgb3ZlciB0byBDaGFuZ2VMb2ct MjAxOC0wOS0xMSA9PQpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2JhY2tlbmRzL0NNYWtlTGlzdHMu dHh0IGIvVG9vbHMvd3BlL2JhY2tlbmRzL0NNYWtlTGlzdHMudHh0CmluZGV4IGY5ZThiNDNiOWZi OWE0NGRlNzY5ZmQ5NWMxMWQ3MDI3NjUxOWM1MDUuLjQzOWU4ZTNmNDhmNDg5ZGZiMzUxMTZlNmE1 YzkwYjY1NGZhNTFiZjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3dwZS9iYWNrZW5kcy9DTWFrZUxpc3Rz LnR4dAorKysgYi9Ub29scy93cGUvYmFja2VuZHMvQ01ha2VMaXN0cy50eHQKQEAgLTIxLDYgKzIx LDcgQEAgc2V0KFdQRVRvb2xpbmdCYWNrZW5kc19JTkNMVURFX0RJUkVDVE9SSUVTCiBzZXQoV1BF VG9vbGluZ0JhY2tlbmRzX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtDQUlST19J TkNMVURFX0RJUlN9CiAgICAgJHtHTElCX0lOQ0xVREVfRElSU30KKyAgICAke0xJQkVQT1hZX0lO Q0xVREVfRElSU30KICAgICAke1dQRV9JTkNMVURFX0RJUlN9CiAgICAgJHtXUEVCQUNLRU5EX0ZE T19JTkNMVURFX0RJUlN9CiApCkBAIC0yOCw2ICsyOSw3IEBAIHNldChXUEVUb29saW5nQmFja2Vu ZHNfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKIHNldChXUEVUb29saW5nQmFja2VuZHNfTElC UkFSSUVTCiAgICAgJHtDQUlST19MSUJSQVJJRVN9CiAgICAgJHtHTElCX0xJQlJBUklFU30KKyAg ICAke0xJQkVQT1hZX0xJQlJBUklFU30KICAgICAke0xJQlhLQkNPTU1PTl9MSUJSQVJJRVN9CiAg ICAgJHtXQVlMQU5EX0xJQlJBUklFU30KICAgICAke1dQRV9MSUJSQVJJRVN9Cg==