189543 2018-09-12 05:43:30 -0700 [GTK] Always prints in portrait when landscape is requested 2018-09-20 00:16:53 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bugzilla tpopela aperez bugs-noreply cgarcia commit-queue mcatanzaro tpopela oldest_to_newest 1458919 0 bugzilla 2018-09-12 05:43:30 -0700 Tested with epiphany and MiniBrowser. webkit2gtk3-2.20.5-1.fc28.x86_64 epiphany-3.28.3.1-1.fc28.x86_64 This happens with every page I try to print. I have to use Firefox to print in landscape mode so that data won't be missing from the printout. 1460956 1 350114 tpopela 2018-09-19 07:43:58 -0700 Created attachment 350114 Patch 1460994 2 350114 aperez 2018-09-19 09:42:30 -0700 Comment on attachment 350114 Patch This LGTM (informal r+!) 1461260 3 350114 commit-queue 2018-09-20 00:11:01 -0700 Comment on attachment 350114 Patch Rejecting attachment 350114 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 350114, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9278329 1461261 4 cgarcia 2018-09-20 00:16:53 -0700 Committed r236245: <https://trac.webkit.org/changeset/236245> 350114 2018-09-19 07:43:58 -0700 2018-09-20 00:11:01 -0700 Patch bug-189543-20180919164357.patch text/plain 1917 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1ODQ0NDI0OWMwNDRjYTlk Y2JlZjJmMGY0NjM0ZGFkNTgzYzJjMjQuLjNiNTcxNjUwMDFmMGFmNGVmYmUwNTE1ODBjODAzMGU0 MjRkOTI1YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDktMTkgIFRvbWFzIFBv cGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbR1RLXSBBbHdheXMgcHJpbnRz IGluIHBvcnRyYWl0IHdoZW4gbGFuZHNjYXBlIGlzIHJlcXVlc3RlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NTQzCisKKyAgICAgICAgV2UgaGF2 ZSB0byBjaGFuZ2UgdGhlIHN1cmZhY2Ugc2l6ZSBiYXNlZCBvbiB0aGUgcmVxdWVzdGVkIG9yaWVu dGF0aW9uLgorICAgICAgICBPdGhlcndpc2Ugb25seSBwb3J0cmFpdCB3aWxsIGJlIHByaW50ZWQg YXMgaXQncyBoYXJkY29kZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dl YlByaW50T3BlcmF0aW9uR3RrLmNwcDoKKwogMjAxOC0wOS0xOCAgQnJlbnQgRnVsZ2hhbSAgPGJm dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBbGxvdyBXZWJDb250ZW50IHByb2Nl c3MgdG8gY2hlY2sgdGhlICJQcm90b2NvbCBDaGFyYWN0ZXJpc3RpY3MiIG9mIGZpbGVzIHRvIHdo aWNoIGl0IGhhcyBhY2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9ndGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwCmluZGV4IGMyZmFlZmJi MjRhYzQ1NTY5OWQzMDk0YTBkYTFkMzE4ZTk3YjYwZmYuLmU1OGU5ZjFkZDdiMDc3ZjU2MWNhNTFj OTJmZWY3MTViMGFlMTQyOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcApAQCAtMTM0LDcg KzEzNCwxNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0gZWxzZSBpZiAoc3VyZmFjZVR5cGUgPT0gQ0FJUk9fU1VSRkFDRV9UWVBFX1BE RikKLSAgICAgICAgICAgIGNhaXJvX3BkZl9zdXJmYWNlX3NldF9zaXplKHN1cmZhY2UsIHdpZHRo LCBoZWlnaHQpOworICAgICAgICAgICAgc3dpdGNoIChndGtfcGFnZV9zZXR1cF9nZXRfb3JpZW50 YXRpb24obV9wYWdlU2V0dXAuZ2V0KCkpKSB7CisgICAgICAgICAgICBjYXNlIEdUS19QQUdFX09S SUVOVEFUSU9OX1BPUlRSQUlUOgorICAgICAgICAgICAgY2FzZSBHVEtfUEFHRV9PUklFTlRBVElP Tl9SRVZFUlNFX1BPUlRSQUlUOgorICAgICAgICAgICAgICAgIGNhaXJvX3BkZl9zdXJmYWNlX3Nl dF9zaXplKHN1cmZhY2UsIHdpZHRoLCBoZWlnaHQpOworICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgY2FzZSBHVEtfUEFHRV9PUklFTlRBVElPTl9MQU5EU0NBUEU6CisgICAgICAg ICAgICBjYXNlIEdUS19QQUdFX09SSUVOVEFUSU9OX1JFVkVSU0VfTEFORFNDQVBFOgorICAgICAg ICAgICAgICAgIGNhaXJvX3BkZl9zdXJmYWNlX3NldF9zaXplKHN1cmZhY2UsIGhlaWdodCwgd2lk dGgpOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQogICAgIH0KIAogICAg IHZvaWQgZW5kUGFnZShjYWlyb190KiBjcikgb3ZlcnJpZGUK