189542 2018-09-12 03:55:36 -0700 [Win][Clang] error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' 2018-09-12 09:49:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1458915 0 fujii 2018-09-12 03:55:36 -0700 [Win][Clang] error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' While trying to build WebKit WinCairo port with the latest Clang (Bug 171618), the following compilation errors are reported. > [4/664] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\win\IntPointWin.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/win/IntPointWin.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c ..\..\Source\WebCore\platform\graphics\win\IntPointWin.cpp > ..\..\Source\WebCore\platform\graphics\win\IntPointWin.cpp(56,17): error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' (aka 'short') in initializer list [-Wc++11-narrowing] > POINTS p = {m_x, m_y}; > ^~~ > ..\..\Source\WebCore\platform\graphics\win\IntPointWin.cpp(56,17): note: insert an explicit cast to silence this issue > POINTS p = {m_x, m_y}; > ^~~ > static_cast<SHORT>( ) > ..\..\Source\WebCore\platform\graphics\win\IntPointWin.cpp(56,22): error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' (aka 'short') in initializer list [-Wc++11-narrowing] > POINTS p = {m_x, m_y}; > ^~~ > ..\..\Source\WebCore\platform\graphics\win\IntPointWin.cpp(56,22): note: insert an explicit cast to silence this issue > POINTS p = {m_x, m_y}; > ^~~ > static_cast<SHORT>( ) > 2 errors generated. > [15/31] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\UIProcess\win\WebInspectorProxyWin.cpp.obj > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/win/WebInspectorProxyWin.cpp.obj > C:\tools\llvm\bin\clang-cl.exe (...) -c ..\..\Source\WebKit\UIProcess\win\WebInspectorProxyWin.cpp > ..\..\Source\WebKit\UIProcess\win\WebInspectorProxyWin.cpp(234,22): error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'LONG' (aka 'long') in initializer list [-Wc++11-narrowing] > RECT r = { 0, 0, initialWindowWidth, initialWindowHeight }; > ^~~~~~~~~~~~~~~~~~ > ..\..\Source\WebKit\UIProcess\win\WebInspectorProxyWin.cpp(234,22): note: insert an explicit cast to silence this issue > RECT r = { 0, 0, initialWindowWidth, initialWindowHeight }; > ^~~~~~~~~~~~~~~~~~ > static_cast<LONG>() > ..\..\Source\WebKit\UIProcess\win\WebInspectorProxyWin.cpp(234,42): error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'LONG' (aka 'long') in initializer list [-Wc++11-narrowing] > RECT r = { 0, 0, initialWindowWidth, initialWindowHeight }; > ^~~~~~~~~~~~~~~~~~~ > ..\..\Source\WebKit\UIProcess\win\WebInspectorProxyWin.cpp(234,42): note: insert an explicit cast to silence this issue > RECT r = { 0, 0, initialWindowWidth, initialWindowHeight }; > ^~~~~~~~~~~~~~~~~~~ > static_cast<LONG>( ) > 2 errors generated. 1458916 1 349539 fujii 2018-09-12 04:07:49 -0700 Created attachment 349539 Patch 1458994 2 349539 commit-queue 2018-09-12 09:47:28 -0700 Comment on attachment 349539 Patch Clearing flags on attachment: 349539 Committed r235942: <https://trac.webkit.org/changeset/235942> 1458995 3 commit-queue 2018-09-12 09:47:29 -0700 All reviewed patches have been landed. Closing bug. 1458996 4 webkit-bug-importer 2018-09-12 09:49:16 -0700 <rdar://problem/44386326> 349539 2018-09-12 04:07:49 -0700 2018-09-12 09:47:28 -0700 Patch bug-189542-20180912200748.patch text/plain 2933 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMwOWZkMzRkZTZlNjJl MDY2M2MzODNjMTE1NmYyNjgzNzkwMWIwMy4uOGQzOWZhYzI5ODQwMGRmODZmMThjZWNjMjNkZGVj MzBjMmVhNTYyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTEyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW0Ns YW5nXSBlcnJvcjogbm9uLWNvbnN0YW50LWV4cHJlc3Npb24gY2Fubm90IGJlIG5hcnJvd2VkIGZy b20gdHlwZSAnaW50JyB0byAnU0hPUlQnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODk1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE5vIGJlaGF2aW9yIGNoYW5nZSkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vSW50UG9pbnRXaW4uY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW50UG9pbnQ6Om9wZXJhdG9yIFBPSU5UUyBjb25zdCk6IE5hcnJvd2VkIG1feCBh bmQgbV95IGJ5IHVzaW5nIHN0YXRpY19jYXN0LgorCiAyMDE4LTA5LTExICBaYW4gRG9iZXJzZWsg IDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIFdQRSBidWlsZCBm aXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCmluZGV4IDk1MWM1NGViNWFiNjlmNGQ0ODA3NDE0Y2E5MWY4YWE1MTI1M2U2OTku LjBjZDAxNzY1YjllZDA5Yzg0NjA5ODBmNTMyZDM4OTI0MjZlYTE0OGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTgtMDktMTIgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlA c29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bQ2xhbmddIGVycm9yOiBub24tY29uc3RhbnQtZXhw cmVzc2lvbiBjYW5ub3QgYmUgbmFycm93ZWQgZnJvbSB0eXBlICdpbnQnIHRvICdTSE9SVCcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU0MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz L3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3Bl Y3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kUGFnZSk6IE5hcnJvd2VkIGluaXRpYWxX aW5kb3dXaWR0aCBhbmQgaW5pdGlhbFdpbmRvd0hlaWdodCBieSB1c2luZyBzdGF0aWNfY2FzdC4K KwogMjAxOC0wOS0xMSAgT2xpdmlhIEJhcm5ldHQgIDxvYmFybmV0dEBhcHBsZS5jb20+CiAKICAg ICAgICAgSW1wbGVtZW50IHRoZSBXZWIgU2hhcmUgQVBJIGZvciBtYWMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9JbnRQb2ludFdpbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vSW50UG9pbnRXaW4uY3BwCmluZGV4IGY3 Njc0OWU4ZDM3MGZhYTE0OTAyMzc5MWJmMTZjMzIxZTUyMzRjYmYuLjQxOWNjZjkwNTYzMDdiYTk0 MDZmYmU5N2UzMjBhYjY4Yjk2YjIwNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9JbnRQb2ludFdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL0ludFBvaW50V2luLmNwcApAQCAtNTMsNyArNTMsNyBAQCBJbnRQ b2ludDo6SW50UG9pbnQoY29uc3QgUE9JTlRTJiBwKQogCiBJbnRQb2ludDo6b3BlcmF0b3IgUE9J TlRTKCkgY29uc3QKIHsKLSAgICBQT0lOVFMgcCA9IHttX3gsIG1feX07CisgICAgUE9JTlRTIHAg PSB7IHN0YXRpY19jYXN0PFNIT1JUPihtX3gpLCBzdGF0aWNfY2FzdDxTSE9SVD4obV95KSB9Owog ICAgIHJldHVybiBwOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93 aW4vV2ViSW5zcGVjdG9yUHJveHlXaW4uY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvd2lu L1dlYkluc3BlY3RvclByb3h5V2luLmNwcAppbmRleCA3NTgxMzNkOTJkYmQ5ZGU1NWFhN2I4MjE4 NjZkYTZkMGMwMDM1YjNhLi5lZTg2MjdlMmMzNWQ1NGY3OGQ5YWU0ODhhMjhhYjJlZGVkNGMxMmY4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93aW4vV2ViSW5zcGVjdG9yUHJv eHlXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQ cm94eVdpbi5jcHAKQEAgLTIzMSw3ICsyMzEsNyBAQCBXZWJQYWdlUHJveHkqIFdlYkluc3BlY3Rv clByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kUGFnZSgpCiAgICAgICAgIG51bGxwdHIsIC8v IGRpZFJlbW92ZU5hdmlnYXRpb25HZXN0dXJlU25hcHNob3QKICAgICB9OwogCi0gICAgUkVDVCBy ID0geyAwLCAwLCBpbml0aWFsV2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQgfTsKKyAg ICBSRUNUIHIgPSB7IDAsIDAsIHN0YXRpY19jYXN0PExPTkc+KGluaXRpYWxXaW5kb3dXaWR0aCks IHN0YXRpY19jYXN0PExPTkc+KGluaXRpYWxXaW5kb3dIZWlnaHQpIH07CiAgICAgYXV0byBwYWdl ID0gaW5zcGVjdGVkUGFnZSgpOwogICAgIG1faW5zcGVjdGVkVmlld1dpbmRvdyA9IHBhZ2UtPnZp ZXdXaWRnZXQoKTsKICAgICBtX2luc3BlY3RlZFZpZXdQYXJlbnRXaW5kb3cgPSA6OkdldFBhcmVu dChtX2luc3BlY3RlZFZpZXdXaW5kb3cpOwo=