<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189437</bug_id>
          
          <creation_ts>2018-09-07 15:29:09 -0700</creation_ts>
          <short_desc>Many modern media control tests leak documents in testing</short_desc>
          <delta_ts>2018-09-17 21:15:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>186214</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>jeremyj-wk</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1457730</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-07 15:29:09 -0700</bug_when>
    <thetext>These and other media tests leak documents:

media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html [ Leak Pass ]
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-audio.html [ Leak Pass ]
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Leak Pass ]
media/modern-media-controls/css/pointer-events-none.html [ Leak ]
media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Leak ]
media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html [ Leak ]
media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Leak ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Leak ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Leak ]
media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Leak Pass ]
media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Leak Pass ]
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Leak Pass ]
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Leak ]
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Leak ]
media/modern-media-controls/placard-support/placard-support-pip.html [ Leak ]
media/modern-media-controls/seek-forward-support/seek-forward-support.html [ Leak ]
media/modern-media-controls/start-support/start-support-audio.html [ Leak Pass ]
media/modern-media-controls/start-support/start-support-click-to-start.html [ Leak ]
media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html [ Leak ]
media/modern-media-controls/tracks-support/tracks-support-audio-tracks.html [ Leak Pass ]
media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html [ Leak Pass ]
media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html [ Leak ]
media/modern-media-controls/volume-down-support/volume-down-support.html [ Leak ]
media/modern-media-controls/volume-up-support/volume-up-support.html [ Leak ]

media/W3C/video/events/event_canplay.html [ Leak Pass ]
media/W3C/video/events/event_canplaythrough.html [ Leak Pass ]
media/W3C/video/events/event_progress.html [ Leak Pass ]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1457732</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-07 15:29:31 -0700</bug_when>
    <thetext>&lt;rdar://problem/44241903&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458006</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-08 22:42:03 -0700</bug_when>
    <thetext>This is about SVGImages in the memory cache, which aren&apos;t cleared because they still have clients when we try to clear the cache (possibly because resources are still loading).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458156</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-10 10:34:06 -0700</bug_when>
    <thetext>These seem to be about the lifetime of the HTMLImageElements, which sometimes extends to after we&apos;ve cleared caches and fetched live documents. Those HTMLImageElements keep the ImageLoader alive, which is a client of the CachedImage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458158</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-10 11:03:06 -0700</bug_when>
    <thetext>There are a couple of variants of this.

Sometimes, the main document has live references, which seem to come from a Strong Handled pointing to the Window object.

Sometimes there are two HTMLImageElements which outlive the GC/clear caches, and they keep the document alive. They are usually one of the SVG data URI images, and modern-media-controls/images/macOS/Pause.svg</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458387</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-10 21:03:12 -0700</bug_when>
    <thetext>We&apos;re racing with ImageLoader::m_derefElementTimer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1459664</commentid>
    <comment_count>6</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-13 23:13:52 -0700</bug_when>
    <thetext>Fixed one issue by waiting on a zero-delay timer before the GC. But tests still leak; some lifetime extension of CachedImages that I haven&apos;t figure out yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460023</commentid>
    <comment_count>7</comment_count>
      <attachid>349851</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-14 21:50:47 -0700</bug_when>
    <thetext>Created attachment 349851
Patch to use RefTracker for tracking CachedResourceHandles on CachedResource</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460024</commentid>
    <comment_count>8</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-14 22:02:40 -0700</bug_when>
    <thetext>To fix all the SVGImage leaks, we have to:

* fire a zero-delay timer
* call document-&gt;cachedResourceLoader().garbageCollectDocumentResources()

before the final GC and live document count.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460025</commentid>
    <comment_count>9</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-14 22:23:25 -0700</bug_when>
    <thetext>Some fullscreen tests seems to leak media elements via WebFullScreenManager::enterFullScreenForElement(WebCore::Element*)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460027</commentid>
    <comment_count>10</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-14 22:40:53 -0700</bug_when>
    <thetext>Here&apos;s some logging for running media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html twice in a row:

WebFullScreenManager 0x6d22a3540 ctor
WebFullScreenManager 0x6d22a3540 enterFullScreenForElement(0x6cb000990)
WebFullScreenManager 0x6d22a3540 willEnterFullScreen() - element 0x6cb000990
Testing that control are shown in fullscreen when the controls attribute is not present.
PASS media.webkitDisplayingFullscreen is false
PASS media.webkitDisplayingFullscreen is true

WebFullScreenManager 0x6d22a3540 enterFullScreenForElement(0x6cf000990)
WebFullScreenManager 0x6d22a3540 willEnterFullScreen() - element 0x6cf000990
Testing that control are shown in fullscreen when the controls attribute is not present.
PASS media.webkitDisplayingFullscreen is false
PASS media.webkitDisplayingFullscreen is true

Jeremy, how is it that WTR can navigate away from webkit-cursor-visibility-auto-hide.html to about:blank but not close the fullscreen?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460046</commentid>
    <comment_count>11</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-15 11:30:41 -0700</bug_when>
    <thetext>Filed bug 189648 on the WebFullscreenManager leaks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460048</commentid>
    <comment_count>12</comment_count>
      <attachid>349860</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-15 11:39:10 -0700</bug_when>
    <thetext>Created attachment 349860
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460049</commentid>
    <comment_count>13</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-09-15 11:41:56 -0700</bug_when>
    <thetext>Attachment 349860 did not pass style-queue:


ERROR: Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:639:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:654:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the &apos;No new tests&apos; and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460065</commentid>
    <comment_count>14</comment_count>
      <attachid>349860</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-09-15 20:45:18 -0700</bug_when>
    <thetext>Comment on attachment 349860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349860&amp;action=review

&gt; Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:637
&gt; +    class TimerOwner {

Would RunLoop::main().dispatch work for this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460078</commentid>
    <comment_count>15</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-16 08:09:09 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #14)
&gt; Comment on attachment 349860 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=349860&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:637
&gt; &gt; +    class TimerOwner {
&gt; 
&gt; Would RunLoop::main().dispatch work for this?

RunLoop::main().dispatch() uses a CFRunLoopSource, and I don&apos;t think that is guaranteed to run after timesrs. I wanted a WebCore timer to ensure that it would hop the Timer used by ImageLoader.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1460492</commentid>
    <comment_count>16</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-17 21:15:04 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/236100/webkit</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>349851</attachid>
            <date>2018-09-14 21:50:47 -0700</date>
            <delta_ts>2018-09-15 11:40:03 -0700</delta_ts>
            <desc>Patch to use RefTracker for tracking CachedResourceHandles on CachedResource</desc>
            <filename>ref-tracker-for-resource-handles.patch</filename>
            <type>text/plain</type>
            <size>6507</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCmluZGV4
IGI0MGYxMzBlNmI3NTVlN2UzNzUwMDViOTE1Zjg4NzY0ZDlkYzM3ZDIuLjFmZDQ2YTMwOTZjZWRm
ZTMwMDI3NWRiOWIzMTRkYjg1YzFjYjVlNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xv
YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcApAQCAtMjQsNiArMjQsNyBAQAogI2luY2x1ZGUgImNv
bmZpZy5oIgogI2luY2x1ZGUgIkNhY2hlZFJlc291cmNlLmgiCiAKKyNpbmNsdWRlICJDYWNoZWRJ
bWFnZS5oIgogI2luY2x1ZGUgIkNhY2hlZFJlc291cmNlQ2xpZW50LmgiCiAjaW5jbHVkZSAiQ2Fj
aGVkUmVzb3VyY2VDbGllbnRXYWxrZXIuaCIKICNpbmNsdWRlICJDYWNoZWRSZXNvdXJjZUhhbmRs
ZS5oIgpAQCAtNjUsNiArNjYsMTIgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVz
cGFjZSBXVEY7CiAKK0hhc2hTZXQ8Q2FjaGVkUmVzb3VyY2UqPiYgQ2FjaGVkUmVzb3VyY2U6OmFs
bENhY2hlZFJlc291cmNlcygpCit7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEhhc2hTZXQ8
Q2FjaGVkUmVzb3VyY2UqPj4gc2V0OworICAgIHJldHVybiBzZXQ7Cit9CisKIFJlc291cmNlTG9h
ZFByaW9yaXR5IENhY2hlZFJlc291cmNlOjpkZWZhdWx0UHJpb3JpdHlGb3JSZXNvdXJjZVR5cGUo
VHlwZSB0eXBlKQogewogICAgIHN3aXRjaCAodHlwZSkgewpAQCAtMTMxLDYgKzEzOCw3IEBAIENh
Y2hlZFJlc291cmNlOjpDYWNoZWRSZXNvdXJjZShDYWNoZWRSZXNvdXJjZVJlcXVlc3QmJiByZXF1
ZXN0LCBUeXBlIHR5cGUsIFBBTDo6CiAgICAgLCBtX2hhc1Vua25vd25FbmNvZGluZyhyZXF1ZXN0
LmlzTGlua1ByZWxvYWQoKSkKICAgICAsIG1faWdub3JlRm9yUmVxdWVzdENvdW50KHJlcXVlc3Qu
aWdub3JlRm9yUmVxdWVzdENvdW50KCkpCiB7CisgICAgYWxsQ2FjaGVkUmVzb3VyY2VzKCkuYWRk
KHRoaXMpOwogICAgIEFTU0VSVChzZXNzaW9uSUQuaXNWYWxpZCgpKTsKIAogICAgIHNldExvYWRQ
cmlvcml0eShyZXF1ZXN0LnByaW9yaXR5KCkpOwpAQCAtMTU1LDYgKzE2Myw4IEBAIENhY2hlZFJl
c291cmNlOjpDYWNoZWRSZXNvdXJjZShjb25zdCBVUkwmIHVybCwgVHlwZSB0eXBlLCBQQUw6OlNl
c3Npb25JRCBzZXNzaW9uCiAgICAgLCBtX3N0YXR1cyhDYWNoZWQpCiAgICAgLCBtX3R5cGUodHlw
ZSkKIHsKKyAgICBhbGxDYWNoZWRSZXNvdXJjZXMoKS5hZGQodGhpcyk7CisKICAgICBBU1NFUlQo
c2Vzc2lvbklELmlzVmFsaWQoKSk7CiAjaWZuZGVmIE5ERUJVRwogICAgIGNhY2hlZFJlc291cmNl
TGVha0NvdW50ZXIuaW5jcmVtZW50KCk7CkBAIC0xNzYsNiArMTg2LDggQEAgQ2FjaGVkUmVzb3Vy
Y2U6On5DYWNoZWRSZXNvdXJjZSgpCiAKICAgICBpZiAobV9vd25pbmdDYWNoZWRSZXNvdXJjZUxv
YWRlcikKICAgICAgICAgbV9vd25pbmdDYWNoZWRSZXNvdXJjZUxvYWRlci0+cmVtb3ZlQ2FjaGVk
UmVzb3VyY2UoKnRoaXMpOworCisgICAgYWxsQ2FjaGVkUmVzb3VyY2VzKCkucmVtb3ZlKHRoaXMp
OwogfQogCiB2b2lkIENhY2hlZFJlc291cmNlOjpmYWlsQmVmb3JlU3RhcnRpbmcoKQpAQCAtNjEy
LDYgKzYyNCw3IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6OmRlY29kZWREYXRhRGVsZXRpb25UaW1l
ckZpcmVkKCkKIGJvb2wgQ2FjaGVkUmVzb3VyY2U6OmRlbGV0ZUlmUG9zc2libGUoKQogewogICAg
IGlmIChjYW5EZWxldGUoKSkgeworICAgICAgICBMT0coUmVzb3VyY2VMb2FkaW5nLCAiQ2FjaGVk
UmVzb3VyY2UgJXAgZGVsZXRlSWZQb3NzaWJsZSAtIGNhbiBkZWxldGUsIGluIGNhY2hlICVkIiwg
dGhpcywgaW5DYWNoZSgpKTsKICAgICAgICAgaWYgKCFpbkNhY2hlKCkpIHsKICAgICAgICAgICAg
IEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6d2lsbERlc3Ryb3lDYWNoZWRSZXNvdXJjZSgqdGhp
cyk7CiAgICAgICAgICAgICBkZWxldGUgdGhpczsKQEAgLTYyMCw2ICs2MzMsOCBAQCBib29sIENh
Y2hlZFJlc291cmNlOjpkZWxldGVJZlBvc3NpYmxlKCkKICAgICAgICAgaWYgKG1fZGF0YSkKICAg
ICAgICAgICAgIG1fZGF0YS0+aGludE1lbW9yeU5vdE5lZWRlZFNvb24oKTsKICAgICB9CisKKyAg
ICBMT0coUmVzb3VyY2VMb2FkaW5nLCAiQ2FjaGVkUmVzb3VyY2UgJXAgZGVsZXRlSWZQb3NzaWJs
ZSAtIGNhbid0IGRlbGV0ZSAoaGFzQ2xpZW50cyAlZCBsb2FkZXIgJXAgcHJlbG9hZENvdW50ICV1
IGhhbmRsZUNvdW50ICV1IHJlc291cmNlVG9SZXZhbGlkYXRlICVwIHByb3h5UmVzb3VyY2UgJXAp
IiwgdGhpcywgaGFzQ2xpZW50cygpLCBtX2xvYWRlci5nZXQoKSwgbV9wcmVsb2FkQ291bnQsIG1f
aGFuZGxlQ291bnQsIG1fcmVzb3VyY2VUb1JldmFsaWRhdGUsIG1fcHJveHlSZXNvdXJjZSk7CiAg
ICAgcmV0dXJuIGZhbHNlOwogfQogCkBAIC03ODAsOCArNzk1LDE1IEBAIHZvaWQgQ2FjaGVkUmVz
b3VyY2U6OnVwZGF0ZVJlc3BvbnNlQWZ0ZXJSZXZhbGlkYXRpb24oY29uc3QgUmVzb3VyY2VSZXNw
b25zZSYgdmFsCiB2b2lkIENhY2hlZFJlc291cmNlOjpyZWdpc3RlckhhbmRsZShDYWNoZWRSZXNv
dXJjZUhhbmRsZUJhc2UqIGgpCiB7CiAgICAgKyttX2hhbmRsZUNvdW50OworICAgIExPRyhSZXNv
dXJjZUxvYWRpbmcsICJDYWNoZWRSZXNvdXJjZSAlcCByZWdpc3RlckhhbmRsZSAtIGhhbmRsZSBj
b3VudCAldSIsIHRoaXMsIG1faGFuZGxlQ291bnQpOworCisgICAgaC0+c2V0VG9rZW4obV9oYW5k
bGVUcmFja2VyLnRyYWNrUmVmKCkpOworCiAgICAgaWYgKG1fcmVzb3VyY2VUb1JldmFsaWRhdGUp
CiAgICAgICAgIG1faGFuZGxlc1RvUmV2YWxpZGF0ZS5hZGQoaCk7CisgICAgCisvLyAgICBpZiAo
aXM8Q2FjaGVkSW1hZ2U+KHRoaXMpKQorLy8gICAgICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOwog
fQogCiB2b2lkIENhY2hlZFJlc291cmNlOjp1bnJlZ2lzdGVySGFuZGxlKENhY2hlZFJlc291cmNl
SGFuZGxlQmFzZSogaCkKQEAgLTc4OSw5ICs4MTEsMTcgQEAgdm9pZCBDYWNoZWRSZXNvdXJjZTo6
dW5yZWdpc3RlckhhbmRsZShDYWNoZWRSZXNvdXJjZUhhbmRsZUJhc2UqIGgpCiAgICAgQVNTRVJU
KG1faGFuZGxlQ291bnQgPiAwKTsKICAgICAtLW1faGFuZGxlQ291bnQ7CiAKKyAgICBMT0coUmVz
b3VyY2VMb2FkaW5nLCAiQ2FjaGVkUmVzb3VyY2UgJXAgdW5yZWdpc3RlckhhbmRsZSAtIGhhbmRs
ZSBjb3VudCAldSIsIHRoaXMsIG1faGFuZGxlQ291bnQpOworCisgICAgbV9oYW5kbGVUcmFja2Vy
LnRyYWNrRGVyZWYoaC0+dG9rZW4oKSk7CisgICAgaC0+c2V0VG9rZW4oVW50cmFja2VkUmVmVG9r
ZW4oKSk7CisgICAgCiAgICAgaWYgKG1fcmVzb3VyY2VUb1JldmFsaWRhdGUpCiAgICAgICAgICBt
X2hhbmRsZXNUb1JldmFsaWRhdGUucmVtb3ZlKGgpOwogCisvLyAgICBpZiAoaXM8Q2FjaGVkSW1h
Z2U+KHRoaXMpKQorLy8gICAgICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOworCiAgICAgaWYgKCFt
X2hhbmRsZUNvdW50KQogICAgICAgICBkZWxldGVJZlBvc3NpYmxlKCk7CiB9CmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaCBiL1NvdXJjZS9X
ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCmluZGV4IGVmMjI5NTUwZjQxMWRj
NTY1MDUyNjFiYzUyNWM3ZGJjZGU3ZDQzZGEuLmQwNGYzYTQ2ZTIyMjBjMWIyZGJhZjFmZDI3MGZj
YWYyNmIzYWRmYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNo
ZWRSZXNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNv
dXJjZS5oCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSA8dGltZS5oPgogI2luY2x1ZGUgPHd0
Zi9IYXNoQ291bnRlZFNldC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CisjaW5jbHVkZSA8
d3RmL1JlZlRyYWNrZXIuaD4KICNpbmNsdWRlIDx3dGYvVHlwZUNhc3RzLmg+CiAjaW5jbHVkZSA8
d3RmL1ZlY3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgpAQCAtOTYsNiAr
OTcsOCBAQCBwdWJsaWM6CiAKICAgICBDYWNoZWRSZXNvdXJjZShDYWNoZWRSZXNvdXJjZVJlcXVl
c3QmJiwgVHlwZSwgUEFMOjpTZXNzaW9uSUQpOwogICAgIHZpcnR1YWwgfkNhY2hlZFJlc291cmNl
KCk7CisgICAgCisgICAgc3RhdGljIEhhc2hTZXQ8Q2FjaGVkUmVzb3VyY2UqPiYgYWxsQ2FjaGVk
UmVzb3VyY2VzKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgbG9hZChDYWNoZWRSZXNvdXJjZUxvYWRl
ciYpOwogCkBAIC0yMTYsNiArMjE5LDggQEAgcHVibGljOgogCiAgICAgYm9vbCBjYW5EZWxldGUo
KSBjb25zdCB7IHJldHVybiAhaGFzQ2xpZW50cygpICYmICFtX2xvYWRlciAmJiAhbV9wcmVsb2Fk
Q291bnQgJiYgIW1faGFuZGxlQ291bnQgJiYgIW1fcmVzb3VyY2VUb1JldmFsaWRhdGUgJiYgIW1f
cHJveHlSZXNvdXJjZTsgfQogICAgIGJvb2wgaGFzT25lSGFuZGxlKCkgY29uc3QgeyByZXR1cm4g
bV9oYW5kbGVDb3VudCA9PSAxOyB9CisgICAgCisgICAgdW5zaWduZWQgaGFuZGxlQ291bnQoKSBj
b25zdCB7IHJldHVybiBtX2hhbmRsZUNvdW50OyB9CiAKICAgICBib29sIGlzRXhwaXJlZCgpIGNv
bnN0OwogCkBAIC0yNzksNiArMjg0LDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0T3JpZ2luYWxS
ZXF1ZXN0KHN0ZDo6dW5pcXVlX3B0cjxSZXNvdXJjZVJlcXVlc3Q+JiYgb3JpZ2luYWxSZXF1ZXN0
KSB7IG1fb3JpZ2luYWxSZXF1ZXN0ID0gV1RGTW92ZShvcmlnaW5hbFJlcXVlc3QpOyB9CiAgICAg
Y29uc3Qgc3RkOjp1bmlxdWVfcHRyPFJlc291cmNlUmVxdWVzdD4mIG9yaWdpbmFsUmVxdWVzdCgp
IGNvbnN0IHsgcmV0dXJuIG1fb3JpZ2luYWxSZXF1ZXN0OyB9CiAKKyAgICBSZWZUcmFja2VyJiBo
YW5kbGVUcmFja2VyKCkgeyByZXR1cm4gbV9oYW5kbGVUcmFja2VyOyB9CisKIHByb3RlY3RlZDoK
ICAgICAvLyBDYWNoZWRSZXNvdXJjZSBjb25zdHJ1Y3RvciB0aGF0IG1heSBiZSB1c2VkIHdoZW4g
dGhlIENhY2hlZFJlc291cmNlIGNhbiBhbHJlYWR5IGJlIGZpbGxlZCB3aXRoIHJlc3BvbnNlIGRh
dGEuCiAgICAgQ2FjaGVkUmVzb3VyY2UoY29uc3QgVVJMJiwgVHlwZSwgUEFMOjpTZXNzaW9uSUQp
OwpAQCAtMzc4LDYgKzM4NSw4IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2RlbGV0ZWQgeyBmYWxz
ZSB9OwogICAgIHVuc2lnbmVkIG1fbHJ1SW5kZXggeyAwIH07CiAjZW5kaWYKKworICAgIFJlZlRy
YWNrZXIgbV9oYW5kbGVUcmFja2VyOwogfTsKIAogY2xhc3MgQ2FjaGVkUmVzb3VyY2U6OkNhbGxi
YWNrIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNv
dXJjZUhhbmRsZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNl
SGFuZGxlLmgKaW5kZXggODJhMGQ3NTc2MTQ4YzZjMjY2MGFmNTEyNjNjZGUxZDg4MTFhMTZlYy4u
MWQzNjIxYzRjZGM0N2VkZGE2MWMyMmY5ZTIwNWE3MzE4N2VmMDZiZCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlSGFuZGxlLmgKKysrIGIvU291
cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlSGFuZGxlLmgKQEAgLTI2LDYg
KzI2LDcgQEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KKyNpbmNs
dWRlIDx3dGYvUmVmVHJhY2tpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00Myw2
ICs0NCw5IEBAIHB1YmxpYzoKICAgICB0eXBlZGVmIENhY2hlZFJlc291cmNlKiBDYWNoZWRSZXNv
dXJjZUhhbmRsZUJhc2U6OipVbnNwZWNpZmllZEJvb2xUeXBlOwogICAgIG9wZXJhdG9yIFVuc3Bl
Y2lmaWVkQm9vbFR5cGUoKSBjb25zdCB7IHJldHVybiBtX3Jlc291cmNlID8gJkNhY2hlZFJlc291
cmNlSGFuZGxlQmFzZTo6bV9yZXNvdXJjZSA6IDA7IH0KIAorICAgIHZvaWQgc2V0VG9rZW4oUmVm
VHJhY2tpbmdUb2tlbiB0b2tlbikgeyBtX3Rva2VuID0gdG9rZW47IH0KKyAgICBSZWZUcmFja2lu
Z1Rva2VuJiB0b2tlbigpIHsgcmV0dXJuIG1fdG9rZW47IH0KKwogcHJvdGVjdGVkOgogICAgIENh
Y2hlZFJlc291cmNlSGFuZGxlQmFzZSgpOwogICAgIENhY2hlZFJlc291cmNlSGFuZGxlQmFzZShD
YWNoZWRSZXNvdXJjZSopOwpAQCAtNTYsNiArNjAsNyBAQCBwcml2YXRlOgogICAgIGZyaWVuZCBj
bGFzcyBDYWNoZWRSZXNvdXJjZTsKIAogICAgIENhY2hlZFJlc291cmNlKiBtX3Jlc291cmNlOwor
ICAgIFJlZlRyYWNraW5nVG9rZW4gbV90b2tlbjsKIH07CiAgICAgCiB0ZW1wbGF0ZSA8Y2xhc3Mg
Uj4gY2xhc3MgQ2FjaGVkUmVzb3VyY2VIYW5kbGUgOiBwdWJsaWMgQ2FjaGVkUmVzb3VyY2VIYW5k
bGVCYXNlIHsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>349860</attachid>
            <date>2018-09-15 11:39:10 -0700</date>
            <delta_ts>2018-09-16 20:58:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189437-20180915113909.patch</filename>
            <type>text/plain</type>
            <size>8679</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVmMWY0MjEyODEwOGVh
MGNhOGM1MTYyZThiZWRmZGZhZDNkNTUzNC4uNmE3MDQyYzQ4M2MyOWM0YjBjYjk0NjVmYzgzM2Ux
YzE4YWQ2ZTM1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTE1ICBTaW1v
biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1hbnkgbW9kZXJu
IG1lZGlhIGNvbnRyb2wgdGVzdHMgbGVhayBkb2N1bWVudHMgaW4gdGVzdGluZworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDM3CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BT
ISkuCisKKyAgICAgICAgKiBwYWdlL01lbW9yeVJlbGVhc2UuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6cmVsZWFzZUNyaXRpY2FsTWVtb3J5KToKKwogMjAxOC0wOS0wOCAgU2ltb24gRnJhc2VyICA8
c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBzdmcvVzNDLVNWRy0xLjEvcmVuZGVy
LWdyb3Vwcy0wMy10LnN2ZyBhbmQgc29tZSBvdGhlciBTVkcgdGVzdHMgbGVhayBkb2N1bWVudHMK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggMDkzNjMxYjE2MmIzOWJjNmViYjJmYjJlNjI4Njk0NDI4NTc4ODE3ZC4uYTcy
OGYzYjU4MjUxODE5ODEzZDAxYjU3N2RjZGYxOWVjNWJkNDVlNCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwyNiBAQAorMjAxOC0wOS0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv
bT4KKworICAgICAgICBNYW55IG1vZGVybiBtZWRpYSBjb250cm9sIHRlc3RzIGxlYWsgZG9jdW1l
bnRzIGluIHRlc3RpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE4OTQzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEluIG9yZGVyIHRvIGFjY3VyYXRlbHkgZGV0ZWN0IGxlYWtzIGluIG1lZGlhIGNvbnRy
b2xzIHRlc3RzIHdoaWNoIHVzZSBsb3RzIG9mCisgICAgICAgIFNWR0ltYWdlcywgd2UgaGF2ZSB0
bzoKKyAgICAgICAgLSBGaXJlIGEgemVyby1kZWxheSB0aW1lciBhZnRlciB0aGUgcG9zdFRhc2ss
IGluIG9yZGVyIGZvciBJbWFnZXNMb2FkZXIncyBtX2RlcmVmRWxlbWVudFRpbWVyCisgICAgICAg
ICAgdG8gY2xlYXIgcmVmZXJlbmNlcyB0byBlbGVtZW50cy4KKyAgICAgICAgLSBIYXZlIHJlbGVh
c2VDcml0aWNhbE1lbW9yeSgpIGNhbGwgQ2FjaGVkUmVzb3VyY2VMb2FkZXIncyBnYXJiYWdlQ29s
bGVjdERvY3VtZW50UmVzb3VyY2VzKCkKKyAgICAgICAgICB0byBkcm9wIHRoZSBsYXN0IGhhbmRs
ZSB0byB0aGUgQ2FjaGVkUmVzb3VyY2UgZm9yIGFuIFNWR0ltYWdlLgorICAgICAgICAtIENhbGwg
V0tCdW5kbGVSZWxlYXNlTWVtb3J5KCkgYWZ0ZXIgdGhlIEdDIGFuZCB0aW1lciwgc2luY2Ugd2Ug
bmVlZCBnYXJiYWdlQ29sbGVjdERvY3VtZW50UmVzb3VyY2VzKCkKKyAgICAgICAgICB0byBydW4g
YWdhaW4gYWZ0ZXIgdGhhdCB0aW1lciBoYXMgZmlyZWQuCisgICAgICAgIAorICAgICAgICBUaGlz
IHNob3VsZCBmaXggYWxsIHRoZSBzcHVyaW91cyBsZWFrIHJlcG9ydHMgaW52b2x2aW5nIFNWR0lt
YWdlIGRvY3VtZW50cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ
L2MvV0tCdW5kbGVQYWdlLmNwcDoKKyAgICAgICAgKFdLQnVuZGxlUGFnZUNhbGxBZnRlclRhc2tz
QW5kVGltZXJzKToKKyAgICAgICAgKFdLQnVuZGxlUGFnZVBvc3RUYXNrKTogRGVsZXRlZC4KKyAg
ICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oOgor
CiAyMDE4LTA5LTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg
ICAgICAgIEJlZm9yZSB0cmFja2luZyBEb2N1bWVudCBsZWFrcywgY2xlYXIgYWxsIGNhY2hlcwpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9NZW1vcnlSZWxlYXNlLmNwcCBiL1NvdXJj
ZS9XZWJDb3JlL3BhZ2UvTWVtb3J5UmVsZWFzZS5jcHAKaW5kZXggNTc3NzhiZmYzYTMyZDdjMGE4
MGIxNTJjZjQ4MGNmMmFhMzE1ZjQ4OC4uNGE2N2ZlMDRiYzA5OTRmZTYxODkzMTliNTA0ZWM2Nzdj
MzBiMGZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9NZW1vcnlSZWxlYXNlLmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lbW9yeVJlbGVhc2UuY3BwCkBAIC0yOCw2ICsy
OCw3IEBACiAKICNpbmNsdWRlICJDU1NGb250U2VsZWN0b3IuaCIKICNpbmNsdWRlICJDU1NWYWx1
ZVBvb2wuaCIKKyNpbmNsdWRlICJDYWNoZWRSZXNvdXJjZUxvYWRlci5oIgogI2luY2x1ZGUgIkNo
cm9tZS5oIgogI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkNvbW1vblZNLmgi
CkBAIC04OCw2ICs4OSw3IEBAIHN0YXRpYyB2b2lkIHJlbGVhc2VDcml0aWNhbE1lbW9yeShTeW5j
aHJvbm91cyBzeW5jaHJvbm91cykKICAgICBmb3IgKGF1dG8mIGRvY3VtZW50IDogY29weVRvVmVj
dG9yT2Y8UmVmUHRyPERvY3VtZW50Pj4oRG9jdW1lbnQ6OmFsbERvY3VtZW50cygpKSkgewogICAg
ICAgICBkb2N1bWVudC0+c3R5bGVTY29wZSgpLnJlbGVhc2VNZW1vcnkoKTsKICAgICAgICAgZG9j
dW1lbnQtPmZvbnRTZWxlY3RvcigpLmVtcHR5Q2FjaGVzKCk7CisgICAgICAgIGRvY3VtZW50LT5j
YWNoZWRSZXNvdXJjZUxvYWRlcigpLmdhcmJhZ2VDb2xsZWN0RG9jdW1lbnRSZXNvdXJjZXMoKTsK
ICAgICB9CiAKICAgICBHQ0NvbnRyb2xsZXI6OnNpbmdsZXRvbigpLmRlbGV0ZUFsbENvZGUoSlND
OjpEZWxldGVBbGxDb2RlSWZOb3RDb2xsZWN0aW5nKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwIGIvU291
cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5j
cHAKaW5kZXggMjRkNGYwZDQ0OWQ0MDcxOTg4NjYxZGQwYzY2YmUwMGYxMDczODE5Zi4uZmNkNmUx
YjE2NmQyZjRiYTgzNmNhZjgyNGQxZWZjMDdmYjNmNWRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAKKysr
IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxl
UGFnZS5jcHAKQEAgLTYyMCw3ICs2MjAsNyBAQCB2b2lkIFdLQnVuZGxlUGFnZVJlZ2lzdGVyU2Ny
b2xsT3BlcmF0aW9uQ29tcGxldGlvbkNhbGxiYWNrKFdLQnVuZGxlUGFnZVJlZiBwYWdlUgogICAg
IH0pOwogfQogCi12b2lkIFdLQnVuZGxlUGFnZVBvc3RUYXNrKFdLQnVuZGxlUGFnZVJlZiBwYWdl
UmVmLCBXS0J1bmRsZVBhZ2VUZXN0Tm90aWZpY2F0aW9uQ2FsbGJhY2sgY2FsbGJhY2ssIHZvaWQq
IGNvbnRleHQpCit2b2lkIFdLQnVuZGxlUGFnZUNhbGxBZnRlclRhc2tzQW5kVGltZXJzKFdLQnVu
ZGxlUGFnZVJlZiBwYWdlUmVmLCBXS0J1bmRsZVBhZ2VUZXN0Tm90aWZpY2F0aW9uQ2FsbGJhY2sg
Y2FsbGJhY2ssIHZvaWQqIGNvbnRleHQpCiB7CiAgICAgaWYgKCFjYWxsYmFjaykKICAgICAgICAg
cmV0dXJuOwpAQCAtNjM0LDggKzYzNCwyOSBAQCB2b2lkIFdLQnVuZGxlUGFnZVBvc3RUYXNrKFdL
QnVuZGxlUGFnZVJlZiBwYWdlUmVmLCBXS0J1bmRsZVBhZ2VUZXN0Tm90aWZpY2F0aW9uQwogICAg
IGlmICghZG9jdW1lbnQpCiAgICAgICAgIHJldHVybjsKIAorICAgIGNsYXNzIFRpbWVyT3duZXIg
eworICAgIHB1YmxpYzoKKyAgICAgICAgVGltZXJPd25lcihXVEY6OkZ1bmN0aW9uPHZvaWQgKHZv
aWQqKT4mJiBjYWxsYmFjaywgdm9pZCogY29udGV4dCkKKyAgICAgICAgICAgIDogbV90aW1lcigq
dGhpcywgJlRpbWVyT3duZXI6OnRpbWVyRmlyZWQpCisgICAgICAgICAgICAsIG1fY2FsbGJhY2so
V1RGTW92ZShjYWxsYmFjaykpCisgICAgICAgICAgICAsIG1fY29udGV4dChjb250ZXh0KQorICAg
ICAgICB7CisgICAgICAgICAgICBtX3RpbWVyLnN0YXJ0T25lU2hvdCgwX3MpOworICAgICAgICB9
CisgICAgICAgIAorICAgICAgICB2b2lkIHRpbWVyRmlyZWQoKQorICAgICAgICB7CisgICAgICAg
ICAgICBtX2NhbGxiYWNrKG1fY29udGV4dCk7CisgICAgICAgICAgICBkZWxldGUgdGhpczsKKyAg
ICAgICAgfQorICAgICAgICAKKyAgICAgICAgV2ViQ29yZTo6VGltZXIgbV90aW1lcjsKKyAgICAg
ICAgV1RGOjpGdW5jdGlvbjx2b2lkICh2b2lkKik+IG1fY2FsbGJhY2s7CisgICAgICAgIHZvaWQq
IG1fY29udGV4dDsKKyAgICB9OworICAgIAogICAgIGRvY3VtZW50LT5wb3N0VGFzayhbPV0gKFdl
YkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmKSB7Ci0gICAgICAgIGNhbGxiYWNrKGNvbnRl
eHQpOworICAgICAgICBuZXcgVGltZXJPd25lcihjYWxsYmFjaywgY29udGV4dCk7IC8vIGRlbGV0
ZXMgaXRzZWxmIHdoZW4gZG9uZS4KICAgICB9KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oIGIvU291
cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5o
CmluZGV4IDI3NjU4OTEyNWVlOGUyYmY1ZTdmZTI1OWZkMmNjNzc2OTNlM2IxMjAuLmNkMDEzZGZl
ZjFiNDk5MWQ0YWRhOTMwODI4OTkzMWQyYTkxM2U4NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAorKysgYi9T
b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdl
LmgKQEAgLTExNyw4ICsxMTcsOCBAQCBXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tCdW5kbGVQYWdl
Q29weUdyb3VwSWRlbnRpZmllcihXS0J1bmRsZVBhZ2VSZWYgcGFnZSk7CiB0eXBlZGVmIHZvaWQg
KCpXS0J1bmRsZVBhZ2VUZXN0Tm90aWZpY2F0aW9uQ2FsbGJhY2spKHZvaWQqIGNvbnRleHQpOwog
V0tfRVhQT1JUIHZvaWQgV0tCdW5kbGVQYWdlUmVnaXN0ZXJTY3JvbGxPcGVyYXRpb25Db21wbGV0
aW9uQ2FsbGJhY2soV0tCdW5kbGVQYWdlUmVmLCBXS0J1bmRsZVBhZ2VUZXN0Tm90aWZpY2F0aW9u
Q2FsbGJhY2ssIHZvaWQqIGNvbnRleHQpOwogCi0vLyBQb3N0cyBhIHRhc2sgaW4gdGhlIFNjcmlw
dEV4ZWN1dGlvbkNvbnRleHQgb2YgdGhlIG1haW4gZnJhbWUuIFVzZWQgdG8gZG8gd29yayBhZnRl
ciBvdGhlciB0YXNrcyBoYXZlIGNvbXBsZXRlZC4KLVdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUGFn
ZVBvc3RUYXNrKFdLQnVuZGxlUGFnZVJlZiwgV0tCdW5kbGVQYWdlVGVzdE5vdGlmaWNhdGlvbkNh
bGxiYWNrLCB2b2lkKiBjb250ZXh0KTsKKy8vIENhbGwgdGhlIGdpdmVuIGNhbGxiYWNrIGFmdGVy
IGJvdGggYSBwb3N0VGFzaygpIG9uIHRoZSBwYWdlJ3MgZG9jdW1lbnQncyBTY3JpcHRFeGVjdXRp
b25Db250ZXh0LCBhbmQgYSB6ZXJvLWRlbGF5IHRpbWVyLgorV0tfRVhQT1JUIHZvaWQgV0tCdW5k
bGVQYWdlQ2FsbEFmdGVyVGFza3NBbmRUaW1lcnMoV0tCdW5kbGVQYWdlUmVmLCBXS0J1bmRsZVBh
Z2VUZXN0Tm90aWZpY2F0aW9uQ2FsbGJhY2ssIHZvaWQqIGNvbnRleHQpOwogCiBXS19FWFBPUlQg
dm9pZCBXS0J1bmRsZVBhZ2VQb3N0TWVzc2FnZShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tTdHJp
bmdSZWYgbWVzc2FnZU5hbWUsIFdLVHlwZVJlZiBtZXNzYWdlQm9keSk7CiAKZGlmZiAtLWdpdCBh
L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OTgyNTQzNTY5NTdmNWZl
YjZkNzJhZTE0ODQwZTc0NGYzNTk4MDg0Li5iNGViMGFiMWZjM2UxODg5Y2I0MzY4YjI4ZDVhY2Yw
ZDFmNDUyNzU3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDktMTUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy
YXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgTWFueSBtb2Rlcm4gbWVkaWEgY29udHJvbCB0ZXN0
cyBsZWFrIGRvY3VtZW50cyBpbiB0ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xODk0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEluIG9yZGVyIHRvIGFjY3VyYXRlbHkgZGV0ZWN0
IGxlYWtzIGluIG1lZGlhIGNvbnRyb2xzIHRlc3RzIHdoaWNoIHVzZSBsb3RzIG9mCisgICAgICAg
IFNWR0ltYWdlcywgd2UgaGF2ZSB0bzoKKyAgICAgICAgLSBGaXJlIGEgemVyby1kZWxheSB0aW1l
ciBhZnRlciB0aGUgcG9zdFRhc2ssIGluIG9yZGVyIGZvciBJbWFnZXNMb2FkZXIncyBtX2RlcmVm
RWxlbWVudFRpbWVyCisgICAgICAgICAgdG8gY2xlYXIgcmVmZXJlbmNlcyB0byBlbGVtZW50cy4K
KyAgICAgICAgLSBIYXZlIHJlbGVhc2VDcml0aWNhbE1lbW9yeSgpIGNhbGwgQ2FjaGVkUmVzb3Vy
Y2VMb2FkZXIncyBnYXJiYWdlQ29sbGVjdERvY3VtZW50UmVzb3VyY2VzKCkKKyAgICAgICAgICB0
byBkcm9wIHRoZSBsYXN0IGhhbmRsZSB0byB0aGUgQ2FjaGVkUmVzb3VyY2UgZm9yIGFuIFNWR0lt
YWdlLgorICAgICAgICAtIENhbGwgV0tCdW5kbGVSZWxlYXNlTWVtb3J5KCkgYWZ0ZXIgdGhlIEdD
IGFuZCB0aW1lciwgc2luY2Ugd2UgbmVlZCBnYXJiYWdlQ29sbGVjdERvY3VtZW50UmVzb3VyY2Vz
KCkKKyAgICAgICAgICB0byBydW4gYWdhaW4gYWZ0ZXIgdGhhdCB0aW1lciBoYXMgZmlyZWQuCisg
ICAgICAgIAorICAgICAgICBUaGlzIHNob3VsZCBmaXggYWxsIHRoZSBzcHVyaW91cyBsZWFrIHJl
cG9ydHMgaW52b2x2aW5nIFNWR0ltYWdlIGRvY3VtZW50cy4KKworICAgICAgICAqIFdlYktpdFRl
c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV1RS
OjpJbmplY3RlZEJ1bmRsZTo6cmVwb3J0TGl2ZURvY3VtZW50cyk6CisgICAgICAgIChXVFI6Oklu
amVjdGVkQnVuZGxlOjpkaWRSZWNlaXZlTWVzc2FnZVRvUGFnZSk6CisKIDIwMTgtMDktMDggIFNp
bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQmVmb3JlIHRy
YWNraW5nIERvY3VtZW50IGxlYWtzLCBjbGVhciBhbGwgY2FjaGVzCmRpZmYgLS1naXQgYS9Ub29s
cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcCBiL1Rv
b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCmlu
ZGV4IDY5MmZiODVhNTEyZmMyZDVjMWU0NTIzNGJmZjA2YzFkMDg0NmUzNmYuLjNiMjg3NmZkMDEw
MmZmMWJmNTRmYTZkMGU1YjAxOGQ4YzkzMmZjOTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRl
c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCisrKyBiL1Rvb2xzL1dl
YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCkBAIC0xODks
NiArMTg5LDkgQEAgc3RhdGljIHZvaWQgcG9zdEdDVGFzayh2b2lkKiBjb250ZXh0KQogCiB2b2lk
IEluamVjdGVkQnVuZGxlOjpyZXBvcnRMaXZlRG9jdW1lbnRzKFdLQnVuZGxlUGFnZVJlZiBwYWdl
KQogeworICAgIC8vIFJlbGVhc2UgbWVtb3J5IGFnYWluLCBhZnRlciB0aGUgR0MgYW5kIHRpbWVy
IGZpcmUuIFRoaXMgaXMgbmVjZXNzYXJ5IHRvIGNsZWFyIGVudHJpZXMgZnJvbSBDYWNoZWRSZXNv
dXJjZUxvYWRlcidzIG1fZG9jdW1lbnRSZXNvdXJjZXMgaW4gc29tZSBzY2VuYXJpb3MuCisgICAg
V0tCdW5kbGVSZWxlYXNlTWVtb3J5KG1fYnVuZGxlKTsKKwogICAgIGNvbnN0IGJvb2wgZXhjbHVk
ZURvY3VtZW50c0luUGFnZUdyb3VwID0gdHJ1ZTsKICAgICBhdXRvIGRvY3VtZW50VVJMcyA9IGFk
b3B0V0soV0tCdW5kbGVHZXRMaXZlRG9jdW1lbnRVUkxzKG1fYnVuZGxlLCBtX3BhZ2VHcm91cCwg
ZXhjbHVkZURvY3VtZW50c0luUGFnZUdyb3VwKSk7CiAgICAgCkBAIC0yODcsNyArMjkwLDcgQEAg
dm9pZCBJbmplY3RlZEJ1bmRsZTo6ZGlkUmVjZWl2ZU1lc3NhZ2VUb1BhZ2UoV0tCdW5kbGVQYWdl
UmVmIHBhZ2UsIFdLU3RyaW5nUmVmIG0KICAgICAgICAgV0tCdW5kbGVSZWxlYXNlTWVtb3J5KG1f
YnVuZGxlKTsKIAogICAgICAgICBXS1JldGFpbihwYWdlKTsgLy8gQmFsYW5jZWQgYnkgdGhlIHJl
bGVhc2UgaW4gcG9zdEdDVGFzay4KLSAgICAgICAgV0tCdW5kbGVQYWdlUG9zdFRhc2socGFnZSwg
cG9zdEdDVGFzaywgKHZvaWQqKXBhZ2UpOworICAgICAgICBXS0J1bmRsZVBhZ2VDYWxsQWZ0ZXJU
YXNrc0FuZFRpbWVycyhwYWdlLCBwb3N0R0NUYXNrLCAodm9pZCopcGFnZSk7CiAgICAgICAgIHJl
dHVybjsKICAgICB9CiAK
</data>
<flag name="review"
          id="367362"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>