189399 2018-09-07 00:39:38 -0700 [Win][Clang] duplicated variable name `advance` in UniscribeController::shapeAndPlaceItem 2018-09-07 16:48:22 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii bfulgham commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1457427 0 fujii 2018-09-07 00:39:38 -0700 [Win][Clang] duplicated variable name `advance` in UniscribeController::shapeAndPlaceItem While trying to build WebKit WinCairo port with the latest Clang (Bug 171618), the following compilation error is reported. This code has been introduced in Bug 188032. > [6/664] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\win\UniscribeController.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/win/UniscribeController.cpp.obj > C:\tools\llvm\bin\clang-cl.exe /nologo -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DHAVE_CONFIG_H=1 -DNOMINMAX -DSTATICALLY_LINKED_WITH_PAL=1 -DUCHAR_TYPE=wchar_t -DUNICODE -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -D__STDC_CONSTANT_MACROS -I..\..\WebKitLibraries\win\include -I. -I..\..\Source\WebCore -I..\..\Source\WebCore\Modules\airplay -I..\..\Source\WebCore\Modules\beacon -I..\..\Source\WebCore\Modules\applepay -I..\..\Source\WebCore\Modules\applepay\paymentrequest -I..\..\Source\WebCore\Modules\cache -I..\..\Source\WebCore\Modules\credentialmanagement -I..\..\Source\WebCore\Modules\encryptedmedia -I..\..\Source\WebCore\Modules\encryptedmedia\legacy -I..\..\Source\WebCore\Modules\entriesapi -I..\..\Source\WebCore\Modules\fetch -I..\..\Source\WebCore\Modules\geolocation -I..\..\Source\WebCore\Modules\indexeddb -I..\..\Source\WebCore\Modules\indexeddb\client -I..\..\Source\WebCore\Modules\indexeddb\server -I..\..\Source\WebCore\Modules\indexeddb\shared -I..\..\Source\WebCore\Modules\mediacapabilities -I..\..\Source\WebCore\Modules\mediacontrols -I..\..\Source\WebCore\Modules\mediasession -I..\..\Source\WebCore\Modules\mediasource -I..\..\Source\WebCore\Modules\mediastream -I..\..\Source\WebCore\Modules\navigatorcontentutils -I..\..\Source\WebCore\Modules\notifications -I..\..\Source\WebCore\Modules\paymentrequest -I..\..\Source\WebCore\Modules\plugins -I..\..\Source\WebCore\Modules\quota -I..\..\Source\WebCore\Modules\speech -I..\..\Source\WebCore\Modules\streams -I..\..\Source\WebCore\Modules\webaudio -I..\..\Source\WebCore\Modules\webauthn -I..\..\Source\WebCore\Modules\webdatabase -I..\..\Source\WebCore\Modules\webdriver -I..\..\Source\WebCore\Modules\websockets -I..\..\Source\WebCore\Modules\webvr -I..\..\Source\WebCore\accessibility -I..\..\Source\WebCore\animation -I..\..\Source\WebCore\bindings -I..\..\Source\WebCore\bindings\js -I..\..\Source\WebCore\bridge -I..\..\Source\WebCore\bridge\c -I..\..\Source\WebCore\bridge\jsc -I..\..\Source\WebCore\contentextensions -I..\..\Source\WebCore\crypto -I..\..\Source\WebCore\crypto\algorithms -I..\..\Source\WebCore\crypto\keys -I..\..\Source\WebCore\crypto\parameters -I..\..\Source\WebCore\css -I..\..\Source\WebCore\css\parser -I..\..\Source\WebCore\cssjit -I..\..\Source\WebCore\dom -I..\..\Source\WebCore\dom\default -I..\..\Source\WebCore\dom\messageports -I..\..\Source\WebCore\domjit -I..\..\Source\WebCore\editing -I..\..\Source\WebCore\fileapi -I..\..\Source\WebCore\history -I..\..\Source\WebCore\html -I..\..\Source\WebCore\html\canvas -I..\..\Source\WebCore\html\forms -I..\..\Source\WebCore\html\parser -I..\..\Source\WebCore\html\shadow -I..\..\Source\WebCore\html\track -I..\..\Source\WebCore\inspector -I..\..\Source\WebCore\inspector\agents -I..\..\Source\WebCore\inspector\agents\page -I..\..\Source\WebCore\inspector\agents\worker -I..\..\Source\WebCore\loader -I..\..\Source\WebCore\loader\appcache -I..\..\Source\WebCore\loader\archive -I..\..\Source\WebCore\loader\archive\mhtml -I..\..\Source\WebCore\loader\cache -I..\..\Source\WebCore\loader\icon -I..\..\Source\WebCore\mathml -I..\..\Source\WebCore\page -I..\..\Source\WebCore\page\animation -I..\..\Source\WebCore\page\csp -I..\..\Source\WebCore\page\scrolling -I..\..\Source\WebCore\platform -I..\..\Source\WebCore\platform\animation -I..\..\Source\WebCore\platform\audio -I..\..\Source\WebCore\platform\crypto -I..\..\Source\WebCore\platform\encryptedmedia -I..\..\Source\WebCore\platform\gamepad -I..\..\Source\WebCore\platform\graphics -I..\..\Source\WebCore\platform\graphics\cpu\arm -I..\..\Source\WebCore\platform\graphics\cpu\arm\filters -I..\..\Source\WebCore\platform\graphics\displaylists -I..\..\Source\WebCore\platform\graphics\filters -I..\..\Source\WebCore\platform\graphics\harfbuzz -I..\..\Source\WebCore\platform\graphics\harfbuzz\ng -I..\..\Source\WebCore\platform\graphics\iso -I..\..\Source\WebCore\platform\graphics\opentype -I..\..\Source\WebCore\platform\graphics\transforms -I..\..\Source\WebCore\platform\mediastream -I..\..\Source\WebCore\platform\mediastream\libwebrtc -I..\..\Source\WebCore\platform\mock -I..\..\Source\WebCore\platform\mock\mediasource -I..\..\Source\WebCore\platform\network -I..\..\Source\WebCore\platform\sql -I..\..\Source\WebCore\platform\text -I..\..\Source\WebCore\platform\text\icu -I..\..\Source\WebCore\platform\vr -I..\..\Source\WebCore\plugins -I..\..\Source\WebCore\rendering -I..\..\Source\WebCore\rendering\line -I..\..\Source\WebCore\rendering\mathml -I..\..\Source\WebCore\rendering\shapes -I..\..\Source\WebCore\rendering\style -I..\..\Source\WebCore\rendering\svg -I..\..\Source\WebCore\rendering\updating -I..\..\Source\WebCore\replay -I..\..\Source\WebCore\storage -I..\..\Source\WebCore\style -I..\..\Source\WebCore\svg -I..\..\Source\WebCore\svg\animation -I..\..\Source\WebCore\svg\graphics -I..\..\Source\WebCore\svg\graphics\filters -I..\..\Source\WebCore\svg\properties -I..\..\Source\WebCore\websockets -I..\..\Source\WebCore\workers -I..\..\Source\WebCore\workers\service -I..\..\Source\WebCore\workers\service\context -I..\..\Source\WebCore\workers\service\server -I..\..\Source\WebCore\xml -I..\..\Source\WebCore\xml\parser -IDerivedSources\WebCore -IDerivedSources\ForwardingHeaders\ANGLE -I..\..\Source\WebCore\platform\graphics\gpu -IDerivedSources\ForwardingHeaders -I..\include\private -I..\include\private\JavaScriptCore -I..\..\Source\WebCore\accessibility\win -I..\..\Source\WebCore\page\win -I..\..\Source\WebCore\platform\graphics\egl -I..\..\Source\WebCore\platform\graphics\opengl -I..\..\Source\WebCore\platform\graphics\win -I..\..\Source\WebCore\platform\mediacapabilities -I..\..\Source\WebCore\platform\network\win -I..\..\Source\WebCore\platform\win -I..\..\Source\ThirdParty\ANGLE\include -I..\..\Source\ThirdParty\ANGLE\include\egl -I..\..\Source\WebCore\platform\cf -I..\..\Source\WebCore\platform\cf\win -I..\..\Source\WebCore\platform\graphics\cairo -I..\..\Source\WebCore\platform\network\curl -I..\..\Source\WebCore\platform\image-decoders -I..\..\Source\WebCore\platform\image-decoders\bmp -I..\..\Source\WebCore\platform\image-decoders\gif -I..\..\Source\WebCore\platform\image-decoders\ico -I..\..\Source\WebCore\platform\image-decoders\jpeg -I..\..\Source\WebCore\platform\image-decoders\png -I..\..\Source\WebCore\platform\image-decoders\webp -I..\..\Source\WebCore\platform\graphics\texmap -I..\..\Source\WebCore\loader\archive\cf -I..\..\WebKitLibraries\win\include\cairo -I..\..\Source\bmalloc -IDerivedSources -I..\..\Source\ThirdParty -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wno-unknown-argument -Wno-nonportable-include-path -Wno-unknown-pragmas -Wno-macro-redefined -Wno-undef -m64 -fno-strict-aliasing /MD /Zi /Ob0 /Od /RTC1 /bigobj /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /std:c++17 /utf-8 /validate-charset -fmsc-version=1911 /Yu"WebCorePrefix.h" /FI"WebCorePrefix.h" /Fp"C:/webkit/ga/WebKitBuild/Debug/Source/WebCore/WebCore_SOURCES/WebCorePrefix.pch" /showIncludes /FoSource\WebCore\CMakeFiles\WebCore.dir\platform\graphics\win\UniscribeController.cpp.obj /Fdlib64\WebCore.pdb -c ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,42): warning: '&&' within '||' [-Wlogical-op-parentheses] > if (m_offsetX >= m_runWidthSoFar && m_run.ltr() || m_offsetX < 0 && m_run.rtl()) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~ > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,42): note: place parentheses around the '&&' expression to silence this warning > if (m_offsetX >= m_runWidthSoFar && m_run.ltr() || m_offsetX < 0 && m_run.rtl()) > ^ > ( ) > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,74): warning: '&&' within '||' [-Wlogical-op-parentheses] > if (m_offsetX >= m_runWidthSoFar && m_run.ltr() || m_offsetX < 0 && m_run.rtl()) > ~~ ~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,74): note: place parentheses around the '&&' expression to silence this warning > if (m_offsetX >= m_runWidthSoFar && m_run.ltr() || m_offsetX < 0 && m_run.rtl()) > ^ > ( ) > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(201,15): warning: using the result of an assignment as a condition without parentheses [-Wparentheses] > while (rc = ::ScriptItemize(cp, length, m_items.size() - 1, &m_control, &m_state, m_items.data(), &numItems) == E_OUTOFMEMORY) { > ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(201,15): note: place parentheses around the assignment to silence this warning > while (rc = ::ScriptItemize(cp, length, m_items.size() - 1, &m_control, &m_state, m_items.data(), &numItems) == E_OUTOFMEMORY) { > ^ > ( ) > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(201,15): note: use '==' to turn this assignment into an equality comparison > while (rc = ::ScriptItemize(cp, length, m_items.size() - 1, &m_control, &m_state, m_items.data(), &numItems) == E_OUTOFMEMORY) { > ^ > == > ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(372,56): error: invalid operands to binary expression ('float' and 'WebCore::GlyphBufferAdvance' (aka 'WebCore::FloatSize')) > GlyphBufferAdvance advance(-origin.width() + advance, -origin.height()); > ~~~~~~~~~~~~~~~ ^ ~~~~~~~ > ..\..\Source\WebCore\platform\graphics/FloatSize.h(175,18): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::FloatSize' for 1st argument > inline FloatSize operator+(const FloatSize& a, const FloatSize& b) > ^ > ..\..\Source\WebCore\platform\graphics/FloatPoint.h(214,19): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::FloatPoint' for 1st argument > inline FloatPoint operator+(const FloatPoint& a, const FloatSize& b) > ^ > ..\..\Source\WebCore\platform\graphics/IntSize.h(193,16): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::IntSize' for 1st argument > inline IntSize operator+(const IntSize& a, const IntSize& b) > ^ > ..\..\Source\WebCore\platform\graphics/IntPoint.h(169,17): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::IntPoint' for 1st argument > inline IntPoint operator+(const IntPoint& a, const IntSize& b) > ^ > ..\..\Source\WebCore\platform\graphics/IntPoint.h(174,17): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::IntPoint' for 1st argument > inline IntPoint operator+(const IntPoint& a, const IntPoint& b) > ^ > ..\..\Source\WebCore\platform\graphics/FloatPoint.h(219,19): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::FloatPoint' for 1st argument > inline FloatPoint operator+(const FloatPoint& a, const FloatPoint& b) > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(239,18): note: candidate function not viable: no known conversion from 'float' to 'const WebCore::FloatRect' for 1st argument > inline FloatRect operator+(const FloatRect& a, const FloatRect& b) > ^ > ..\..\Source\WebCore\platform\graphics/FontSelectionAlgorithm.h(114,30): note: candidate function not viable: no known conversion from 'float' to 'WebCore::FontSelectionValue' for 1st argument > constexpr FontSelectionValue operator+(FontSelectionValue a, FontSelectionValue b) > ^ > 3 warnings and 1 error generated. 1457429 1 349119 fujii 2018-09-07 00:46:14 -0700 Created attachment 349119 Patch 1457774 2 349119 commit-queue 2018-09-07 16:47:27 -0700 Comment on attachment 349119 Patch Clearing flags on attachment: 349119 Committed r235820: <https://trac.webkit.org/changeset/235820> 1457775 3 commit-queue 2018-09-07 16:47:28 -0700 All reviewed patches have been landed. Closing bug. 1457776 4 webkit-bug-importer 2018-09-07 16:48:22 -0700 <rdar://problem/44244357> 349119 2018-09-07 00:46:14 -0700 2018-09-07 16:47:27 -0700 Patch bug-189399-20180907164613.patch text/plain 2215 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzliYjU5MjUwMjlkNDA0 YWRkZDFjNDZiY2ZjMDEwYjQ4MGI3ODMwNy4uZTg2ZGJjMDE3NzViYzBhOWNkODkzZDI1OGIwM2Nh NGRjZDZkNmEzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA5LTA3ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW0Ns YW5nXSBkdXBsaWNhdGVkIHZhcmlhYmxlIG5hbWUgYGFkdmFuY2VgIGluIFVuaXNjcmliZUNvbnRy b2xsZXI6OnNoYXBlQW5kUGxhY2VJdGVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODkzOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDbGFuZyByZXBvcnRzIHRoZSBmb2xsb3dpbmcgY29tcGlsYXRpb24g ZXJyb3I6CisKKyAgICAgICAgVW5pc2NyaWJlQ29udHJvbGxlci5jcHAoMzcyLDU2KTogIGVycm9y OiBpbnZhbGlkIG9wZXJhbmRzIHRvIGJpbmFyeSBleHByZXNzaW9uICgnZmxvYXQnIGFuZCAnV2Vi Q29yZTo6R2x5cGhCdWZmZXJBZHZhbmNlJyAoYWthICdXZWJDb3JlOjpGbG9hdFNpemUnKSkKKyAg ICAgICAgICAgICBHbHlwaEJ1ZmZlckFkdmFuY2UgYWR2YW5jZSgtb3JpZ2luLndpZHRoKCkgKyBh ZHZhbmNlLCAtb3JpZ2luLmhlaWdodCgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB+fn5+fn5+fn5+fn5+fn4gXiB+fn5+fn5+CisgICAgICAgIE5vIG5ldyB0ZXN0 cyAoTm8gYmVoYXZpb3IgY2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dp bi9VbmlzY3JpYmVDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVuaXNjcmliZUNv bnRyb2xsZXI6OnNoYXBlQW5kUGxhY2VJdGVtKTogUmVwbGFjZWQgdGhlIHNlY29uZCB2YXJpYWJs ZSBuYW1lZCBgYWR2YW5jZWAgd2l0aCBgZ2x5cGhBZHZhbmNlYC4KKwogMjAxOC0wOS0wNSAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBvd25lcnNoaXAg b2Ygb3V0Z29pbmcgc291cmNlIHRvIFJUQ1J0cFNlbmRlciBiYWNrZW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJv bGxlci5jcHAKaW5kZXggYTAxNDc3MzQ0NzVhM2QyNWY3MjY2MmE4YzhhODdjOGJlNTgwNjVkNi4u MGI2MTYyNmQ0NTNhYjdkMWFjOGVhODI0MjFiMTE2YzBmNWQ1NTZjMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmliZUNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVDb250 cm9sbGVyLmNwcApAQCAtMzY5LDggKzM2OSw4IEBAIGJvb2wgVW5pc2NyaWJlQ29udHJvbGxlcjo6 c2hhcGVBbmRQbGFjZUl0ZW0oY29uc3QgVUNoYXIqIGNwLCB1bnNpZ25lZCBpLCBjb25zdCBGCiAg ICAgICAgICAgICAgICAgZ2x5cGhCdWZmZXItPnNldEluaXRpYWxBZHZhbmNlKG9yaWdpbik7CiAg ICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgZ2x5cGhCdWZmZXItPmV4cGFuZExhc3RB ZHZhbmNlKG9yaWdpbik7Ci0gICAgICAgICAgICBHbHlwaEJ1ZmZlckFkdmFuY2UgYWR2YW5jZSgt b3JpZ2luLndpZHRoKCkgKyBhZHZhbmNlLCAtb3JpZ2luLmhlaWdodCgpKTsKLSAgICAgICAgICAg IGdseXBoQnVmZmVyLT5hZGQoZ2x5cGgsIGZvbnREYXRhLCBhZHZhbmNlKTsKKyAgICAgICAgICAg IEdseXBoQnVmZmVyQWR2YW5jZSBnbHlwaEFkdmFuY2UoLW9yaWdpbi53aWR0aCgpICsgYWR2YW5j ZSwgLW9yaWdpbi5oZWlnaHQoKSk7CisgICAgICAgICAgICBnbHlwaEJ1ZmZlci0+YWRkKGdseXBo LCBmb250RGF0YSwgZ2x5cGhBZHZhbmNlKTsKICAgICAgICAgfQogCiAgICAgICAgIEZsb2F0UmVj dCBnbHlwaEJvdW5kcyA9IGZvbnREYXRhLT5ib3VuZHNGb3JHbHlwaChnbHlwaCk7Cg==