189381 2018-09-06 16:01:44 -0700 Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading 2018-09-07 16:01:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189389 1 dbates dbates aestes ddkilzer simon.fraser webkit-bug-importer oldest_to_newest 1457311 0 dbates 2018-09-06 16:01:44 -0700 Today I made some changes in my local working copy that affected the grouping of unified source files such that I got my build failed with the following errors: [[ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:1: platform/ios/wak/WKGraphics.mm:34:17: error: expected namespace name using namespace WebCore; ^ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3: platform/ios/wak/WebCoreThread.mm:868:20: error: no member named 'Threading' in namespace 'WebCore'; did you mean 'LogThreading'? using WebCore::Threading; ~~~~~~~~~^~~~~~~~~ LogThreading In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3: In file included from platform/ios/wak/WebCoreThread.mm:33: /Volumes/Data/WebKitDev/Safari/OpenSource/Source/WebCore/platform/Logging.h:109:22: note: 'LogThreading' declared here WEBCORE_LOG_CHANNELS(DECLARE_LOG_CHANNEL) ^ 2 errors generated. ]] 1457312 1 349088 dbates 2018-09-06 16:05:18 -0700 Created attachment 349088 Patch 1457745 2 349088 dbates 2018-09-07 16:00:15 -0700 Comment on attachment 349088 Patch Clearing flags on attachment: 349088 Committed r235816: <https://trac.webkit.org/changeset/235816> 1457746 3 dbates 2018-09-07 16:00:16 -0700 All reviewed patches have been landed. Closing bug. 1457747 4 webkit-bug-importer 2018-09-07 16:01:26 -0700 <rdar://problem/44242882> 349088 2018-09-06 16:05:18 -0700 2018-09-07 16:00:15 -0700 Patch bug-189381-20180906160517.patch text/plain 2130 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RiYmU5YzUwMWU0N2Ji ZWI3OTZjY2QwNmI5ZjUwMTIyNzcwYzBlZC4uOWMxMzUyODhmYmMzOGNhNzAxNzcxM2RiN2ExZTI3 ZmEzYjdkYWRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA5LTA2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBSZW1vdmUg ZXh0cmFuZW91cyAidXNpbmcgbmFtZXNwYWNlIiBhbmQgc2NvcGUgV2ViQ29yZTo6TG9nVGhyZWFk aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkz ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2lvcy93YWsvV0tHcmFwaGljcy5tbToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2Fr L1dlYkNvcmVUaHJlYWQubW06CisgICAgICAgIChXZWJUaHJlYWRFbmFibGUpOgorCiAyMDE4LTA5 LTA2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZD XSBBZGQgc3VwcG9ydCBmb3IgbWluKG1heCktaGVpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dLR3JhcGhpY3MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3Mvd2FrL1dLR3JhcGhpY3MubW0KaW5kZXggZGZjNmUwZWUzNWY3ZjhmNDlmY2Q2MDkz MDJiNzRkMzFjOTYwYmVkYS4uOGUzYjBkNWI4MWMyYjM4MTcyNjM3ZDhhNDFkNjAzMWEwZGY1NmE3 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XS0dyYXBoaWNz Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0tHcmFwaGljcy5tbQpA QCAtMzEsOCArMzEsNiBAQAogI2ltcG9ydCAiV2ViQ29yZVRocmVhZEludGVybmFsLmgiCiAjaW1w b3J0IDxwYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oPgogCi11c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKLQogc3RhdGljIGlubGluZSB2b2lkIF9GaWxsUmVjdHNVc2luZ09wZXJhdGlvbihDR0Nv bnRleHRSZWYgY29udGV4dCwgY29uc3QgQ0dSZWN0KiByZWN0cywgaW50IGNvdW50LCBDR0NvbXBv c2l0ZU9wZXJhdGlvbiBvcCkKIHsKICAgICBpbnQgaTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbSBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbQppbmRleCAxZmFmOGQ1ZDUwM2UxZTE4ZTI0 NTllNDQyNGRlYTk2YjU1MzBiZGI4Li5kYWZhM2RjNGE0ODdlMmJlYzkyNGQxNmUwZWI0NTYzYTkx MTNhODYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNv cmVUaHJlYWQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3Jl VGhyZWFkLm1tCkBAIC04NjYsOCArODY2LDEwIEBAIFdlYlRocmVhZENvbnRleHQqIFdlYlRocmVh ZEN1cnJlbnRDb250ZXh0KHZvaWQpCiB2b2lkIFdlYlRocmVhZEVuYWJsZSh2b2lkKQogewogICAg IFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRSghV2ViQ29yZTo6SU9TQXBwbGljYXRpb246Omlz V2ViUHJvY2VzcygpLCAiVGhlIFdlYlByb2Nlc3Mgc2hvdWxkIG5ldmVyIHJ1biBhIFdlYiBUaHJl YWQiKTsKLSAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQoKSkK KyAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQoKSkgeworICAg ICAgICB1c2luZyBXZWJDb3JlOjpMb2dUaHJlYWRpbmc7CiAgICAgICAgIFJFTEVBU0VfTE9HX0ZB VUxUKFRocmVhZGluZywgIlNwcmluZ0JvYXJkIGVuYWJsZWQgV2ViVGhyZWFkLiIpOworICAgIH0K IAogICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBmbGFnOwogICAgIHN0ZDo6Y2FsbF9vbmNlKGZs YWcsIFN0YXJ0V2ViVGhyZWFkKTsK