189376 2018-09-06 14:37:42 -0700 Ignore-opens-during-unload counter of a parent should apply to its children during beforeunload event 2018-09-26 12:30:04 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothygu99 cdumez achristensen cdumez commit-queue dbates ews-watchlist ggaren japhet rniwa webkit-bug-importer youennf oldest_to_newest 1457264 0 timothygu99 2018-09-06 14:37:42 -0700 Per https://html.spec.whatwg.org/multipage/browsing-the-web.html#prompt-to-unload-a-document, the ignore-opens-during-unload counter of the document on which "prompt to unload" is called should stay incremented even as its descendants are being prompted for unload. This is the behavior of Firefox as well as Chrome 70+. Test is available at https://github.com/web-platform-tests/wpt/blob/master/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window.js. In particular, the "document.open should bail out when ignore-opens-during-unload is greater than 0 during beforeunload event (open(parent) while unloading parent and child)" test currently fails. 1458048 1 webkit-bug-importer 2018-09-09 13:33:27 -0700 <rdar://problem/44282754> 1463642 2 350870 cdumez 2018-09-26 10:42:38 -0700 Created attachment 350870 Patch 1463684 3 350870 commit-queue 2018-09-26 12:30:02 -0700 Comment on attachment 350870 Patch Clearing flags on attachment: 350870 Committed r236517: <https://trac.webkit.org/changeset/236517> 1463685 4 commit-queue 2018-09-26 12:30:04 -0700 All reviewed patches have been landed. Closing bug. 350870 2018-09-26 10:42:38 -0700 2018-09-26 12:30:02 -0700 Patch bug-189376-20180926104238.patch text/plain 4789 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQwZTk1Y2YwOGFkMDZj MmUwYmYxNTMzNjk3ZDVlNGJlZTNkZDI5Ni4uYTljMTMyYmEwN2U2MWM1ZTVmNjdlZWI2ZWUwODUz OThiZjFhMDcyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA5LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSWdub3JlLW9wZW5zLWR1cmlu Zy11bmxvYWQgY291bnRlciBvZiBhIHBhcmVudCBzaG91bGQgYXBwbHkgdG8gaXRzIGNoaWxkcmVu IGR1cmluZyBiZWZvcmV1bmxvYWQgZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4OTM3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDQyODI3 NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBzdXJlIHRoZSBJZ25vcmUtb3BlbnMtZHVyaW5nLXVubG9hZCBjb3VudGVyIG9mIGEgcGFyZW50 IHN0YXlzIGluY3JlbWVudGVkIHdoaWxlIHdlIGFyZSBmaXJpbmcgdGhlCisgICAgICAgIGJlZm9y ZXVubG9hZCBldmVudCBmb3IgaXRzIGRlc2NlbmRhbnRzLCBhcyBwZXI6CisgICAgICAgIC0gaHR0 cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvYnJvd3NpbmctdGhlLXdlYi5odG1s I3Byb21wdC10by11bmxvYWQtYS1kb2N1bWVudAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmVi YXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnNob3VsZENsb3NlKToKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpkaXNwYXRjaEJlZm9yZVVubG9hZEV2ZW50KToKKwog MjAxOC0wOS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWIgQW5pbWF0aW9uc10gRW5zdXJlIHJlbmRlcmVycyB3aXRoIGFjY2VsZXJhdGVkIGFuaW1h dGlvbnMgaGF2ZSBsYXllcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4 IGU3NmQwZGI3YzMyN2I3ODg4N2UyMDMzYTliZTNjMTY3OTU1OWE0MzEuLmE5MWY2YmRlNDJjYmRi NTk3YmU0YTVhZDcwOGM1ZWMzNGM3ZjkyYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcApAQCAtMzEyMiw2ICszMTIyLDcgQEAgYm9vbCBGcmFtZUxvYWRlcjo6c2hvdWxkQ2xv c2UoKQogICAgIGJvb2wgc2hvdWxkQ2xvc2UgPSBmYWxzZTsKICAgICB7CiAgICAgICAgIE5hdmln YXRpb25EaXNhYmxlciBuYXZpZ2F0aW9uRGlzYWJsZXIoJm1fZnJhbWUpOworICAgICAgICBJZ25v cmVPcGVuc0R1cmluZ1VubG9hZENvdW50SW5jcmVtZW50ZXIgaWdub3JlT3BlbnNEdXJpbmdVbmxv YWRDb3VudEluY3JlbWVudGVyKG1fZnJhbWUuZG9jdW1lbnQoKSk7CiAgICAgICAgIHNpemVfdCBp OwogCiAgICAgICAgIGZvciAoaSA9IDA7IGkgPCB0YXJnZXRGcmFtZXMuc2l6ZSgpOyBpKyspIHsK QEAgLTMyMjksNyArMzIzMCw2IEBAIGJvb2wgRnJhbWVMb2FkZXI6OmRpc3BhdGNoQmVmb3JlVW5s b2FkRXZlbnQoQ2hyb21lJiBjaHJvbWUsIEZyYW1lTG9hZGVyKiBmcmFtZUxvCiAKICAgICB7CiAg ICAgICAgIEZvcmJpZFByb21wdHNTY29wZSBmb3JiaWRQcm9tcHRzKG1fZnJhbWUucGFnZSgpKTsK LSAgICAgICAgSWdub3JlT3BlbnNEdXJpbmdVbmxvYWRDb3VudEluY3JlbWVudGVyIGlnbm9yZU9w ZW5zRHVyaW5nVW5sb2FkQ291bnRJbmNyZW1lbnRlcihtX2ZyYW1lLmRvY3VtZW50KCkpOwogICAg ICAgICBkb21XaW5kb3ctPmRpc3BhdGNoRXZlbnQoYmVmb3JlVW5sb2FkRXZlbnQsIGRvbVdpbmRv dy0+ZG9jdW1lbnQoKSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRl eCA4MDNlNDNkNGU4N2Q3YTZjMDFlMjBiZWU5MDQzNTkzZmYyN2E3NTk5Li5iMDcwZDg0Mjk2MzYx OGZiOTE3ZmQ4NmI4MjYzODNhYjJiZTcxNGRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0wOS0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgorCisgICAgICAgIElnbm9yZS1vcGVucy1kdXJpbmctdW5sb2FkIGNvdW50ZXIgb2Yg YSBwYXJlbnQgc2hvdWxkIGFwcGx5IHRvIGl0cyBjaGlsZHJlbiBkdXJpbmcgYmVmb3JldW5sb2Fk IGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODkzNzYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0MjgyNzU0PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUgZXhpc3RpbmcgdGVz dCBub3cgdGhhdCBvbmUgbW9yZSBjaGVjayBpcyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBs YXRmb3JtLXRlc3RzL2h0bWwvd2ViYXBwYXBpcy9keW5hbWljLW1hcmt1cC1pbnNlcnRpb24vb3Bl bmluZy10aGUtaW5wdXQtc3RyZWFtL2lnbm9yZS1vcGVucy1kdXJpbmctdW5sb2FkLndpbmRvdy1l eHBlY3RlZC50eHQ6CisKIDIwMTgtMDktMjUgIFlVSEFOIFdVICA8eXVoYW5fd3VAYXBwbGUuY29t PgogCiAgICAgICAgIEltcGxlbWVudCBNZWRpYVN0cmVhbVRyYWNrIENvbnRlbnQgSGludHMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC93ZWJhcHBhcGlzL2R5bmFtaWMtbWFya3VwLWluc2VydGlvbi9vcGVuaW5nLXRoZS1pbnB1dC1z dHJlYW0vaWdub3JlLW9wZW5zLWR1cmluZy11bmxvYWQud2luZG93LWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC93ZWJhcHBhcGlz L2R5bmFtaWMtbWFya3VwLWluc2VydGlvbi9vcGVuaW5nLXRoZS1pbnB1dC1zdHJlYW0vaWdub3Jl LW9wZW5zLWR1cmluZy11bmxvYWQud2luZG93LWV4cGVjdGVkLnR4dAppbmRleCA4NWNlMjAzYmQy YTg4ZGYzOTM5ZjZkYmEzYTYwY2Q1NWFiYTA1ODhmLi5lZDdkMjA2YWFkMWVmMzJmZmFjNmI3ZTY4 ZmQxZTY5MDRiNGE2ZWQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvd2ViYXBwYXBpcy9keW5hbWljLW1hcmt1cC1pbnNlcnRpb24v b3BlbmluZy10aGUtaW5wdXQtc3RyZWFtL2lnbm9yZS1vcGVucy1kdXJpbmctdW5sb2FkLndpbmRv dy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9odG1sL3dlYmFwcGFwaXMvZHluYW1pYy1tYXJrdXAtaW5zZXJ0aW9uL29wZW5pbmct dGhlLWlucHV0LXN0cmVhbS9pZ25vcmUtb3BlbnMtZHVyaW5nLXVubG9hZC53aW5kb3ctZXhwZWN0 ZWQudHh0CkBAIC0yLDcgKzIsNyBAQAogSGFybmVzcyBFcnJvciAoVElNRU9VVCksIG1lc3NhZ2Ug PSBudWxsCiAKIFBBU1MgZG9jdW1lbnQub3BlbiBzaG91bGQgYmFpbCBvdXQgd2hlbiBpZ25vcmUt b3BlbnMtZHVyaW5nLXVubG9hZCBpcyBncmVhdGVyIHRoYW4gMCBkdXJpbmcgYmVmb3JldW5sb2Fk IGV2ZW50IChpbiB0b3AtbGV2ZWwgYnJvd3NpbmcgY29udGV4dCkgCi1GQUlMIGRvY3VtZW50Lm9w ZW4gc2hvdWxkIGJhaWwgb3V0IHdoZW4gaWdub3JlLW9wZW5zLWR1cmluZy11bmxvYWQgaXMgZ3Jl YXRlciB0aGFuIDAgZHVyaW5nIGJlZm9yZXVubG9hZCBldmVudCAob3BlbihwYXJlbnQpIHdoaWxl IHVubG9hZGluZyBwYXJlbnQgYW5kIGNoaWxkKSBhc3NlcnRfbm90X2VxdWFsczogZ290IGRpc2Fs bG93ZWQgdmFsdWUgMAorUEFTUyBkb2N1bWVudC5vcGVuIHNob3VsZCBiYWlsIG91dCB3aGVuIGln bm9yZS1vcGVucy1kdXJpbmctdW5sb2FkIGlzIGdyZWF0ZXIgdGhhbiAwIGR1cmluZyBiZWZvcmV1 bmxvYWQgZXZlbnQgKG9wZW4ocGFyZW50KSB3aGlsZSB1bmxvYWRpbmcgcGFyZW50IGFuZCBjaGls ZCkgCiBQQVNTIGRvY3VtZW50Lm9wZW4gc2hvdWxkIGJhaWwgb3V0IHdoZW4gaWdub3JlLW9wZW5z LWR1cmluZy11bmxvYWQgaXMgZ3JlYXRlciB0aGFuIDAgZHVyaW5nIGJlZm9yZXVubG9hZCBldmVu dCAob3BlbihwYXJlbnQpIHdoaWxlIHVubG9hZGluZyBjaGlsZCBvbmx5KSAKIFBBU1MgZG9jdW1l bnQub3BlbiBzaG91bGQgYmFpbCBvdXQgd2hlbiBpZ25vcmUtb3BlbnMtZHVyaW5nLXVubG9hZCBp cyBncmVhdGVyIHRoYW4gMCBkdXJpbmcgcGFnZWhpZGUgZXZlbnQgKGluIHRvcC1sZXZlbCBicm93 c2luZyBjb250ZXh0KSAKIFBBU1MgZG9jdW1lbnQub3BlbiBzaG91bGQgYmFpbCBvdXQgd2hlbiBp Z25vcmUtb3BlbnMtZHVyaW5nLXVubG9hZCBpcyBncmVhdGVyIHRoYW4gMCBkdXJpbmcgcGFnZWhp ZGUgZXZlbnQgKG9wZW4ocGFyZW50KSB3aGlsZSB1bmxvYWRpbmcgcGFyZW50IGFuZCBjaGlsZCkg Cg==