<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189287</bug_id>
          
          <creation_ts>2018-09-04 17:14:44 -0700</creation_ts>
          <short_desc>Add generic entrypoint and run loop in TestWebKitAPI</short_desc>
          <delta_ts>2018-09-04 18:58:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>annulen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1456543</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-09-04 17:14:44 -0700</bug_when>
    <thetext>The JSCOnly implementation is really a generic implementation. Also main.cpp is the same as WPE&apos;s.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456570</commentid>
    <comment_count>1</comment_count>
      <attachid>348878</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-09-04 17:57:05 -0700</bug_when>
    <thetext>Created attachment 348878
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456572</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-09-04 17:58:50 -0700</bug_when>
    <thetext>Attachment 348878 did not pass style-queue:


ERROR: Tools/TestWebKitAPI/generic/UtilitiesGeneric.cpp:38:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456574</commentid>
    <comment_count>3</comment_count>
      <attachid>348880</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-09-04 18:00:57 -0700</bug_when>
    <thetext>Created attachment 348880
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456589</commentid>
    <comment_count>4</comment_count>
      <attachid>348880</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-09-04 18:38:00 -0700</bug_when>
    <thetext>Comment on attachment 348880
Patch

Good</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456594</commentid>
    <comment_count>5</comment_count>
      <attachid>348880</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-04 18:57:07 -0700</bug_when>
    <thetext>Comment on attachment 348880
Patch

Clearing flags on attachment: 348880

Committed r235654: &lt;https://trac.webkit.org/changeset/235654&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456595</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-04 18:57:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456596</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-04 18:58:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/44122651&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348878</attachid>
            <date>2018-09-04 17:57:05 -0700</date>
            <delta_ts>2018-09-04 18:00:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189287.diff</filename>
            <type>text/plain</type>
            <size>6124</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMDYz
MzU2YmRiOS4uZTRiYzk0NzQ5NjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxOC0wOS0wNCAgRG9uIE9sbXN0ZWFk
ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEFkZCBnZW5lcmljIGVudHJ5cG9p
bnQgYW5kIHJ1biBsb29wIGluIFRlc3RXZWJLaXRBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTI4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbXBsZW1lbnRhdGlvbnMgaW4ganNjb25seSBh
cmUgcGxhdGZvcm0gYWdub3N0aWMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3Jt
SlNDT25seS5jbWFrZToKKyAgICAgICAgVXNlIHRoZSBnbGliIGltcGxlbWVudGF0aW9uIG9mIFV0
aWxpdGllcyB3aGVuIHVzaW5nIHRoYXQgYXMgYSBydW4gbG9vcAorICAgICAgICBvdGhlcndpc2Ug
dXNlIHRoZSBnZW5lcmljIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ
SS9QbGF0Zm9ybVV0aWxpdGllcy5oOgorICAgICAgICBSZW1vdmUgcmVwZWF0ZWQgZW50cmllcyBm
cm9tIFV0aWxpdGllcy5oLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5j
bWFrZToKKyAgICAgICAgVXNlIHRoZSBnZW5lcmljIG1haW4uY3BwLgorICAgICAgICAKKyAgICAg
ICAgKiBUZXN0V2ViS2l0QVBJL2dlbmVyaWMvVXRpbGl0aWVzR2VuZXJpYy5jcHA6IFJlbmFtZWQg
ZnJvbSBUb29scy9UZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1VdGlsaXRpZXNKU0NPbmx5
LmNwcC4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bik6CisgICAgICAgIChUZXN0
V2ViS2l0QVBJOjpVdGlsOjpzcGluUnVuTG9vcCk6CisgICAgICAgIE1vdmVkIHRvIGEgZ2VuZXJp
YyBpbXBsZW1lbnRhdGlvbiBhbmQgYWRkZWQgc3BpblJ1bkxvb3AuCisKKyAgICAgICAgKiBUZXN0
V2ViS2l0QVBJL2dlbmVyaWMvbWFpbi5jcHA6IFJlbmFtZWQgZnJvbSBUb29scy9UZXN0V2ViS2l0
QVBJL2pzY29ubHkvbWFpbi5jcHAuCisgICAgICAgIFNoYXJlIGJldHdlZW4gSlNDT25seSBhbmQg
V1BFCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL3dwZS9tYWluLmNwcDogUmVtb3ZlZC4KKwog
MjAxOC0wOS0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg
ICAgICBQZXJsIGRvZXNuJ3QgbGlrZSBjYWxsaW5nIGtleXMgb24gYSByZWZlcmVuY2UKZGlmZiAt
LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1KU0NPbmx5LmNtYWtlIGIvVG9vbHMv
VGVzdFdlYktpdEFQSS9QbGF0Zm9ybUpTQ09ubHkuY21ha2UKaW5kZXggN2U1M2Y4NmUyOTguLmEz
ZmEyZGE5NTVkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25s
eS5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25seS5jbWFrZQpA
QCAtOSwxMyArOSwxOSBAQCBpZiAoTE9XRVJDQVNFX0VWRU5UX0xPT1BfVFlQRSBTVFJFUVVBTCAi
Z2xpYiIpCiAgICAgaW5jbHVkZV9kaXJlY3RvcmllcyhTWVNURU0KICAgICAgICAgJHtHTElCX0lO
Q0xVREVfRElSU30KICAgICApCisgICAgbGlzdChBUFBFTkQgVGVzdFdURl9TT1VSQ0VTCisgICAg
ICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L2dsaWIvVXRpbGl0aWVzR0xpYi5jcHAKKyAgICApCitl
bHNlICgpCisgICAgbGlzdChBUFBFTkQgVGVzdFdURl9TT1VSQ0VTCisgICAgICAgICR7VEVTVFdF
QktJVEFQSV9ESVJ9L2dlbmVyaWMvVXRpbGl0aWVzR2VuZXJpYy5jcHAKKyAgICApCiBlbmRpZiAo
KQogCiBzZXQodGVzdF9tYWluX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElfRElSfS9qc2Nv
bmx5L21haW4uY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vZ2VuZXJpYy9tYWluLmNwcAog
KQogCiBsaXN0KEFQUEVORCBUZXN0V1RGX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElfRElS
fS9qc2Nvbmx5L1BsYXRmb3JtVXRpbGl0aWVzSlNDT25seS5jcHAKICAgICAke1RFU1RXRUJLSVRB
UElfRElSfS9UZXN0cy9XVEYvUnVuTG9vcC5jcHAKICkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX
ZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZv
cm1VdGlsaXRpZXMuaAppbmRleCBlMWUzMDllNjkzMS4uZjU1NTVmZDlkMDggMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaAorKysgYi9Ub29scy9UZXN0
V2ViS2l0QVBJL1BsYXRmb3JtVXRpbGl0aWVzLmgKQEAgLTQyLDEwICs0Miw2IEBAIE9CSkNfQ0xB
U1MgTlNEaWN0aW9uYXJ5OwogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogbmFtZXNwYWNlIFV0
aWwgewogCi0vLyBSdW5zIGEgcGxhdGZvcm0gcnVubG9vcCB1bnRpbCB0aGUgJ2RvbmUnIGlzIHRy
dWUuIAotdm9pZCBydW4oYm9vbCogZG9uZSk7Ci12b2lkIHNsZWVwKGRvdWJsZSBzZWNvbmRzKTsK
LQogc3RkOjpzdHJpbmcgdG9TVEQoY29uc3QgY2hhciopOwogI2lmIFVTRShGT1VOREFUSU9OKQog
c3RkOjpzdHJpbmcgdG9TVEQoTlNTdHJpbmcgKik7CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi
S2l0QVBJL1BsYXRmb3JtV1BFLmNtYWtlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQ
RS5jbWFrZQppbmRleCA3NDU3Yzc1ZTFhZi4uMDZkMmM5OGI0YmYgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQ
SS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMjksNyArMjksNyBAQCBpbmNsdWRlX2RpcmVjdG9yaWVz
KFNZU1RFTQogKQogCiBzZXQodGVzdF9tYWluX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElf
RElSfS93cGUvbWFpbi5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9nZW5lcmljL21haW4u
Y3BwCiApCiAKIHNldChidW5kbGVfaGFybmVzc19TT1VSQ0VTCmRpZmYgLS1naXQgYS9Ub29scy9U
ZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1VdGlsaXRpZXNKU0NPbmx5LmNwcCBiL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvZ2VuZXJpYy9VdGlsaXRpZXNHZW5lcmljLmNwcApzaW1pbGFyaXR5IGlu
ZGV4IDg3JQpyZW5hbWUgZnJvbSBUb29scy9UZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1V
dGlsaXRpZXNKU0NPbmx5LmNwcApyZW5hbWUgdG8gVG9vbHMvVGVzdFdlYktpdEFQSS9nZW5lcmlj
L1V0aWxpdGllc0dlbmVyaWMuY3BwCmluZGV4IGNkM2VjMDJlYjQ0Li5hODNkZDYzYWEyOSAxMDA2
NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9qc2Nvbmx5L1BsYXRmb3JtVXRpbGl0aWVzSlND
T25seS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9nZW5lcmljL1V0aWxpdGllc0dlbmVy
aWMuY3BwCkBAIC0yNCwyNiArMjQsMjUgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0j
aW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbmNsdWRlICJVdGlsaXRpZXMuaCIKIAog
I2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CiAKLSNpZiBVU0UoR0xJQl9FVkVOVF9MT09QKQotI2lu
Y2x1ZGUgPGdsaWIuaD4KLSNpbmNsdWRlIDx3dGYvZ2xpYi9HUmVmUHRyLmg+Ci0jZW5kaWYKLQog
bmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogbmFtZXNwYWNlIFV0aWwgewogCiB2b2lkIHJ1bihi
b29sKiBkb25lKQogewogICAgIHdoaWxlICghKmRvbmUpIHsKLSNpZiBVU0UoR0xJQl9FVkVOVF9M
T09QKQotICAgICAgICBnX21haW5fY29udGV4dF9pdGVyYXRpb24oUnVuTG9vcDo6Y3VycmVudCgp
Lm1haW5Db250ZXh0KCksIGZhbHNlKTsKLSNlbHNlCiAgICAgICAgIFdURjo6UnVuTG9vcDo6aXRl
cmF0ZSgpOwotI2VuZGlmCisgICAgfQorfQorCit2b2lkIHNwaW5SdW5Mb29wKHVpbnQ2NF90IGNv
dW50KQoreworICAgIHdoaWxlIChjb3VudCA+IDApIHsKKyAgICAgICAgV1RGOjpSdW5Mb29wOjpj
dXJyZW50KCkuaXRlcmF0ZSgpOworICAgICAgICBjb3VudC0tOwogICAgIH0KIH0KIApkaWZmIC0t
Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9qc2Nvbmx5L21haW4uY3BwIGIvVG9vbHMvVGVzdFdl
YktpdEFQSS9nZW5lcmljL21haW4uY3BwCnNpbWlsYXJpdHkgaW5kZXggMTAwJQpyZW5hbWUgZnJv
bSBUb29scy9UZXN0V2ViS2l0QVBJL2pzY29ubHkvbWFpbi5jcHAKcmVuYW1lIHRvIFRvb2xzL1Rl
c3RXZWJLaXRBUEkvZ2VuZXJpYy9tYWluLmNwcApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp
dEFQSS93cGUvbWFpbi5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL3dwZS9tYWluLmNwcApkZWxl
dGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZjY1NjhiNmMzMmQuLjAwMDAwMDAwMDAwCi0tLSBh
L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvd3BlL21haW4uY3BwCisrKyAvZGV2L251bGwKQEAgLTEsMzIg
KzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNiBJZ2FsaWEgUy5MLgotICoKLSAqIFJl
ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig
d2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl
IGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICogMS4gUmVkaXN0cmlidXRpb25z
IG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5v
dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l
ci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0
aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z
IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVudGF0aW9u
IGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgot
ICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENP
TlRSSUJVVE9SUyBgYEFTIElTJycKLSAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJB
TlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAotICogVEhFIElNUExJRUQgV0FS
UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgot
ICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBP
UiBJVFMgQ09OVFJJQlVUT1JTCi0gKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNU
LCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCi0gKiBDT05TRVFVRU5USUFMIERB
TUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgotICog
U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ
VFM7IE9SIEJVU0lORVNTCi0gKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB
TlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgotICogQ09OVFJBQ1QsIFNUUklDVCBM
SUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKLSAq
IEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVO
IElGIEFEVklTRUQgT0YKLSAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KLSAqLwot
Ci0jaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiVGVzdHNDb250cm9sbGVyLmgiCi0KLWlu
dCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKLXsKLSAgICByZXR1cm4gVGVzdFdlYktpdEFQ
STo6VGVzdHNDb250cm9sbGVyOjpzaW5nbGV0b24oKS5ydW4oYXJnYywgYXJndikgPyBFWElUX1NV
Q0NFU1MgOiBFWElUX0ZBSUxVUkU7Ci19Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348880</attachid>
            <date>2018-09-04 18:00:57 -0700</date>
            <delta_ts>2018-09-04 18:57:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189287.diff</filename>
            <type>text/plain</type>
            <size>6137</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMDYz
MzU2YmRiOS4uZTRiYzk0NzQ5NjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxOC0wOS0wNCAgRG9uIE9sbXN0ZWFk
ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEFkZCBnZW5lcmljIGVudHJ5cG9p
bnQgYW5kIHJ1biBsb29wIGluIFRlc3RXZWJLaXRBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTI4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbXBsZW1lbnRhdGlvbnMgaW4ganNjb25seSBh
cmUgcGxhdGZvcm0gYWdub3N0aWMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3Jt
SlNDT25seS5jbWFrZToKKyAgICAgICAgVXNlIHRoZSBnbGliIGltcGxlbWVudGF0aW9uIG9mIFV0
aWxpdGllcyB3aGVuIHVzaW5nIHRoYXQgYXMgYSBydW4gbG9vcAorICAgICAgICBvdGhlcndpc2Ug
dXNlIHRoZSBnZW5lcmljIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ
SS9QbGF0Zm9ybVV0aWxpdGllcy5oOgorICAgICAgICBSZW1vdmUgcmVwZWF0ZWQgZW50cmllcyBm
cm9tIFV0aWxpdGllcy5oLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5j
bWFrZToKKyAgICAgICAgVXNlIHRoZSBnZW5lcmljIG1haW4uY3BwLgorICAgICAgICAKKyAgICAg
ICAgKiBUZXN0V2ViS2l0QVBJL2dlbmVyaWMvVXRpbGl0aWVzR2VuZXJpYy5jcHA6IFJlbmFtZWQg
ZnJvbSBUb29scy9UZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1VdGlsaXRpZXNKU0NPbmx5
LmNwcC4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bik6CisgICAgICAgIChUZXN0
V2ViS2l0QVBJOjpVdGlsOjpzcGluUnVuTG9vcCk6CisgICAgICAgIE1vdmVkIHRvIGEgZ2VuZXJp
YyBpbXBsZW1lbnRhdGlvbiBhbmQgYWRkZWQgc3BpblJ1bkxvb3AuCisKKyAgICAgICAgKiBUZXN0
V2ViS2l0QVBJL2dlbmVyaWMvbWFpbi5jcHA6IFJlbmFtZWQgZnJvbSBUb29scy9UZXN0V2ViS2l0
QVBJL2pzY29ubHkvbWFpbi5jcHAuCisgICAgICAgIFNoYXJlIGJldHdlZW4gSlNDT25seSBhbmQg
V1BFCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL3dwZS9tYWluLmNwcDogUmVtb3ZlZC4KKwog
MjAxOC0wOS0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg
ICAgICBQZXJsIGRvZXNuJ3QgbGlrZSBjYWxsaW5nIGtleXMgb24gYSByZWZlcmVuY2UKZGlmZiAt
LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1KU0NPbmx5LmNtYWtlIGIvVG9vbHMv
VGVzdFdlYktpdEFQSS9QbGF0Zm9ybUpTQ09ubHkuY21ha2UKaW5kZXggN2U1M2Y4NmUyOTguLmEz
ZmEyZGE5NTVkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25s
eS5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25seS5jbWFrZQpA
QCAtOSwxMyArOSwxOSBAQCBpZiAoTE9XRVJDQVNFX0VWRU5UX0xPT1BfVFlQRSBTVFJFUVVBTCAi
Z2xpYiIpCiAgICAgaW5jbHVkZV9kaXJlY3RvcmllcyhTWVNURU0KICAgICAgICAgJHtHTElCX0lO
Q0xVREVfRElSU30KICAgICApCisgICAgbGlzdChBUFBFTkQgVGVzdFdURl9TT1VSQ0VTCisgICAg
ICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L2dsaWIvVXRpbGl0aWVzR0xpYi5jcHAKKyAgICApCitl
bHNlICgpCisgICAgbGlzdChBUFBFTkQgVGVzdFdURl9TT1VSQ0VTCisgICAgICAgICR7VEVTVFdF
QktJVEFQSV9ESVJ9L2dlbmVyaWMvVXRpbGl0aWVzR2VuZXJpYy5jcHAKKyAgICApCiBlbmRpZiAo
KQogCiBzZXQodGVzdF9tYWluX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElfRElSfS9qc2Nv
bmx5L21haW4uY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vZ2VuZXJpYy9tYWluLmNwcAog
KQogCiBsaXN0KEFQUEVORCBUZXN0V1RGX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElfRElS
fS9qc2Nvbmx5L1BsYXRmb3JtVXRpbGl0aWVzSlNDT25seS5jcHAKICAgICAke1RFU1RXRUJLSVRB
UElfRElSfS9UZXN0cy9XVEYvUnVuTG9vcC5jcHAKICkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX
ZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZv
cm1VdGlsaXRpZXMuaAppbmRleCBlMWUzMDllNjkzMS4uZjU1NTVmZDlkMDggMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaAorKysgYi9Ub29scy9UZXN0
V2ViS2l0QVBJL1BsYXRmb3JtVXRpbGl0aWVzLmgKQEAgLTQyLDEwICs0Miw2IEBAIE9CSkNfQ0xB
U1MgTlNEaWN0aW9uYXJ5OwogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogbmFtZXNwYWNlIFV0
aWwgewogCi0vLyBSdW5zIGEgcGxhdGZvcm0gcnVubG9vcCB1bnRpbCB0aGUgJ2RvbmUnIGlzIHRy
dWUuIAotdm9pZCBydW4oYm9vbCogZG9uZSk7Ci12b2lkIHNsZWVwKGRvdWJsZSBzZWNvbmRzKTsK
LQogc3RkOjpzdHJpbmcgdG9TVEQoY29uc3QgY2hhciopOwogI2lmIFVTRShGT1VOREFUSU9OKQog
c3RkOjpzdHJpbmcgdG9TVEQoTlNTdHJpbmcgKik7CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi
S2l0QVBJL1BsYXRmb3JtV1BFLmNtYWtlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQ
RS5jbWFrZQppbmRleCA3NDU3Yzc1ZTFhZi4uMDZkMmM5OGI0YmYgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQ
SS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMjksNyArMjksNyBAQCBpbmNsdWRlX2RpcmVjdG9yaWVz
KFNZU1RFTQogKQogCiBzZXQodGVzdF9tYWluX1NPVVJDRVMKLSAgICAke1RFU1RXRUJLSVRBUElf
RElSfS93cGUvbWFpbi5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9nZW5lcmljL21haW4u
Y3BwCiApCiAKIHNldChidW5kbGVfaGFybmVzc19TT1VSQ0VTCmRpZmYgLS1naXQgYS9Ub29scy9U
ZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1VdGlsaXRpZXNKU0NPbmx5LmNwcCBiL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvZ2VuZXJpYy9VdGlsaXRpZXNHZW5lcmljLmNwcApzaW1pbGFyaXR5IGlu
ZGV4IDg2JQpyZW5hbWUgZnJvbSBUb29scy9UZXN0V2ViS2l0QVBJL2pzY29ubHkvUGxhdGZvcm1V
dGlsaXRpZXNKU0NPbmx5LmNwcApyZW5hbWUgdG8gVG9vbHMvVGVzdFdlYktpdEFQSS9nZW5lcmlj
L1V0aWxpdGllc0dlbmVyaWMuY3BwCmluZGV4IGNkM2VjMDJlYjQ0Li43NDRkNWE0YzZlOSAxMDA2
NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9qc2Nvbmx5L1BsYXRmb3JtVXRpbGl0aWVzSlND
T25seS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9nZW5lcmljL1V0aWxpdGllc0dlbmVy
aWMuY3BwCkBAIC0yNCwyNiArMjQsMjQgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0j
aW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbmNsdWRlICJVdGlsaXRpZXMuaCIKIAog
I2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CiAKLSNpZiBVU0UoR0xJQl9FVkVOVF9MT09QKQotI2lu
Y2x1ZGUgPGdsaWIuaD4KLSNpbmNsdWRlIDx3dGYvZ2xpYi9HUmVmUHRyLmg+Ci0jZW5kaWYKLQog
bmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogbmFtZXNwYWNlIFV0aWwgewogCiB2b2lkIHJ1bihi
b29sKiBkb25lKQogewotICAgIHdoaWxlICghKmRvbmUpIHsKLSNpZiBVU0UoR0xJQl9FVkVOVF9M
T09QKQotICAgICAgICBnX21haW5fY29udGV4dF9pdGVyYXRpb24oUnVuTG9vcDo6Y3VycmVudCgp
Lm1haW5Db250ZXh0KCksIGZhbHNlKTsKLSNlbHNlCisgICAgd2hpbGUgKCEqZG9uZSkKICAgICAg
ICAgV1RGOjpSdW5Mb29wOjppdGVyYXRlKCk7Ci0jZW5kaWYKK30KKwordm9pZCBzcGluUnVuTG9v
cCh1aW50NjRfdCBjb3VudCkKK3sKKyAgICB3aGlsZSAoY291bnQgPiAwKSB7CisgICAgICAgIFdU
Rjo6UnVuTG9vcDo6Y3VycmVudCgpLml0ZXJhdGUoKTsKKyAgICAgICAgY291bnQtLTsKICAgICB9
CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvanNjb25seS9tYWluLmNwcCBi
L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2VuZXJpYy9tYWluLmNwcApzaW1pbGFyaXR5IGluZGV4IDEw
MCUKcmVuYW1lIGZyb20gVG9vbHMvVGVzdFdlYktpdEFQSS9qc2Nvbmx5L21haW4uY3BwCnJlbmFt
ZSB0byBUb29scy9UZXN0V2ViS2l0QVBJL2dlbmVyaWMvbWFpbi5jcHAKZGlmZiAtLWdpdCBhL1Rv
b2xzL1Rlc3RXZWJLaXRBUEkvd3BlL21haW4uY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS93cGUv
bWFpbi5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGY2NTY4YjZjMzJkLi4wMDAw
MDAwMDAwMAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL3dwZS9tYWluLmNwcAorKysgL2Rldi9u
dWxsCkBAIC0xLDMyICswLDAgQEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYgSWdhbGlhIFMu
TC4KLSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv
cm1zLCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92
aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuIFJl
ZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJp
Z2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93
aW5nIGRpc2NsYWltZXIuCi0gKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVz
dCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qg
b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotICogICAg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRp
c3RyaWJ1dGlvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElO
Qy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnCi0gKiBBTkQgQU5ZIEVYUFJFU1MgT1Ig
SU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSAqIFRI
RSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBB
IFBBUlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxM
IEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUwotICogQkUgTElBQkxFIEZPUiBBTlkgRElS
RUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUgotICogQ09O
U0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VS
RU1FTlQgT0YKLSAqIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBE
QVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUwotICogSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB
VVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4KLSAqIENPTlRS
QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP
VEhFUldJU0UpCi0gKiBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBT
T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCi0gKiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE
QU1BR0UuCi0gKi8KLQotI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIlRlc3RzQ29udHJv
bGxlci5oIgotCi1pbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCi17Ci0gICAgcmV0dXJu
IFRlc3RXZWJLaXRBUEk6OlRlc3RzQ29udHJvbGxlcjo6c2luZ2xldG9uKCkucnVuKGFyZ2MsIGFy
Z3YpID8gRVhJVF9TVUNDRVNTIDogRVhJVF9GQUlMVVJFOwotfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>