189280 2018-09-04 16:20:16 -0700 Rename experimental feature for process swap on navigation 2018-09-04 19:38:21 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren koivisto webkit-bug-importer oldest_to_newest 1456501 0 cdumez 2018-09-04 16:20:16 -0700 The "process swap on navigation" experimental feature on macOS Mojave does not work due to missing browser changes, resulting in frequent load hangs. When enabling the experimental feature in WebKit ToT or Safari Technology Preview for testing, it enables it as well for Mojave's system Safari which is annoying. I propose we rename the experimental feature so that the feature stays disabled in Mojave's system Safari even when enabled in WebKit ToT / STP. 1456506 1 348865 cdumez 2018-09-04 16:25:27 -0700 Created attachment 348865 Patch 1456600 2 348865 commit-queue 2018-09-04 19:37:01 -0700 Comment on attachment 348865 Patch Clearing flags on attachment: 348865 Committed r235656: <https://trac.webkit.org/changeset/235656> 1456601 3 commit-queue 2018-09-04 19:37:02 -0700 All reviewed patches have been landed. Closing bug. 1456602 4 webkit-bug-importer 2018-09-04 19:38:21 -0700 <rdar://problem/44123439> 348865 2018-09-04 16:25:27 -0700 2018-09-04 19:37:01 -0700 Patch bug-189280-20180904162526.patch text/plain 5031 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMyMzQwNzM0ODExMTJlYTMy OGZkN2RjMjZkMWJlMmY4ODJmYTY1ZTAuLmIxNDM4ZjI5ZjY2YjllNDFhNTY2ZDM1MDNhYWJhNzQ0 NDM4MzhmMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTgtMDktMDQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgZXhwZXJpbWVudGFsIGZl YXR1cmUgZm9yIHByb2Nlc3Mgc3dhcCBvbiBuYXZpZ2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyODAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgInByb2Nlc3Mgc3dhcCBvbiBuYXZpZ2F0 aW9uIiBleHBlcmltZW50YWwgZmVhdHVyZSBvbiBtYWNPUyBNb2phdmUgZG9lcyBub3Qgd29yayBk dWUgdG8gbWlzc2luZworICAgICAgICBicm93c2VyIGNoYW5nZXMsIHJlc3VsdGluZyBpbiBmcmVx dWVudCBsb2FkIGhhbmdzLiBXaGVuIGVuYWJsaW5nIHRoZSBleHBlcmltZW50YWwgZmVhdHVyZSBp biBXZWJLaXQKKyAgICAgICAgVG9UIG9yIFNhZmFyaSBUZWNobm9sb2d5IFByZXZpZXcgZm9yIHRl c3RpbmcsIGl0IGVuYWJsZXMgaXQgYXMgd2VsbCBmb3IgTW9qYXZlJ3Mgc3lzdGVtIFNhZmFyaSB3 aGljaAorICAgICAgICBpcyBhbm5veWluZy4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbmFtZXMg dGhlIGV4cGVyaW1lbnRhbCBmZWF0dXJlIHNvIHRoYXQgdGhlIGZlYXR1cmUgc3RheXMgZGlzYWJs ZWQgaW4gTW9qYXZlJ3Mgc3lzdGVtCisgICAgICAgIFNhZmFyaSBldmVuIHdoZW4gZW5hYmxlZCBp biBXZWJLaXQgVG9UIC8gU1RQLgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh bWw6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwOgorICAgICAg ICAoV0tQcmVmZXJlbmNlc1NldFByb2Nlc3NTd2FwT25OYXZpZ2F0aW9uRW5hYmxlZCk6CisgICAg ICAgIChXS1ByZWZlcmVuY2VzR2V0UHJvY2Vzc1N3YXBPbk5hdmlnYXRpb25FbmFibGVkKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcmVmZXJlbmNlczo6dXBkYXRlQm9vbFZhbHVlRm9yRXhwZXJpbWVudGFsRmVhdHVyZUtleSk6 CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUHJvY2Vzc1Bvb2w6OmNyZWF0ZVdlYlBhZ2UpOgorCiAyMDE4LTA5LTA0ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHByb2Nlc3MgcG9vbCBjb25m aWd1cmF0aW9uIGZsYWcgdG8gdHVybiBvbiBhdXRvbWF0aWMgcHJvY2VzcyBwcmUtd2FybWluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggOTRhMDFlYjI2MGU2 ZmU0NzExODgxOGM2YzA3N2Q5YzFiN2JmOWVmYy4uMDMxMGM1YmU1ZDI3MTMwZTVlY2FjMmFiN2Zl MmIxYjQ0YTRlZGRlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVy ZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1s CkBAIC0xMzE2LDExICsxMzE2LDExIEBAIEVuY3J5cHRlZE1lZGlhQVBJRW5hYmxlZDoKICAgY2F0 ZWdvcnk6IGV4cGVyaW1lbnRhbAogICBjb25kaXRpb246IEVOQUJMRShFTkNSWVBURURfTUVESUEp CiAKLVByb2Nlc3NTd2FwT25OYXZpZ2F0aW9uRW5hYmxlZDoKK1Byb2Nlc3NTd2FwT25Dcm9zc1Np dGVOYXZpZ2F0aW9uRW5hYmxlZDoKICAgdHlwZTogYm9vbAogICBkZWZhdWx0VmFsdWU6IGZhbHNl Ci0gIGh1bWFuUmVhZGFibGVOYW1lOiAiU3dhcCBQcm9jZXNzZXMgb24gTmF2aWdhdGlvbiIKLSAg aHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiU3dhcCBXZWJDb250ZW50IHByb2Nlc3NlcyBvbiBj cm9zcy1vcmlnaW4gbmF2aWdhdGlvbnMiCisgIGh1bWFuUmVhZGFibGVOYW1lOiAiU3dhcCBQcm9j ZXNzZXMgb24gQ3Jvc3MtU2l0ZSBOYXZpZ2F0aW9uIgorICBodW1hblJlYWRhYmxlRGVzY3JpcHRp b246ICJTd2FwIFdlYkNvbnRlbnQgcHJvY2Vzc2VzIG9uIGNyb3NzLXNpdGUgbmF2aWdhdGlvbnMi CiAgIGNhdGVnb3J5OiBleHBlcmltZW50YWwKICAgd2ViY29yZUJpbmRpbmc6IG5vbmUKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcAppbmRleCBk ZDI3MWI1OWRmNzYwODkwNDQ1ZmVkMWQ2MzMzOGYxZDlmNjA4ODcxLi5kYTk4ZmQ1NTc2OTM4OWNi MDZhMjA0OGRkZjIxZmFiOGViNWJiYWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcApAQCAtMjA3OSwxMiArMjA3OSwxMiBAQCBib29sIFdL UHJlZmVyZW5jZXNHZXRDb2xvckZpbHRlckVuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJl bmNlc1JlZikKIAogdm9pZCBXS1ByZWZlcmVuY2VzU2V0UHJvY2Vzc1N3YXBPbk5hdmlnYXRpb25F bmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZykKIHsKLSAg ICB0b0ltcGwocHJlZmVyZW5jZXNSZWYpLT5zZXRQcm9jZXNzU3dhcE9uTmF2aWdhdGlvbkVuYWJs ZWQoZmxhZyk7CisgICAgdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+c2V0UHJvY2Vzc1N3YXBPbkNy b3NzU2l0ZU5hdmlnYXRpb25FbmFibGVkKGZsYWcpOwogfQogCiBib29sIFdLUHJlZmVyZW5jZXNH ZXRQcm9jZXNzU3dhcE9uTmF2aWdhdGlvbkVuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJl bmNlc1JlZikKIHsKLSAgICByZXR1cm4gdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+cHJvY2Vzc1N3 YXBPbk5hdmlnYXRpb25FbmFibGVkKCk7CisgICAgcmV0dXJuIHRvSW1wbChwcmVmZXJlbmNlc1Jl ZiktPnByb2Nlc3NTd2FwT25Dcm9zc1NpdGVOYXZpZ2F0aW9uRW5hYmxlZCgpOwogfQogCiB2b2lk IFdLUHJlZmVyZW5jZXNTZXRQdW5jaE91dFdoaXRlQmFja2dyb3VuZHNJbkRhcmtNb2RlKFdLUHJl ZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcAppbmRleCA2MmNhZGVjMjdjNWZlMjQ4YjQ1MGUxNzNk MmE2OTJlODI1ZmU3ZmM5Li4wODRiZWQzZWMxYmVkNjJiMjQyZjZiYmZhNDgwMTgwZDhlZjIzODU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCkBAIC0xMzMs NyArMTMzLDcgQEAgdm9pZCBXZWJQcmVmZXJlbmNlczo6dXBkYXRlQm9vbFZhbHVlRm9yS2V5KGNv bnN0IFN0cmluZyYga2V5LCBib29sIHZhbHVlKQogCiB2b2lkIFdlYlByZWZlcmVuY2VzOjp1cGRh dGVCb29sVmFsdWVGb3JFeHBlcmltZW50YWxGZWF0dXJlS2V5KGNvbnN0IFN0cmluZyYga2V5LCBi b29sIHZhbHVlKQogewotICAgIGlmIChrZXkgPT0gV2ViUHJlZmVyZW5jZXNLZXk6OnByb2Nlc3NT d2FwT25OYXZpZ2F0aW9uRW5hYmxlZEtleSgpKSB7CisgICAgaWYgKGtleSA9PSBXZWJQcmVmZXJl bmNlc0tleTo6cHJvY2Vzc1N3YXBPbkNyb3NzU2l0ZU5hdmlnYXRpb25FbmFibGVkS2V5KCkpIHsK ICAgICAgICAgZm9yIChhdXRvKiBwYWdlIDogbV9wYWdlcykKICAgICAgICAgICAgIHBhZ2UtPnBy b2Nlc3MoKS5wcm9jZXNzUG9vbCgpLmNvbmZpZ3VyYXRpb24oKS5zZXRQcm9jZXNzU3dhcHNPbk5h dmlnYXRpb24odmFsdWUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9v bC5jcHAKaW5kZXggNDExZmU2MTI1MmY5ZGNhOWI2ZTk1YjRlMmM5OWU1ZmNlZGI5YmIzMi4uMmQy YTk4YjZkOTQ5YWUxMjk5ZTZiYmZhNjczYTg0Nzk2ZTRkZTQ4MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApAQCAtMTE1NSw3ICsxMTU1LDcgQEAgUmVmPFdl YlBhZ2VQcm94eT4gV2ViUHJvY2Vzc1Bvb2w6OmNyZWF0ZVdlYlBhZ2UoUGFnZUNsaWVudCYgcGFn ZUNsaWVudCwgUmVmPEFQSToKICNlbmRpZgogCiAgICAgYXV0byBwYWdlID0gcHJvY2Vzcy0+Y3Jl YXRlV2ViUGFnZShwYWdlQ2xpZW50LCBXVEZNb3ZlKHBhZ2VDb25maWd1cmF0aW9uKSk7Ci0gICAg aWYgKHBhZ2UtPnByZWZlcmVuY2VzKCkucHJvY2Vzc1N3YXBPbk5hdmlnYXRpb25FbmFibGVkKCkp IHsKKyAgICBpZiAocGFnZS0+cHJlZmVyZW5jZXMoKS5wcm9jZXNzU3dhcE9uQ3Jvc3NTaXRlTmF2 aWdhdGlvbkVuYWJsZWQoKSkgewogICAgICAgICBtX2NvbmZpZ3VyYXRpb24tPnNldFByb2Nlc3NT d2Fwc09uTmF2aWdhdGlvbih0cnVlKTsKICAgICAgICAgLy8gRklYTUU6IEZvciBub3csIHR1cm5p bmcgb24gUFNPTiBmcm9tIHRoZSBleHBlcmltZW50YWwgZmVhdHVyZXMgbWVudSBhbHNvIHR1cm5z IG9uCiAgICAgICAgIC8vIGF1dG9tYXRpYyBwcm9jZXNzIHdhcm1pbmcgdW50aWwgY2xpZW50cyBj YW4gYmUgdXBkYXRlZC4K