189224 2018-09-01 20:36:30 -0700 REGRESSION(r235165): [GStreamer] Major video performance regression 2018-09-04 18:17:48 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188693 P2 Normal --- 1 mcatanzaro zan bugs-noreply calvaris mcatanzaro pgriffis pnormand zan oldest_to_newest 1456003 0 mcatanzaro 2018-09-01 20:36:30 -0700 r235165 "[CoordGraphics] Switch to Nicosia::CompositionLayer state tracking" has introduced a *very major* video performance regression that should be immediately noticeable e.g. when playing any video on YouTube. I can reproduce the same issue on http://download.blender.org/peach/bigbuckbunny_movies/big_buck_bunny_720p_stereo.ogg, which is a much simpler case than YouTube. It's not straightforward to rollout due to many code changes in these files. Fortunately, this commit is not on the 2.22 branch, so video playback in 2.21.92 is fine. 1456175 1 348774 zan 2018-09-03 09:07:24 -0700 Created attachment 348774 Patch 1456176 2 pnormand 2018-09-03 09:16:14 -0700 I tested this on desktop GTK and iMX6 WPE. Regression fixed. Thanks! 1456272 3 calvaris 2018-09-04 01:29:12 -0700 I guess this didn't land yet, otherwise bug would be closed, right? 1456273 4 348774 zan 2018-09-04 01:38:30 -0700 Comment on attachment 348774 Patch Clearing flags on attachment: 348774 Committed r235608: <https://trac.webkit.org/changeset/235608> 1456274 5 zan 2018-09-04 01:38:34 -0700 All reviewed patches have been landed. Closing bug. 1456579 6 mcatanzaro 2018-09-04 18:17:48 -0700 (In reply to Philippe Normand from comment #2) > I tested this on desktop GTK and iMX6 WPE. Regression fixed. Thanks! It's fixed for me too, yay! 348774 2018-09-03 09:07:24 -0700 2018-09-04 01:38:30 -0700 Patch bug-189224-20180903180722.patch text/plain 2276 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0Mzk3ZDJmZDY0NGZmZDEx ZTIwN2EyOTllNDM5MmM0OTMyMTdhMDUuLmRiMDdkYjA1NDk1ZTc3MzhiOTNjMzE2YThiZWZkMWQ2 ZWRkOTVjZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDktMDMgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzNTE2 NSk6IFtHU3RyZWFtZXJdIE1ham9yIHZpZGVvIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTIyNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcDoKKyAgICAgICAgKFdl YktpdDo6Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjp1cGRhdGVTY2VuZVN0YXRlKTogRHJvcCB0 aGUgZWFybHkKKyAgICAgICAgcmV0dXJuIHVzZWQgd2hlbiB0aGUgc2NlbmUgc3RhdGUgd2Fzbid0 IHVwZGF0ZWQgdGhyb3VnaCBhIGxheWVyIGZsdXNoLAorICAgICAgICBhbmQgaW5zdGVhZCBhbHdh eXMgcnVuIHRocm91Z2ggbGF5ZXIgY2hhbmdlcyBhbmQgYmFja2luZ3MuIFRoaXMgd2F5IHdlCisg ICAgICAgIHdvbid0IG1pc3MgcHJveHkgb2JqZWN0cyB0aGF0IG5lZWQgc3dhcHBpbmcgZXZlbiBp ZiBub25lIG9mIHRoZSBsYXllcgorICAgICAgICBzdGF0ZXMgd2VyZSBjaGFuZ2VkLiBSZWR1Y2lu ZyB0aGUgYW1vdW50IG9mIHdvcmsgZG9uZSBoZXJlIHdoZW4gc2NlbmUKKyAgICAgICAgaGFzbid0 IGJlZW4gdXBkYXRlZCBtaWdodCBiZSBwb3NzaWJsZSwgYnV0IGl0J3Mgbm90IGEgaHVnZSBib3R0 bGVuZWNrLgorCiAyMDE4LTA5LTAxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBbQ0ZOZXR3b3JrXSBVcGRhdGUgQ0ZOZXR3b3JrIFNQSSB1c2UgdG8gdXNlIENGTmV0 d29ya1NQSS5oIG1vcmUgY29uc2lzdGVudGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3NTY2VuZS5jcHAKaW5kZXggMmZlNjZhZWI3YzI3N2Y2YWZhZTVlMGY2MjVjYjIxMzc3NTc0MjEy MC4uYjVhZWFkZWJhNGUyZWMzMjFmZWZjMzRhYzc3YmU4MDBkNzVmMDA1MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzU2NlbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcApAQCAtMjU5LDkgKzI1OSw5IEBAIHZvaWQg Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjp1cGRhdGVTY2VuZVN0YXRlKCkKICAgICBtX25pY29z aWEuc2NlbmUtPmFjY2Vzc1N0YXRlKAogICAgICAgICBbdGhpcywgJmxheWVyc0J5QmFja2luZ10o Tmljb3NpYTo6U2NlbmU6OlN0YXRlJiBzdGF0ZSkKICAgICAgICAgewotICAgICAgICAgICAgLy8g QmFpbCBpZiB0aGUgc2NlbmUgZGlkbid0IGNoYW5nZS4KLSAgICAgICAgICAgIGlmIChzdGF0ZS5p ZCA9PSBtX25pY29zaWEuc3RhdGUuaWQpCi0gICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICAgICAgLy8gRklYTUU6IHRyeSB0byBtaW5pbWl6ZSB0aGUgYW1vdW50IG9mIHdvcmsgaW4gY2Fz ZSB0aGUgU2NlbmU6OlN0YXRlIG9iamVjdAorICAgICAgICAgICAgLy8gZGlkbid0IGNoYW5nZSAo aS5lLiBubyBsYXllciBmbHVzaCB3YXMgZG9uZSksIGJ1dCBkb24ndCBmb3JnZXQgdG8gcHJvcGVy bHkKKyAgICAgICAgICAgIC8vIGdhdGhlciBhbmQgdXBkYXRlIHByb3h5IG9iamVjdHMgZm9yIGNv bnRlbnQgbGF5ZXJzLgogCiAgICAgICAgICAgICAvLyBIYW5kbGUgdGhlIHJvb3QgbGF5ZXIsIGFk ZGluZyBpdCB0byB0aGUgVGV4dHVyZU1hcHBlckxheWVyIHRyZWUKICAgICAgICAgICAgIC8vIG9u IHRoZSBmaXJzdCB1cGRhdGUuIE5vIHN1Y2ggY2hhbmdlIGlzIGV4cGVjdGVkIGxhdGVyLgo=