189197 2018-08-31 10:00:01 -0700 [JSC] [Armv7] implement patchableBranch8() 2020-06-04 04:03:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1455729 0 guijemont 2018-08-31 10:00:01 -0700 The build is broken for Armv7 since r235517 because it needs an implementation of that method. 1455738 1 348646 guijemont 2018-08-31 10:17:45 -0700 Created attachment 348646 Patch Tentative implemention, currently running tests on a device to check that it does not break anything. 1455739 2 guijemont 2018-08-31 10:18:17 -0700 (In reply to Guillaume Emont from comment #1) > Created attachment 348646 [details] > Patch > > Tentative implemention, currently running tests on a device to check that it > does not break anything. (Copy-pasted from the Arm64 implementation, but that should do). 1455744 3 mark.lam 2018-08-31 10:26:20 -0700 I already landed a build fix for this in r235557: <https://trac.webkit.org/r235557>. Does that not work? 1455746 4 guijemont 2018-08-31 10:28:13 -0700 (In reply to Mark Lam from comment #3) > I already landed a build fix for this in r235557: > <https://trac.webkit.org/r235557>. Does that not work? Yes, that should work, I had not seen it yet. Sorry for the noise. 1455748 5 webkit-bug-importer 2018-08-31 10:29:17 -0700 <rdar://problem/43945560> 348646 2018-08-31 10:17:45 -0700 2020-06-04 04:03:05 -0700 Patch bug-189197-20180831191744.patch text/plain 1619 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZTZjNmNhODgyMjFhODI0NzBhMjQwMjczMmYwMGNkODcwMjUzNDg0Li5kYmRkNWZiOTFlYjI1NDll YWIwOTBjMjY5OTU4M2UwODI1YzZlNTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wOC0zMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW0pTQ10gW0FybXY3XSBpbXBsZW1lbnQgcGF0Y2hhYmxlQnJhbmNo OCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkx OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFz c2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1i bGVyQVJNdjc6OnBhdGNoYWJsZUJyYW5jaDgpOiBBZGRlZC4KKwogMjAxOC0wOC0zMSAgTWFyayBM YW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG1pc3NpbmcgZXhjZXB0aW9u IGNoZWNrIGluIGFycmF5UHJvdG9GdW5jTGFzdEluZGV4T2YoKS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKaW5kZXggODFk NGY3ZWYyNjg1ZDM0ZTNkMGVkOWU5ZGU4ZjJiMWJhNDM3YTEyMi4uMmNjMGI0ZDA3OTdkNzcxMjI3 MTUyZmM1YzZlMTQ1ZGQxM2RjNWEzYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKQEAgLTE5MzMsNyArMTkzMywxNSBA QCBwdWJsaWM6CiAgICAgICAgIG1fbWFrZUp1bXBQYXRjaGFibGUgPSBmYWxzZTsKICAgICAgICAg cmV0dXJuIFBhdGNoYWJsZUp1bXAocmVzdWx0KTsKICAgICB9Ci0gICAgCisKKyAgICBQYXRjaGFi bGVKdW1wIHBhdGNoYWJsZUJyYW5jaDgoUmVsYXRpb25hbENvbmRpdGlvbiBjb25kLCBBZGRyZXNz IGxlZnQsIFRydXN0ZWRJbW0zMiBpbW0pCisgICAgeworICAgICAgICBtX21ha2VKdW1wUGF0Y2hh YmxlID0gdHJ1ZTsKKyAgICAgICAgSnVtcCByZXN1bHQgPSBicmFuY2g4KGNvbmQsIGxlZnQsIGlt bSk7CisgICAgICAgIG1fbWFrZUp1bXBQYXRjaGFibGUgPSBmYWxzZTsKKyAgICAgICAgcmV0dXJu IFBhdGNoYWJsZUp1bXAocmVzdWx0KTsKKyAgICB9CisKICAgICBQYXRjaGFibGVKdW1wIHBhdGNo YWJsZUJyYW5jaFRlc3QzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCByZWcsIFRy dXN0ZWRJbW0zMiBtYXNrID0gVHJ1c3RlZEltbTMyKC0xKSkKICAgICB7CiAgICAgICAgIG1fbWFr ZUp1bXBQYXRjaGFibGUgPSB0cnVlOwo=