189183 2018-08-30 21:38:37 -0700 slotchange-event-bubbling.html fails in Chrome & Firefox 2018-08-31 13:42:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189144 1 rniwa rniwa cdumez ggaren koivisto lforschler webkit-bug-importer wenson_hsieh oldest_to_newest 1455553 0 rniwa 2018-08-30 21:38:37 -0700 There is a bug in slotchange-event-bubbling.html such that it fails in Chrome & Firefox. We would start failing this test as well once the bug 189144 is fixed. 1455558 1 348600 rniwa 2018-08-30 21:43:03 -0700 Created attachment 348600 Fixes the test 1455835 2 348600 cdumez 2018-08-31 13:32:56 -0700 Comment on attachment 348600 Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review > LayoutTests/ChangeLog:8 > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. Typo: assinged > LayoutTests/ChangeLog:10 > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask Typo: implements -> implement / fails -> fail > LayoutTests/ChangeLog:13 > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing is emptied -> to be emptied? 1455837 3 rniwa 2018-08-31 13:39:25 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 348600 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348600&action=review > > > LayoutTests/ChangeLog:8 > > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. > > Typo: assinged Fixed. > > LayoutTests/ChangeLog:10 > > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask > > Typo: implements -> implement / fails -> fail Fixed. > > LayoutTests/ChangeLog:13 > > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing > > is emptied -> to be emptied? Fixed. 1455838 4 rniwa 2018-08-31 13:41:59 -0700 Committed r235568: <https://trac.webkit.org/changeset/235568> 1455839 5 webkit-bug-importer 2018-08-31 13:42:17 -0700 <rdar://problem/43953435> 348600 2018-08-30 21:43:03 -0700 2018-08-31 13:32:56 -0700 Fixes the test bug-189183-20180830214302.patch text/plain 7056 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzNTUzNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA4LTMwICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHNsb3RjaGFuZ2UtZXZlbnQtYnViYmxpbmcuaHRt bCBmYWlscyBpbiBDaHJvbWUgJiBGaXJlZm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBzbG90Y2hhbmdlIGV2ZW50IGlzIHN1cHBvc2VkIHRvIGZpcmUg d2hlbiBhIHNsb3QgZWxlbWVudCBpcyBpbnNlcnRlZCBhbmQgdGhlcmUgYXJlIGFzc2luZ2VkIG5v ZGVzLgorCisgICAgICAgIEZpcmVmb3ggYW5kIENocm9tZSBpbXBsZW1lbnRzIHRoaXMgYmVoYXZp b3IgYW5kIGZhaWxzIHRoaXMgdGVzdCBzaW5jZSB0aGUgdGVzdCBkb2Vzbid0IGxldCBtaWNyb3N0 YXNrCisgICAgICAgIGNoZWNrIHBvaW50IHJ1biBiZWZvcmUgc3RhcnQgbXV0YXRpbmcgdGhlIERP TS4KKworICAgICAgICBGaXhlZCB0aGUgdGVzdCBieSBtYW51YWxseSB3YWl0aW5nIGZvciB0aGUg Y3VycmVudCBtaWNyb3Rhc2sgcXVldWUgaXMgZW1wdGllZCBhZnRlciBjb25zdHJ1Y3RpbmcKKyAg ICAgICAgdGhlIHRlc3Qgc2hhZG93IHRyZWUgc28gdGhhdCBzbG90Y2hhbmdlIGV2ZW50IGZyb20g dGhlIGluaXRpYWwgdHJlZSBjb25zdHJ1Y3Rpb24gZG9lc24ndCBnZXQgbWVyZ2VkCisgICAgICAg IHdpdGggc2xvdGNoYW5nZSBldmVudCBmaXJlZCBmb3IgdGhlIGFjdHVhbCBET00gbXV0YXRpb24g YmVpbmcgdGVzdGVkLgorCisgICAgICAgIEFsc28gZml4ZWQgdHlwb3MgaW4gc2xvdGNoYW5nZS1p bi1mYWxsYmFjay5odG1sIGFuZCBhIGJ1ZyB0aGF0IHdlIHdlcmUgcmVtb3ZpbmcgdGhlIHNsb3Qg aW5zdGVhZAorICAgICAgICBvZiB0aGUgc2hhZG93IGhvc3QgYXQgdGhlIGVuZCBvZiBlYWNoIHRl c3QgY2FzZS4KKworICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9zbG90Y2hhbmdlLWV2ZW50LWJ1 YmJsaW5nLmh0bWw6CisgICAgICAgICogZmFzdC9zaGFkb3ctZG9tL3Nsb3RjaGFuZ2UtaW4tZmFs bGJhY2suaHRtbDoKKwogMjAxOC0wOC0zMCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIENvdW50ZXJNYXBzIHNob3VsZCBob2xkIGEgdW5pcXVlX3B0ciBvZiBDb3Vu dGVyTWFwLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL3Nsb3RjaGFuZ2UtZXZl bnQtYnViYmxpbmcuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1k b20vc2xvdGNoYW5nZS1ldmVudC1idWJibGluZy5odG1sCShyZXZpc2lvbiAyMzU1MzcpCisrKyBM YXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vc2xvdGNoYW5nZS1ldmVudC1idWJibGluZy5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC03NSw3ICs3NSw3IEBAIHRlc3Rfc2xvdGNoYW5nZV9ldmVudF9i dWJibGVzKCdvcGVuJywgZmEKIHRlc3Rfc2xvdGNoYW5nZV9ldmVudF9idWJibGVzKCdvcGVuJywg dHJ1ZSk7CiAKIGZ1bmN0aW9uIHRlc3Rfc2luZ2xlX3Nsb3RjaGFuZ2VfZXZlbnRfZm9yX25lc3Rl ZF9zbG90cyhvdXRlck1vZGUsIGlubmVyTW9kZSwgY29ubmVjdGVkKSB7Ci0gICAgcHJvbWlzZV90 ZXN0KCgpID0+IHsKKyAgICBwcm9taXNlX3Rlc3QoYXN5bmMgKCkgPT4gewogICAgICAgICBjb25z dCBvdXRlckhvc3QgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdvdXRlci1ob3N0Jyk7CiAgICAg ICAgIGlmIChjb25uZWN0ZWQpCiAgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KG91dGVySG9zdCk7CkBAIC05MSw2ICs5MSw4IEBAIGZ1bmN0aW9uIHRlc3Rfc2luZ2xlX3Nsb3Rj aGFuZ2VfZXZlbnRfZm8KICAgICAgICAgY29uc3QgaW5uZXJTbG90UGFyZW50ID0gaW5uZXJTaGFk b3cucXVlcnlTZWxlY3RvcignZGl2Jyk7CiAgICAgICAgIGNvbnN0IGlubmVyU2xvdCA9IGlubmVy U2hhZG93LnF1ZXJ5U2VsZWN0b3IoJ3Nsb3QnKTsKIAorICAgICAgICBhd2FpdCBQcm9taXNlLnJl c29sdmUoKTsKKwogICAgICAgICBjb25zdCBvYnNlcnZlciA9IGNyZWF0ZV9zbG90Y2hhbmdlX29i c2VydmVyKCk7CiAgICAgICAgIG9ic2VydmVyLm9ic2VydmUob3V0ZXJTbG90KTsKICAgICAgICAg b2JzZXJ2ZXIub2JzZXJ2ZShpbm5lckhvc3QpOwpAQCAtMTA5LDIzICsxMTEsMjMgQEAgZnVuY3Rp b24gdGVzdF9zaW5nbGVfc2xvdGNoYW5nZV9ldmVudF9mbwogICAgICAgICBvdXRlckhvc3QudGV4 dENvbnRlbnQgPSAnICc7CiAKICAgICAgICAgYXNzZXJ0X2FycmF5X2VxdWFscyhvYnNlcnZlci50 YWtlTG9nKCksIFtdLCAnc2xvdGNoYW5nZSBldmVudCBtdXN0IG5vdCBiZSBmaXJlZCBzeW5jaHJv bm91c2x5Jyk7Ci0gICAgICAgIHJldHVybiBQcm9taXNlLnJlc29sdmUoKS50aGVuKCgpID0+IHsK LSAgICAgICAgICAgIGNvbnN0IGxvZyA9IG9ic2VydmVyLnRha2VMb2coKTsKKyAgICAgICAgYXdh aXQgUHJvbWlzZS5yZXNvbHZlKCk7CiAKLSAgICAgICAgICAgIGNvbnN0IGV2ZW50cyA9IG5ldyBT ZXQobG9nLm1hcCgoZW50cnkpID0+IGVudHJ5LmV2ZW50KSk7Ci0gICAgICAgICAgICBhc3NlcnRf ZXF1YWxzKGV2ZW50cy5zaXplLCAxLCAnTXV0YXRpbmcgdGhlIGFzc2lnbmVkIGNvbnRlbnQgb2Yg YSBzbG90IG11c3QgZmlyZSBleGFjdGx5IG9uZSBzbG90Y2hhbmdlIGV2ZW50Jyk7CisgICAgICAg IGNvbnN0IGxvZyA9IG9ic2VydmVyLnRha2VMb2coKTsKIAotICAgICAgICAgICAgYXNzZXJ0X3Ns b3RjaGFuZ2VfbG9nKGxvZ1swXSwgb3V0ZXJTbG90LCBvdXRlclNsb3QsICdzbG90Y2hhbmdlIGV2 ZW50IG11c3QgYmUgZGlzcGF0Y2hlZCBhdCB0aGUgc2xvdCBlbGVtZW50IGZpcnN0Jyk7Ci0gICAg ICAgICAgICBhc3NlcnRfc2xvdGNoYW5nZV9sb2cobG9nWzFdLCBpbm5lclNsb3QsIG91dGVyU2xv dCwgJ3Nsb3RjaGFuZ2UgZXZlbnQgbXVzdCBidWJibGUgdXAgZnJvbSBhIHNsb3QgZWxlbWVudCB0 byBpdHMgYXNzaWduZWQgc2xvdCcpOwotICAgICAgICAgICAgYXNzZXJ0X3Nsb3RjaGFuZ2VfbG9n KGxvZ1syXSwgaW5uZXJTbG90UGFyZW50LCBvdXRlclNsb3QsICdzbG90Y2hhbmdlIGV2ZW50IG11 c3QgYnViYmxlIHVwIHRvIHRoZSBwYXJlbnQgbm9kZSBvZiBhIHNsb3QnKTsKLSAgICAgICAgICAg IGFzc2VydF9zbG90Y2hhbmdlX2xvZyhsb2dbM10sIGlubmVyU2hhZG93LCBvdXRlclNsb3QsICdz bG90Y2hhbmdlIGV2ZW50IG11c3QgYnViYmxlIHVwIHRvIHRoZSBzaGFkb3cgcm9vdCcpOwotICAg ICAgICAgICAgYXNzZXJ0X3Nsb3RjaGFuZ2VfbG9nKGxvZ1s0XSwgaW5uZXJIb3N0LCBvdXRlclNs b3QsCi0gICAgICAgICAgICAgICAgJ3Nsb3RjaGFuZ2UgZXZlbnQgbXVzdCBidWJibGUgdXAgdG8g dGhlIHNoYWRvdyBob3N0IGlmIHRoZSBob3N0IGlzIGEgZGVzY2VuZGVudCBvZiB0aGUgdHJlZSBp biB3aGljaCB0aGUgZXZlbnQgd2FzIGZpcmVkJyk7Ci0gICAgICAgICAgICBhc3NlcnRfc2xvdGNo YW5nZV9sb2cobG9nWzVdLCBvdXRlckhvc3RQYXJlbnQsIG91dGVyU2xvdCwKLSAgICAgICAgICAg ICAgICAnc2xvdGNoYW5nZSBldmVudCBtdXN0IGJ1YmJsZSB1cCB0byB0aGUgcGFyZW50IG9mIGFu IGlubmVyIHNoYWRvdyBob3N0Jyk7Ci0gICAgICAgICAgICBhc3NlcnRfc2xvdGNoYW5nZV9sb2co bG9nWzZdLCBvdXRlclNoYWRvdywgb3V0ZXJTbG90LCAnc2xvdGNoYW5nZSBldmVudCBtdXN0IGJ1 YmJsZSB1cCB0byB0aGUgc2hhZG93IHJvb3QnKTsKLSAgICAgICAgICAgIGFzc2VydF9lcXVhbHMo bG9nLmxlbmd0aCwgNywgJ3Nsb3RjaGFuZ2UgbXVzdCBub3QgYnViYmxlIGJleW9uZCB0aGUgc2hh ZG93IHJvb3QgaW4gd2hpY2ggdGhlIGV2ZW50IHdhcyBmaXJlZCcpOwotICAgICAgICB9KTsKKyAg ICAgICAgY29uc3QgZXZlbnRzID0gbmV3IFNldChsb2cubWFwKChlbnRyeSkgPT4gZW50cnkuZXZl bnQpKTsKKyAgICAgICAgYXNzZXJ0X2VxdWFscyhldmVudHMuc2l6ZSwgMSwgJ011dGF0aW5nIHRo ZSBhc3NpZ25lZCBjb250ZW50IG9mIGEgc2xvdCBtdXN0IGZpcmUgZXhhY3RseSBvbmUgc2xvdGNo YW5nZSBldmVudCcpOworCisgICAgICAgIGFzc2VydF9zbG90Y2hhbmdlX2xvZyhsb2dbMF0sIG91 dGVyU2xvdCwgb3V0ZXJTbG90LCAnc2xvdGNoYW5nZSBldmVudCBtdXN0IGJlIGRpc3BhdGNoZWQg YXQgdGhlIHNsb3QgZWxlbWVudCBmaXJzdCcpOworICAgICAgICBhc3NlcnRfc2xvdGNoYW5nZV9s b2cobG9nWzFdLCBpbm5lclNsb3QsIG91dGVyU2xvdCwgJ3Nsb3RjaGFuZ2UgZXZlbnQgbXVzdCBi dWJibGUgdXAgZnJvbSBhIHNsb3QgZWxlbWVudCB0byBpdHMgYXNzaWduZWQgc2xvdCcpOworICAg ICAgICBhc3NlcnRfc2xvdGNoYW5nZV9sb2cobG9nWzJdLCBpbm5lclNsb3RQYXJlbnQsIG91dGVy U2xvdCwgJ3Nsb3RjaGFuZ2UgZXZlbnQgbXVzdCBidWJibGUgdXAgdG8gdGhlIHBhcmVudCBub2Rl IG9mIGEgc2xvdCcpOworICAgICAgICBhc3NlcnRfc2xvdGNoYW5nZV9sb2cobG9nWzNdLCBpbm5l clNoYWRvdywgb3V0ZXJTbG90LCAnc2xvdGNoYW5nZSBldmVudCBtdXN0IGJ1YmJsZSB1cCB0byB0 aGUgc2hhZG93IHJvb3QnKTsKKyAgICAgICAgYXNzZXJ0X3Nsb3RjaGFuZ2VfbG9nKGxvZ1s0XSwg aW5uZXJIb3N0LCBvdXRlclNsb3QsCisgICAgICAgICAgICAnc2xvdGNoYW5nZSBldmVudCBtdXN0 IGJ1YmJsZSB1cCB0byB0aGUgc2hhZG93IGhvc3QgaWYgdGhlIGhvc3QgaXMgYSBkZXNjZW5kZW50 IG9mIHRoZSB0cmVlIGluIHdoaWNoIHRoZSBldmVudCB3YXMgZmlyZWQnKTsKKyAgICAgICAgYXNz ZXJ0X3Nsb3RjaGFuZ2VfbG9nKGxvZ1s1XSwgb3V0ZXJIb3N0UGFyZW50LCBvdXRlclNsb3QsCisg ICAgICAgICAgICAnc2xvdGNoYW5nZSBldmVudCBtdXN0IGJ1YmJsZSB1cCB0byB0aGUgcGFyZW50 IG9mIGFuIGlubmVyIHNoYWRvdyBob3N0Jyk7CisgICAgICAgIGFzc2VydF9zbG90Y2hhbmdlX2xv Zyhsb2dbNl0sIG91dGVyU2hhZG93LCBvdXRlclNsb3QsICdzbG90Y2hhbmdlIGV2ZW50IG11c3Qg YnViYmxlIHVwIHRvIHRoZSBzaGFkb3cgcm9vdCcpOworICAgICAgICBhc3NlcnRfZXF1YWxzKGxv Zy5sZW5ndGgsIDcsICdzbG90Y2hhbmdlIG11c3Qgbm90IGJ1YmJsZSBiZXlvbmQgdGhlIHNoYWRv dyByb290IGluIHdoaWNoIHRoZSBldmVudCB3YXMgZmlyZWQnKTsKICAgICB9LCBgQSBzaW5nbGUg c2xvdGNoYW5nZSBldmVudCBtdXN0IGJ1YmJsZSBmcm9tIGEgJHtjb25uZWN0ZWQgPyAnY29ubmVj dGVkJyA6ICdkaXNjb25uZWN0ZWQnfSAke2lubmVyTW9kZX0tbW9kZSBzaGFkb3cgdHJlZSB0b2AK ICAgICAgICAgKyBgYSBzbG90IGluIGl0cyBwYXJlbnQgJHtvdXRlck1vZGV9LW1vZGUgc2hhZG93 IHRyZWVgKTsKIH0KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9zbG90Y2hhbmdl LWluLWZhbGxiYWNrLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ct ZG9tL3Nsb3RjaGFuZ2UtaW4tZmFsbGJhY2suaHRtbAkocmV2aXNpb24gMjM1NTM3KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL3Nsb3RjaGFuZ2UtaW4tZmFsbGJhY2suaHRtbAkod29y a2luZyBjb3B5KQpAQCAtMTksMTQgKzE5LDE0IEBAIGZ1bmN0aW9uIGdlbmVyYXRlVGVzdHMoLi4u YXJncykgewogICAgIHRlc3RNdXRhdGluZ1Nsb3QoJ29wZW4nLCBmYWxzZSwgLi4uYXJncyk7CiB9 CiAKLWZ1bmN0aW9uIHRlc3RNdXRhdGluZ1Nsb3QobW9kZSwgY29ubmVjdGVkVG9Eb2N1bWVudCwg c2hhZG93Q29udGVudCwgc2xvdE5hbWUsIHByZXBhcmVTbG90LCBtdXRhdGVTbG90LCBkZXNjcmlw dGlvbikKK2Z1bmN0aW9uIHRlc3RNdXRhdGluZ1Nsb3QobW9kZSwgY29ubmVjdGVkVG9Eb2N1bWVu dCwgaG9zdENvbnRlbnQsIHNsb3ROYW1lLCBwcmVwYXJlU2xvdCwgbXV0YXRlU2xvdCwgZGVzY3Jp cHRpb24pCiB7CiAgICAgcHJvbWlzZV90ZXN0KGFzeW5jIGZ1bmN0aW9uICgpIHsKICAgICAgICAg Y29uc3QgaG9zdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwogICAgICAgICBpZiAo Y29ubmVjdGVkVG9Eb2N1bWVudCkKICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQoaG9zdCk7Ci0gICAgICAgIGlmIChzaGFkb3dDb250ZW50KQotICAgICAgICAgICAgaG9zdC5p bm5lckhUTUwgPSBzaGFkb3dDb250ZW50OworICAgICAgICBpZiAoaG9zdENvbnRlbnQpCisgICAg ICAgICAgICBob3N0LmlubmVySFRNTCA9IGhvc3RDb250ZW50OwogCiAgICAgICAgIGNvbnN0IHNo YWRvd1Jvb3QgPSBob3N0LmF0dGFjaFNoYWRvdyh7bW9kZX0pOwogCkBAIC00NCw5ICs0NCw5IEBA IGZ1bmN0aW9uIHRlc3RNdXRhdGluZ1Nsb3QobW9kZSwgY29ubmVjdGUKIAogICAgICAgICBtdXRh dGVTbG90KHNsb3QpOwogICAgICAgICBhd2FpdCBQcm9taXNlLnJlc29sdmUoKTsKLSAgICAgICAg YXNzZXJ0X2VxdWFscyhldmVudENvdW50LCBzaGFkb3dDb250ZW50ID8gMCA6IDEpOworICAgICAg ICBhc3NlcnRfZXF1YWxzKGV2ZW50Q291bnQsIGhvc3RDb250ZW50ID8gMCA6IDEpOwogCi0gICAg ICAgIHNsb3QucmVtb3ZlKCk7CisgICAgICAgIGhvc3QucmVtb3ZlKCk7CiAgICAgfSwgZGVzY3Jp cHRpb24gKyBgIGluIGEgJHtjb25uZWN0ZWRUb0RvY3VtZW50ID8gJ2Nvbm5lY3RlZCcgOiAnZGlz Y29ubmVjdGVkJ30gJHttb2RlfSBtb2RlIHNoYWRvdyByb290YCk7CiB9CiAK