189170 2018-08-30 13:34:38 -0700 REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share 2018-08-31 02:54:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171100 1 obarnett webkit-unassigned commit-queue ddkilzer ews-watchlist thorton webkit-bug-importer oldest_to_newest 1455383 0 obarnett 2018-08-30 13:34:38 -0700 REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share 1455384 1 348537 obarnett 2018-08-30 13:35:44 -0700 Created attachment 348537 Patch 1455387 2 ews-watchlist 2018-08-30 13:40:01 -0700 Attachment 348537 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1455389 3 348537 thorton 2018-08-30 13:40:44 -0700 Comment on attachment 348537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348537&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Get this outta here. Maybe "No new tests; fixing a failing existing test." 1455390 4 348540 obarnett 2018-08-30 13:42:59 -0700 Created attachment 348540 Patch 1455420 5 348540 commit-queue 2018-08-30 14:33:45 -0700 Comment on attachment 348540 Patch Clearing flags on attachment: 348540 Committed r235524: <https://trac.webkit.org/changeset/235524> 1455421 6 commit-queue 2018-08-30 14:33:46 -0700 All reviewed patches have been landed. Closing bug. 1455628 7 webkit-bug-importer 2018-08-31 02:54:03 -0700 <rdar://problem/43932707> 348537 2018-08-30 13:35:44 -0700 2018-08-30 13:42:58 -0700 Patch bug-189170-20180830133543.patch text/plain 1365 obarnett U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjE5NWVjZDlkZDAwNGE4 NGZiMDg3ZDg0ZmZmMzNhYzZiYmY2MDJmYy4uODFhYzcyYmEwYWY4N2ZlMmZhMGJkYzM2NGRhNGYx YWQ5ODZlNjgzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTMwICBPbGl2 aWEgQmFybmV0dCAgPG9iYXJuZXR0QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MzU0ODkpOiBmYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbCBjcmFzaGVz IHVuZGVyIE5hdmlnYXRvcjo6c2hhcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4OTE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9O YXZpZ2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmF2aWdhdG9yOjpzaGFyZSk6CisgICAg ICAgIEFkZGVkIG51bGwgY2hlY2sgZm9yIGZyYW1lLgorCiAyMDE4LTA4LTMwICBBbmR5IEVzdGVz ICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbUGF5bWVudCBSZXF1ZXN0XSBJbXBsZW1l bnQgdGhlIFBheW1lbnRNZXRob2RDaGFuZ2VFdmVudCBhbmQgUGF5bWVudE1ldGhvZENoYW5nZUV2 ZW50SW5pdCBpbnRlcmZhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmln YXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAKaW5kZXggMmFlZjdh OWNjNTAyMWU0MGM3MTk1Yzg4MmU0MDBlMzM5Y2ZiMzQ4ZS4uNzU2OWNhODU0ZWM2YmIwOTkzZTVj M2E3ZDBlZTgyNDE5ZjUyYjNhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZp Z2F0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcApAQCAtOTks NyArOTksNyBAQCBib29sIE5hdmlnYXRvcjo6b25MaW5lKCkgY29uc3QKIAogdm9pZCBOYXZpZ2F0 b3I6OnNoYXJlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIGNvbnRleHQsIFNoYXJlRGF0YSBkYXRh LCBSZWY8RGVmZXJyZWRQcm9taXNlPiYmIHByb21pc2UpCiB7Ci0gICAgaWYgKCFtX2ZyYW1lLT5w YWdlKCkpIHsKKyAgICBpZiAoIW1fZnJhbWUgfHwgIW1fZnJhbWUtPnBhZ2UoKSkgewogICAgICAg ICBwcm9taXNlLT5yZWplY3QoVHlwZUVycm9yKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 348540 2018-08-30 13:42:59 -0700 2018-08-30 14:33:45 -0700 Patch bug-189170-20180830134259.patch text/plain 1389 obarnett U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjE5NWVjZDlkZDAwNGE4 NGZiMDg3ZDg0ZmZmMzNhYzZiYmY2MDJmYy4uY2FlMzljYjk3YTFlZWJjNzY0ODcwMmE3OWRhMTFi NmFkZDUwYjliMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTMwICBPbGl2 aWEgQmFybmV0dCAgPG9iYXJuZXR0QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MzU0ODkpOiBmYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbCBjcmFzaGVz IHVuZGVyIE5hdmlnYXRvcjo6c2hhcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4OTE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgZml4aW5nIGEgZmFpbGluZyBleGlzdGluZyB0 ZXN0LgorCisgICAgICAgICogcGFnZS9OYXZpZ2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TmF2aWdhdG9yOjpzaGFyZSk6CisgICAgICAgIEFkZGVkIG51bGwgY2hlY2sgZm9yIGZyYW1lLgor CiAyMDE4LTA4LTMwICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBb UGF5bWVudCBSZXF1ZXN0XSBJbXBsZW1lbnQgdGhlIFBheW1lbnRNZXRob2RDaGFuZ2VFdmVudCBh bmQgUGF5bWVudE1ldGhvZENoYW5nZUV2ZW50SW5pdCBpbnRlcmZhY2VzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL05h dmlnYXRvci5jcHAKaW5kZXggMmFlZjdhOWNjNTAyMWU0MGM3MTk1Yzg4MmU0MDBlMzM5Y2ZiMzQ4 ZS4uNzU2OWNhODU0ZWM2YmIwOTkzZTVjM2E3ZDBlZTgyNDE5ZjUyYjNhMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvTmF2aWdhdG9yLmNwcApAQCAtOTksNyArOTksNyBAQCBib29sIE5hdmlnYXRvcjo6b25MaW5l KCkgY29uc3QKIAogdm9pZCBOYXZpZ2F0b3I6OnNoYXJlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQm IGNvbnRleHQsIFNoYXJlRGF0YSBkYXRhLCBSZWY8RGVmZXJyZWRQcm9taXNlPiYmIHByb21pc2Up CiB7Ci0gICAgaWYgKCFtX2ZyYW1lLT5wYWdlKCkpIHsKKyAgICBpZiAoIW1fZnJhbWUgfHwgIW1f ZnJhbWUtPnBhZ2UoKSkgewogICAgICAgICBwcm9taXNlLT5yZWplY3QoVHlwZUVycm9yKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0K