189164 2018-08-30 11:18:04 -0700 Document.p.contains returns true for nodes in shadow tree 2020-09-28 16:48:49 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216656 InRadar P2 Normal --- 148695 1 jridgewell rniwa cdumez darin jridgewell rniwa webkit-bug-importer oldest_to_newest 1455305 0 348515 jridgewell 2018-08-30 11:18:04 -0700 Created attachment 348515 Document contains test case `Document.p.contains` currently returns true for nodes inside a shadow tree. This incorrect according to the [spec](https://dom.spec.whatwg.org/#dom-node-contains), which uses "inclusive descendant" not "shadow-including inclusive descendant". Note that `Element.p.contains` always does the right thing for nodes in a shadow tree. Steps to reproduce: - Go to https://output.jsbin.com/gasefow/quiet - Observe "Doc contains node in shadow tree" is written to the page This report invalidates the bug at https://bugs.webkit.org/show_bug.cgi?id=119371 (which asks for for `Node.p.contains` to return true). Further reading at https://www.w3.org/Bugs/Public/show_bug.cgi?id=22141, which argued for the broken `Document.p.contains` behavior. Instead of breaking contains, `Node.p.isConnected` was added in https://github.com/w3c/webcomponents/issues/81. 1692230 1 rniwa 2020-09-26 15:22:49 -0700 This works for me now. 1692583 2 jridgewell 2020-09-28 10:06:24 -0700 I tested with Safari TP 113, and it still fails. Is there a recent commit that fixes the behavior? To be clear, we do not want to see any output on the test page, it should be blank. Safari still shows "Doc contains node in shadow tree" for me. 1692687 3 rniwa 2020-09-28 15:26:40 -0700 (In reply to Justin Ridgewell from comment #2) > I tested with Safari TP 113, and it still fails. Is there a recent commit > that fixes the behavior? > > To be clear, we do not want to see any output on the test page, it should be > blank. Safari still shows "Doc contains node in shadow tree" for me. Oh, weird. I don't know what I was testing but you're right this is definitely broken. 1692689 4 rniwa 2020-09-28 15:31:55 -0700 Ah, okay, I know what happened there. Darin fixed this in https://trac.webkit.org/r267220. Node::isDescendantOf has a special code for when "other" node is a document node. Before r267220, we had the following code, which incorrectly assumed that any node which is connected to "other" is a descendent of "other": if (other.isDocumentNode()) return &document() == &other && !isDocumentNode() && isConnected(); After r267220, now correctly checks that the root node of the current tree is same as "other": if (other.isDocumentNode()) return &treeScope().rootNode() == &other && !isDocumentNode() && isConnected(); I expect this bug will be fixed the next STP. 1692691 5 webkit-bug-importer 2020-09-28 15:32:36 -0700 <rdar://problem/69720558> 1692693 6 rniwa 2020-09-28 15:33:15 -0700 Actually, let's add a test for this. 1692694 7 rniwa 2020-09-28 15:33:29 -0700 Adding a test. 1692698 8 darin 2020-09-28 15:47:12 -0700 I knew I was fixing a bug. I’m embarrassed that I didn’t add a test case for it. 1692700 9 darin 2020-09-28 16:03:34 -0700 And really surprised WPT doesn’t already have one! 1692702 10 rniwa 2020-09-28 16:09:54 -0700 (In reply to Darin Adler from comment #9) > And really surprised WPT doesn’t already have one! Yeah! 1692711 11 409929 rniwa 2020-09-28 16:43:47 -0700 Created attachment 409929 Adds a test 1692713 12 rniwa 2020-09-28 16:48:49 -0700 Committed r267719: <https://trac.webkit.org/changeset/267719> 348515 2018-08-30 11:18:04 -0700 2020-09-28 15:21:25 -0700 Document contains test case doc-contains-sd.js text/html 269 jridgewell dmFyIGRpdiA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2RpdicpOwp2YXIgc2QgPSBkaXYuYXR0 YWNoU2hhZG93KHsgbW9kZTogJ29wZW4nIH0pOwpzZC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdzcGFuJykpOwoKaWYgKGRvY3VtZW50LmNvbnRhaW5zKHNkLmZpcnN0Q2hpbGQp KSB7CiAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAnPGgxIHN0eWxlPSJjb2xvcjogcmVkIj5E b2MgY29udGFpbnMgbm9kZSBpbiBzaGFkb3cgdHJlZTwvaDE+JzsKfQo= 409929 2020-09-28 16:43:47 -0700 2020-09-28 16:45:51 -0700 Adds a test bug-189164-20200928164347.patch text/plain 3471 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2NzcxOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTI4ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERvY3VtZW50LnAuY29udGFpbnMgcmV0dXJucyB0 cnVlIGZvciBub2RlcyBpbiBzaGFkb3cgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIGFmdGVyIHIyNjcyMjAgaGFk IGZpeGVkIHRoaXMgYnVnLgorCisgICAgICAgICogZmFzdC9zaGFkb3ctZG9tL2RvY3VtZW50LWNv bnRhaW5zLXJldHVybnMtZmFsc2UtZm9yLW5vZGUtaW5zaWRlLXNoYWRvdy10cmVlLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9zaGFkb3ctZG9tL2RvY3VtZW50LWNvbnRhaW5z LXJldHVybnMtZmFsc2UtZm9yLW5vZGUtaW5zaWRlLXNoYWRvdy10cmVlLmh0bWw6IEFkZGVkLgor CiAyMDIwLTA5LTI4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgog CiAgICAgICAgIFtUZXh0dXJlTWFwcGVyXSBFbmFibGUgYSBkZXB0aCBidWZmZXIgZm9yIHByZXNl cnZlLTNkCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vZG9jdW1lbnQtY29udGFp bnMtcmV0dXJucy1mYWxzZS1mb3Itbm9kZS1pbnNpZGUtc2hhZG93LXRyZWUtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9kb2N1bWVudC1jb250 YWlucy1yZXR1cm5zLWZhbHNlLWZvci1ub2RlLWluc2lkZS1zaGFkb3ctdHJlZS1leHBlY3RlZC50 eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2RvY3VtZW50 LWNvbnRhaW5zLXJldHVybnMtZmFsc2UtZm9yLW5vZGUtaW5zaWRlLXNoYWRvdy10cmVlLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIxIEBACitUZXN0cyBmb3IgZG9jdW1l bnQuY29udGFpbnMuIEl0IHNob3VsZCByZXR1cm4gZmFsc2Ugb24gY29ubmVjdGVkIG5vZGVzIHdp dGhpbiBhIHNoYWRvdyByb290CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNT IHNoYWRvd0hvc3QuaXNDb25uZWN0ZWQgaXMgZmFsc2UKK1BBU1Mgc2hhZG93Um9vdC5pc0Nvbm5l Y3RlZCBpcyBmYWxzZQorUEFTUyBzaGFkb3dSb290Q2hpbGQuaXNDb25uZWN0ZWQgaXMgZmFsc2UK K1BBU1MgZG9jdW1lbnQuY29udGFpbnMoc2hhZG93SG9zdCkgaXMgZmFsc2UKK1BBU1MgZG9jdW1l bnQuY29udGFpbnMoc2hhZG93Um9vdCkgaXMgZmFsc2UKK1BBU1MgZG9jdW1lbnQuY29udGFpbnMo c2hhZG93Um9vdENoaWxkKSBpcyBmYWxzZQorUEFTUyBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHNoYWRvd0hvc3QpOyBzaGFkb3dIb3N0LmlzQ29ubmVjdGVkIGlzIHRydWUKK1BBU1Mgc2hhZG93 Um9vdC5pc0Nvbm5lY3RlZCBpcyB0cnVlCitQQVNTIHNoYWRvd1Jvb3RDaGlsZC5pc0Nvbm5lY3Rl ZCBpcyB0cnVlCitQQVNTIGRvY3VtZW50LmNvbnRhaW5zKHNoYWRvd0hvc3QpIGlzIHRydWUKK1BB U1MgZG9jdW1lbnQuY29udGFpbnMoc2hhZG93Um9vdCkgaXMgZmFsc2UKK1BBU1MgZG9jdW1lbnQu Y29udGFpbnMoc2hhZG93Um9vdENoaWxkKSBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc2hh ZG93LWRvbS9kb2N1bWVudC1jb250YWlucy1yZXR1cm5zLWZhbHNlLWZvci1ub2RlLWluc2lkZS1z aGFkb3ctdHJlZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRv bS9kb2N1bWVudC1jb250YWlucy1yZXR1cm5zLWZhbHNlLWZvci1ub2RlLWluc2lkZS1zaGFkb3ct dHJlZS5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9k b2N1bWVudC1jb250YWlucy1yZXR1cm5zLWZhbHNlLWZvci1ub2RlLWluc2lkZS1zaGFkb3ctdHJl ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgor PGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbignVGVzdHMgZm9yIGRvY3VtZW50LmNv bnRhaW5zLiBJdCBzaG91bGQgcmV0dXJuIGZhbHNlIG9uIGNvbm5lY3RlZCBub2RlcyB3aXRoaW4g YSBzaGFkb3cgcm9vdCcpOworCitjb25zdCBzaGFkb3dIb3N0ID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiZGl2Iik7Citjb25zdCBzaGFkb3dSb290ID0gc2hhZG93SG9zdC5hdHRhY2hTaGFkb3co e21vZGU6ICdjbG9zZWQnfSk7Citjb25zdCBzaGFkb3dSb290Q2hpbGQgPSBzaGFkb3dSb290LmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpKTsKKworc2hvdWxkQmVGYWxz ZSgnc2hhZG93SG9zdC5pc0Nvbm5lY3RlZCcpOworc2hvdWxkQmVGYWxzZSgnc2hhZG93Um9vdC5p c0Nvbm5lY3RlZCcpOworc2hvdWxkQmVGYWxzZSgnc2hhZG93Um9vdENoaWxkLmlzQ29ubmVjdGVk Jyk7CitzaG91bGRCZUZhbHNlKCdkb2N1bWVudC5jb250YWlucyhzaGFkb3dIb3N0KScpOworc2hv dWxkQmVGYWxzZSgnZG9jdW1lbnQuY29udGFpbnMoc2hhZG93Um9vdCknKTsKK3Nob3VsZEJlRmFs c2UoJ2RvY3VtZW50LmNvbnRhaW5zKHNoYWRvd1Jvb3RDaGlsZCknKTsKKworc2hvdWxkQmVUcnVl KCdkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHNoYWRvd0hvc3QpOyBzaGFkb3dIb3N0LmlzQ29u bmVjdGVkJyk7CitzaG91bGRCZVRydWUoJ3NoYWRvd1Jvb3QuaXNDb25uZWN0ZWQnKTsKK3Nob3Vs ZEJlVHJ1ZSgnc2hhZG93Um9vdENoaWxkLmlzQ29ubmVjdGVkJyk7CitzaG91bGRCZVRydWUoJ2Rv Y3VtZW50LmNvbnRhaW5zKHNoYWRvd0hvc3QpJyk7CitzaG91bGRCZUZhbHNlKCdkb2N1bWVudC5j b250YWlucyhzaGFkb3dSb290KScpOworc2hvdWxkQmVGYWxzZSgnZG9jdW1lbnQuY29udGFpbnMo c2hhZG93Um9vdENoaWxkKScpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K