189089 2018-08-29 10:29:08 -0700 Remove PseudoElementUserAgentCustom. 2018-09-04 18:24:18 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emilio emilio commit-queue darin dbates koivisto mmaxfield rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1454829 0 emilio 2018-08-29 10:29:08 -0700 Looks like it was added in bug 100826, but seems unused now, I couldn't find anything that set the pseudo attribute to something that wasn't -webkit- stuff, so this doesn't match anything. I hope we can remove it without issues. 1454840 1 emilio 2018-08-29 10:53:37 -0700 Test at https://github.com/web-platform-tests/wpt/pull/12743. 1454849 2 348416 emilio 2018-08-29 11:08:53 -0700 Created attachment 348416 Patch 1456007 3 darin 2018-09-01 22:04:04 -0700 Ryosuke, would you review this patch? 1456532 4 mmaxfield 2018-09-04 16:59:18 -0700 Looks good to me, but I'll let Ryosuke give the final review. 1456535 5 348416 rniwa 2018-09-04 17:02:29 -0700 Comment on attachment 348416 Patch Sure, this looks unused now. ::part(~) would be a different implementation anyway. 1456540 6 rniwa 2018-09-04 17:06:05 -0700 Note that this is a potentially Web incompatible change if some websites had been relying on these pseudo element names being valid in some of their rules. But the chance of it happening is low enough that I'm comfortable making this change given this isn't a feature ever exposed to the Web. 1456578 7 emilio 2018-09-04 18:16:35 -0700 (In reply to Ryosuke Niwa from comment #6) > Note that this is a potentially Web incompatible change if some websites had > been relying on these pseudo element names being valid in some of their > rules. But the chance of it happening is low enough that I'm comfortable > making this change given this isn't a feature ever exposed to the Web. Right, that's why I wanted to remove it if possible sooner rather than later. Thanks a lot for the review! 1456580 8 348416 commit-queue 2018-09-04 18:18:38 -0700 Comment on attachment 348416 Patch Rejecting attachment 348416 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 348416, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=348416&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189089&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 348416 from bug 189089. Fetching: https://bugs.webkit.org/attachment.cgi?id=348416 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej patching file Source/WebCore/css/CSSSelector.cpp patching file Source/WebCore/css/CSSSelector.h patching file Source/WebCore/css/RuleSet.cpp patching file Source/WebCore/css/parser/CSSParserSelector.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9096418 1456584 9 emilio 2018-09-04 18:23:10 -0700 Committed r235652: <https://trac.webkit.org/changeset/235652> 1456587 10 webkit-bug-importer 2018-09-04 18:24:18 -0700 <rdar://problem/44121968> 348416 2018-08-29 11:08:53 -0700 2018-09-04 18:18:38 -0700 Patch bug-189089-20180829200851.patch text/plain 6355 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE3ZGM3NDBmNWE3OWJm MjVlMzcxMWRiZWNjM2QwZTcwYjIxZjFlYS4uODU4OWVhZTQxYmViM2M0MzU1YjhlYzYyNzk0MTJk NmNkODkwNWYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw4ICsxLDI3IEBACisyMDE4LTA4LTI5ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgorCisgICAgICAgIFJlbW92ZSBQ c2V1ZG9FbGVtZW50VXNlckFnZW50Q3VzdG9tLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MDg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgYXQgaHR0cHM6Ly9naXRodWIuY29tL3dlYi1wbGF0 Zm9ybS10ZXN0cy93cHQvcHVsbC8xMjc0My4KKworICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxlY3Rvcjo6cHNldWRvSWQpOgorICAgICAgICAo V2ViQ29yZTo6Q1NTU2VsZWN0b3I6OnBhcnNlUHNldWRvRWxlbWVudFR5cGUpOgorICAgICAgICAq IGNzcy9DU1NTZWxlY3Rvci5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OmlzQ3Vz dG9tUHNldWRvRWxlbWVudCBjb25zdCk6CisgICAgICAgICogY3NzL1J1bGVTZXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UnVsZVNldDo6YWRkUnVsZSk6CisgICAgICAgICogY3NzL3BhcnNlci9D U1NQYXJzZXJTZWxlY3Rvci5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyU2VsZWN0b3I6 Om5lZWRzSW1wbGljaXRTaGFkb3dDb21iaW5hdG9yRm9yTWF0Y2hpbmcgY29uc3QpOgorCiAyMDE4 LTA4LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVt b3ZlIGVtcHR5IGRpcmVjdG9yaWVzIGZyb20gZnJvbSBzdm4ud2Via2l0Lm9yZyByZXBvc2l0b3J5 CiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODkwODE+CiAKICAgICAgICAgKiBNb2R1 bGVzL3Byb3hpbWl0eTogUmVtb3ZlZC4KIAogMjAxOC0wOC0yOCAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAKaW5kZXggYjJmZGQxYmQ1 ZWZlOWVhYWQ0ZWNjMGJmZTlmMzUyNjhmM2Y4YjdiMi4uYjM0NzczNTcxMmVhMjZiODBhODBmYmMy M2FhY2JkOThmNzg3OTg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVj dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCkBAIC0yOTQs MTcgKzI5NCwxNiBAQCBQc2V1ZG9JZCBDU1NTZWxlY3Rvcjo6cHNldWRvSWQoUHNldWRvRWxlbWVu dFR5cGUgdHlwZSkKICAgICAgICAgcmV0dXJuIFBzZXVkb0lkOjpTY3JvbGxiYXJUcmFja1BpZWNl OwogICAgIGNhc2UgUHNldWRvRWxlbWVudFJlc2l6ZXI6CiAgICAgICAgIHJldHVybiBQc2V1ZG9J ZDo6UmVzaXplcjsKICNpZiBFTkFCTEUoVklERU9fVFJBQ0spCiAgICAgY2FzZSBQc2V1ZG9FbGVt ZW50Q3VlOgogI2VuZGlmCiAgICAgY2FzZSBQc2V1ZG9FbGVtZW50U2xvdHRlZDoKICAgICBjYXNl IFBzZXVkb0VsZW1lbnRVbmtub3duOgotICAgIGNhc2UgUHNldWRvRWxlbWVudFVzZXJBZ2VudEN1 c3RvbToKICAgICBjYXNlIFBzZXVkb0VsZW1lbnRXZWJLaXRDdXN0b206CiAgICAgY2FzZSBQc2V1 ZG9FbGVtZW50V2ViS2l0Q3VzdG9tTGVnYWN5UHJlZml4ZWQ6CiAgICAgICAgIHJldHVybiBQc2V1 ZG9JZDo6Tm9uZTsKICAgICB9CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1 cm4gUHNldWRvSWQ6Ok5vbmU7CiB9CkBAIC0zMTMsMTkgKzMxMiwxNiBAQCBDU1NTZWxlY3Rvcjo6 UHNldWRvRWxlbWVudFR5cGUgQ1NTU2VsZWN0b3I6OnBhcnNlUHNldWRvRWxlbWVudFR5cGUoY29u c3QgU3RyaW5nJgogewogICAgIGlmIChuYW1lLmlzTnVsbCgpKQogICAgICAgICByZXR1cm4gUHNl dWRvRWxlbWVudFVua25vd247CiAKICAgICBQc2V1ZG9FbGVtZW50VHlwZSB0eXBlID0gcGFyc2VQ c2V1ZG9FbGVtZW50U3RyaW5nKCpuYW1lLmltcGwoKSk7CiAgICAgaWYgKHR5cGUgPT0gUHNldWRv RWxlbWVudFVua25vd24pIHsKICAgICAgICAgaWYgKG5hbWUuc3RhcnRzV2l0aCgiLXdlYmtpdC0i KSkKICAgICAgICAgICAgIHR5cGUgPSBQc2V1ZG9FbGVtZW50V2ViS2l0Q3VzdG9tOwotCi0gICAg ICAgIGlmIChuYW1lLnN0YXJ0c1dpdGgoIngtIikpCi0gICAgICAgICAgICB0eXBlID0gUHNldWRv RWxlbWVudFVzZXJBZ2VudEN1c3RvbTsKICAgICB9CiAgICAgcmV0dXJuIHR5cGU7CiB9CiAKIAog Ym9vbCBDU1NTZWxlY3Rvcjo6b3BlcmF0b3I9PShjb25zdCBDU1NTZWxlY3RvciYgb3RoZXIpIGNv bnN0CiB7CiAgICAgY29uc3QgQ1NTU2VsZWN0b3IqIHNlbDEgPSB0aGlzOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT U2VsZWN0b3IuaAppbmRleCBhNmExYmQ5NmQ2MzVmNDUwYzJmNGYzNzZiYmZhYmFhOGNiNGFlM2My Li4wZWM1ODcwYWNlNGFiN2JiYzk3ZWQ5ZjViZmJiYjZjMjUzNjM2MDA5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTU2VsZWN0b3IuaApAQCAtMTc4LDE3ICsxNzgsMTYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICAgICAgUHNldWRvRWxlbWVudFNjcm9sbGJhciwKICAgICAgICAgICAgIFBzZXVkb0Vs ZW1lbnRTY3JvbGxiYXJCdXR0b24sCiAgICAgICAgICAgICBQc2V1ZG9FbGVtZW50U2Nyb2xsYmFy Q29ybmVyLAogICAgICAgICAgICAgUHNldWRvRWxlbWVudFNjcm9sbGJhclRodW1iLAogICAgICAg ICAgICAgUHNldWRvRWxlbWVudFNjcm9sbGJhclRyYWNrLAogICAgICAgICAgICAgUHNldWRvRWxl bWVudFNjcm9sbGJhclRyYWNrUGllY2UsCiAgICAgICAgICAgICBQc2V1ZG9FbGVtZW50U2VsZWN0 aW9uLAogICAgICAgICAgICAgUHNldWRvRWxlbWVudFNsb3R0ZWQsCi0gICAgICAgICAgICBQc2V1 ZG9FbGVtZW50VXNlckFnZW50Q3VzdG9tLAogICAgICAgICAgICAgUHNldWRvRWxlbWVudFdlYktp dEN1c3RvbSwKIAogICAgICAgICAgICAgLy8gV2ViS2l0Q3VzdG9tIHRoYXQgYXBwZWFyZWQgaW4g YW4gb2xkIHByZWZpeGVkIGZvcm0KICAgICAgICAgICAgIC8vIGFuZCBuZWVkIHNwZWNpYWwgaGFu ZGxpbmcuCiAgICAgICAgICAgICBQc2V1ZG9FbGVtZW50V2ViS2l0Q3VzdG9tTGVnYWN5UHJlZml4 ZWQsCiAgICAgICAgIH07CiAKICAgICAgICAgZW51bSBQYWdlUHNldWRvQ2xhc3NUeXBlIHsKQEAg LTQwNiwxOCArNDA1LDE3IEBAIGlubGluZSBib29sIENTU1NlbGVjdG9yOjptYXRjaGVzUHNldWRv RWxlbWVudCgpIGNvbnN0CiBpbmxpbmUgYm9vbCBDU1NTZWxlY3Rvcjo6aXNVbmtub3duUHNldWRv RWxlbWVudCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1hdGNoKCkgPT0gUHNldWRvRWxlbWVudCAm JiBwc2V1ZG9FbGVtZW50VHlwZSgpID09IFBzZXVkb0VsZW1lbnRVbmtub3duOwogfQogCiBpbmxp bmUgYm9vbCBDU1NTZWxlY3Rvcjo6aXNDdXN0b21Qc2V1ZG9FbGVtZW50KCkgY29uc3QKIHsKICAg ICByZXR1cm4gbWF0Y2goKSA9PSBQc2V1ZG9FbGVtZW50Ci0gICAgICAgICYmIChwc2V1ZG9FbGVt ZW50VHlwZSgpID09IFBzZXVkb0VsZW1lbnRVc2VyQWdlbnRDdXN0b20KLSAgICAgICAgICAgIHx8 IHBzZXVkb0VsZW1lbnRUeXBlKCkgPT0gUHNldWRvRWxlbWVudFdlYktpdEN1c3RvbQorICAgICAg ICAmJiAocHNldWRvRWxlbWVudFR5cGUoKSA9PSBQc2V1ZG9FbGVtZW50V2ViS2l0Q3VzdG9tCiAg ICAgICAgICAgICB8fCBwc2V1ZG9FbGVtZW50VHlwZSgpID09IFBzZXVkb0VsZW1lbnRXZWJLaXRD dXN0b21MZWdhY3lQcmVmaXhlZCk7CiB9CiAKIGlubGluZSBib29sIENTU1NlbGVjdG9yOjppc1dl YktpdEN1c3RvbVBzZXVkb0VsZW1lbnQoKSBjb25zdAogewogICAgIHJldHVybiBwc2V1ZG9FbGVt ZW50VHlwZSgpID09IFBzZXVkb0VsZW1lbnRXZWJLaXRDdXN0b20gfHwgcHNldWRvRWxlbWVudFR5 cGUoKSA9PSBQc2V1ZG9FbGVtZW50V2ViS2l0Q3VzdG9tTGVnYWN5UHJlZml4ZWQ7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxlU2V0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9SdWxlU2V0LmNwcAppbmRleCBmNGI1YmZmM2MyYmRkODI1Nzc1ZDRjNzYzZmRjY2YwNzAy MThkYjI0Li4yZTExYWUxZjlhYjVkMmYxZTg5YmFjMDk1ZDY5Y2FjMDUxODU1YzAwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL1J1bGVTZXQuY3BwCkBAIC0yMzcsMTcgKzIzNywxNiBAQCB2b2lkIFJ1bGVTZXQ6OmFkZFJ1 bGUoU3R5bGVSdWxlKiBydWxlLCB1bnNpZ25lZCBzZWxlY3RvckluZGV4LCB1bnNpZ25lZCBzZWxl Y3RvcgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBDU1NTZWxl Y3Rvcjo6VGFnOgogICAgICAgICAgICAgaWYgKHNlbGVjdG9yLT50YWdRTmFtZSgpLmxvY2FsTmFt ZSgpICE9IHN0YXJBdG9tKCkpCiAgICAgICAgICAgICAgICAgdGFnU2VsZWN0b3IgPSBzZWxlY3Rv cjsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9F bGVtZW50OgogICAgICAgICAgICAgc3dpdGNoIChzZWxlY3Rvci0+cHNldWRvRWxlbWVudFR5cGUo KSkgewotICAgICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvRWxlbWVudFVzZXJBZ2Vu dEN1c3RvbToKICAgICAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0VsZW1lbnRXZWJL aXRDdXN0b206CiAgICAgICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVtZW50V2Vi S2l0Q3VzdG9tTGVnYWN5UHJlZml4ZWQ6CiAgICAgICAgICAgICAgICAgY3VzdG9tUHNldWRvRWxl bWVudFNlbGVjdG9yID0gc2VsZWN0b3I7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVtZW50U2xvdHRlZDoKICAgICAgICAgICAg ICAgICBzbG90dGVkUHNldWRvRWxlbWVudFNlbGVjdG9yID0gc2VsZWN0b3I7CiAgICAgICAgICAg ICAgICAgYnJlYWs7CiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJTZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUv Y3NzL3BhcnNlci9DU1NQYXJzZXJTZWxlY3Rvci5oCmluZGV4IDQ5OGJlYTA2MjJmYzNlZmIyNjYz ODE0YmYzYjU5NDE4NjAwZjFhMGIuLjg2MGZkYTFjMTExMmFiOTlhMzI4M2UzYTIzYzY0MTdjZWE1 NzI3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUGFyc2VyU2Vs ZWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlclNlbGVjdG9y LmgKQEAgLTExMiwxNiArMTEyLDE1IEBAIGlubGluZSBib29sIENTU1BhcnNlclNlbGVjdG9yOjpo YXNTaGFkb3dEZXNjZW5kYW50KCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9zZWxlY3Rvci0+cmVs YXRpb24oKSA9PSBDU1NTZWxlY3Rvcjo6U2hhZG93RGVzY2VuZGFudDsKIH0KIAogaW5saW5lIGJv b2wgQ1NTUGFyc2VyU2VsZWN0b3I6Om5lZWRzSW1wbGljaXRTaGFkb3dDb21iaW5hdG9yRm9yTWF0 Y2hpbmcoKSBjb25zdAogewogICAgIHJldHVybiBtYXRjaCgpID09IENTU1NlbGVjdG9yOjpQc2V1 ZG9FbGVtZW50CiAgICAgICAgICYmIChwc2V1ZG9FbGVtZW50VHlwZSgpID09IENTU1NlbGVjdG9y OjpQc2V1ZG9FbGVtZW50V2ViS2l0Q3VzdG9tCi0gICAgICAgICAgICB8fCBwc2V1ZG9FbGVtZW50 VHlwZSgpID09IENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVtZW50VXNlckFnZW50Q3VzdG9tCiAjaWYg RU5BQkxFKFZJREVPX1RSQUNLKQogICAgICAgICAgICAgfHwgcHNldWRvRWxlbWVudFR5cGUoKSA9 PSBDU1NTZWxlY3Rvcjo6UHNldWRvRWxlbWVudEN1ZQogI2VuZGlmCiAgICAgICAgICAgICB8fCBw c2V1ZG9FbGVtZW50VHlwZSgpID09IENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVtZW50V2ViS2l0Q3Vz dG9tTGVnYWN5UHJlZml4ZWQpOwogfQogCiB9Cg==