189083 2018-08-29 09:42:13 -0700 [WHLSL] Ensure that isLValue is copied by the rewriter 2018-10-13 15:06:15 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176199 187735 1 tdenney tdenney commit-queue dino mmaxfield webkit-bug-importer oldest_to_newest 1454796 0 tdenney 2018-08-29 09:42:13 -0700 [WHLSL] Ensure that isLValue is copied by the rewriter 1454798 1 348403 tdenney 2018-08-29 09:43:35 -0700 Created attachment 348403 Patch 1454804 2 348405 tdenney 2018-08-29 09:59:20 -0700 Created attachment 348405 Patch 1454807 3 348405 mmaxfield 2018-08-29 10:02:04 -0700 Comment on attachment 348405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348405&action=review > Tools/WebGPUShadingLanguageRI/Test.js:275 > + function ternaryExpressionIsLValue(node) > + { > + let isLValue; > + class TernaryExpressionVisitor extends Visitor { > + visitTernaryExpression(node) > + { > + isLValue = node.isLValue; > + } > + } > + node.visit(new TernaryExpressionVisitor()); > + return isLValue; > + } This is an unfortunate test, because it doesn't describe anything user-visible. Are you sure there's no way this bug is visible without using compiler internals? 1454809 4 348405 tdenney 2018-08-29 10:05:44 -0700 Comment on attachment 348405 Patch The last place that isLValue gets read in the interpreter is inside Checker, however after that has completed the entire program is rewritten using Inliner, which is a subclass of Rewriter. 1454854 5 348405 commit-queue 2018-08-29 11:24:54 -0700 Comment on attachment 348405 Patch Clearing flags on attachment: 348405 Committed r235470: <https://trac.webkit.org/changeset/235470> 1454855 6 commit-queue 2018-08-29 11:24:55 -0700 All reviewed patches have been landed. Closing bug. 1454856 7 webkit-bug-importer 2018-08-29 11:25:38 -0700 <rdar://problem/43850362> 1468873 8 mmaxfield 2018-10-13 15:06:15 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/73 348403 2018-08-29 09:43:35 -0700 2018-08-29 09:59:18 -0700 Patch bug-189083-20180829094334.patch text/plain 1580 tdenney U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM3NDZjZmExY2FlYWYwNWI0YWE5NmMzZDU1NjZhNzFm OGJlNjM4My4uZDliMjg2ODYzZmJmODYzMTI1MmQ3MzllM2M1MGMwMjgzZTJjZGI4NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA4LTI5ICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CisKKyAg ICAgICAgW1dITFNMXSBFbnN1cmUgdGhhdCBpc0xWYWx1ZSBpcyBjb3BpZWQgYnkgdGhlIHJld3Jp dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkw ODMKKworICAgICAgICBUaGUgdmFsdWUgb2YgaXNMVmFsdWUgd2FzIG5vdCBwcm9wYWdhdGVkIHdo ZW4gbmV3IFRlcm5hcnlFeHByZXNzaW9ucyBhcmUKKyAgICAgICAgY3JlYXRlZCBpbiBSZXdyaXRl ci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzOgorICAgICAgICAoUmV3cml0ZXIucHJv dG90eXBlLnZpc2l0VGVybmFyeUV4cHJlc3Npb24pOgorCiAyMDE4LTA4LTI5ICBEYXZpZCBLaWx6 ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGVtcHR5IGRpcmVjdG9y aWVzIGZyb20gZnJvbSBzdm4ud2Via2l0Lm9yZyByZXBvc2l0b3J5CmRpZmYgLS1naXQgYS9Ub29s cy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9SZXdyaXRlci5qcyBiL1Rvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCmluZGV4IDk0ZDNhNzYyZTM4ZmI5MjFjNTg0Y2JhZmZm MWY1OTQ3OGViYjc5MWQuLjNjOTUwMjBhYTRkNmM0YmIwOTM1NzVhYjQwOTY4YTVjYjU0ZWI3NTgg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCisr KyBiL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCkBAIC0xNjcsNyAr MTY3LDkgQEAgY2xhc3MgUmV3cml0ZXIgewogCiAgICAgdmlzaXRUZXJuYXJ5RXhwcmVzc2lvbihu b2RlKQogICAgIHsKLSAgICAgICAgcmV0dXJuIG5ldyBUZXJuYXJ5RXhwcmVzc2lvbihub2RlLm9y aWdpbiwgbm9kZS5wcmVkaWNhdGUudmlzaXQodGhpcyksIG5vZGUuYm9keUV4cHJlc3Npb24udmlz aXQodGhpcyksIG5vZGUuZWxzZUV4cHJlc3Npb24udmlzaXQodGhpcykpOworICAgICAgICBsZXQg cmVzdWx0ID0gbmV3IFRlcm5hcnlFeHByZXNzaW9uKG5vZGUub3JpZ2luLCBub2RlLnByZWRpY2F0 ZS52aXNpdCh0aGlzKSwgbm9kZS5ib2R5RXhwcmVzc2lvbi52aXNpdCh0aGlzKSwgbm9kZS5lbHNl RXhwcmVzc2lvbi52aXNpdCh0aGlzKSk7CisgICAgICAgIHJlc3VsdC5pc0xWYWx1ZSA9IG5vZGUu aXNMVmFsdWU7CisgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogICAgIAogICAgIF9oYW5k bGVQcm9wZXJ0eUFjY2Vzc0V4cHJlc3Npb24ocmVzdWx0LCBub2RlKQo= 348405 2018-08-29 09:59:20 -0700 2018-08-29 11:24:54 -0700 Patch bug-189083-20180829095919.patch text/plain 3028 tdenney U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM3NDZjZmExY2FlYWYwNWI0YWE5NmMzZDU1NjZhNzFm OGJlNjM4My4uNGQxMjI3NmY4N2UwNDIyMDE5ZDQxNDllMTc4NTBhZjA2MTQ1ZWQxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTA4LTI5ICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CisKKyAg ICAgICAgW1dITFNMXSBFbnN1cmUgdGhhdCBpc0xWYWx1ZSBpcyBjb3BpZWQgYnkgdGhlIHJld3Jp dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkw ODMKKworICAgICAgICBUaGUgdmFsdWUgb2YgaXNMVmFsdWUgd2FzIG5vdCBwcm9wYWdhdGVkIHdo ZW4gbmV3IFRlcm5hcnlFeHByZXNzaW9ucyBhcmUKKyAgICAgICAgY3JlYXRlZCBpbiBSZXdyaXRl ci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzOgorICAgICAgICAoUmV3cml0ZXIucHJv dG90eXBlLnZpc2l0VGVybmFyeUV4cHJlc3Npb24pOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Rlc3QuanM6IEFkZCBuZXcgdGVzdCB0byB2ZXJpZnkgdGhlIHZhbHVlIGlzCisg ICAgICAgIHByb3BhZ2F0ZWQuCisKIDIwMTgtMDgtMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZW1wdHkgZGlyZWN0b3JpZXMgZnJvbSBmcm9t IHN2bi53ZWJraXQub3JnIHJlcG9zaXRvcnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzIGIvVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkv UmV3cml0ZXIuanMKaW5kZXggOTRkM2E3NjJlMzhmYjkyMWM1ODRjYmFmZmYxZjU5NDc4ZWJiNzkx ZC4uM2M5NTAyMGFhNGQ2YzRiYjA5MzU3NWFiNDA5NjhhNWNiNTRlYjc1OCAxMDA2NDQKLS0tIGEv VG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUmV3cml0ZXIuanMKKysrIGIvVG9vbHMvV2Vi R1BVU2hhZGluZ0xhbmd1YWdlUkkvUmV3cml0ZXIuanMKQEAgLTE2Nyw3ICsxNjcsOSBAQCBjbGFz cyBSZXdyaXRlciB7CiAKICAgICB2aXNpdFRlcm5hcnlFeHByZXNzaW9uKG5vZGUpCiAgICAgewot ICAgICAgICByZXR1cm4gbmV3IFRlcm5hcnlFeHByZXNzaW9uKG5vZGUub3JpZ2luLCBub2RlLnBy ZWRpY2F0ZS52aXNpdCh0aGlzKSwgbm9kZS5ib2R5RXhwcmVzc2lvbi52aXNpdCh0aGlzKSwgbm9k ZS5lbHNlRXhwcmVzc2lvbi52aXNpdCh0aGlzKSk7CisgICAgICAgIGxldCByZXN1bHQgPSBuZXcg VGVybmFyeUV4cHJlc3Npb24obm9kZS5vcmlnaW4sIG5vZGUucHJlZGljYXRlLnZpc2l0KHRoaXMp LCBub2RlLmJvZHlFeHByZXNzaW9uLnZpc2l0KHRoaXMpLCBub2RlLmVsc2VFeHByZXNzaW9uLnZp c2l0KHRoaXMpKTsKKyAgICAgICAgcmVzdWx0LmlzTFZhbHVlID0gbm9kZS5pc0xWYWx1ZTsKKyAg ICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAgICAgCiAgICAgX2hhbmRsZVByb3BlcnR5QWNj ZXNzRXhwcmVzc2lvbihyZXN1bHQsIG5vZGUpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJHUFVTaGFk aW5nTGFuZ3VhZ2VSSS9UZXN0LmpzIGIvVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVz dC5qcwppbmRleCA0ZjM5NWE5NGNjNzI4M2RkNjJhMDA0ZmExZDRjM2I5ZmFhZDMwYTYxLi5mZGMx MTczMDg1NjdlNTUyODkwNTQ2YzliODE5OWZiNTc2N2QzMzY1IDEwMDY0NAotLS0gYS9Ub29scy9X ZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCisrKyBiL1Rvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Rlc3QuanMKQEAgLTI2MCw2ICsyNjAsMjkgQEAgdGVzdHMudGVybmFyeUV4cHJl c3Npb24gPSBmdW5jdGlvbigpIHsKICAgICAgICAgKGUpID0+IGUgaW5zdGFuY2VvZiBXVHlwZUVy cm9yKTsKIH0KIAordGVzdHMudGVybmFyeUV4cHJlc3Npb25Jc0xWYWx1ZSA9IGZ1bmN0aW9uKCkg eworICAgIGZ1bmN0aW9uIHRlcm5hcnlFeHByZXNzaW9uSXNMVmFsdWUobm9kZSkKKyAgICB7Cisg ICAgICAgIGxldCBpc0xWYWx1ZTsKKyAgICAgICAgY2xhc3MgVGVybmFyeUV4cHJlc3Npb25WaXNp dG9yIGV4dGVuZHMgVmlzaXRvciB7CisgICAgICAgICAgICB2aXNpdFRlcm5hcnlFeHByZXNzaW9u KG5vZGUpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgaXNMVmFsdWUgPSBub2RlLmlz TFZhbHVlOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIG5vZGUudmlzaXQobmV3 IFRlcm5hcnlFeHByZXNzaW9uVmlzaXRvcigpKTsKKyAgICAgICAgcmV0dXJuIGlzTFZhbHVlOwor ICAgIH0KKworICAgIGxldCBwcm9ncmFtID0gZG9QcmVwKGBpbnQgZm9vKCkgeyByZXR1cm4gMCA8 IDEgPyAwIDogMTsgfWApOworICAgIGlmICh0ZXJuYXJ5RXhwcmVzc2lvbklzTFZhbHVlKHByb2dy YW0pKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoYHItdmFsdWUgdGVybmFyeSBleHByZXNzaW9u IGluY29ycmVjdGx5IHBhcnNlZCBhcyBsLXZhbHVlYCk7CisKKyAgICBwcm9ncmFtID0gZG9QcmVw KGB2b2lkIGZvbygpIHsgaW50IHg7IGludCB5OyAoMCA8IDEgPyB4IDogeSkgPSAxOyB9YCk7Cisg ICAgaWYgKCF0ZXJuYXJ5RXhwcmVzc2lvbklzTFZhbHVlKHByb2dyYW0pKQorICAgICAgICB0aHJv dyBuZXcgRXJyb3IoYGwtdmFsdWUgdGVybmFyeSBleHByZXNzaW9uIGluY29ycmVjdGx5IHBhcnNl ZCBhcyByLXZhbHVlYCk7Cit9CisKIHRlc3RzLmxpdGVyYWxCb29sID0gZnVuY3Rpb24oKSB7CiAg ICAgbGV0IHByb2dyYW0gPSBkb1ByZXAoImJvb2wgZm9vKCkgeyByZXR1cm4gdHJ1ZTsgfSIpOwog ICAgIGNoZWNrQm9vbChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFtdKSwg dHJ1ZSk7Cg==