188983 2018-08-27 07:38:28 -0700 [GTK][JSC] Add warn_unused_result attribute to some APIs 2018-09-03 00:18:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pgriffis webkit-unassigned bugs-noreply cgarcia commit-queue ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1453876 0 pgriffis 2018-08-27 07:38:28 -0700 [GTK][JSC] Add warn_unused_result attribute to some APIs 1453877 1 348143 pgriffis 2018-08-27 07:38:56 -0700 Created attachment 348143 Patch 1453900 2 mcatanzaro 2018-08-27 09:12:50 -0700 Normally I would leave this to Carlos Garcia, but he is quite busy this week and it's clearly a good improvement. 1453901 3 mcatanzaro 2018-08-27 09:13:21 -0700 P.S. I assume this doesn't add build warnings in WebKit's own build! 1453903 4 mcatanzaro 2018-08-27 09:15:46 -0700 Rationale: programmers intuitively expect that it is safe to ignore the return value of a function call if the result is unneeded or void. But, as Patrick discovered, this leads to memory leaks if you think you can get away with that when using jsc_value_object_invoke_method() or jsc_value_function_call(). 1453922 5 348143 commit-queue 2018-08-27 09:39:19 -0700 Comment on attachment 348143 Patch Clearing flags on attachment: 348143 Committed r235373: <https://trac.webkit.org/changeset/235373> 1453923 6 commit-queue 2018-08-27 09:39:20 -0700 All reviewed patches have been landed. Closing bug. 1453925 7 webkit-bug-importer 2018-08-27 09:40:22 -0700 <rdar://problem/43756976> 1456123 8 cgarcia 2018-09-03 00:18:07 -0700 Thanks! There are more cases like evaluate functions. 348143 2018-08-27 07:38:56 -0700 2018-08-27 09:39:19 -0700 Patch bug-188983-20180827103855.patch text/plain 2741 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDJhYzBiZmEwNjcxODA3MDdlMGE1YmI1YWFlNzRlZjJlYjNhZTYwLi44YjhhNTJmNGVkNDQ4Njgw MzJhYTIyZWQ5OGZkODgzZTk3ZGQzYzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0wOC0yNyAgUGF0cmljayBHcmlmZmlzICA8cGdyaWZmaXNAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtKU0NdIEFkZCB3YXJuX3VudXNlZF9yZXN1bHQgYXR0cmli dXRlIHRvIHNvbWUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg4OTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBBUEkvZ2xpYi9KU0NWYWx1ZS5oOgorCiAyMDE4LTA4LTI0ICBZdXN1a2UgU3V6 dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pTQ10gQXJyYXku cHJvdG90eXBlLnJldmVyc2UgbW9kaWZpZXMgSlNJbW11dGFibGVCdXR0ZXJmbHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NWYWx1ZS5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS9nbGliL0pTQ1ZhbHVlLmgKaW5kZXggZWI1ZjVmZTEzZWI2Zjk2MmIy MjExNzgwYzcyN2IxN2M1ZWFhMWFmNS4uZmFlNjI2N2E2ZWU0Njk2MDEyNGI4YzM5OGJlN2M0ZmU4 MDNjOWJhNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9nbGliL0pTQ1Zh bHVlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9nbGliL0pTQ1ZhbHVlLmgKQEAg LTE4MiwxMyArMTgyLDEzIEBAIEpTQ19BUEkgSlNDVmFsdWUgKgoganNjX3ZhbHVlX29iamVjdF9p bnZva2VfbWV0aG9kICAgICAgICAgICAgKEpTQ1ZhbHVlICAgICAgICAgICAgICp2YWx1ZSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICAgICAg ICAgICAqbmFtZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBH VHlwZSAgICAgICAgICAgICAgICAgZmlyc3RfcGFyYW1ldGVyX3R5cGUsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uKTsKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAuLi4pIEdfR05VQ19XQVJOX1VOVVNFRF9SRVNVTFQ7CiAK IEpTQ19BUEkgSlNDVmFsdWUgKgoganNjX3ZhbHVlX29iamVjdF9pbnZva2VfbWV0aG9kdiAgICAg ICAgICAgKEpTQ1ZhbHVlICAgICAgICAgICAgICp2YWx1ZSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICAgICAgICAgICAqbmFtZSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBndWludCAgICAgICAgICAgICAg ICAgbl9wYXJhbWV0ZXJzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEpTQ1ZhbHVlICAgICAgICAgICAgKipwYXJhbWV0ZXJzKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBKU0NWYWx1ZSAgICAgICAgICAgICoqcGFyYW1ldGVy cykgR19HTlVDX1dBUk5fVU5VU0VEX1JFU1VMVDsKIAogSlNDX0FQSSB2b2lkCiBqc2NfdmFsdWVf b2JqZWN0X2RlZmluZV9wcm9wZXJ0eV9kYXRhICAgICAoSlNDVmFsdWUgICAgICAgICAgICAgKnZh bHVlLApAQCAtMjQwLDEyICsyNDAsMTIgQEAganNjX3ZhbHVlX2lzX2Z1bmN0aW9uICAgICAgICAg ICAgICAgICAgICAgKEpTQ1ZhbHVlICAgICAgICAgICAgICp2YWx1ZSk7CiBKU0NfQVBJIEpTQ1Zh bHVlICoKIGpzY192YWx1ZV9mdW5jdGlvbl9jYWxsICAgICAgICAgICAgICAgICAgIChKU0NWYWx1 ZSAgICAgICAgICAgICAqdmFsdWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgR1R5cGUgICAgICAgICAgICAgICAgIGZpcnN0X3BhcmFtZXRlcl90eXBlLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC4uLik7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uKSBHX0dOVUNfV0FSTl9VTlVTRURf UkVTVUxUOwogCiBKU0NfQVBJIEpTQ1ZhbHVlICoKIGpzY192YWx1ZV9mdW5jdGlvbl9jYWxsdiAg ICAgICAgICAgICAgICAgIChKU0NWYWx1ZSAgICAgICAgICAgICAqdmFsdWUsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3VpbnQgICAgICAgICAgICAgICAgIG5f cGFyYW1ldGVycywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBK U0NWYWx1ZSAgICAgICAgICAgICoqcGFyYW1ldGVycyk7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSlNDVmFsdWUgICAgICAgICAgICAqKnBhcmFtZXRlcnMpIEdf R05VQ19XQVJOX1VOVVNFRF9SRVNVTFQ7CiAKIEpTQ19BUEkgZ2Jvb2xlYW4KIGpzY192YWx1ZV9p c19jb25zdHJ1Y3RvciAgICAgICAgICAgICAgICAgIChKU0NWYWx1ZSAgICAgICAgICAgICAqdmFs dWUpOwo=