188959 2018-08-26 20:39:16 -0700 Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering 2018-08-27 10:00:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 174968 1 hi hi bburg commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1453780 0 hi 2018-08-26 20:39:16 -0700 STEPS TO REPRODUCE: 1. Open WebInspector to a page with a 2D canvas 2. Take a recording of the 2D canvas (try to find one with a few thousand actions) 3. Filter by "as" among the recording actions in the NavigationSidebar 4. Backspace the text in the filter box to just have "a" => Nothing appears, including no "No Filter Results" 1453782 1 348115 hi 2018-08-26 20:41:58 -0700 Created attachment 348115 Patch 1453909 2 348115 bburg 2018-08-27 09:24:58 -0700 Comment on attachment 348115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348115&action=review r=me but please make it more readable > Source/WebInspectorUI/UserInterface/Views/TreeElement.js:169 > + this.treeOutline.soon.updateVirtualizedElements(!this._hidden && this.selected ? this : null); Pls extract this condition out so I know what the logic is trying to compute. i.e., let focusedTreeElement = ... 1453913 3 348151 hi 2018-08-27 09:29:21 -0700 Created attachment 348151 Patch 1453937 4 348151 commit-queue 2018-08-27 09:59:48 -0700 Comment on attachment 348151 Patch Clearing flags on attachment: 348151 Committed r235377: <https://trac.webkit.org/changeset/235377> 1453938 5 commit-queue 2018-08-27 09:59:50 -0700 All reviewed patches have been landed. Closing bug. 1453939 6 webkit-bug-importer 2018-08-27 10:00:24 -0700 <rdar://problem/43757744> 348115 2018-08-26 20:41:58 -0700 2018-08-27 09:29:17 -0700 Patch bug-188959-20180826204157.patch text/plain 1720 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzNGQwM2UzZDA1OWI3OWI4NjY1NjM1NjZjOWQ2 OTVjMjQ0YTdhMmQuLjQ1Mjc5Y2Q3MzM1MWE0YWEzN2M1YWU5NGM2MDMwZThlZDNhMzVjZWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiB2aXJ0dWFsaXplZCBUcmVlT3V0bGluZSBpcyBlbXB0eSB3aGVuIGZpbHRlcmlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTU5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50LmpzOgorICAgICAgICAoV0kuVHJlZUVsZW1lbnQu cHJvdG90eXBlLnNldCBoaWRkZW4pOgorICAgICAgICBPbmx5IHNldCBgZm9jdXNlZFRyZWVFbGVt ZW50YCBpZiB0aGUgYFdJLlRyZWVFbGVtZW50YCBpcyBzZWxlY3RlZCBhbmQgbm90IGhpZGRlbi4g VGhlcmUgaXMKKyAgICAgICAgbm8gcmVhc29uIHRvIGZvY3VzIGEgaGlkZGVuIG9yIHVuc2VsZWN0 ZWQgYFdJLlRyZWVFbGVtZW50YC4KKwogMjAxOC0wOC0yMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBjYW4n dCBlbnRlciBkZWNpbWFsIG51bWJlcnMgZm9yIG9wYWNpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanMKaW5kZXgg YzIxYTU5M2I4N2VlZDJkMDY4ZGEzZjBjODBlZDhhZjY4YWQzNDQzNC4uZmU2MzNmNmNkZTllZjNh MDM4OWU3N2M5ZDY2YmM0MTUyNWUyYmRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanMKQEAgLTE2Niw3ICsx NjYsNyBAQCBXSS5UcmVlRWxlbWVudCA9IGNsYXNzIFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuT2Jq ZWN0CiAgICAgICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLmhpZGRlbiA9IHRoaXMuX2hp ZGRlbjsKIAogICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZSkgewotICAgICAgICAgICAgdGhp cy50cmVlT3V0bGluZS5zb29uLnVwZGF0ZVZpcnR1YWxpemVkRWxlbWVudHModGhpcyk7CisgICAg ICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnNvb24udXBkYXRlVmlydHVhbGl6ZWRFbGVtZW50cygh dGhpcy5faGlkZGVuICYmIHRoaXMuc2VsZWN0ZWQgPyB0aGlzIDogbnVsbCk7CiAKICAgICAgICAg ICAgIHRoaXMudHJlZU91dGxpbmUuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRyZWVPdXRs aW5lLkV2ZW50LkVsZW1lbnRWaXNpYmlsaXR5RGlkQ2hhbmdlLCB7ZWxlbWVudDogdGhpc30pOwog ICAgICAgICB9Cg== 348151 2018-08-27 09:29:21 -0700 2018-08-27 09:59:48 -0700 Patch bug-188959-20180827092920.patch text/plain 1828 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzNGQwM2UzZDA1OWI3OWI4NjY1NjM1NjZjOWQ2 OTVjMjQ0YTdhMmQuLjIzN2E2Y2M3MTQyYmU5NmQxZDU5N2Y5MDM5YTRkNjY0YmQ1ODMxNjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTI3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiB2aXJ0dWFsaXplZCBUcmVlT3V0bGluZSBpcyBlbXB0eSB3aGVuIGZpbHRlcmlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTU5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJpYW4gQnVyZy4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXSS5UcmVlRWxlbWVudC5wcm90 b3R5cGUuc2V0IGhpZGRlbik6CisgICAgICAgIE9ubHkgc2V0IGBmb2N1c2VkVHJlZUVsZW1lbnRg IGlmIHRoZSBgV0kuVHJlZUVsZW1lbnRgIGlzIHNlbGVjdGVkIGFuZCBub3QgaGlkZGVuLiBUaGVy ZSBpcworICAgICAgICBubyByZWFzb24gdG8gZm9jdXMgYSBoaWRkZW4gb3IgdW5zZWxlY3RlZCBg V0kuVHJlZUVsZW1lbnRgLgorCiAyMDE4LTA4LTIzICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb2xvciBwaWNrZXI6IGNhbid0IGVu dGVyIGRlY2ltYWwgbnVtYmVycyBmb3Igb3BhY2l0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcwppbmRleCBjMjFh NTkzYjg3ZWVkMmQwNjhkYTNmMGM4MGVkOGFmNjhhZDM0NDM0Li5kNDg3MTQ3Yzk1MTU3MWFlZjU1 M2E3Nzg2OWRhMDVlZjQ3YTM1YjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcwpAQCAtMTY2LDcgKzE2Niwx MCBAQCBXSS5UcmVlRWxlbWVudCA9IGNsYXNzIFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLmhpZGRlbiA9IHRoaXMuX2hpZGRl bjsKIAogICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZSkgewotICAgICAgICAgICAgdGhpcy50 cmVlT3V0bGluZS5zb29uLnVwZGF0ZVZpcnR1YWxpemVkRWxlbWVudHModGhpcyk7CisgICAgICAg ICAgICBsZXQgZm9jdXNlZFRyZWVFbGVtZW50ID0gbnVsbDsKKyAgICAgICAgICAgIGlmICghdGhp cy5faGlkZGVuICYmIHRoaXMuc2VsZWN0ZWQpCisgICAgICAgICAgICAgICAgZm9jdXNlZFRyZWVF bGVtZW50ID0gdGhpczsKKyAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuc29vbi51cGRhdGVW aXJ0dWFsaXplZEVsZW1lbnRzKGZvY3VzZWRUcmVlRWxlbWVudCk7CiAKICAgICAgICAgICAgIHRo aXMudHJlZU91dGxpbmUuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRyZWVPdXRsaW5lLkV2 ZW50LkVsZW1lbnRWaXNpYmlsaXR5RGlkQ2hhbmdlLCB7ZWxlbWVudDogdGhpc30pOwogICAgICAg ICB9Cg==