<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188956</bug_id>
          
          <creation_ts>2018-08-26 14:54:56 -0700</creation_ts>
          <short_desc>[Xcode] Don’t make unnecessary, broken WebKitPluginAgent symlink when WK_USE_OVERRIDE_FRAMEWORKS_DIR=YES</short_desc>
          <delta_ts>2018-08-26 18:00:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to>mitz</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1453732</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-08-26 14:54:56 -0700</bug_when>
    <thetext>&lt;rdar://problem/43253221&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1453733</commentid>
    <comment_count>1</comment_count>
      <attachid>348103</attachid>
    <who name="">mitz</who>
    <bug_when>2018-08-26 15:04:16 -0700</bug_when>
    <thetext>Created attachment 348103
Update the build phase that makes the symlink</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1453737</commentid>
    <comment_count>2</comment_count>
      <attachid>348103</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-08-26 15:47:57 -0700</bug_when>
    <thetext>Comment on attachment 348103
Update the build phase that makes the symlink

Rejecting attachment 348103 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 348103, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348103&amp;action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=188956&amp;ctype=xml&amp;excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 348103 from bug 188956.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348103
Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKitLegacy/ChangeLog
	M	Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 3e5c51ff171204665ccb28e40b46b9c75d56067f and refs/remotes/origin/master differ, using rebase:
:040000 040000 7f21da625bc17a78b3bd037b8a7e1f3c61147a02 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKitLegacy/ChangeLog
	M	Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 3e5c51ff171204665ccb28e40b46b9c75d56067f and refs/remotes/origin/master differ, using rebase:
:040000 040000 7f21da625bc17a78b3bd037b8a7e1f3c61147a02 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/8990191</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1453743</commentid>
    <comment_count>3</comment_count>
      <attachid>348103</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-08-26 18:00:28 -0700</bug_when>
    <thetext>Comment on attachment 348103
Update the build phase that makes the symlink

Clearing flags on attachment: 348103

Committed r235340: &lt;https://trac.webkit.org/changeset/235340&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1453744</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-08-26 18:00:29 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348103</attachid>
            <date>2018-08-26 15:04:16 -0700</date>
            <delta_ts>2018-08-26 18:00:28 -0700</delta_ts>
            <desc>Update the build phase that makes the symlink</desc>
            <filename>bug-188956-20180826150416.patch</filename>
            <type>text/plain</type>
            <size>3522</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzUzMzgpCisrKyBTb3VyY2UvV2Vi
S2l0TGVnYWN5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4
LTA4LTI2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW1hjb2Rl
XSBEb27igJl0IG1ha2UgdW5uZWNlc3NhcnksIGJyb2tlbiBXZWJLaXRQbHVnaW5BZ2VudCBzeW1s
aW5rIHdoZW4gV0tfVVNFX09WRVJSSURFX0ZSQU1FV09SS1NfRElSPVlFUworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTU2CisgICAgICAgIDxyZGFy
Oi8vcHJvYmxlbS80MzI1MzIyMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIFdlYktpdExlZ2FjeS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBV
cGRhdGVkIHRoZSBTeW1saW5rIFdlYktpdFBsdWdpbkhvc3QgYnVpbGQgcGhhc2UuCisKIDIwMTgt
MDgtMDEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg
ICAgICBNb3ZlIGFsbCBjYWxscyB0byBSZXNvdXJjZUxvYWRlcjo6c3RhcnQgdG8gV2ViS2l0TGVn
YWN5CkluZGV4OiBTb3VyY2UvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS54Y29kZXByb2ovcHJv
amVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXRMZWdhY3kvV2ViS2l0TGVn
YWN5Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHJldmlzaW9uIDIzNTMzOCkKKysrIFNvdXJj
ZS9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdv
cmtpbmcgY29weSkKQEAgLTMyNzEsNyArMzI3MSw3IEBACiAJCQkpOwogCQkJcnVuT25seUZvckRl
cGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwotCQkJ
c2hlbGxTY3JpcHQgPSAiaWYgW1sgJHtXS19QTEFURk9STV9OQU1FfSAhPSBcIm1hY29zeFwiIF1d
OyB0aGVuXG4gICAgZXhpdCAwXG5maVxuXG5bWyAtaCBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vV2Vi
S2l0TGVnYWN5LmZyYW1ld29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiIF1dIHx8IGxuIC1zIFZl
cnNpb25zL0N1cnJlbnQvV2ViS2l0UGx1Z2luSG9zdC5hcHAgXCIke1RBUkdFVF9CVUlMRF9ESVJ9
L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIlxuW1sgLWggXCIk
e1RBUkdFVF9CVUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luQWdl
bnRcIiBdXSB8fCBsbiAtcyBWZXJzaW9ucy9DdXJyZW50L1dlYktpdFBsdWdpbkFnZW50IFwiJHtU
QVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1dlYktpdFBsdWdpbkFnZW50
XCJcblxuaWYgW1sgXCIke0NPTkZJR1VSQVRJT059XCIgIT0gXCJQcm9kdWN0aW9uXCIgJiYgJHtB
Q1RJT059ID09IFwiYnVpbGRcIiAgJiYgISAtZSBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vV2ViS2l0
TGVnYWN5LmZyYW1ld29yay9WZXJzaW9ucy9BL1dlYktpdFBsdWdpbkhvc3QuYXBwXCIgXV07IHRo
ZW5cbiAgICBpZiBbWyAtZSBcIi9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1dlYktpdC5mcmFt
ZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIiBdXTsgdGhlblxuICAgICAgICBsbiAtcyAvU3lz
dGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL1dlYktpdFBsdWdpbkhvc3Qu
YXBwIFwiJHtUQVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25z
L0EvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIlxuICAgIGVsc2VcbiAgICAgICAgbG4gLXMgL1N5c3Rl
bS9MaWJyYXJ5L0ZyYW1ld29ya3MvV2ViS2l0LmZyYW1ld29yay9WZXJzaW9ucy9BL0ZyYW1ld29y
a3MvV2ViS2l0TGVnYWN5LmZyYW1ld29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcCBcIiR7VEFSR0VU
X0JVSUxEX0RJUn0vV2ViS2l0TGVnYWN5LmZyYW1ld29yay9WZXJzaW9ucy9BL1dlYktpdFBsdWdp
bkhvc3QuYXBwXCJcbiAgICBmaVxuZmlcbiI7CisJCQlzaGVsbFNjcmlwdCA9ICJpZiBbWyAke1dL
X1BMQVRGT1JNX05BTUV9ICE9IFwibWFjb3N4XCIgXV07IHRoZW5cbiAgICBleGl0IDBcbmZpXG5c
bltbIC1oIFwiJHtUQVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1dlYktp
dFBsdWdpbkhvc3QuYXBwXCIgXV0gfHwgbG4gLXMgVmVyc2lvbnMvQ3VycmVudC9XZWJLaXRQbHVn
aW5Ib3N0LmFwcCBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vV2ViS2l0TGVnYWN5LmZyYW1ld29yay9X
ZWJLaXRQbHVnaW5Ib3N0LmFwcFwiXG5bWyAke1dLX1VTRV9PVkVSUklERV9GUkFNRVdPUktTX0RJ
Un0gPT0gXCJZRVNcIiBdXSB8fCBbWyAtaCBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vV2ViS2l0TGVn
YWN5LmZyYW1ld29yay9XZWJLaXRQbHVnaW5BZ2VudFwiIF1dIHx8IGxuIC1zIFZlcnNpb25zL0N1
cnJlbnQvV2ViS2l0UGx1Z2luQWdlbnQgXCIke1RBUkdFVF9CVUlMRF9ESVJ9L1dlYktpdExlZ2Fj
eS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luQWdlbnRcIlxuXG5pZiBbWyBcIiR7Q09ORklHVVJBVElP
Tn1cIiAhPSBcIlByb2R1Y3Rpb25cIiAmJiAke0FDVElPTn0gPT0gXCJidWlsZFwiICAmJiAhIC1l
IFwiJHtUQVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25zL0Ev
V2ViS2l0UGx1Z2luSG9zdC5hcHBcIiBdXTsgdGhlblxuICAgIGlmIFtbIC1lIFwiL1N5c3RlbS9M
aWJyYXJ5L0ZyYW1ld29ya3MvV2ViS2l0LmZyYW1ld29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwi
IF1dOyB0aGVuXG4gICAgICAgIGxuIC1zIC9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1dlYktp
dC5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5hcHAgXCIke1RBUkdFVF9CVUlMRF9ESVJ9L1dl
YktpdExlZ2FjeS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiXG4g
ICAgZWxzZVxuICAgICAgICBsbiAtcyAvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9XZWJLaXQu
ZnJhbWV3b3JrL1ZlcnNpb25zL0EvRnJhbWV3b3Jrcy9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1dl
YktpdFBsdWdpbkhvc3QuYXBwIFwiJHtUQVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJh
bWV3b3JrL1ZlcnNpb25zL0EvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIlxuICAgIGZpXG5maVxuIjsK
IAkJfTsKIAkJMUMzOTVERTIwQzZCRThFMDAwMEQxRTUyIC8qIEdlbmVyYXRlIEV4cG9ydCBGaWxl
cyAqLyA9IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>