188939 2018-08-24 17:33:58 -0700 Fix authentication for clients of WKPageLoaderClient after r234941 2018-08-27 08:45:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer youennf oldest_to_newest 1453634 0 achristensen 2018-08-24 17:33:58 -0700 Fix authentication for clients of WKPageLoaderClient after r234941 1453638 1 348063 achristensen 2018-08-24 17:42:37 -0700 Created attachment 348063 Patch 1453641 2 348063 youennf 2018-08-24 18:23:51 -0700 Comment on attachment 348063 Patch LGTM. We should increase our testing of unimplemented callbacks config through API tests so that our defaults do not change. In that particular case, that would require launching the http server... 1453883 3 achristensen 2018-08-27 08:44:30 -0700 http://trac.webkit.org/r235364 1453884 4 webkit-bug-importer 2018-08-27 08:45:17 -0700 <rdar://problem/43755378> 348063 2018-08-24 17:42:37 -0700 2018-08-24 18:23:51 -0700 Patch bug-188939-20180824174236.patch text/plain 6311 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzUzMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA4LTI0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGF1dGhlbnRp Y2F0aW9uIGZvciBjbGllbnRzIG9mIFdLUGFnZUxvYWRlckNsaWVudCBhZnRlciByMjM0OTQxCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg5MzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHNpbXBsaWZp ZWQgdGhlIGF1dGhlbnRpY2F0aW9uIGNvZGUgcGF0aCBlbGVnYW50bHkgZm9yIGNsaWVudHMgb2Yg V0tQYWdlTmF2aWdhdGlvbkNsaWVudC9XS05hdmlnYXRpb25EZWxlZ2F0ZSwKKyAgICAgICAgYnV0 IGNsaWVudHMgb2YgV0tQYWdlTG9hZGVyQ2xpZW50IHRoYXQgZG8gbm90IGltcGxlbWVudCBkaWRS ZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2VJbkZyYW1lIHdvdWxkIGhhbmcuCisgICAgICAg IFRoaXMgZml4ZXMgdGhhdC4gIEkndmUgYWxzbyBtYWRlIHRoZSBwZXJmb3JtRGVmYXVsdEhhbmRs aW5nICh3aGVuIGRlbGVnYXRlcyBhcmUgbm90IGltcGxlbWVudGVkKSBhbmQgcmVqZWN0UHJvdGVj dGlvblNwYWNlQW5kQ29udGludWUKKyAgICAgICAgKHdoZW4gY2FuQXV0aGVudGljYXRpb25BZ2Fp bnN0UHJvdGVjdGlvblNwYWNlIHJldHVybnMgZmFsc2UpIGJlaGF2ZSBjb3JyZWN0bHkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSUxvYWRlckNsaWVudC5oOgorICAgICAgICAoQVBJOjpM b2FkZXJDbGllbnQ6OmRpZFJlYWNoTGF5b3V0TWlsZXN0b25lKToKKyAgICAgICAgKEFQSTo6TG9h ZGVyQ2xpZW50OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlSW5GcmFtZSk6 IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAgICAg IChXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KToKKyAgICAgICAgKFdLUGFnZVNldFBhZ2VOYXZp Z2F0aW9uQ2xpZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRl Lm1tOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25DbGllbnQ6 OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSk6CisKIDIwMTgtMDgtMjMgIEplZmYg TWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSAtW1dLTmF2aWdhdGlv bkRlbGVnYXRlIF93ZWJWaWV3OmRlY2lkZVBvbGljeUZvclBsdWdpbkxvYWRXaXRoQ3VycmVudFBv bGljeTpwbHVnaW5JbmZvOnVuYXZhaWxhYmlsaXR5RGVzY3JpcHRpb246XQpJbmRleDogU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSUxvYWRlckNsaWVudC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElMb2FkZXJDbGllbnQuaAkocmV2aXNpb24gMjM1 MzM4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSUxvYWRlckNsaWVudC5oCSh3 b3JraW5nIGNvcHkpCkBAIC03Niw4ICs3Niw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg ZGlkRGV0ZWN0WFNTRm9yRnJhbWUoV2ViS2l0OjpXZWJQYWdlUHJveHkmLCBXZWJLaXQ6OldlYkZy YW1lUHJveHkmLCBBUEk6Ok9iamVjdCopIHsgfQogCiAgICAgdmlydHVhbCB2b2lkIGRpZFJlYWNo TGF5b3V0TWlsZXN0b25lKFdlYktpdDo6V2ViUGFnZVByb3h5JiwgV2ViQ29yZTo6TGF5b3V0TWls ZXN0b25lcykgeyB9Ci0gICAgCi0gICAgdmlydHVhbCBib29sIGNhbkF1dGhlbnRpY2F0ZUFnYWlu c3RQcm90ZWN0aW9uU3BhY2VJbkZyYW1lKFdlYktpdDo6V2ViUGFnZVByb3h5JiwgV2ViS2l0OjpX ZWJGcmFtZVByb3h5JiwgV2ViS2l0OjpXZWJQcm90ZWN0aW9uU3BhY2UqKSB7IHJldHVybiBmYWxz ZTsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2VJ bkZyYW1lKFdlYktpdDo6V2ViUGFnZVByb3h5JiwgV2ViS2l0OjpXZWJGcmFtZVByb3h5JiwgV2Vi S2l0OjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5JikgeyB9CiAKICAgICB2aXJ0dWFsIHZv aWQgZGlkU3RhcnRQcm9ncmVzcyhXZWJLaXQ6OldlYlBhZ2VQcm94eSYpIHsgfQpJbmRleDogU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCShyZXZpc2lvbiAyMzUzMzgpCisr KyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMTY1LDE4ICsxMTY1LDEyIEBAIHZvaWQgV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudChX S1BhZ2VSZWYKICAgICAgICAgICAgIG1fY2xpZW50LmRpZERldGVjdFhTU0ZvckZyYW1lKHRvQVBJ KCZwYWdlKSwgdG9BUEkoJmZyYW1lKSwgdG9BUEkodXNlckRhdGEpLCBtX2NsaWVudC5iYXNlLmNs aWVudEluZm8pOwogICAgICAgICB9CiAKLSAgICAgICAgYm9vbCBjYW5BdXRoZW50aWNhdGVBZ2Fp bnN0UHJvdGVjdGlvblNwYWNlSW5GcmFtZShXZWJQYWdlUHJveHkmIHBhZ2UsIFdlYkZyYW1lUHJv eHkmIGZyYW1lLCBXZWJQcm90ZWN0aW9uU3BhY2UqIHByb3RlY3Rpb25TcGFjZSkgb3ZlcnJpZGUK LSAgICAgICAgewotICAgICAgICAgICAgaWYgKCFtX2NsaWVudC5jYW5BdXRoZW50aWNhdGVBZ2Fp bnN0UHJvdGVjdGlvblNwYWNlSW5GcmFtZSkKLSAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 Ci0KLSAgICAgICAgICAgIHJldHVybiBtX2NsaWVudC5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJv dGVjdGlvblNwYWNlSW5GcmFtZSh0b0FQSSgmcGFnZSksIHRvQVBJKCZmcmFtZSksIHRvQVBJKHBy b3RlY3Rpb25TcGFjZSksIG1fY2xpZW50LmJhc2UuY2xpZW50SW5mbyk7Ci0gICAgICAgIH0KLQog ICAgICAgICB2b2lkIGRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUluRnJhbWUoV2Vi UGFnZVByb3h5JiBwYWdlLCBXZWJGcmFtZVByb3h5JiBmcmFtZSwgQXV0aGVudGljYXRpb25DaGFs bGVuZ2VQcm94eSYgYXV0aGVudGljYXRpb25DaGFsbGVuZ2UpIG92ZXJyaWRlCiAgICAgICAgIHsK KyAgICAgICAgICAgIGlmIChtX2NsaWVudC5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlv blNwYWNlSW5GcmFtZSAmJiAhbV9jbGllbnQuY2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rp b25TcGFjZUluRnJhbWUodG9BUEkoJnBhZ2UpLCB0b0FQSSgmZnJhbWUpLCB0b0FQSShhdXRoZW50 aWNhdGlvbkNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSksIG1fY2xpZW50LmJhc2UuY2xpZW50 SW5mbykpCisgICAgICAgICAgICAgICAgcmV0dXJuIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLnJl amVjdFByb3RlY3Rpb25TcGFjZUFuZENvbnRpbnVlKCk7CiAgICAgICAgICAgICBpZiAoIW1fY2xp ZW50LmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUluRnJhbWUpCi0gICAgICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIHJldHVybiBhdXRoZW50aWNhdGlvbkNoYWxs ZW5nZS5wZXJmb3JtRGVmYXVsdEhhbmRsaW5nKCk7CiAKICAgICAgICAgICAgIG1fY2xpZW50LmRp ZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUluRnJhbWUodG9BUEkoJnBhZ2UpLCB0b0FQ SSgmZnJhbWUpLCB0b0FQSSgmYXV0aGVudGljYXRpb25DaGFsbGVuZ2UpLCBtX2NsaWVudC5iYXNl LmNsaWVudEluZm8pOwogICAgICAgICB9CkBAIC0yMzEwLDE5ICsyMzA0LDEyIEBAIHZvaWQgV0tQ YWdlU2V0UGFnZU5hdmlnYXRpb25DbGllbnQoV0tQYWcKICAgICAgICAgICAgIG1fY2xpZW50LnJl bmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdlKHRvQVBJKCZwYWdlKSwgcGFnZVJlbmRlcmluZ1Byb2dy ZXNzRXZlbnRzKG1pbGVzdG9uZXMpLCBudWxscHRyLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8p OwogICAgICAgICB9CiAgICAgICAgIAotICAgICAgICBib29sIGNhbkF1dGhlbnRpY2F0ZUFnYWlu c3RQcm90ZWN0aW9uU3BhY2UoV2ViUGFnZVByb3h5JiBwYWdlLCBXZWJQcm90ZWN0aW9uU3BhY2Uq IHByb3RlY3Rpb25TcGFjZSkgb3ZlcnJpZGUKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKCFt X2NsaWVudC5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKQotICAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIHJldHVybiBtX2NsaWVudC5jYW5BdXRo ZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKHRvQVBJKCZwYWdlKSwgdG9BUEkocHJvdGVj dGlvblNwYWNlKSwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsKLSAgICAgICAgfQotICAgICAg ICAKICAgICAgICAgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoV2ViUGFn ZVByb3h5JiBwYWdlLCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5JiBhdXRoZW50aWNhdGlv bkNoYWxsZW5nZSkgb3ZlcnJpZGUKICAgICAgICAgewogICAgICAgICAgICAgaWYgKG1fY2xpZW50 LmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UgJiYgIW1fY2xpZW50LmNhbkF1 dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UodG9BUEkoJnBhZ2UpLCB0b0FQSShhdXRo ZW50aWNhdGlvbkNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSksIG1fY2xpZW50LmJhc2UuY2xp ZW50SW5mbykpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdl LnJlamVjdFByb3RlY3Rpb25TcGFjZUFuZENvbnRpbnVlKCk7CiAgICAgICAgICAgICBpZiAoIW1f Y2xpZW50LmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSkKLSAgICAgICAgICAgICAg ICByZXR1cm4gYXV0aGVudGljYXRpb25DaGFsbGVuZ2UucmVqZWN0UHJvdGVjdGlvblNwYWNlQW5k Q29udGludWUoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gYXV0aGVudGljYXRpb25DaGFsbGVu Z2UucGVyZm9ybURlZmF1bHRIYW5kbGluZygpOwogICAgICAgICAgICAgbV9jbGllbnQuZGlkUmVj ZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHRvQVBJKCZwYWdlKSwgdG9BUEkoJmF1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlKSwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsKICAgICAgICAgfQog CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0 YXRlLm1tCShyZXZpc2lvbiAyMzUzMzgpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9OYXZpZ2F0aW9uU3RhdGUubW0JKHdvcmtpbmcgY29weSkKQEAgLTg1Myw3ICs4NTMsNyBAQCB2 b2lkIE5hdmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6CiB2b2lkIE5hdmlnYXRpb25T dGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6ZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdl KFdlYlBhZ2VQcm94eSYsIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHkmIGF1dGhlbnRpY2F0 aW9uQ2hhbGxlbmdlKQogewogICAgIGlmICghbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9u RGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2VD b21wbGV0aW9uSGFuZGxlcikKLSAgICAgICAgcmV0dXJuIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdl LnJlamVjdFByb3RlY3Rpb25TcGFjZUFuZENvbnRpbnVlKCk7CisgICAgICAgIHJldHVybiBhdXRo ZW50aWNhdGlvbkNoYWxsZW5nZS5wZXJmb3JtRGVmYXVsdEhhbmRsaW5nKCk7CiAKICAgICBhdXRv IG5hdmlnYXRpb25EZWxlZ2F0ZSA9IG1fbmF2aWdhdGlvblN0YXRlLm1fbmF2aWdhdGlvbkRlbGVn YXRlLmdldCgpOwogICAgIGlmICghbmF2aWdhdGlvbkRlbGVnYXRlKQo=