188908 2018-08-23 16:55:41 -0700 [Curl] Implement deleteCookie() 2018-08-30 10:41:16 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke chris.reid commit-queue ews-watchlist fujii galpeter joepeck webkit-bug-importer youennf oldest_to_newest 1453318 0 basuke 2018-08-23 16:55:41 -0700 Delete cookie was not implemented. 1453477 1 basuke 2018-08-24 10:29:19 -0700 It is used from the web inspector. 1453478 2 348020 basuke 2018-08-24 10:31:47 -0700 Created attachment 348020 PATCH 1453788 3 348020 fujii 2018-08-26 21:29:02 -0700 Comment on attachment 348020 PATCH I think this is not right. NetworkStorageSession::deleteCookie should delete cookies only in the storage session for private browsing mode. But, I don't object to land this change. 1453789 4 348020 commit-queue 2018-08-26 21:55:16 -0700 Comment on attachment 348020 PATCH Clearing flags on attachment: 348020 Committed r235351: <https://trac.webkit.org/changeset/235351> 1453790 5 commit-queue 2018-08-26 21:55:18 -0700 All reviewed patches have been landed. Closing bug. 1453791 6 webkit-bug-importer 2018-08-26 21:56:16 -0700 <rdar://problem/43742331> 1454580 7 basuke 2018-08-28 15:24:49 -0700 (In reply to Fujii Hironori from comment #3) > Comment on attachment 348020 [details] > PATCH > > I think this is not right. NetworkStorageSession::deleteCookie > should delete cookies only in the storage session for private > browsing mode. But, I don't object to land this change. I cannot get what you say. CookieJarCurlDatabase::deleteCookie() will be called with proper NetworkStorageSession object. It doesn't tightly connected to private mode, but it may happen on default session. The method itself will be called from web inspector to delete specific cookie. These are my understanding. 1455123 8 fujii 2018-08-29 20:02:02 -0700 Curl port should suport multiple cookie storages for private browsing mode as well as other ports does. NetworkStorageSession::deleteCookie should delete cookies only in its cookie storage. 1455275 9 basuke 2018-08-30 10:41:16 -0700 Got it. Your point is that every network storage session shares same cookie jar db. We should fix that. Also we need a reference implementation of private mode in MiniBrowser. 348020 2018-08-24 10:31:47 -0700 2018-08-26 21:55:16 -0700 PATCH 188908.diff text/plain 1726 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGM4YjYwZDcwYi4uMzUwNDNiZTc0ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wOC0yNCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIEltcGxlbWVudCBkZWxldGVDb29raWUoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4OTA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBkZWxldGlu ZyBjb29raWVzIGZyb20gdGhlIHdlYiBpbnNwZWN0b3IKKworICAgICAgICBUZXN0ZWQgZnJvbSB0 aGUgd2ViIGluc3BlY3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9Db29r aWVKYXJDdXJsRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29va2llSmFyQ3VybERh dGFiYXNlOjpkZWxldGVDb29raWUgY29uc3QpOgorCiAyMDE4LTA4LTIwICBNaWNoYWVsIENhdGFu emFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIFN5bmMgdW5p ZmllZCBidWlsZCB3aXRoIENvY29hIHBvcnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybERhdGFiYXNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJsRGF0YWJhc2UuY3BwCmlu ZGV4IGZhZDlkOTRhYzMyLi41ZTg0NTRhYTU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmxEYXRhYmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmxEYXRhYmFzZS5j cHAKQEAgLTExMyw5ICsxMTMsMTAgQEAgYm9vbCBDb29raWVKYXJDdXJsRGF0YWJhc2U6OmdldFJh d0Nvb2tpZXMoY29uc3QgTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBzZXNzaW9uLAogICAgIHJldHVy biBjb29raWVKYXJEQi5zZWFyY2hDb29raWVzKGZpcnN0UGFydHkuc3RyaW5nKCksIHN0ZDo6bnVs bG9wdCwgc3RkOjpudWxsb3B0LCBzdGQ6Om51bGxvcHQsIHJhd0Nvb2tpZXMpOwogfQogCi12b2lk IENvb2tpZUphckN1cmxEYXRhYmFzZTo6ZGVsZXRlQ29va2llKGNvbnN0IE5ldHdvcmtTdG9yYWdl U2Vzc2lvbiYsIGNvbnN0IFVSTCYsIGNvbnN0IFN0cmluZyYpIGNvbnN0Cit2b2lkIENvb2tpZUph ckN1cmxEYXRhYmFzZTo6ZGVsZXRlQ29va2llKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYg c2Vzc2lvbiwgY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3QKIHsKLSAg ICAvLyBGSVhNRTogTm90IHlldCBpbXBsZW1lbnRlZAorICAgIENvb2tpZUphckRCJiBjb29raWVK YXJEQiA9IHNlc3Npb24uY29va2llRGF0YWJhc2UoKTsKKyAgICBjb29raWVKYXJEQi5kZWxldGVD b29raWUodXJsLCBuYW1lKTsKIH0KIAogdm9pZCBDb29raWVKYXJDdXJsRGF0YWJhc2U6OmdldEhv c3RuYW1lc1dpdGhDb29raWVzKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYsIEhhc2hTZXQ8 U3RyaW5nPiYpIGNvbnN0Cg==