188906 2018-08-23 16:01:07 -0700 Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy 2018-08-27 09:43:31 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen commit-queue ggaren rniwa ryanhaddad oldest_to_newest 1453278 0 sihui_liu 2018-08-23 16:01:07 -0700 In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of sharedCookieStorage. When we launch the network process later, we pass the sharedCookieStorage to network process, so network process has the correct cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the setting message if the network process is not launched. 1453279 1 sihui_liu 2018-08-23 16:01:22 -0700 <rdar://problem/42875795> 1453280 2 sihui_liu 2018-08-23 16:01:58 -0700 <rdar://problem/43539661> 1453283 3 347966 sihui_liu 2018-08-23 16:06:57 -0700 Created attachment 347966 Patch 1453473 4 347966 ggaren 2018-08-24 10:02:04 -0700 Comment on attachment 347966 Patch r=me 1453486 5 347966 commit-queue 2018-08-24 10:46:08 -0700 Comment on attachment 347966 Patch Clearing flags on attachment: 347966 Committed r235321: <https://trac.webkit.org/changeset/235321> 1453487 6 commit-queue 2018-08-24 10:46:09 -0700 All reviewed patches have been landed. Closing bug. 1453582 7 sihui_liu 2018-08-24 15:01:58 -0700 Failed to invoke the callback in early return. 1453585 8 348044 sihui_liu 2018-08-24 15:03:59 -0700 Created attachment 348044 Patch 1453637 9 348044 commit-queue 2018-08-24 17:39:38 -0700 Comment on attachment 348044 Patch Rejecting attachment 348044 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 348044, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=348044&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=188906&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 348044 from bug 188906. Fetching: https://bugs.webkit.org/attachment.cgi?id=348044 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/UIProcess/WebCookieManagerProxy.cpp ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: Commits are currently disabled while we update infrastructure. W: f06372109b0ab3aa050594c410308ffe25d059a4 and refs/remotes/origin/master differ, using rebase: :040000 040000 a30ae21dc76e281b437ed3a04bfed4ace20e83db 162abbfb909fd78b90c6722de4a4368f8d472b8a M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/UIProcess/WebCookieManagerProxy.cpp ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: Commits are currently disabled while we update infrastructure. W: f06372109b0ab3aa050594c410308ffe25d059a4 and refs/remotes/origin/master differ, using rebase: :040000 040000 a30ae21dc76e281b437ed3a04bfed4ace20e83db 162abbfb909fd78b90c6722de4a4368f8d472b8a M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/8977477 1453927 10 348044 commit-queue 2018-08-27 09:43:30 -0700 Comment on attachment 348044 Patch Clearing flags on attachment: 348044 Committed r235374: <https://trac.webkit.org/changeset/235374> 1453928 11 commit-queue 2018-08-27 09:43:31 -0700 All reviewed patches have been landed. Closing bug. 347966 2018-08-23 16:06:57 -0700 2018-08-24 17:07:26 -0700 Patch bug-188906-20180823160656.patch text/plain 2040 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNlY2ExYzliNTMxN2FiMThl Nzg0YjNlMTk4YmYwOTkyMjU4ODJjOTEuLjUwMDNmNGE2YzZjZjhhOTM0Njc1ZjBlZTJlN2UxNjJi NWZhMjkxNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDgtMjMgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgbGF1bmNoIG5ldHdvcmsg cHJvY2VzcyBpbiBXZWJDb29raWVNYW5hZ2VyUHJveHk6OnNldEhUVFBDb29raWVBY2NlcHRQb2xp Y3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODkw NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDM1Mzk2NjE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gV2ViQ29va2llTWFuYWdlclByb3h5Ojpz ZXRIVFRQQ29va2llQWNjZXB0UG9saWN5LCB3ZSBwZXJzaXN0IHRoZSBjb29raWVBY2NlcHRQb2xp Y3kgb2YgCisgICAgICAgIHNoYXJlZENvb2tpZVN0b3JhZ2UuIFdoZW4gd2UgbGF1bmNoIHRoZSBu ZXR3b3JrIHByb2Nlc3MgbGF0ZXIsIHdlIHBhc3MgdGhlIAorICAgICAgICBpZGVudGlmaWVyIG9m IHNoYXJlZENvb2tpZVN0b3JhZ2UgdG8gbmV0d29yayBwcm9jZXNzLCBzbyBuZXR3b3JrIHByb2Nl c3MgaGFzIHRoZSBjb3JyZWN0IAorICAgICAgICBjb29raWVBY2NlcHRQb2xpY3kuIFRoZXJlZm9y ZSwgd2UgZG9uJ3QgaGF2ZSB0byBsYXVuY2ggdGhlIG5ldHdvcmsgcHJvY2VzcyBhbmQgc2VuZCB0 aGUgCisgICAgICAgIHNldHRpbmcgbWVzc2FnZSBpZiB0aGUgbmV0d29yayBwcm9jZXNzIGlzIG5v dCBsYXVuY2hlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb29raWVNYW5hZ2VyUHJveHku Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb29raWVNYW5hZ2VyUHJveHk6OnNldEhUVFBDb29r aWVBY2NlcHRQb2xpY3kpOgorCiAyMDE4LTA4LTIzICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzQ5NDIuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJDb29raWVNYW5hZ2VyUHJveHku Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQ29va2llTWFuYWdlclByb3h5LmNwcApp bmRleCAwNmZmMDZlYThlMmY5YmI0ODdmNDMwYTFiZWQ5Y2UxNjVhMjk1MDgzLi5lYzZmNTkwZTY1 MzY0NjE1MzgyMjllNDI2YzVmMzAzZDQ1YTFiOTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJDb29raWVNYW5hZ2VyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYkNvb2tpZU1hbmFnZXJQcm94eS5jcHAKQEAgLTI1Miw2ICsyNTIsOSBAQCB2 b2lkIFdlYkNvb2tpZU1hbmFnZXJQcm94eTo6c2V0SFRUUENvb2tpZUFjY2VwdFBvbGljeShQQUw6 OlNlc3Npb25JRCwgSFRUUENvb2tpZQogICAgIHByb2Nlc3NQb29sKCktPnNldEluaXRpYWxIVFRQ Q29va2llQWNjZXB0UG9saWN5KHBvbGljeSk7CiAjZW5kaWYKIAorICAgIGlmICghcHJvY2Vzc1Bv b2woKS0+bmV0d29ya1Byb2Nlc3MoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYXV0byBjYWxs YmFja0lEID0gbV9jYWxsYmFja3MucHV0KFdURk1vdmUoY2FsbGJhY2tGdW5jdGlvbiksIHByb2Nl c3NQb29sKCktPmVuc3VyZU5ldHdvcmtQcm9jZXNzKCkudGhyb3R0bGVyKCkuYmFja2dyb3VuZEFj dGl2aXR5VG9rZW4oKSk7CiAgICAgcHJvY2Vzc1Bvb2woKS0+c2VuZFRvTmV0d29ya2luZ1Byb2Nl c3MoTWVzc2FnZXM6OldlYkNvb2tpZU1hbmFnZXI6OlNldEhUVFBDb29raWVBY2NlcHRQb2xpY3ko cG9saWN5LCBPcHRpb25hbENhbGxiYWNrSUQoY2FsbGJhY2tJRCkpKTsKIH0K 348044 2018-08-24 15:03:59 -0700 2018-08-27 09:43:30 -0700 Patch bug-188906-20180824150358.patch text/plain 1734 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwMDljMzc0ODE0ODFhM2Nm ZDQzMWFhM2Q1MDZjODVjZDgzNGRiNDIuLjE0N2E5OWE4MzAwNGQ1M2NiYzI2MGVlZjE1Y2I3MmRi NWRjZmEyMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDgtMjQgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgbGF1bmNoIG5ldHdvcmsg cHJvY2VzcyBpbiBXZWJDb29raWVNYW5hZ2VyUHJveHk6OnNldEhUVFBDb29raWVBY2NlcHRQb2xp Y3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODkw NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDI4NzU3OTU+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNhbGxiYWNrIGluIGVhcmx5IHJldHVy bi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb29raWVNYW5hZ2VyUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJDb29raWVNYW5hZ2VyUHJveHk6OnNldEhUVFBDb29raWVBY2NlcHRQ b2xpY3kpOgorCiAyMDE4LTA4LTI0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNlIF9XS0luc3BlY3RvcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQ29va2llTWFuYWdlclByb3h5LmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkNvb2tpZU1hbmFnZXJQcm94eS5jcHAKaW5kZXggMDhjZmY1 OGViMjljMzkwNGQ2ZmU5NWQzODQ5NDdmY2I2OTFiZDc3MC4uMGEyMGQ4NTRmNDRmMjFhYmM1YTQz YmJkMGQ3N2M4NjkyZjhmMjc2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViQ29va2llTWFuYWdlclByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJDb29raWVNYW5hZ2VyUHJveHkuY3BwCkBAIC0yNTEsOCArMjUxLDEwIEBAIHZvaWQgV2ViQ29v a2llTWFuYWdlclByb3h5OjpzZXRIVFRQQ29va2llQWNjZXB0UG9saWN5KFBBTDo6U2Vzc2lvbklE LCBIVFRQQ29va2llCiAgICAgcHJvY2Vzc1Bvb2woKS0+c2V0SW5pdGlhbEhUVFBDb29raWVBY2Nl cHRQb2xpY3kocG9saWN5KTsKICNlbmRpZgogCi0gICAgaWYgKCFwcm9jZXNzUG9vbCgpLT5uZXR3 b3JrUHJvY2VzcygpKQorICAgIGlmICghcHJvY2Vzc1Bvb2woKS0+bmV0d29ya1Byb2Nlc3MoKSkg eworICAgICAgICBjYWxsYmFja0Z1bmN0aW9uKENhbGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpOwog ICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgYXV0byBjYWxsYmFja0lEID0gbV9jYWxsYmFj a3MucHV0KFdURk1vdmUoY2FsbGJhY2tGdW5jdGlvbiksIHByb2Nlc3NQb29sKCktPmVuc3VyZU5l dHdvcmtQcm9jZXNzKCkudGhyb3R0bGVyKCkuYmFja2dyb3VuZEFjdGl2aXR5VG9rZW4oKSk7CiAg ICAgcHJvY2Vzc1Bvb2woKS0+c2VuZFRvTmV0d29ya2luZ1Byb2Nlc3MoTWVzc2FnZXM6OldlYkNv b2tpZU1hbmFnZXI6OlNldEhUVFBDb29raWVBY2NlcHRQb2xpY3kocG9saWN5LCBPcHRpb25hbENh bGxiYWNrSUQoY2FsbGJhY2tJRCkpKTsK