188901 2018-08-23 14:04:53 -0700 [CMake] Have checks are not getting set inside CMake properly 2018-08-23 15:54:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead annulen commit-queue fujii lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1453212 0 don.olmstead 2018-08-23 14:04:53 -0700 Currently it looks like CMake have checks are not being set properly within the build. After https://trac.webkit.org/changeset/235241/webkit I noticed that the check for HAVE_MALLOC_TRIM within PerformanceTests/CMakeLists.txt was not set to OFF but instead was set to HAVE_MALLOC_TEST_value. The cmakeconfig.h however was correct. 1453214 1 347951 don.olmstead 2018-08-23 14:10:35 -0700 Created attachment 347951 Patch 1453223 2 347951 mcatanzaro 2018-08-23 14:31:44 -0700 Comment on attachment 347951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347951&action=review > PerformanceTests/CMakeLists.txt:5 > +else () > + message(WARNING "MallocBench is not available on this platform") Isn't this warning message just going to be annoying? > Source/cmake/WebKitFeatures.cmake:365 > - SET_AND_EXPOSE_TO_BUILD(${_variable} ${_variable}_value) > + SET_AND_EXPOSE_TO_BUILD(${_variable} ${${_variable}_value}) Ouch. 1453251 3 347951 don.olmstead 2018-08-23 15:25:39 -0700 Comment on attachment 347951 Patch WinCairo EWS had an internal failure. AppleWin EWS is hitting a new compilation error. I think this is fine but will roll out if WinCairo has problems. 1453268 4 347951 commit-queue 2018-08-23 15:53:12 -0700 Comment on attachment 347951 Patch Clearing flags on attachment: 347951 Committed r235253: <https://trac.webkit.org/changeset/235253> 1453269 5 commit-queue 2018-08-23 15:53:13 -0700 All reviewed patches have been landed. Closing bug. 1453271 6 webkit-bug-importer 2018-08-23 15:54:16 -0700 <rdar://problem/43662371> 347951 2018-08-23 14:10:35 -0700 2018-08-23 15:53:12 -0700 Patch bug-188901.diff text/plain 3084 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkYWYxYzFhN2ZhZS4uNjBj ZGMzNWM4MTEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxOC0wOC0yMyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtDTWFrZV0gSGF2ZSBjaGVja3MgYXJlIG5vdCBnZXR0aW5nIHNldCBpbnNp ZGUgQ01ha2UgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4ODkwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1ha2Ugc3VyZSB0aGUgdmFyaWFibGUncyB2YWx1ZSBpcyBzZW50IHRvIFNFVF9B TkRfRVhQT1NFX1RPX0JVSUxECisgICAgICAgIHdpdGhpbiB0aGUgV0VCS0lUX0NIRUNLX0hBVkVf KiBtYWNyb3MuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6 CisKIDIwMTgtMDgtMjMgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAog ICAgICAgICBbQ01ha2VdIEFkZCBIQVZFX01BTExPQ19UUklNIGRlZmluaXRpb24KZGlmZiAtLWdp dCBhL1BlcmZvcm1hbmNlVGVzdHMvQ01ha2VMaXN0cy50eHQgYi9QZXJmb3JtYW5jZVRlc3RzL0NN YWtlTGlzdHMudHh0CmluZGV4IDA2NTdmNDc5NjhkLi40MzIyZDJhZDg5MiAxMDA2NDQKLS0tIGEv UGVyZm9ybWFuY2VUZXN0cy9DTWFrZUxpc3RzLnR4dAorKysgYi9QZXJmb3JtYW5jZVRlc3RzL0NN YWtlTGlzdHMudHh0CkBAIC0xLDYgKzEsOCBAQAogIyBNYWxsb2NCZW5jaCByZXF1aXJlcyBtYWxs b2NfdHJpbSBmb3Igbm9uLUFwcGxlIHBsYXRmb3JtcwogaWYgKE5PVCBVU0VfU1lTVEVNX01BTExP QyBBTkQgKEFQUExFIE9SIEhBVkVfTUFMTE9DX1RSSU0pKQogICAgIGFkZF9zdWJkaXJlY3Rvcnko TWFsbG9jQmVuY2gpCitlbHNlICgpCisgICAgbWVzc2FnZShXQVJOSU5HICJNYWxsb2NCZW5jaCBp cyBub3QgYXZhaWxhYmxlIG9uIHRoaXMgcGxhdGZvcm0iKQogZW5kaWYgKCkKIAogV0VCS0lUX0lO Q0xVREVfQ09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRl c3RzL0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgwMzkxZjgw YWFkLi4yMTYyNDkxNWNjNCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cK KysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0w OC0yMyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtD TWFrZV0gSGF2ZSBjaGVja3MgYXJlIG5vdCBnZXR0aW5nIHNldCBpbnNpZGUgQ01ha2UgcHJvcGVy bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODkw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBu b3RpZmljYXRpb24gdGhhdCBNYWxsb2NCZW5jaCBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIENN YWtlTGlzdHMudHh0OgorCiAyMDE4LTA4LTIzICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRA c29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBBZGQgSEFWRV9NQUxMT0NfVFJJTSBkZWZpbml0 aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3Vy Y2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5kZXggZTE1YjZmZTFlOWQuLjU1ZmRiZDMw YTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKKysrIGIv U291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC0zNjIsMjIgKzM2MiwyMiBAQCBl bmRtYWNybygpCiAKIG1hY3JvKFdFQktJVF9DSEVDS19IQVZFX0lOQ0xVREUgX3ZhcmlhYmxlIF9o ZWFkZXIpCiAgICAgY2hlY2tfaW5jbHVkZV9maWxlKCR7X2hlYWRlcn0gJHtfdmFyaWFibGV9X3Zh bHVlKQotICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKCR7X3ZhcmlhYmxlfSAke192YXJpYWJs ZX1fdmFsdWUpCisgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoJHtfdmFyaWFibGV9ICR7JHtf dmFyaWFibGV9X3ZhbHVlfSkKIGVuZG1hY3JvKCkKIAogbWFjcm8oV0VCS0lUX0NIRUNLX0hBVkVf RlVOQ1RJT04gX3ZhcmlhYmxlIF9mdW5jdGlvbikKICAgICBjaGVja19mdW5jdGlvbl9leGlzdHMo JHtfZnVuY3Rpb259ICR7X3ZhcmlhYmxlfV92YWx1ZSkKLSAgICBTRVRfQU5EX0VYUE9TRV9UT19C VUlMRCgke192YXJpYWJsZX0gJHtfdmFyaWFibGV9X3ZhbHVlKQorICAgIFNFVF9BTkRfRVhQT1NF X1RPX0JVSUxEKCR7X3ZhcmlhYmxlfSAkeyR7X3ZhcmlhYmxlfV92YWx1ZX0pCiBlbmRtYWNybygp CiAKIG1hY3JvKFdFQktJVF9DSEVDS19IQVZFX1NZTUJPTCBfdmFyaWFibGUgX3N5bWJvbCBfaGVh ZGVyKQogICAgIGNoZWNrX3N5bWJvbF9leGlzdHMoJHtfc3ltYm9sfSAke19oZWFkZXJ9ICR7X3Zh cmlhYmxlfV92YWx1ZSkKLSAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRCgke192YXJpYWJsZX0g JHtfdmFyaWFibGV9X3ZhbHVlKQorICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKCR7X3Zhcmlh YmxlfSAkeyR7X3ZhcmlhYmxlfV92YWx1ZX0pCiBlbmRtYWNybygpCiAKIG1hY3JvKFdFQktJVF9D SEVDS19IQVZFX1NUUlVDVCBfdmFyaWFibGUgX3N0cnVjdCBfbWVtYmVyIF9oZWFkZXIpCiAgICAg Y2hlY2tfc3RydWN0X2hhc19tZW1iZXIoJHtfc3RydWN0fSAke19tZW1iZXJ9ICR7X2hlYWRlcn0g JHtfdmFyaWFibGV9X3ZhbHVlKQotICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKCR7X3Zhcmlh YmxlfSAke192YXJpYWJsZX1fdmFsdWUpCisgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoJHtf dmFyaWFibGV9ICR7JHtfdmFyaWFibGV9X3ZhbHVlfSkKIGVuZG1hY3JvKCkKIAogb3B0aW9uKEVO QUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVMgIkVuYWJsZSBleHBlcmltZW50YWwgZmVhdHVyZXMi IE9GRikK