188895 2018-08-23 11:33:35 -0700 YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag 2018-08-23 12:58:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue ews-watchlist keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1453142 0 msaboff 2018-08-23 11:33:35 -0700 There is a slight bug in the RegExp JIT code where we use the m_containsNestedSubpatterns before the JIT compilation has set it. The result is that this limits somewhat the regexps that can take advantage of JIT'ed greedy sub patterns. 1453152 1 347944 msaboff 2018-08-23 11:58:39 -0700 Created attachment 347944 Patch 1453154 2 347944 mark.lam 2018-08-23 12:05:15 -0700 Comment on attachment 347944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347944&action=review r=me > Source/JavaScriptCore/yarr/YarrJIT.cpp:3565 > + codeBlock.setUsesPaternContextBuffer(); nit: "Patern" looks mis-spelled. Maybe fix in a follow up patch since it's not related to this issue. 1453158 3 347944 msaboff 2018-08-23 12:16:22 -0700 Comment on attachment 347944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347944&action=review >> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565 >> + codeBlock.setUsesPaternContextBuffer(); > > nit: "Patern" looks mis-spelled. Maybe fix in a follow up patch since it's not related to this issue. I fixed that in the patch I'm working on. I can factor that out if you like. 1453165 4 mark.lam 2018-08-23 12:42:52 -0700 (In reply to Michael Saboff from comment #3) > Comment on attachment 347944 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347944&action=review > > >> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565 > >> + codeBlock.setUsesPaternContextBuffer(); > > > > nit: "Patern" looks mis-spelled. Maybe fix in a follow up patch since it's not related to this issue. > > I fixed that in the patch I'm working on. I can factor that out if you like. Either works for me. 1453176 5 347944 commit-queue 2018-08-23 12:57:52 -0700 Comment on attachment 347944 Patch Clearing flags on attachment: 347944 Committed r235238: <https://trac.webkit.org/changeset/235238> 1453177 6 commit-queue 2018-08-23 12:57:53 -0700 All reviewed patches have been landed. Closing bug. 1453178 7 webkit-bug-importer 2018-08-23 12:58:18 -0700 <rdar://problem/43654564> 347944 2018-08-23 11:58:39 -0700 2018-08-23 12:57:52 -0700 Patch 188895.patch text/plain 1751 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM1MjMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA4LTIzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFlBUlI6IE5lZWQgdG8gSklUIGNvbXBpbGUgYSBSZWdFeHAgYmVmb3JlIHVzaW5nIGNvbnRh aW5zTmVzdGVkU3VicGF0dGVybnMgZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRm91bmQgd2hpbGUgd29ya2luZyBvbiBhbm90aGVyIGNoYW5nZS4g IFRoaXMgd2lsbCBhbGxvdyBwcm9jZXNzaW5nIG9mIG5lc3RlZAorICAgICAgICBwYXJlbnRoZXNp cyB0aGF0IHJlcXVpcmUgc2F2ZWQgUGFyZW5Db250ZXh0IHN0cnVjdHVyZXMuCisKKyAgICAgICAg KiB5YXJyL1lhcnJKSVQuY3BwOgorICAgICAgICAoSlNDOjpZYXJyOjpZYXJyR2VuZXJhdG9yOjpj b21waWxlKToKKwogMjAxOC0wOC0yMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNv bT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 ODU5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAkocmV2aXNpb24g MjM1MjIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyckpJVC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM1NDUsMTEgKzM1NDUsNiBAQCBwdWJsaWM6CiAgICAgICAgIH0KICNlbmRp ZgogCi0jaWYgRU5BQkxFKFlBUlJfSklUX0FMTF9QQVJFTlNfRVhQUkVTU0lPTlMpCi0gICAgICAg IGlmIChtX2NvbnRhaW5zTmVzdGVkU3VicGF0dGVybnMpCi0gICAgICAgICAgICBjb2RlQmxvY2su c2V0VXNlc1BhdGVybkNvbnRleHRCdWZmZXIoKTsKLSNlbmRpZgotCiAgICAgICAgIC8vIFdlIG5l ZWQgdG8gY29tcGlsZSBiZWZvcmUgZ2VuZXJhdGluZyBjb2RlIHNpbmNlIHdlIHNldCBmbGFncyBi YXNlZCBvbiBjb21waWxhdGlvbiB0aGF0CiAgICAgICAgIC8vIGFyZSB1c2VkIGR1cmluZyBnZW5l cmF0aW9uLgogICAgICAgICBvcENvbXBpbGVCb2R5KG1fcGF0dGVybi5tX2JvZHkpOwpAQCAtMzU2 NSw2ICszNTYwLDExIEBAIHB1YmxpYzoKICAgICAgICAgaWYgKG1fZGlzYXNzZW1ibGVyKQogICAg ICAgICAgICAgbV9kaXNhc3NlbWJsZXItPnNldFN0YXJ0T2ZDb2RlKGxhYmVsKCkpOwogCisjaWYg RU5BQkxFKFlBUlJfSklUX0FMTF9QQVJFTlNfRVhQUkVTU0lPTlMpCisgICAgICAgIGlmIChtX2Nv bnRhaW5zTmVzdGVkU3VicGF0dGVybnMpCisgICAgICAgICAgICBjb2RlQmxvY2suc2V0VXNlc1Bh dGVybkNvbnRleHRCdWZmZXIoKTsKKyNlbmRpZgorCiAgICAgICAgIGdlbmVyYXRlRW50ZXIoKTsK IAogICAgICAgICBKdW1wIGhhc0lucHV0ID0gY2hlY2tJbnB1dCgpOwo=