188891 2018-08-23 10:38:27 -0700 REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent 2018-12-19 17:28:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1453115 0 timothy 2018-08-23 10:38:27 -0700 <rdar://problem/42344352> 1453117 1 webkit-bug-importer 2018-08-23 10:38:45 -0700 <rdar://problem/43648659> 1453118 2 347934 timothy 2018-08-23 10:41:00 -0700 Created attachment 347934 Patch 1453120 3 347934 simon.fraser 2018-08-23 10:41:47 -0700 Comment on attachment 347934 Patch Needs a test. 1460645 4 347934 timothy 2018-09-18 10:41:10 -0700 Comment on attachment 347934 Patch Yesterday and this morning I tried to write an API test for this. I was not able to recreate the bug in the test harness -- only in Mail. In the test runner, rootBackgroundColorOrTransparencyChanged() ends upon getting called with extendedBackgroundColorChanged as true and then false in short succession. So the bad early return was blocking updateRootLayerConfiguration() first, but then ends up getting it scheduled soon after then the color does not change. Maybe you have a suggestion on how to write a test for this, but I'm at a loss. Can we just get this landed? Reverting the bad part of r232991 and returning us to the old behavior of no early return. 1460646 5 timothy 2018-09-18 10:42:11 -0700 Typo fix: "...scheduled soon after when the color does not change." 1460655 6 simon.fraser 2018-09-18 11:11:42 -0700 You should be able to change view transparency in a layout test, then dump the graphics layer tree to show the "contentsOpaque" on the page tile layers (assuming we can dump them. if not, make a way to dump them!). 1460673 7 timothy 2018-09-18 11:48:50 -0700 (In reply to Simon Fraser (smfr) from comment #6) > You should be able to change view transparency in a layout test, then dump > the graphics layer tree to show the "contentsOpaque" on the page tile layers > (assuming we can dump them. if not, make a way to dump them!). That is what I was doing, but with an API test. And it wasn't triggering the problem observed in Mail. 1461086 8 timothy 2018-09-19 12:46:50 -0700 I get the same results in a layout test as I did with the API test -- I can't reproduce the bug. The contentsOpaque flag always get cleared. Before: (GraphicsLayer (anchor 0.00 0.00) (bounds 785.00 1024.00) (children 1 (GraphicsLayer (bounds 785.00 1024.00) (contentsOpaque 1) (tile cache coverage 0, 0 785 x 1024) (tile size 785 x 512) (top left tile 0, 0 tiles grid 1 x 2) (in window 1) ) ) ) After setDrawsBackground(false): (GraphicsLayer (anchor 0.00 0.00) (bounds 785.00 1024.00) (children 1 (GraphicsLayer (bounds 785.00 1024.00) (tile cache coverage 0, 0 785 x 1024) (tile size 785 x 512) (top left tile 0, 0 tiles grid 1 x 2) (in window 1) ) ) ) 1461087 9 timothy 2018-09-19 12:49:40 -0700 My test used an internals.setDrawsBackground(false) that triggers the same code path Mail is using. 1489628 10 347934 commit-queue 2018-12-19 17:28:12 -0800 Comment on attachment 347934 Patch Clearing flags on attachment: 347934 Committed r239414: <https://trac.webkit.org/changeset/239414> 1489629 11 commit-queue 2018-12-19 17:28:14 -0800 All reviewed patches have been landed. Closing bug. 347934 2018-08-23 10:41:00 -0700 2018-12-19 17:28:12 -0800 Patch bug-188891-20180823104100.patch text/plain 2239 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVmMmFlMjBjNDY1ZTQ4 ZDBhNTEzYzU1Zjc2YTQyY2UwNzY3ODc2OC4uNmUyNTZmMWZiNzQzODllMDRkOTliMmY5ZjgwOTk3 MGYwMzI4NjQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTIzICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjMyOTkxKTogU3dpdGNoaW5nIHRvIGRhcmsgbW9kZSBpbiBNYWlsIGRvZXMgbm90IHVwZGF0ZSB0 aGUgbWVzc2FnZSB2aWV3IHRvIGJlIHRyYW5zcGFyZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4OTEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0v NDIzNDQzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyb290QmFja2dyb3VuZENvbG9yT3JUcmFuc3BhcmVu Y3lDaGFuZ2VkKToKKyAgICAgICAgRG9uJ3QgcmV0dXJuIGVhcmx5IHdoZW4gbV9sYXllckZvck92 ZXJoYW5nQXJlYXMgaXMgbnVsbCB0byBhdm9pZCBza2lwcGluZworICAgICAgICBzZXRSb290TGF5 ZXJDb25maWd1cmF0aW9uTmVlZHNVcGRhdGUoKSBhbmQgc2NoZWR1bGVDb21wb3NpdGluZ0xheWVy VXBkYXRlKCkuCisKIDIwMTgtMDgtMjMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgW0F0dGFjaG1lbnQgU3VwcG9ydF0gQXR0YWNobWVudCBlbGVtZW50 cyBkb24ndCBhcHBlYXIgaW4gZHJhZyBpbWFnZXMgb24gbWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggNWIzYWI5OGYw ZjBjMTFhNGVhMjRmMzY2MjM4MDBhMTBhZGQxOWJhMC4uNzQ1NTI1NWYwNTA0MThkYjNkNmM1ODlm MDU1YzRhZjUzZmVlOTM0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTMyMjEsMTMgKzMyMjEsMTIgQEAgdm9pZCBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OnJvb3RCYWNrZ3JvdW5kQ29sb3JPclRyYW5zcGFyZW5jeUNoYW5n ZWQoKQogICAgICAgICBwYWdlKCkuY2hyb21lKCkuY2xpZW50KCkucGFnZUV4dGVuZGVkQmFja2dy b3VuZENvbG9yRGlkQ2hhbmdlKG1fcm9vdEV4dGVuZGVkQmFja2dyb3VuZENvbG9yKTsKICAgICAg ICAgCiAjaWYgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQotICAgICAgICBpZiAoIW1fbGF5ZXJGb3JP dmVyaGFuZ0FyZWFzKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAKLSAgICAgICAgbV9s YXllckZvck92ZXJoYW5nQXJlYXMtPnNldEJhY2tncm91bmRDb2xvcihtX3Jvb3RFeHRlbmRlZEJh Y2tncm91bmRDb2xvcik7Ci0gICAgICAgIAotICAgICAgICBpZiAoIW1fcm9vdEV4dGVuZGVkQmFj a2dyb3VuZENvbG9yLmlzVmFsaWQoKSkKLSAgICAgICAgICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0Fy ZWFzLT5zZXRDdXN0b21BcHBlYXJhbmNlKEdyYXBoaWNzTGF5ZXI6OkN1c3RvbUFwcGVhcmFuY2U6 OlNjcm9sbGluZ092ZXJoYW5nKTsKKyAgICAgICAgaWYgKG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFz KSB7CisgICAgICAgICAgICBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcy0+c2V0QmFja2dyb3VuZENv bG9yKG1fcm9vdEV4dGVuZGVkQmFja2dyb3VuZENvbG9yKTsKKworICAgICAgICAgICAgaWYgKCFt X3Jvb3RFeHRlbmRlZEJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgICAgICAgICAg bV9sYXllckZvck92ZXJoYW5nQXJlYXMtPnNldEN1c3RvbUFwcGVhcmFuY2UoR3JhcGhpY3NMYXll cjo6Q3VzdG9tQXBwZWFyYW5jZTo6U2Nyb2xsaW5nT3ZlcmhhbmcpOworICAgICAgICB9CiAjZW5k aWYKICAgICB9CiAgICAgCg==