188863 2018-08-22 13:58:35 -0700 Remove privateBrowsingEnabled from NetworkProcessCreationParameters 2018-09-13 11:21:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 sihui_liu sihui_liu achristensen oldest_to_newest 1452800 0 sihui_liu 2018-08-22 13:58:35 -0700 We should send a message to network process to create a privateBrowsing session instead of using the creation parameter. 1452801 1 347844 sihui_liu 2018-08-22 14:01:49 -0700 Created attachment 347844 Patch 1453131 2 347844 achristensen 2018-08-23 11:09:40 -0700 Comment on attachment 347844 Patch This doesn't accomplish anything useful except separating a message into two messages. 1453290 3 sihui_liu 2018-08-23 16:16:09 -0700 I was trying to remove the whole networkProcessCreationParameters, aiming to stop the initializing network process from processPool. But it seems we still need to send a lot of setting messages through webprocesspool, so I am not sure if this is a correct idea now... 1453302 4 347844 achristensen 2018-08-23 16:30:57 -0700 Comment on attachment 347844 Patch You only need to remove the NetworkProcessCreationParameters members that come from a WebProcessPool. This one comes from a static function WebPreferences::anyPagesAreUsingPrivateBrowsing 347844 2018-08-22 14:01:49 -0700 2018-08-23 11:09:40 -0700 Patch bug-188863-20180822140148.patch text/plain 5081 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg0MGM2NGU1NzNiNTNkODI0 ZTI5YjVmZmFmYzgxOWZjMTRkMTE5ZWUuLmM1ZjUxMDZkYjEyMTY3M2U0ZTlkYzhmNDM3OTcyYWY5 YTdkOTU0NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMjIgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHByaXZhdGVCcm93c2lu Z0VuYWJsZWQgZnJvbSBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjppbml0 aWFsaXplTmV0d29ya1Byb2Nlc3MpOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1By b2Nlc3NDcmVhdGlvblBhcmFtZXRlcnM6OmVuY29kZSBjb25zdCk6CisgICAgICAgIChXZWJLaXQ6 Ok5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUpOgorICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmg6CisgICAgICAg ICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJv Y2Vzc1Bvb2w6OmVuc3VyZU5ldHdvcmtQcm9jZXNzKToKKwogMjAxOC0wOC0yMiAgU2lodWkgTGl1 ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgcmVtb3ZpbmcgZGVmYXVsdFNl c3Npb25QYXJhbWV0ZXJzIGZyb20gTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3Bw IGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXgg ZDU4MzY3MDc3Zjk2MDA1ZjM5Mjg5ZTU5ZTM1MWVkYjI3NTA3ZGU4Zi4uZDM3ZmNhYmU5MWIyZTI1 YWQwMTVlYTA5ZDE1ODhhOGE0NzViMTQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTI3NiwxMCArMjc2LDYgQEAgdm9pZCBOZXR3 b3JrUHJvY2Vzczo6aW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKE5ldHdvcmtQcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiYKIAogICAgIHNldENhbkhhbmRsZUhUVFBTU2VydmVyVHJ1c3RFdmFsdWF0 aW9uKHBhcmFtZXRlcnMuY2FuSGFuZGxlSFRUUFNTZXJ2ZXJUcnVzdEV2YWx1YXRpb24pOwogCi0g ICAgLy8gRklYTUU6IGluc3RlYWQgb2YgaGFuZGxpbmcgdGhpcyBoZXJlLCBhIG1lc3NhZ2Ugc2hv dWxkIGJlIHNlbnQgbGF0ZXIgKHNjYWxlcyB0byBtdWx0aXBsZSBzZXNzaW9ucykKLSAgICBpZiAo cGFyYW1ldGVycy5wcml2YXRlQnJvd3NpbmdFbmFibGVkKQotICAgICAgICBSZW1vdGVOZXR3b3Jr aW5nQ29udGV4dDo6ZW5zdXJlV2Vic2l0ZURhdGFTdG9yZVNlc3Npb24oV2Vic2l0ZURhdGFTdG9y ZVBhcmFtZXRlcnM6OmxlZ2FjeVByaXZhdGVTZXNzaW9uUGFyYW1ldGVycygpKTsKLQogICAgIGlm IChwYXJhbWV0ZXJzLnNob3VsZFVzZVRlc3RpbmdOZXR3b3JrU2Vzc2lvbikKICAgICAgICAgTmV0 d29ya1N0b3JhZ2VTZXNzaW9uOjpzd2l0Y2hUb05ld1Rlc3RpbmdTZXNzaW9uKCk7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3NDcmVhdGlv blBhcmFtZXRlcnMuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKaW5kZXggY2Q3ZGJhOGU5YTM1OGMzNzhmYTk1NWVj ZGZjMzIzM2Y1YTk5MzA0YS4uNzJhZjRkYzE5ZGIxMjM3ZmQyNGNkYmNiOWY2NTU1YzZlNTY1MzE2 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vz c0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKQEAgLTQxLDcgKzQxLDYgQEAg TmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnM6Ok5ldHdvcmtQcm9jZXNzQ3JlYXRpb25Q YXJhbWV0ZXJzKCkKIAogdm9pZCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZW5j b2RlKElQQzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKIHsKLSAgICBlbmNvZGVyIDw8IHByaXZh dGVCcm93c2luZ0VuYWJsZWQ7CiAgICAgZW5jb2Rlci5lbmNvZGVFbnVtKGNhY2hlTW9kZWwpOwog ICAgIGVuY29kZXIgPDwgZGlza0NhY2hlU2l6ZU92ZXJyaWRlOwogICAgIGVuY29kZXIgPDwgY2Fu SGFuZGxlSFRUUFNTZXJ2ZXJUcnVzdEV2YWx1YXRpb247CkBAIC0xMTIsOCArMTExLDYgQEAgdm9p ZCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2RlKElQQzo6RW5jb2RlciYg ZW5jb2RlcikgY29uc3QKIAogYm9vbCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6 ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2RlciwgTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFt ZXRlcnMmIHJlc3VsdCkKIHsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5wcml2YXRl QnJvd3NpbmdFbmFibGVkKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghZGVjb2Rl ci5kZWNvZGVFbnVtKHJlc3VsdC5jYWNoZU1vZGVsKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LmRpc2tDYWNoZVNpemVPdmVycmlkZSkpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzQ3Jl YXRpb25QYXJhbWV0ZXJzLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgKaW5kZXggNTRlNmFiMDRjNjQzZTJhZGUwZDQ0YjVk ZWE0ZmRmOTFmZWVjZTdlZC4uNjJlODZlYTAyYmZiNGJmMzU5MWM1Nzk1NTJhOWY3NzVjMmUxNjky MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vz c0NyZWF0aW9uUGFyYW1ldGVycy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaApAQCAtNTEsNyArNTEsNiBAQCBzdHJ1 Y3QgTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMgewogICAgIHZvaWQgZW5jb2RlKElQ Qzo6RW5jb2RlciYpIGNvbnN0OwogICAgIHN0YXRpYyBib29sIGRlY29kZShJUEM6OkRlY29kZXIm LCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYpOwogCi0gICAgYm9vbCBwcml2YXRl QnJvd3NpbmdFbmFibGVkIHsgZmFsc2UgfTsKICAgICBDYWNoZU1vZGVsIGNhY2hlTW9kZWwgeyBD YWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXIgfTsKICAgICBpbnQ2NF90IGRpc2tDYWNoZVNpemVPdmVy cmlkZSB7IC0xIH07CiAgICAgYm9vbCBjYW5IYW5kbGVIVFRQU1NlcnZlclRydXN0RXZhbHVhdGlv biB7IHRydWUgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApp bmRleCA5NjVkMzBiN2RmNDE2ZTc1YzExM2IzMjVlZjlmNzUzYzljMWE5OGQ0Li5hNTYxMDJkOGIz MDFhOGM0NTI5NTY2YmFkMWEwZjVkMWI5YjMzMDdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC00OTUsOCArNDk1LDYgQEAgTmV0d29ya1Byb2Nlc3NQ cm94eSYgV2ViUHJvY2Vzc1Bvb2w6OmVuc3VyZU5ldHdvcmtQcm9jZXNzKFdlYnNpdGVEYXRhU3Rv cmUqIHdpdGgKICAgICAgICAgbV93ZWJzaXRlRGF0YVN0b3JlLT53ZWJzaXRlRGF0YVN0b3JlKCku Y2xlYXJQZW5kaW5nQ29va2llcygpOwogICAgIH0KIAotICAgIHBhcmFtZXRlcnMucHJpdmF0ZUJy b3dzaW5nRW5hYmxlZCA9IFdlYlByZWZlcmVuY2VzOjphbnlQYWdlc0FyZVVzaW5nUHJpdmF0ZUJy b3dzaW5nKCk7Ci0KICAgICBwYXJhbWV0ZXJzLmNhY2hlTW9kZWwgPSBjYWNoZU1vZGVsKCk7CiAg ICAgcGFyYW1ldGVycy5kaXNrQ2FjaGVTaXplT3ZlcnJpZGUgPSBtX2NvbmZpZ3VyYXRpb24tPmRp c2tDYWNoZVNpemVPdmVycmlkZSgpOwogICAgIHBhcmFtZXRlcnMuY2FuSGFuZGxlSFRUUFNTZXJ2 ZXJUcnVzdEV2YWx1YXRpb24gPSBtX2NhbkhhbmRsZUhUVFBTU2VydmVyVHJ1c3RFdmFsdWF0aW9u OwpAQCAtNTYxLDYgKzU1OSw5IEBAIE5ldHdvcmtQcm9jZXNzUHJveHkmIFdlYlByb2Nlc3NQb29s OjplbnN1cmVOZXR3b3JrUHJvY2VzcyhXZWJzaXRlRGF0YVN0b3JlKiB3aXRoCiAgICAgICAgIHdp dGhXZWJzaXRlRGF0YVN0b3JlLT5jbGVhclBlbmRpbmdDb29raWVzKCk7CiAgICAgfQogCisgICAg aWYgKFdlYlByZWZlcmVuY2VzOjphbnlQYWdlc0FyZVVzaW5nUHJpdmF0ZUJyb3dzaW5nKCkpCisg ICAgICAgIHNlbmRUb05ldHdvcmtpbmdQcm9jZXNzKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6 QWRkV2Vic2l0ZURhdGFTdG9yZShXZWJzaXRlRGF0YVN0b3JlUGFyYW1ldGVyczo6bGVnYWN5UHJp dmF0ZVNlc3Npb25QYXJhbWV0ZXJzKCkpKTsKKwogICAgIHJldHVybiAqbV9uZXR3b3JrUHJvY2Vz czsKIH0KIAo=