188826 2018-08-21 16:29:06 -0700 Change Selection modification to not snap the grabber when selecting above or below the selection anchor 2018-09-08 15:22:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner ap bdakin commit-queue rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1452386 0 megan_gardner 2018-08-21 16:29:06 -0700 Change Selection modification to not snap the grabber when selecting above or below the selection anchor 1452394 1 347724 megan_gardner 2018-08-21 16:37:06 -0700 Created attachment 347724 Patch 1452395 2 webkit-bug-importer 2018-08-21 16:38:20 -0700 <rdar://problem/43583165> 1452435 3 347724 thorton 2018-08-21 17:15:25 -0700 Comment on attachment 347724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1224 > + IntPoint adjustedPoint(pointInRootViewCoordinates.x(), pointInRootViewCoordinates.y()); Why not just `IntPoint adjustedPoint = pointInRootViewCoordinates`? > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1228 > + int startY = caret.y() + caret.height() / 2; We have center(), maybe use that? 1452437 4 347724 wenson_hsieh 2018-08-21 17:19:54 -0700 Comment on attachment 347724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1242 > + HitTestResult hitTest = frame.eventHandler().hitTestResultAtPoint(adjustedPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowChildFrameContent); adjustedPoint is in root view coordinates, no? 1452439 5 347724 thorton 2018-08-21 17:22:02 -0700 Comment on attachment 347724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1242 >> + HitTestResult hitTest = frame.eventHandler().hitTestResultAtPoint(adjustedPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowChildFrameContent); > > adjustedPoint is in root view coordinates, no? Oops. 1452445 6 347741 megan_gardner 2018-08-21 17:37:34 -0700 Created attachment 347741 Patch for landing 1452479 7 347741 commit-queue 2018-08-21 18:41:56 -0700 Comment on attachment 347741 Patch for landing Clearing flags on attachment: 347741 Committed r235153: <https://trac.webkit.org/changeset/235153> 1452480 8 commit-queue 2018-08-21 18:41:58 -0700 All reviewed patches have been landed. Closing bug. 1453093 9 ap 2018-08-23 09:55:50 -0700 Ryan is fixing layout tests in bug 188888. In the future, please wait for EWS before landing patches. 1457931 10 347741 wenson_hsieh 2018-09-08 15:22:07 -0700 Comment on attachment 347741 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=347741&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1230 > + adjustedPoint.setY(startY); It looks like the caret bounds are in content coordinates, but adjusted point is in root view coordinates? > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1235 > + adjustedPoint.setY(endY); (Here too) 347724 2018-08-21 16:37:06 -0700 2018-08-21 17:37:32 -0700 Patch bug-188826-20180821163706.patch text/plain 7018 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlNGYzMGMwOTFiM2Y2OGQ2 YmRiZjdlYmY0ZGU5NmE2Mzc5ZjZiOGQuLjk4MWJjMmZhNjI3ODY3MDI2ZGQ2ZDA1MTVhOGIzNWRk MTg5MWI4NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMjEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgU2VsZWN0 aW9uIG1vZGlmaWNhdGlvbiB0byBub3Qgc25hcCB0aGUgZ3JhYmJlciB3aGVuIHNlbGVjdGluZyBh Ym92ZSBvciBiZWxvdyB0aGUgc2VsZWN0aW9uIGFuY2hvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW5nIHNpbmdsZSBsaW5lcyBpcyBzb21l dGltZXMgZGlmZmljdWx0IGJlY2F1c2Ugd2UgY3VycmVudGx5IHNuYXAgc2VsZWN0aW9ucyB0byBz aW5nbGUKKyAgICAgICAgY2hhcmFjdGVycyBpZiB3ZSBtb3ZlIHBhc3QgdGhlIHBvc2l0aW9uIG9m IHRoZSBvdGhlciBhbmNob3IgaW4gb3VyIHNlbGVjdGlvbi4gVGhpcyBwYXRjaCBjaGFuZ2VzCisg ICAgICAgIHRoaXMgYmVoYXZpb3VyIHRvIHJlZmxlY3QgdGhlIGJlaGF2aW91ciBpbiB0aGUgcmVz dCBvZiB0aGlzIHN5c3RlbSwgd2hpY2ggc25hcHMgdGhlIHNlbGVjdGlvbgorICAgICAgICB0byB0 aGUgcG9zaXRpb24gb24gdGhlIGxpbmUgb2YgdGhlIG90aGVyIGFuY2hvciwgcmF0aGVyIHRoYW4g c25hcHBpbmcgaXQgYWxsIHRoZSB3YXkgYSBzaW5nbGUKKyAgICAgICAgY2hhcmFjdGVyLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAo V2ViS2l0OjpyYW5nZUZvclBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzKToKKwogMjAxOC0wOC0y MSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVz ZSBWaXNpYmxlUG9zaXRpb24gdG8gY2FsY3VsYXRlIHNlbGVjdGlvbiByYW5nZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXgg MDMwMTEzZjY1YWYwYTdkY2U4ZjkxMTczNmNlZGYwMGZlYjZmYWRkZC4uZmFjYWU5YjhiNDE0MWFm ODQwOTdlYTBmN2M4MjExZjQxNWUxMGY2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTEyMTcsMjAgKzEyMTcsMzQgQEAg dm9pZCBXZWJQYWdlOjpzZWxlY3RXaXRoR2VzdHVyZShjb25zdCBJbnRQb2ludCYgcG9pbnQsIHVp bnQzMl90IGdyYW51bGFyaXR5LCB1aW4KIAogc3RhdGljIFJlZlB0cjxSYW5nZT4gcmFuZ2VGb3JQ b2ludEluUm9vdFZpZXdDb29yZGluYXRlcyhGcmFtZSYgZnJhbWUsIGNvbnN0IEludFBvaW50JiBw b2ludEluUm9vdFZpZXdDb29yZGluYXRlcywgYm9vbCBiYXNlSXNTdGFydCkKIHsKLSAgICBJbnRQ b2ludCBwb2ludEluRG9jdW1lbnQgPSBmcmFtZS52aWV3KCktPnJvb3RWaWV3VG9Db250ZW50cyhw b2ludEluUm9vdFZpZXdDb29yZGluYXRlcyk7CisgICAgVmlzaWJsZVNlbGVjdGlvbiBleGlzdGlu Z1NlbGVjdGlvbiA9IGZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigpOworICAgIFZpc2libGVQ b3NpdGlvbiBzZWxlY3Rpb25TdGFydCA9IGV4aXN0aW5nU2VsZWN0aW9uLnZpc2libGVTdGFydCgp OworICAgIFZpc2libGVQb3NpdGlvbiBzZWxlY3Rpb25FbmQgPSBleGlzdGluZ1NlbGVjdGlvbi52 aXNpYmxlRW5kKCk7CisgICAgCisgICAgSW50UG9pbnQgYWRqdXN0ZWRQb2ludChwb2ludEluUm9v dFZpZXdDb29yZGluYXRlcy54KCksIHBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzLnkoKSk7Cisg ICAgCisgICAgaWYgKGJhc2VJc1N0YXJ0KSB7CisgICAgICAgIEludFJlY3QgY2FyZXQgPSBleGlz dGluZ1NlbGVjdGlvbi52aXNpYmxlU3RhcnQoKS5hYnNvbHV0ZUNhcmV0Qm91bmRzKCk7CisgICAg ICAgIGludCBzdGFydFkgPSBjYXJldC55KCkgKyBjYXJldC5oZWlnaHQoKSAvIDI7CisgICAgICAg IGlmIChhZGp1c3RlZFBvaW50LnkoKSA8IHN0YXJ0WSkKKyAgICAgICAgICAgIGFkanVzdGVkUG9p bnQuc2V0WShzdGFydFkpOworICAgIH0gZWxzZSB7CisgICAgICAgIEludFJlY3QgY2FyZXQgPSBl eGlzdGluZ1NlbGVjdGlvbi52aXNpYmxlRW5kKCkuYWJzb2x1dGVDYXJldEJvdW5kcygpOworICAg ICAgICBpbnQgZW5kWSA9IGNhcmV0LnkoKSArIGNhcmV0LmhlaWdodCgpIC8gMjsKKyAgICAgICAg aWYgKGFkanVzdGVkUG9pbnQueSgpID4gZW5kWSkKKyAgICAgICAgICAgIGFkanVzdGVkUG9pbnQu c2V0WShlbmRZKTsKKyAgICB9CisgICAgCisgICAgSW50UG9pbnQgcG9pbnRJbkRvY3VtZW50ID0g ZnJhbWUudmlldygpLT5yb290Vmlld1RvQ29udGVudHMoYWRqdXN0ZWRQb2ludCk7CiAgICAgVmlz aWJsZVBvc2l0aW9uIHJlc3VsdDsKICAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlOwogICAgIAotICAg IEhpdFRlc3RSZXN1bHQgaGl0VGVzdCA9IGZyYW1lLmV2ZW50SGFuZGxlcigpLmhpdFRlc3RSZXN1 bHRBdFBvaW50KHBvaW50SW5Eb2N1bWVudCwgSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5IHwgSGl0 VGVzdFJlcXVlc3Q6OkFjdGl2ZSB8IEhpdFRlc3RSZXF1ZXN0OjpBbGxvd0NoaWxkRnJhbWVDb250 ZW50KTsKKyAgICBIaXRUZXN0UmVzdWx0IGhpdFRlc3QgPSBmcmFtZS5ldmVudEhhbmRsZXIoKS5o aXRUZXN0UmVzdWx0QXRQb2ludChhZGp1c3RlZFBvaW50LCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9u bHkgfCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlIHwgSGl0VGVzdFJlcXVlc3Q6OkFsbG93Q2hpbGRG cmFtZUNvbnRlbnQpOwogICAgIGlmIChoaXRUZXN0LnRhcmdldE5vZGUoKSkKICAgICAgICAgcmVz dWx0ID0gZnJhbWUuZXZlbnRIYW5kbGVyKCkuc2VsZWN0aW9uRXh0ZW50UmVzcGVjdGluZ0VkaXRp bmdCb3VuZGFyeShmcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKSwgaGl0VGVzdC5sb2NhbFBv aW50KCksIGhpdFRlc3QudGFyZ2V0Tm9kZSgpKS5kZWVwRXF1aXZhbGVudCgpOwogICAgIGVsc2UK ICAgICAgICAgcmVzdWx0ID0gZnJhbWUudmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQocG9pbnRJbkRv Y3VtZW50KS5kZWVwRXF1aXZhbGVudCgpOwogICAgIAotICAgIFZpc2libGVTZWxlY3Rpb24gZXhp c3RpbmdTZWxlY3Rpb24gPSBmcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKTsKLSAgICBWaXNp YmxlUG9zaXRpb24gc2VsZWN0aW9uU3RhcnQgPSBleGlzdGluZ1NlbGVjdGlvbi52aXNpYmxlU3Rh cnQoKTsKLSAgICBWaXNpYmxlUG9zaXRpb24gc2VsZWN0aW9uRW5kID0gZXhpc3RpbmdTZWxlY3Rp b24udmlzaWJsZUVuZCgpOwotICAgIAogICAgIGlmIChiYXNlSXNTdGFydCkgewogICAgICAgICBp ZiAoY29tcGFyZVBvc2l0aW9ucyhyZXN1bHQsIHNlbGVjdGlvblN0YXJ0KSA8PSAwKQogICAgICAg ICAgICAgcmVzdWx0ID0gc2VsZWN0aW9uU3RhcnQubmV4dCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI1NGY4OWVjOWVj MTE2MDVjY2NhYWE1ZmUwMzViZDQwMGNiYTc2ZjcuLmViOGNlN2RlYzAyNThjOGQxOTk5NTA2YTQy NTRmNTkzNGU1OTE1YzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0wOC0yMSAgTWVnYW4g R2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBTZWxl Y3Rpb24gbW9kaWZpY2F0aW9uIHRvIG5vdCBzbmFwIHRoZSBncmFiYmVyIHdoZW4gc2VsZWN0aW5n IGFib3ZlIG9yIGJlbG93IHRoZSBzZWxlY3Rpb24gYW5jaG9yCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg4MjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWxlY3Rpbmcgc2luZ2xlIGxpbmVzIGlzIHNv bWV0aW1lcyBkaWZmaWN1bHQgYmVjYXVzZSB3ZSBjdXJyZW50bHkgc25hcCBzZWxlY3Rpb25zIHRv IHNpbmdsZQorICAgICAgICBjaGFyYWN0ZXJzIGlmIHdlIG1vdmUgcGFzdCB0aGUgcG9zaXRpb24g b2YgdGhlIG90aGVyIGFuY2hvciBpbiBvdXIgc2VsZWN0aW9uLiBUaGlzIHBhdGNoIGNoYW5nZXMK KyAgICAgICAgdGhpcyBiZWhhdmlvdXIgdG8gcmVmbGVjdCB0aGUgYmVoYXZpb3VyIGluIHRoZSBy ZXN0IG9mIHRoaXMgc3lzdGVtLCB3aGljaCBzbmFwcyB0aGUgc2VsZWN0aW9uCisgICAgICAgIHRv IHRoZSBwb3NpdGlvbiBvbiB0aGUgbGluZSBvZiB0aGUgb3RoZXIgYW5jaG9yLCByYXRoZXIgdGhh biBzbmFwcGluZyBpdCBhbGwgdGhlIHdheSBhIHNpbmdsZQorICAgICAgICBjaGFyYWN0ZXIuIFRo aXMgdXBkYXRlcyB0aGUgdGVzdHMgdG8gcmVmbGVjdCB0aGlzIG5ldyBiZWhhdmlvdXIuCisKKyAg ICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctZG93bi10 by1jaGFuZ2Utc2VsZWN0ZWQtdGV4dC5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL3RvdWNo L2lvcy9sb25nLXByZXNzLXRoZW4tZHJhZy11cC10by1jaGFuZ2Utc2VsZWN0ZWQtdGV4dC5odG1s OgorCiAyMDE4LTA4LTIxICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5v cmc+CiAKICAgICAgICAgU3VwcG9ydCAibmFtZSIgb3B0aW9uIGZvciBkZWRpY2F0ZWQgd29ya2Vy cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJl c3MtdGhlbi1kcmFnLWRvd24tdG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9sb25nLXByZXNzLXRoZW4tZHJhZy1kb3duLXRvLWNo YW5nZS1zZWxlY3RlZC10ZXh0Lmh0bWwKaW5kZXggYjk4ZDdjMTgzZTIxYjIxMGYzNDQ1MmQyNmJl Njk4ZGFiODQ1YWE0ZC4uZGMxMjRmMDk3MmZhZjRmYTExZjdkMGQyYzMwZDJiYzdjYzIyZDdjYyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3Mt dGhlbi1kcmFnLWRvd24tdG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctZG93bi10by1j aGFuZ2Utc2VsZWN0ZWQtdGV4dC5odG1sCkBAIC02Myw3ICs2Myw3IEBACiAgICAgICAgICAgICBv dXRwdXQgKz0gJzxicj4nOwogCiAgICAgICAgICAgICB2YXIgcmVzdWx0ID0gYXdhaXQgdG91Y2hB bmREcmFnRnJvbVBvaW50VG9Qb2ludChkcmFnWCwgZHJhZ1ksIGRyYWdYLCBkcmFnWTQpOwotICAg ICAgICAgICAgaWYgKGRvY3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgPT0gInMiKQor ICAgICAgICAgICAgaWYgKGRvY3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgPT0gInNl ZCIpCiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdQQVNTOiBDb3JyZWN0IFNlbGVjdGlvbic7 CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdGQUlMOiBmYWls ZWQgdG8gcmVkdWNlIHNlbGVjdGlvbiB0byBhIHNpbmdsZSBjaGFyYWN0ZXIgYnkgZHJhZ2dpbmcg dXAuIEluY29ycmVjdCBTZWxlY3Rpb246ICcgKyBkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0 cmluZygpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xv bmctcHJlc3MtdGhlbi1kcmFnLXVwLXRvLWNoYW5nZS1zZWxlY3RlZC10ZXh0Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctdXAtdG8t Y2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbAppbmRleCAxOTNlZGRmY2Y4MDUzMWNhOTcyZWViOTYx NWNhYTZjMjFjYTY3ZDgzLi4xZjI4OWZmNDFjZWY3NGQ2YTIyOWNlZTI3YzMwNjI5YzkxZTI5YTRl IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVz cy10aGVuLWRyYWctdXAtdG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctdXAtdG8tY2hh bmdlLXNlbGVjdGVkLXRleHQuaHRtbApAQCAtNjMsNyArNjMsNyBAQAogICAgICAgICAgICAgb3V0 cHV0ICs9ICc8YnI+JzsKIAogICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGF3YWl0IHRvdWNoQW5k RHJhZ0Zyb21Qb2ludFRvUG9pbnQoZHJhZ1gsIGRyYWdZLCBkcmFnWCwgZHJhZ1k0KTsKLSAgICAg ICAgICAgIGlmIChkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpID09ICJ0IikKKyAg ICAgICAgICAgIGlmIChkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpID09ICJ1dCIp CiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdQQVNTOiBDb3JyZWN0IFNlbGVjdGlvbic7CiAg ICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdGQUlMOiBmYWlsZWQg dG8gcmVkdWNlIHNlbGVjdGlvbiB0byBhIHNpbmdsZSBjaGFyYWN0ZXIgYnkgZHJhZ2dpbmcgZG93 bi4gSW5jb3JyZWN0IFNlbGVjdGlvbjogJyArIGRvY3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3Ry aW5nKCk7Cg== 347741 2018-08-21 17:37:34 -0700 2018-08-21 18:41:56 -0700 Patch for landing bug-188826-20180821173733.patch text/plain 6490 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlNGYzMGMwOTFiM2Y2OGQ2 YmRiZjdlYmY0ZGU5NmE2Mzc5ZjZiOGQuLjNjOTJhNWQ5N2FlNzU4NTBmYThhMzRkMjhhYTgwYmEw NjQ1Zjc1NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMjEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgU2VsZWN0 aW9uIG1vZGlmaWNhdGlvbiB0byBub3Qgc25hcCB0aGUgZ3JhYmJlciB3aGVuIHNlbGVjdGluZyBh Ym92ZSBvciBiZWxvdyB0aGUgc2VsZWN0aW9uIGFuY2hvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg VGltIEhvcnRvbi4KKworICAgICAgICBTZWxlY3Rpbmcgc2luZ2xlIGxpbmVzIGlzIHNvbWV0aW1l cyBkaWZmaWN1bHQgYmVjYXVzZSB3ZSBjdXJyZW50bHkgc25hcCBzZWxlY3Rpb25zIHRvIHNpbmds ZQorICAgICAgICBjaGFyYWN0ZXJzIGlmIHdlIG1vdmUgcGFzdCB0aGUgcG9zaXRpb24gb2YgdGhl IG90aGVyIGFuY2hvciBpbiBvdXIgc2VsZWN0aW9uLiBUaGlzIHBhdGNoIGNoYW5nZXMKKyAgICAg ICAgdGhpcyBiZWhhdmlvdXIgdG8gcmVmbGVjdCB0aGUgYmVoYXZpb3VyIGluIHRoZSByZXN0IG9m IHRoaXMgc3lzdGVtLCB3aGljaCBzbmFwcyB0aGUgc2VsZWN0aW9uCisgICAgICAgIHRvIHRoZSBw b3NpdGlvbiBvbiB0aGUgbGluZSBvZiB0aGUgb3RoZXIgYW5jaG9yLCByYXRoZXIgdGhhbiBzbmFw cGluZyBpdCBhbGwgdGhlIHdheSBhIHNpbmdsZQorICAgICAgICBjaGFyYWN0ZXIuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJL aXQ6OnJhbmdlRm9yUG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMpOgorCiAyMDE4LTA4LTIxICBN ZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFZp c2libGVQb3NpdGlvbiB0byBjYWxjdWxhdGUgc2VsZWN0aW9uIHJhbmdlcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCAwMzAx MTNmNjVhZjBhN2RjZThmOTExNzM2Y2VkZjAwZmViNmZhZGRkLi5iMDIzNTEzNGQwN2MwNzMxYmRm ZjQ4NDRmZmE4M2ZkZDcyNzcxZWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMTIxNyw3ICsxMjE3LDI1IEBAIHZvaWQg V2ViUGFnZTo6c2VsZWN0V2l0aEdlc3R1cmUoY29uc3QgSW50UG9pbnQmIHBvaW50LCB1aW50MzJf dCBncmFudWxhcml0eSwgdWluCiAKIHN0YXRpYyBSZWZQdHI8UmFuZ2U+IHJhbmdlRm9yUG9pbnRJ blJvb3RWaWV3Q29vcmRpbmF0ZXMoRnJhbWUmIGZyYW1lLCBjb25zdCBJbnRQb2ludCYgcG9pbnRJ blJvb3RWaWV3Q29vcmRpbmF0ZXMsIGJvb2wgYmFzZUlzU3RhcnQpCiB7Ci0gICAgSW50UG9pbnQg cG9pbnRJbkRvY3VtZW50ID0gZnJhbWUudmlldygpLT5yb290Vmlld1RvQ29udGVudHMocG9pbnRJ blJvb3RWaWV3Q29vcmRpbmF0ZXMpOworICAgIFZpc2libGVTZWxlY3Rpb24gZXhpc3RpbmdTZWxl Y3Rpb24gPSBmcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKTsKKyAgICBWaXNpYmxlUG9zaXRp b24gc2VsZWN0aW9uU3RhcnQgPSBleGlzdGluZ1NlbGVjdGlvbi52aXNpYmxlU3RhcnQoKTsKKyAg ICBWaXNpYmxlUG9zaXRpb24gc2VsZWN0aW9uRW5kID0gZXhpc3RpbmdTZWxlY3Rpb24udmlzaWJs ZUVuZCgpOworICAgIAorICAgIEludFBvaW50IGFkanVzdGVkUG9pbnQgPSBwb2ludEluUm9vdFZp ZXdDb29yZGluYXRlczsKKyAgICAKKyAgICBpZiAoYmFzZUlzU3RhcnQpIHsKKyAgICAgICAgSW50 UmVjdCBjYXJldCA9IGV4aXN0aW5nU2VsZWN0aW9uLnZpc2libGVTdGFydCgpLmFic29sdXRlQ2Fy ZXRCb3VuZHMoKTsKKyAgICAgICAgaW50IHN0YXJ0WSA9IGNhcmV0LmNlbnRlcigpLnkoKTsKKyAg ICAgICAgaWYgKGFkanVzdGVkUG9pbnQueSgpIDwgc3RhcnRZKQorICAgICAgICAgICAgYWRqdXN0 ZWRQb2ludC5zZXRZKHN0YXJ0WSk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgSW50UmVjdCBjYXJl dCA9IGV4aXN0aW5nU2VsZWN0aW9uLnZpc2libGVFbmQoKS5hYnNvbHV0ZUNhcmV0Qm91bmRzKCk7 CisgICAgICAgIGludCBlbmRZID0gY2FyZXQuY2VudGVyKCkueSgpOworICAgICAgICBpZiAoYWRq dXN0ZWRQb2ludC55KCkgPiBlbmRZKQorICAgICAgICAgICAgYWRqdXN0ZWRQb2ludC5zZXRZKGVu ZFkpOworICAgIH0KKyAgICAKKyAgICBJbnRQb2ludCBwb2ludEluRG9jdW1lbnQgPSBmcmFtZS52 aWV3KCktPnJvb3RWaWV3VG9Db250ZW50cyhhZGp1c3RlZFBvaW50KTsKICAgICBWaXNpYmxlUG9z aXRpb24gcmVzdWx0OwogICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2U7CiAgICAgCkBAIC0xMjI3LDEw ICsxMjQ1LDYgQEAgc3RhdGljIFJlZlB0cjxSYW5nZT4gcmFuZ2VGb3JQb2ludEluUm9vdFZpZXdD b29yZGluYXRlcyhGcmFtZSYgZnJhbWUsIGNvbnN0IEludFAKICAgICBlbHNlCiAgICAgICAgIHJl c3VsdCA9IGZyYW1lLnZpc2libGVQb3NpdGlvbkZvclBvaW50KHBvaW50SW5Eb2N1bWVudCkuZGVl cEVxdWl2YWxlbnQoKTsKICAgICAKLSAgICBWaXNpYmxlU2VsZWN0aW9uIGV4aXN0aW5nU2VsZWN0 aW9uID0gZnJhbWUuc2VsZWN0aW9uKCkuc2VsZWN0aW9uKCk7Ci0gICAgVmlzaWJsZVBvc2l0aW9u IHNlbGVjdGlvblN0YXJ0ID0gZXhpc3RpbmdTZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCk7Ci0gICAg VmlzaWJsZVBvc2l0aW9uIHNlbGVjdGlvbkVuZCA9IGV4aXN0aW5nU2VsZWN0aW9uLnZpc2libGVF bmQoKTsKLSAgICAKICAgICBpZiAoYmFzZUlzU3RhcnQpIHsKICAgICAgICAgaWYgKGNvbXBhcmVQ b3NpdGlvbnMocmVzdWx0LCBzZWxlY3Rpb25TdGFydCkgPD0gMCkKICAgICAgICAgICAgIHJlc3Vs dCA9IHNlbGVjdGlvblN0YXJ0Lm5leHQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiNTRmODllYzllYzExNjA1Y2NjYWFh NWZlMDM1YmQ0MDBjYmE3NmY3Li43ZjE5YjYxNzI1MTE2ODgxYzFiMmNiNWRiNDkyMTZmNjk2MWZl MTY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMjEgIE1lZ2FuIEdhcmRuZXIgIDxt ZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgU2VsZWN0aW9uIG1vZGlm aWNhdGlvbiB0byBub3Qgc25hcCB0aGUgZ3JhYmJlciB3aGVuIHNlbGVjdGluZyBhYm92ZSBvciBi ZWxvdyB0aGUgc2VsZWN0aW9uIGFuY2hvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg4ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRv bi4KKworICAgICAgICBTZWxlY3Rpbmcgc2luZ2xlIGxpbmVzIGlzIHNvbWV0aW1lcyBkaWZmaWN1 bHQgYmVjYXVzZSB3ZSBjdXJyZW50bHkgc25hcCBzZWxlY3Rpb25zIHRvIHNpbmdsZQorICAgICAg ICBjaGFyYWN0ZXJzIGlmIHdlIG1vdmUgcGFzdCB0aGUgcG9zaXRpb24gb2YgdGhlIG90aGVyIGFu Y2hvciBpbiBvdXIgc2VsZWN0aW9uLiBUaGlzIHBhdGNoIGNoYW5nZXMKKyAgICAgICAgdGhpcyBi ZWhhdmlvdXIgdG8gcmVmbGVjdCB0aGUgYmVoYXZpb3VyIGluIHRoZSByZXN0IG9mIHRoaXMgc3lz dGVtLCB3aGljaCBzbmFwcyB0aGUgc2VsZWN0aW9uCisgICAgICAgIHRvIHRoZSBwb3NpdGlvbiBv biB0aGUgbGluZSBvZiB0aGUgb3RoZXIgYW5jaG9yLCByYXRoZXIgdGhhbiBzbmFwcGluZyBpdCBh bGwgdGhlIHdheSBhIHNpbmdsZQorICAgICAgICBjaGFyYWN0ZXIuIFRoaXMgdXBkYXRlcyB0aGUg dGVzdHMgdG8gcmVmbGVjdCB0aGlzIG5ldyBiZWhhdmlvdXIuCisKKyAgICAgICAgKiBmYXN0L2V2 ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctZG93bi10by1jaGFuZ2Utc2VsZWN0 ZWQtdGV4dC5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL3RvdWNoL2lvcy9sb25nLXByZXNz LXRoZW4tZHJhZy11cC10by1jaGFuZ2Utc2VsZWN0ZWQtdGV4dC5odG1sOgorCiAyMDE4LTA4LTIx ICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAg U3VwcG9ydCAibmFtZSIgb3B0aW9uIGZvciBkZWRpY2F0ZWQgd29ya2VycwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3MtdGhlbi1kcmFnLWRv d24tdG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3RvdWNoL2lvcy9sb25nLXByZXNzLXRoZW4tZHJhZy1kb3duLXRvLWNoYW5nZS1zZWxlY3RlZC10 ZXh0Lmh0bWwKaW5kZXggYjk4ZDdjMTgzZTIxYjIxMGYzNDQ1MmQyNmJlNjk4ZGFiODQ1YWE0ZC4u ZGMxMjRmMDk3MmZhZjRmYTExZjdkMGQyYzMwZDJiYzdjYzIyZDdjYyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3MtdGhlbi1kcmFnLWRvd24t dG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctZG93bi10by1jaGFuZ2Utc2VsZWN0ZWQt dGV4dC5odG1sCkBAIC02Myw3ICs2Myw3IEBACiAgICAgICAgICAgICBvdXRwdXQgKz0gJzxicj4n OwogCiAgICAgICAgICAgICB2YXIgcmVzdWx0ID0gYXdhaXQgdG91Y2hBbmREcmFnRnJvbVBvaW50 VG9Qb2ludChkcmFnWCwgZHJhZ1ksIGRyYWdYLCBkcmFnWTQpOwotICAgICAgICAgICAgaWYgKGRv Y3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgPT0gInMiKQorICAgICAgICAgICAgaWYg KGRvY3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgPT0gInNlZCIpCiAgICAgICAgICAg ICAgICAgb3V0cHV0ICs9ICdQQVNTOiBDb3JyZWN0IFNlbGVjdGlvbic7CiAgICAgICAgICAgICBl bHNlCiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdGQUlMOiBmYWlsZWQgdG8gcmVkdWNlIHNl bGVjdGlvbiB0byBhIHNpbmdsZSBjaGFyYWN0ZXIgYnkgZHJhZ2dpbmcgdXAuIEluY29ycmVjdCBT ZWxlY3Rpb246ICcgKyBkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2xvbmctcHJlc3MtdGhlbi1k cmFnLXVwLXRvLWNoYW5nZS1zZWxlY3RlZC10ZXh0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctdXAtdG8tY2hhbmdlLXNlbGVjdGVk LXRleHQuaHRtbAppbmRleCAxOTNlZGRmY2Y4MDUzMWNhOTcyZWViOTYxNWNhYTZjMjFjYTY3ZDgz Li4xZjI4OWZmNDFjZWY3NGQ2YTIyOWNlZTI3YzMwNjI5YzkxZTI5YTRlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctdXAt dG8tY2hhbmdlLXNlbGVjdGVkLXRleHQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy90b3VjaC9pb3MvbG9uZy1wcmVzcy10aGVuLWRyYWctdXAtdG8tY2hhbmdlLXNlbGVjdGVkLXRl eHQuaHRtbApAQCAtNjMsNyArNjMsNyBAQAogICAgICAgICAgICAgb3V0cHV0ICs9ICc8YnI+JzsK IAogICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGF3YWl0IHRvdWNoQW5kRHJhZ0Zyb21Qb2ludFRv UG9pbnQoZHJhZ1gsIGRyYWdZLCBkcmFnWCwgZHJhZ1k0KTsKLSAgICAgICAgICAgIGlmIChkb2N1 bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpID09ICJ0IikKKyAgICAgICAgICAgIGlmIChk b2N1bWVudC5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpID09ICJ1dCIpCiAgICAgICAgICAgICAg ICAgb3V0cHV0ICs9ICdQQVNTOiBDb3JyZWN0IFNlbGVjdGlvbic7CiAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgb3V0cHV0ICs9ICdGQUlMOiBmYWlsZWQgdG8gcmVkdWNlIHNlbGVj dGlvbiB0byBhIHNpbmdsZSBjaGFyYWN0ZXIgYnkgZHJhZ2dpbmcgZG93bi4gSW5jb3JyZWN0IFNl bGVjdGlvbjogJyArIGRvY3VtZW50LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCk7Cg==