188801 2018-08-21 11:52:06 -0700 Web Inspector: `console.inspect(sessionStorage)` first time does not show Session Storage content view if Storage tab was previously unvisited 2018-08-23 13:21:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1452188 0 joepeck 2018-08-21 11:52:06 -0700 `console.inspect(sessionStorage)` first time does not show Session Storage content view if Storage tab was previously unvisited Steps to Reproduce: 1. Inspect this page 2. Show Elements Tab (having not shown Storage Tab) 3. js> inspect(sessionStorage) => Expected Storage Tab to be shown with the Session Storage selected Regression: Probably a long ago one. Maybe lazy tab construction? 1453126 1 347937 hi 2018-08-23 11:00:25 -0700 Created attachment 347937 Patch 1453138 2 347937 mattbaker 2018-08-23 11:22:48 -0700 Comment on attachment 347937 Patch r=me 1453193 3 347937 commit-queue 2018-08-23 13:20:23 -0700 Comment on attachment 347937 Patch Clearing flags on attachment: 347937 Committed r235242: <https://trac.webkit.org/changeset/235242> 1453194 4 commit-queue 2018-08-23 13:20:24 -0700 All reviewed patches have been landed. Closing bug. 1453196 5 webkit-bug-importer 2018-08-23 13:21:48 -0700 <rdar://problem/43655286> 347937 2018-08-23 11:00:25 -0700 2018-08-23 13:20:23 -0700 Patch bug-188801-20180823120023.patch text/plain 2862 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkNmI4NjViNWI2YTcyNzViNTJkMmNhYjQxMGI2 ZTRhY2I2YjYzMjcuLmQyNDJiYmJlNThhY2I3YjkwMDc2ZGNkMjYzMjgyOWQyOTMxMjFmODggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA4LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBg Y29uc29sZS5pbnNwZWN0KHNlc3Npb25TdG9yYWdlKWAgZmlyc3QgdGltZSBkb2VzIG5vdCBzaG93 IFNlc3Npb24gU3RvcmFnZSBjb250ZW50IHZpZXcgaWYgU3RvcmFnZSB0YWIgd2FzIHByZXZpb3Vz bHkgdW52aXNpdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODg4MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kudGFiQ29udGVu dFZpZXdDbGFzc0ZvclJlcHJlc2VudGVkT2JqZWN0KToKKyAgICAgICAgKFdJLl9zdG9yYWdlV2Fz SW5zcGVjdGVkKToKKyAgICAgICAgU2luY2UgdGhlIGBXSS5TdG9yYWdlU2lkZWJhclBhbmVsYCBp cyBub3QgY3JlYXRlZCB1bnRpbCB0aGUgYFdJLlN0b3JhZ2VUYWJDb250ZW50Vmlld2AgaXMKKyAg ICAgICAgY3JlYXRlZCwgdGhlIGBXSS5TdG9yYWdlTWFuYWdlci5FdmVudC5ET01TdG9yYWdlT2Jq ZWN0V2FzSW5zcGVjdGVkYCBhbmQKKyAgICAgICAgYFdJLlN0b3JhZ2VNYW5hZ2VyLkV2ZW50LkRh dGFiYXNlV2FzSW5zcGVjdGVkYCBldmVudHMgZG8gbm90IHJlYWNoIHRoZSBzaWRlYmFyLiBXZSBz aG91bGQKKyAgICAgICAgZm9sbG93IHdoYXQgYFdJLl9kb21Ob2RlV2FzSW5zcGVjdGVkYCBkb2Vz IGFuZCBhZGRpdGlvbmFsbHkgY2FsbCBgV0kuc2hvd1JlcHJlc2VudGVkT2JqZWN0YAorICAgICAg ICBvbiB0aGUgaW5zcGVjdGVkIG9iamVjdC4KKwogMjAxOC0wOC0yMSAgTWF0dCBCYWtlciAgPG1h dHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIFRyZWVP dXRsaW5lRGF0YUdyaWRTeW5jaHJvbml6ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCBjZDJlOGE1MjZlNzFkMTE5ZmE1ZWQ1Mzc4 MmNmNjVhMzMzMGM2ZDA4Li5iYzgxZDlkOTBiZjRhNWYxZDZjYzBlMWQxNDQ4NjYzYTQ0ZTUxMzA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzCkBAIC0xMTIxLDEyICsxMTIxLDExIEBAIFdJLnRhYkNvbnRlbnRWaWV3Q2xhc3NGb3JSZXBy ZXNlbnRlZE9iamVjdCA9IGZ1bmN0aW9uKHJlcHJlc2VudGVkT2JqZWN0KQogICAgICAgICB8fCAo cmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXSS5Db2xsZWN0aW9uICYmICEocmVwcmVzZW50 ZWRPYmplY3QgaW5zdGFuY2VvZiBXSS5DYW52YXNDb2xsZWN0aW9uKSkpCiAgICAgICAgIHJldHVy biBXSS5SZXNvdXJjZXNUYWJDb250ZW50VmlldzsKIAotICAgIC8vIEZJWE1FOiBNb3ZlIHRoZXNl IHRvIGEgU3RvcmFnZSB0YWIuCiAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2Yg V0kuRE9NU3RvcmFnZU9iamVjdCB8fCByZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdJLkNv b2tpZVN0b3JhZ2VPYmplY3QgfHwKICAgICAgICAgcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXSS5EYXRhYmFzZVRhYmxlT2JqZWN0IHx8IHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2Yg V0kuRGF0YWJhc2VPYmplY3QgfHwKICAgICAgICAgcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXSS5BcHBsaWNhdGlvbkNhY2hlRnJhbWUgfHwgcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXSS5JbmRleGVkRGF0YWJhc2VPYmplY3RTdG9yZSB8fAotICAgICAgICByZXByZXNlbnRlZE9i amVjdCBpbnN0YW5jZW9mIFdJLkluZGV4ZWREYXRhYmFzZU9iamVjdFN0b3JlSW5kZXgpCi0gICAg ICAgIHJldHVybiBXSS5SZXNvdXJjZXNUYWJDb250ZW50VmlldzsKKyAgICAgICAgcmVwcmVzZW50 ZWRPYmplY3QgaW5zdGFuY2VvZiBXSS5JbmRleGVkRGF0YWJhc2UgfHwgcmVwcmVzZW50ZWRPYmpl Y3QgaW5zdGFuY2VvZiBXSS5JbmRleGVkRGF0YWJhc2VPYmplY3RTdG9yZUluZGV4KQorICAgICAg ICByZXR1cm4gV0kuU3RvcmFnZVRhYkNvbnRlbnRWaWV3OwogCiAgICAgaWYgKHJlcHJlc2VudGVk T2JqZWN0IGluc3RhbmNlb2YgV0kuQ2FudmFzQ29sbGVjdGlvbikKICAgICAgICAgcmV0dXJuIFdJ LkNhbnZhc1RhYkNvbnRlbnRWaWV3OwpAQCAtMTgxNSw2ICsxODE0LDcgQEAgV0kuX21vdmVXaW5k b3dNb3VzZURvd24gPSBmdW5jdGlvbihldmVudCkKIFdJLl9zdG9yYWdlV2FzSW5zcGVjdGVkID0g ZnVuY3Rpb24oZXZlbnQpCiB7CiAgICAgdGhpcy5zaG93U3RvcmFnZVRhYigpOworICAgIHRoaXMu c2hvd1JlcHJlc2VudGVkT2JqZWN0KGV2ZW50LmRhdGEuZG9tU3RvcmFnZSwgbnVsbCwge2lnbm9y ZVNlYXJjaFRhYjogdHJ1ZX0pOwogfTsKIAogV0kuX2RvbU5vZGVXYXNJbnNwZWN0ZWQgPSBmdW5j dGlvbihldmVudCkK