188738 2018-08-19 21:57:40 -0700 [GTK] Sort inspector GResource manifest to ensure reproducible builds 2018-08-20 09:49:19 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkitbmw webkit-unassigned aperez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1451529 0 webkitbmw 2018-08-19 21:57:40 -0700 bug 174540 occurred again in openSUSE's webkit2gtk3 package (even though webkitgtk and webkitgtk3 packages are dropped) 1451530 1 347480 webkitbmw 2018-08-19 22:02:19 -0700 Created attachment 347480 fixing patch 1451562 2 347480 aperez 2018-08-20 02:42:35 -0700 Comment on attachment 347480 fixing patch Hi Bernhard! I think it would be fine to merge the patchit, but it would need to follow the convention of including a ChangeLog entry. You can generate one for your changes using “Tools/Scripts/prepare-ChangeLog”. If you have a Git checkout, you can pass “-g <commitish>” to indicate for which commit(s) the entry will be generated. Could you please be so kind as to add the ChangeLog entry and re-submit the patch? Thanks in advance! 1451595 3 347495 webkitbmw 2018-08-20 07:18:57 -0700 Created attachment 347495 patch with changelog entry 1451599 4 347495 mcatanzaro 2018-08-20 07:21:52 -0700 Comment on attachment 347495 patch with changelog entry In the future, you can use the r? and cq? flags to request review and commit, respectively. 1451620 5 347495 commit-queue 2018-08-20 09:49:17 -0700 Comment on attachment 347495 patch with changelog entry Clearing flags on attachment: 347495 Committed r235080: <https://trac.webkit.org/changeset/235080> 1451621 6 commit-queue 2018-08-20 09:49:19 -0700 All reviewed patches have been landed. Closing bug. 347480 2018-08-19 22:02:19 -0700 2018-08-20 07:18:57 -0700 fixing patch webkit2gtk3-reproducible.patch text/plain 871 webkitbmw W0dUS10gU29ydCBpbnNwZWN0b3IgR1Jlc291cmNlIG1hbmlmZXN0IHRvIGVuc3VyZSByZXByb2R1 Y2libGUgYnVpbGRzCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ1 NDAKClBhdGNoIGJ5IEJlcm5oYXJkIE0uIFdpZWRlbWFubiA8YndpZWRlbWFubkBzdXNlLmRlPiBv biAyMDE4LTA4LTE5CgoqIGd0ay9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0 LnB5OgooZ2V0X2ZpbGVuYW1lcyk6IHNvcnQgbGlzdCBvZiBpbnB1dCBmaWxlcwoKSW5kZXg6IHdl YmtpdGd0ay0yLjIwLjUvVG9vbHMvZ2xpYi9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1h bmlmZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHdlYmtpdGd0ay0yLjIwLjUub3JpZy9Ub29scy9nbGli L2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkKKysrIHdlYmtpdGd0ay0y LjIwLjUvVG9vbHMvZ2xpYi9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5 CkBAIC0zNCw2ICszNCw4IEBAIGRlZiBnZXRfZmlsZW5hbWVzKGRpcmVjdG9yeSk6CiAgICAgICAg ICAgICByZXR1cm4gVHJ1ZQogCiAgICAgZm9yIHJvb3QsIGRpcnMsIGZpbGVzIGluIG9zLndhbGso ZGlyZWN0b3J5KToKKyAgICAgICAgZGlycy5zb3J0KCkKKyAgICAgICAgZmlsZXMuc29ydCgpCiAg ICAgICAgIGZvciBmaWxlIGluIGZpbGVzOgogICAgICAgICAgICAgZmlsZW5hbWUgPSBvcy5wYXRo LmpvaW4ocm9vdCwgZmlsZSkKICAgICAgICAgICAgIGJhc2VfZGlyX2luZGV4ID0gZmlsZW5hbWUu cmZpbmQoQkFTRV9ESVIpCg== 347495 2018-08-20 07:18:57 -0700 2018-08-20 09:49:17 -0700 patch with changelog entry 0001-GTK-Sort-inspector-GResource-manifest-to-ensure-repr.patch text/plain 1747 webkitbmw RnJvbSBkNDgzOGRlMTI5YzA0ZDZiZGQ1MjJmYmRmODY3YzBjNTdlZmY2NTcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQmVybmhhcmQgTS4gV2llZGVtYW5uIiA8YndpZWRlbWFubkBz dXNlLmRlPgpEYXRlOiBNb24sIDIwIEF1ZyAyMDE4IDE2OjEzOjExICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0dUS10gU29ydCBpbnNwZWN0b3IgR1Jlc291cmNlIG1hbmlmZXN0IHRvIGVuc3VyZQog cmVwcm9kdWNpYmxlIGJ1aWxkcwoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4ODczOAoKKiBnbGliL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3Qu cHk6CihnZXRfZmlsZW5hbWVzKTogc29ydCBsaXN0IG9mIGlucHV0IGZpbGVzCi0tLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysr KysrKwogVG9vbHMvZ2xpYi9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5 IHwgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZWYyNTI0ZTQuLmJlNDkz OWQwMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA4LTIwICBCZXJuaGFyZCBNLiBXaWVkZW1hbm4gIDxid2ll ZGVtYW5uQHN1c2UuZGU+CisKKyAgICAgICAgW0dUS10gU29ydCBpbnNwZWN0b3IgR1Jlc291cmNl IG1hbmlmZXN0IHRvIGVuc3VyZSByZXByb2R1Y2libGUgYnVpbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg3MzgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGdsaWIvZ2VuZXJhdGUtaW5zcGVjdG9y LWdyZXNvdXJjZS1tYW5pZmVzdC5weToKKyAgICAgICAgKGdldF9maWxlbmFtZXMpOiBzb3J0IGxp c3Qgb2YgaW5wdXQgZmlsZXMKKwogMjAxOC0wOC0yMCAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2 ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEFkZCBXUEUgRGVidWcgY29uZmlndXJhdGlvbiB0 byB0aGUgZmxha2luZXNzIGRhc2hib2FyZApkaWZmIC0tZ2l0IGEvVG9vbHMvZ2xpYi9nZW5lcmF0 ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5IGIvVG9vbHMvZ2xpYi9nZW5lcmF0ZS1p bnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5CmluZGV4IDYzYjUzZGQ1OS4uNDZjNDY0ZDZl IDEwMDc1NQotLS0gYS9Ub29scy9nbGliL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFu aWZlc3QucHkKKysrIGIvVG9vbHMvZ2xpYi9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1h bmlmZXN0LnB5CkBAIC0zNCw2ICszNCw4IEBAIGRlZiBnZXRfZmlsZW5hbWVzKGRpcmVjdG9yeSk6 CiAgICAgICAgICAgICByZXR1cm4gVHJ1ZQogCiAgICAgZm9yIHJvb3QsIGRpcnMsIGZpbGVzIGlu IG9zLndhbGsoZGlyZWN0b3J5KToKKyAgICAgICAgZGlycy5zb3J0KCkKKyAgICAgICAgZmlsZXMu c29ydCgpCiAgICAgICAgIGZvciBmaWxlIGluIGZpbGVzOgogICAgICAgICAgICAgZmlsZW5hbWUg PSBvcy5wYXRoLmpvaW4ocm9vdCwgZmlsZSkKICAgICAgICAgICAgIGJhc2VfZGlyX2luZGV4ID0g ZmlsZW5hbWUucmZpbmQoQkFTRV9ESVIpCi0tIAoyLjE2LjQKCg==