188725 2018-08-18 16:48:03 -0700 REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames() 2018-08-19 08:16:57 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 187379 1 ddkilzer ddkilzer commit-queue ggaren joepeck mitz sihui_liu webkit-bug-importer oldest_to_newest 1451428 0 ddkilzer 2018-08-18 16:48:03 -0700 Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames(): void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames) { for (auto& hostName : hostNames) _CFNetworkResetHSTS(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL), session.platformSession()); } Found by internal static analyzer bot. 1451429 1 webkit-bug-importer 2018-08-18 16:48:18 -0700 <rdar://problem/43469670> 1451430 2 347453 ddkilzer 2018-08-18 16:50:46 -0700 Created attachment 347453 Patch v1 1451449 3 347453 commit-queue 2018-08-19 08:16:56 -0700 Comment on attachment 347453 Patch v1 Clearing flags on attachment: 347453 Committed r235016: <https://trac.webkit.org/changeset/235016> 1451450 4 commit-queue 2018-08-19 08:16:57 -0700 All reviewed patches have been landed. Closing bug. 347453 2018-08-18 16:50:46 -0700 2018-08-19 08:16:56 -0700 Patch v1 bug-188725-20180818165036.patch text/plain 2050 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjMzUyYTQ1YmIwNjFmZDdl MDlmOTE5NjI5MGFmYWFmOWM0ZDFhZjIuLjllZjZjNGYxYTEyNjk2NmY0MzQxZDkxYzE2ZjJjZjUy ZTkzNmEwZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDgtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjM0Mzk2 KTogTGVhayBvZiBDRlVSTFJlZiBpbiBXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpkZWxldGVIU1RT Q2FjaGVGb3JIb3N0TmFtZXMoKQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTg4NzI1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktp dDo6TmV0d29ya1Byb2Nlc3M6OmRlbGV0ZUhTVFNDYWNoZUZvckhvc3ROYW1lcyk6IFVzZQorICAg ICAgICBhZG9wdENGKCkgdG8gcHJldmVudCBhIGxlYWsuCisKIDIwMTgtMDgtMTYgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBjYW5CdWJibGUgYW5k IGNhbmNlbGFibGUgYm9vbGVhbnMgaW4gRXZlbnQgYnkgZW51bSBjbGFzc2VzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29j b2EubW0KaW5kZXggYzkzNDhlNzQxOGI3NzlkNzRhYjdlYzg3NWRkOGIxNGE3OTQ4M2NmZS4uMDAy M2ZlMTYxYjUzZWY1YmMzYTUzNDQzOWI2NjJlNThjZGEwZTY1YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5t bQpAQCAtNDUsNiArNDUsNyBAQAogI2ltcG9ydCA8d3RmL0Jsb2NrUHRyLmg+CiAjaW1wb3J0IDx3 dGYvQ2FsbGJhY2tBZ2dyZWdhdG9yLmg+CiAjaW1wb3J0IDx3dGYvUHJvY2Vzc1ByaXZpbGVnZS5o PgorI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAt MTU5LDggKzE2MCwxMCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpnZXRIb3N0TmFtZXNXaXRoSFNU U0NhY2hlKFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgcwogCiB2b2lkIE5ldHdvcmtQ cm9jZXNzOjpkZWxldGVIU1RTQ2FjaGVGb3JIb3N0TmFtZXMoV2ViQ29yZTo6TmV0d29ya1N0b3Jh Z2VTZXNzaW9uJiBzZXNzaW9uLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgaG9zdE5hbWVzKQogewot ICAgIGZvciAoYXV0byYgaG9zdE5hbWUgOiBob3N0TmFtZXMpCi0gICAgICAgIF9DRk5ldHdvcmtS ZXNldEhTVFMoQ0ZVUkxDcmVhdGVXaXRoU3RyaW5nKGtDRkFsbG9jYXRvckRlZmF1bHQsIGhvc3RO YW1lLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCksIE5VTEwpLCBzZXNzaW9uLnBsYXRmb3JtU2Vzc2lv bigpKTsKKyAgICBmb3IgKGF1dG8mIGhvc3ROYW1lIDogaG9zdE5hbWVzKSB7CisgICAgICAgIGF1 dG8gdXJsID0gYWRvcHRDRihDRlVSTENyZWF0ZVdpdGhTdHJpbmcoa0NGQWxsb2NhdG9yRGVmYXVs dCwgaG9zdE5hbWUuY3JlYXRlQ0ZTdHJpbmcoKS5nZXQoKSwgTlVMTCkpOworICAgICAgICBfQ0ZO ZXR3b3JrUmVzZXRIU1RTKHVybC5nZXQoKSwgc2Vzc2lvbi5wbGF0Zm9ybVNlc3Npb24oKSk7Cisg ICAgfQogfQogCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpjbGVhckhTVFNDYWNoZShXZWJDb3JlOjpO ZXR3b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Npb24sIFdhbGxUaW1lIG1vZGlmaWVkU2luY2UpCg==