188673 2018-08-16 13:11:15 -0700 Begin moving preference SPI from WKWebViewConfiguration to WKPreferences 2018-08-16 15:56:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 achristensen achristensen sam simon.fraser thorton oldest_to_newest 1450825 0 achristensen 2018-08-16 13:11:15 -0700 Begin moving preference SPI from WKWebViewConfiguration to WKPreferences 1450829 1 347292 achristensen 2018-08-16 13:12:43 -0700 Created attachment 347292 Patch 1450922 2 achristensen 2018-08-16 15:56:52 -0700 After talking with Anders and Sam, we've agreed that the right approach is to move things from settings/preferences to PageConfiguration. 347292 2018-08-16 13:12:43 -0700 2018-08-16 15:56:09 -0700 Patch bug-188673-20180816131242.patch text/plain 7527 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ5NDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA4LTE2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQmVnaW4gbW92aW5n IHByZWZlcmVuY2UgU1BJIGZyb20gV0tXZWJWaWV3Q29uZmlndXJhdGlvbiB0byBXS1ByZWZlcmVu Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg2 NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGRv IHRoaXMgYnkgZGVwcmVjYXRpbmcgdGhlIG9sZCBTUEksIG1ha2luZyBuZXcgU1BJLCBhbmQgdXNp bmcgdGhlIHZhbHVlIGZyb20gdGhlIG9sZCBpZiB0aGUgbmV3IGhhc24ndCBiZWVuIHVzZWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06CisgICAgICAg ICgtW1dLUHJlZmVyZW5jZXMgX2F0dGFjaG1lbnRFbGVtZW50RW5hYmxlZF0pOgorICAgICAgICAo LVtXS1ByZWZlcmVuY2VzIF9zZXRBdHRhY2htZW50RWxlbWVudEVuYWJsZWQ6XSk6CisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcg X2luaXRpYWxpemVXaXRoQ29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg6CisKIDIwMTgtMDgtMTYgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBUcmFu c2l0aW9uIG1vcmUgV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBpdmFycyB0byBBUEk6OlBhZ2VDb25m aWd1cmF0aW9uIHZhbHVlcwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLUHJlZmVyZW5jZXMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0JKHJldmlzaW9uIDIzNDkzMikKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCSh3b3JraW5nIGNvcHkp CkBAIC00MTcsNiArNDE3LDE2IEBAIC0gKHZvaWQpX3NldERldmVsb3BlckV4dHJhc0VuYWJsZWQ6 KEJPT0wKICAgICBfcHJlZmVyZW5jZXMtPnNldERldmVsb3BlckV4dHJhc0VuYWJsZWQoZGV2ZWxv cGVyRXh0cmFzRW5hYmxlZCk7CiB9CiAKKy0gKEJPT0wpX2F0dGFjaG1lbnRFbGVtZW50RW5hYmxl ZAoreworICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPmF0dGFjaG1lbnRFbGVtZW50RW5hYmxlZCgp OworfQorCistICh2b2lkKV9zZXRBdHRhY2htZW50RWxlbWVudEVuYWJsZWQ6KEJPT0wpYXR0YWNo bWVudEVsZW1lbnRFbmFibGVkCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRBdHRhY2htZW50RWxl bWVudEVuYWJsZWQoYXR0YWNobWVudEVsZW1lbnRFbmFibGVkKTsKK30KKwogLSAoQk9PTClfbG9n c1BhZ2VNZXNzYWdlc1RvU3lzdGVtQ29uc29sZUVuYWJsZWQKIHsKICAgICByZXR1cm4gX3ByZWZl cmVuY2VzLT5sb2dzUGFnZU1lc3NhZ2VzVG9TeXN0ZW1Db25zb2xlRW5hYmxlZCgpOwpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVy ZW5jZXNQcml2YXRlLmgJKHJldmlzaW9uIDIzNDkzMikKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04 Miw2ICs4Miw4IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIF9XS0VkaXRhYmxlTGkKIAog QHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZDop IEJPT0wgX2RldmVsb3BlckV4dHJhc0VuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAu MTEpLCBpb3MoOS4wKSk7CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEF0dGFj aG1lbnRFbGVtZW50RW5hYmxlZDopIEJPT0wgX2F0dGFjaG1lbnRFbGVtZW50RW5hYmxlZCBXS19B UElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKKwogQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0TG9nc1BhZ2VNZXNzYWdlc1RvU3lzdGVtQ29u c29sZUVuYWJsZWQ6KSBCT09MIF9sb2dzUGFnZU1lc3NhZ2VzVG9TeXN0ZW1Db25zb2xlRW5hYmxl ZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMSksIGlvcyg5LjApKTsKIAogQHByb3BlcnR5 IChub25hdG9taWMsIHNldHRlcj1fc2V0SGlkZGVuUGFnZURPTVRpbWVyVGhyb3R0bGluZ0VuYWJs ZWQ6KSBCT09MIF9oaWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nRW5hYmxlZCBXS19BUElfQVZB SUxBQkxFKG1hY29zeCgxMC4xMiksIGlvcygxMC4wKSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlzaW9uIDIzNDk0NikKKysr IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHdvcmtpbmcg Y29weSkKQEAgLTUzMSw2ICs1MzEsOCBAQCAtICh2b2lkKV9pbml0aWFsaXplV2l0aENvbmZpZ3Vy YXRpb246KFdLCiAKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNl dChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpzdXBwcmVzc2VzSW5jcmVtZW50YWxSZW5kZXJp bmdLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29uZmlndXJh dGlvbiBzdXBwcmVzc2VzSW5jcmVtZW50YWxSZW5kZXJpbmddKSk7CiAKKyNwcmFnbWEgY2xhbmcg ZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdkZXBy ZWNhdGVkLWRlY2xhcmF0aW9ucyIKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZh bHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpzaG91bGRSZXNwZWN0SW1hZ2VP cmllbnRhdGlvbktleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19j b25maWd1cmF0aW9uIF9yZXNwZWN0c0ltYWdlT3JpZW50YXRpb25dKSk7CiAgICAgcGFnZUNvbmZp Z3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tl eTo6c2hvdWxkUHJpbnRCYWNrZ3JvdW5kc0tleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3Rv cmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9wcmludHNCYWNrZ3JvdW5kc10pKTsKICAgICBw YWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZl cmVuY2VzS2V5OjppbmNyZW1lbnRhbFJlbmRlcmluZ1N1cHByZXNzaW9uVGltZW91dEtleSgpLCBX ZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKFtfY29uZmlndXJhdGlvbiBfaW5jcmVt ZW50YWxSZW5kZXJpbmdTdXBwcmVzc2lvblRpbWVvdXRdKSk7CkBAIC01NzMsNyArNTc1LDggQEAg ICAgIC8vIFdlIGFyZSBpbiB0aGUgVmlldydzIGluaXRpYWxpemF0aQogICAgIHBhZ2VDb25maWd1 cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6 Om1haW5Db250ZW50VXNlckdlc3R1cmVPdmVycmlkZUVuYWJsZWRLZXkoKSwgV2ViS2l0OjpXZWJQ cmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29uZmlndXJhdGlvbiBfbWFpbkNvbnRlbnRVc2Vy R2VzdHVyZU92ZXJyaWRlRW5hYmxlZF0pKTsKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVy ZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjppbnZpc2libGVBdXRv cGxheU5vdFBlcm1pdHRlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVl KCEhW19jb25maWd1cmF0aW9uIF9pbnZpc2libGVBdXRvcGxheU5vdFBlcm1pdHRlZF0pKTsKICAg ICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlBy ZWZlcmVuY2VzS2V5OjptZWRpYURhdGFMb2Fkc0F1dG9tYXRpY2FsbHlLZXkoKSwgV2ViS2l0OjpX ZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29uZmlndXJhdGlvbiBfbWVkaWFEYXRhTG9h ZHNBdXRvbWF0aWNhbGx5XSkpOwotICAgIHBhZ2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFs dWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OmF0dGFjaG1lbnRFbGVtZW50RW5h YmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1 cmF0aW9uIF9hdHRhY2htZW50RWxlbWVudEVuYWJsZWRdKSk7CisgICAgaWYgKCFwYWdlQ29uZmln dXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLmNvbnRhaW5zKFdlYktpdDo6V2ViUHJlZmVyZW5j ZXNLZXk6OmF0dGFjaG1lbnRFbGVtZW50RW5hYmxlZEtleSgpKSkKKyAgICAgICAgcGFnZUNvbmZp Z3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tl eTo6YXR0YWNobWVudEVsZW1lbnRFbmFibGVkS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNT dG9yZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gX2F0dGFjaG1lbnRFbGVtZW50RW5hYmxlZF0p KTsKIAogI2lmIEVOQUJMRShEQVRBX0RFVEVDVElPTikgJiYgUExBVEZPUk0oSU9TKQogICAgIHBh Z2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVy ZW5jZXNLZXk6OmRhdGFEZXRlY3RvclR5cGVzS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNT dG9yZTo6VmFsdWUoc3RhdGljX2Nhc3Q8dWludDMyX3Q+KGZyb21XS0RhdGFEZXRlY3RvclR5cGVz KFtfY29uZmlndXJhdGlvbiBkYXRhRGV0ZWN0b3JUeXBlc10pKSkpOwpAQCAtNTk1LDYgKzU5OCw3 IEBAICAgICAvLyBXZSBhcmUgaW4gdGhlIFZpZXcncyBpbml0aWFsaXphdGkKICNpZiBFTkFCTEUo TEVHQUNZX0VOQ1JZUFRFRF9NRURJQSkKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5j ZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpsZWdhY3lFbmNyeXB0ZWRN ZWRpYUFQSUVuYWJsZWRLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSgh IVtfY29uZmlndXJhdGlvbiBfbGVnYWN5RW5jcnlwdGVkTWVkaWFBUElFbmFibGVkXSkpOwogI2Vu ZGlmCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCiAKICNpZiBQTEFURk9STShJT1MpICYm IEVOQUJMRShTRVJWSUNFX1dPUktFUikKICAgICBpZiAoIVdURjo6cHJvY2Vzc0hhc0VudGl0bGVt ZW50KCJjb20uYXBwbGUuZGV2ZWxvcGVyLldlYktpdC5TZXJ2aWNlV29ya2VycyIpKQpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Q cml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmgJKHJldmlzaW9uIDIzNDkzMikKKysrIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uUHJp dmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCw3IEBAIHR5cGVkZWYgTlNfRU5VTShO U1VJbnRlZ2VyLCBfV0tEcmFnTGlmdEQKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3Nl dE1haW5Db250ZW50VXNlckdlc3R1cmVPdmVycmlkZUVuYWJsZWQ6KSBCT09MIF9tYWluQ29udGVu dFVzZXJHZXN0dXJlT3ZlcnJpZGVFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEy KSwgaW9zKDEwLjApKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEludmlzaWJs ZUF1dG9wbGF5Tm90UGVybWl0dGVkOikgQk9PTCBfaW52aXNpYmxlQXV0b3BsYXlOb3RQZXJtaXR0 ZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIpLCBpb3MoMTAuMCkpOwogQHByb3BlcnR5 IChub25hdG9taWMsIHNldHRlcj1fc2V0TWVkaWFEYXRhTG9hZHNBdXRvbWF0aWNhbGx5OikgQk9P TCBfbWVkaWFEYXRhTG9hZHNBdXRvbWF0aWNhbGx5IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEw LjEyKSwgaW9zKDEwLjApKTsKLUBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEF0dGFj aG1lbnRFbGVtZW50RW5hYmxlZDopIEJPT0wgX2F0dGFjaG1lbnRFbGVtZW50RW5hYmxlZCBXS19B UElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMiksIGlvcygxMC4wKSk7CitAcHJvcGVydHkgKG5vbmF0 b21pYywgc2V0dGVyPV9zZXRBdHRhY2htZW50RWxlbWVudEVuYWJsZWQ6KSBCT09MIF9hdHRhY2ht ZW50RWxlbWVudEVuYWJsZWQgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgiV0tQ cmVmZXJlbmNlcy5fYXR0YWNobWVudEVsZW1lbnRFbmFibGVkIiwgbWFjb3N4KDEwLjEyLCBXS19N QUNfVEJBKSwgaW9zKDEwLjAsIFdLX0lPU19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBz ZXR0ZXI9X3NldEluaXRpYWxDYXBpdGFsaXphdGlvbkVuYWJsZWQ6KSBCT09MIF9pbml0aWFsQ2Fw aXRhbGl6YXRpb25FbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyKSwgaW9zKDEw LjApKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEFwcGxlUGF5RW5hYmxlZDop IEJPT0wgX2FwcGxlUGF5RW5hYmxlZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMiksIGlv cygxMC4wKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRXYWl0c0ZvclBhaW50 QWZ0ZXJWaWV3RGlkTW92ZVRvV2luZG93OikgQk9PTCBfd2FpdHNGb3JQYWludEFmdGVyVmlld0Rp ZE1vdmVUb1dpbmRvdyBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMi4zKSwgaW9zKDEwLjMp KTsK