188665 2018-08-16 11:35:44 -0700 Transition more WKWebViewConfiguration ivars to API::PageConfiguration values 2020-01-27 17:12:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen amandatheloves ap fedrikjames26 gail_brown31 joepeck sprycarolus ssxnetwork webkit-bug-importer oldest_to_newest 1450764 0 achristensen 2018-08-16 11:35:44 -0700 Transition more WKWebViewConfiguration ivars to API::PageConfiguration values 1450765 1 347279 achristensen 2018-08-16 11:36:56 -0700 Created attachment 347279 Patch 1450774 2 347279 joepeck 2018-08-16 11:49:09 -0700 Comment on attachment 347279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347279&action=review r=me > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-376 > - configuration->_cpuLimit = self->_cpuLimit; These copies are removed since PageConfiguration::copy already handles it? Nice! 1611716 9 achristensen 2020-01-27 17:11:38 -0800 This was committed long ago to http://trac.webkit.org/r234946 1611718 10 webkit-bug-importer 2020-01-27 17:12:20 -0800 <rdar://problem/58940859> 347279 2018-08-16 11:36:56 -0700 2018-08-16 11:49:09 -0700 Patch bug-188665-20180816113656.patch text/plain 7409 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ5NDQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA4LTE2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVHJhbnNpdGlvbiBt b3JlIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gaXZhcnMgdG8gQVBJOjpQYWdlQ29uZmlndXJhdGlv biB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4ODY2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFQUExJQ0FUSU9OX01BTklGRVNUIGlzIGVuYWJsZWQgb24gYWxsIENvY29hIHBsYXRmb3Jtcywg c28gSSByZW1vdmVkIHNvbWUgZ3VhcmRzLCB0b28hCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0FQSVBhZ2VDb25maWd1cmF0aW9uLmNwcDoKKyAgICAgICAgKEFQSTo6UGFnZUNvbmZpZ3VyYXRp b246OmFwcGxpY2F0aW9uTWFuaWZlc3QgY29uc3QpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv QVBJUGFnZUNvbmZpZ3VyYXRpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9pbml0aWFsaXplV2l0aENvbmZpZ3Vy YXRpb246XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1 cmF0aW9uLm1tOgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIGluaXRdKToKKyAg ICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBjb3B5V2l0aFpvbmU6XSk6CisgICAgICAg ICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gX2FwcGxpY2F0aW9uTWFuaWZlc3RdKToKKyAgICAg ICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfc2V0QXBwbGljYXRpb25NYW5pZmVzdDpdKToK KyAgICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfc2V0Q1BVTGltaXQ6XSk6CisgICAg ICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gX2NwdUxpbWl0XSk6CisKIDIwMTgtMDgtMTYg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBU cmFuc2l0aW9uIG1vcmUgV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBpdmFycyB0byBBUEk6OlBhZ2VD b25maWd1cmF0aW9uIHZhbHVlcwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQ SVBhZ2VDb25maWd1cmF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQVBJUGFnZUNvbmZpZ3VyYXRpb24uY3BwCShyZXZpc2lvbiAyMzQ5MzIpCisrKyBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUGFnZUNvbmZpZ3VyYXRpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODgsNyArMTg4LDcgQEAgdm9pZCBQYWdlQ29uZmlndXJhdGlvbjo6c2V0 VVJMU2NoZW1lSGFuZAogfQogCiAjaWYgRU5BQkxFKEFQUExJQ0FUSU9OX01BTklGRVNUKQotY29u c3QgQXBwbGljYXRpb25NYW5pZmVzdCogUGFnZUNvbmZpZ3VyYXRpb246OmFwcGxpY2F0aW9uTWFu aWZlc3QoKSBjb25zdAorQXBwbGljYXRpb25NYW5pZmVzdCogUGFnZUNvbmZpZ3VyYXRpb246OmFw cGxpY2F0aW9uTWFuaWZlc3QoKSBjb25zdAogewogICAgIHJldHVybiBtX2FwcGxpY2F0aW9uTWFu aWZlc3QuZ2V0KCk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUGFn ZUNvbmZpZ3VyYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQVBJUGFnZUNvbmZpZ3VyYXRpb24uaAkocmV2aXNpb24gMjM0OTMyKQorKysgU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0FQSVBhZ2VDb25maWd1cmF0aW9uLmgJKHdvcmtpbmcgY29weSkK QEAgLTExMSw3ICsxMTEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRPdmVycmlkZUNvbnRlbnRT ZWN1cml0eVBvbGljeShjb25zdCBXVEY6OlN0cmluZyYgb3ZlcnJpZGVDb250ZW50U2VjdXJpdHlQ b2xpY3kpIHsgbV9vdmVycmlkZUNvbnRlbnRTZWN1cml0eVBvbGljeSA9IG92ZXJyaWRlQ29udGVu dFNlY3VyaXR5UG9saWN5OyB9CiAKICNpZiBFTkFCTEUoQVBQTElDQVRJT05fTUFOSUZFU1QpCi0g ICAgY29uc3QgQXBwbGljYXRpb25NYW5pZmVzdCogYXBwbGljYXRpb25NYW5pZmVzdCgpIGNvbnN0 OworICAgIEFwcGxpY2F0aW9uTWFuaWZlc3QqIGFwcGxpY2F0aW9uTWFuaWZlc3QoKSBjb25zdDsK ICAgICB2b2lkIHNldEFwcGxpY2F0aW9uTWFuaWZlc3QoQXBwbGljYXRpb25NYW5pZmVzdCopOwog I2VuZGlmCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbQkocmV2aXNpb24gMjM0OTQyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTQxLDEzICs1NDEsNyBA QCAtICh2b2lkKV9pbml0aWFsaXplV2l0aENvbmZpZ3VyYXRpb246KFdLCiAgICAgcGFnZUNvbmZp Z3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tl eTo6aW5jb21wbGV0ZUltYWdlQm9yZGVyRW5hYmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVu Y2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9pbmNvbXBsZXRlSW1hZ2VCb3JkZXJF bmFibGVkXSkpOwogICAgIHBhZ2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0 KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OnNob3VsZERlZmVyQXN5bmNocm9ub3VzU2NyaXB0 c1VudGlsQWZ0ZXJEb2N1bWVudExvYWRLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3Jl OjpWYWx1ZSghIVtfY29uZmlndXJhdGlvbiBfc2hvdWxkRGVmZXJBc3luY2hyb25vdXNTY3JpcHRz VW50aWxBZnRlckRvY3VtZW50TG9hZF0pKTsKIAotI2lmIEVOQUJMRShBUFBMSUNBVElPTl9NQU5J RkVTVCkKLSAgICBwYWdlQ29uZmlndXJhdGlvbi0+c2V0QXBwbGljYXRpb25NYW5pZmVzdChbX2Nv bmZpZ3VyYXRpb24gX2FwcGxpY2F0aW9uTWFuaWZlc3RdID8gW2NvbmZpZ3VyYXRpb24gX2FwcGxp Y2F0aW9uTWFuaWZlc3RdLT5fYXBwbGljYXRpb25NYW5pZmVzdC5nZXQoKSA6IG51bGxwdHIpOwot I2VuZGlmCi0KICNpZiBQTEFURk9STShNQUMpCi0gICAgaWYgKGF1dG8gY3B1TGltaXQgPSBbX2Nv bmZpZ3VyYXRpb24gX2NwdUxpbWl0XSkKLSAgICAgICAgcGFnZUNvbmZpZ3VyYXRpb24tPnNldENQ VUxpbWl0KGNwdUxpbWl0KTsKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVl cygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpzaG93c1VSTHNJblRvb2xUaXBzRW5h YmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1 cmF0aW9uIF9zaG93c1VSTHNJblRvb2xUaXBzXSkpOwogICAgIHBhZ2VDb25maWd1cmF0aW9uLT5w cmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OnNlcnZpY2VD b250cm9sc0VuYWJsZWRLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSgh IVtfY29uZmlndXJhdGlvbiBfc2VydmljZUNvbnRyb2xzRW5hYmxlZF0pKTsKICAgICBwYWdlQ29u ZmlndXJhdGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2Vz S2V5OjppbWFnZUNvbnRyb2xzRW5hYmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3Rv cmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9pbWFnZUNvbnRyb2xzRW5hYmxlZF0pKTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0 aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCShyZXZpc2lvbiAyMzQ5NDIpCisrKyBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMzksNiArMzksNyBAQAogI2ltcG9ydCAiV0tXZWJWaWV3Q29udGVudFByb3Zp ZGVyUmVnaXN0cnkuaCIKICNpbXBvcnQgIldlYktpdDJJbml0aWFsaXplLmgiCiAjaW1wb3J0ICJX ZWJVUkxTY2hlbWVIYW5kbGVyQ29jb2EuaCIKKyNpbXBvcnQgIl9XS0FwcGxpY2F0aW9uTWFuaWZl c3RJbnRlcm5hbC5oIgogI2ltcG9ydCAiX1dLVmlzaXRlZExpbmtTdG9yZS5oIgogI2ltcG9ydCAi X1dLV2Vic2l0ZURhdGFTdG9yZUludGVybmFsLmgiCiAjaW1wb3J0IDxXZWJDb3JlL1J1bnRpbWVB cHBsaWNhdGlvbkNoZWNrcy5oPgpAQCAtMTQxLDE3ICsxNDIsMTIgQEAgc3RhdGljIF9XS0RyYWdM aWZ0RGVsYXkgdG9EcmFnTGlmdERlbGF5KAogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIFdLUmV0 YWluUHRyPFdLUGFnZUdyb3VwUmVmPiBfcGFnZUdyb3VwOwotICAgIGRvdWJsZSBfY3B1TGltaXQ7 CiAgICAgQk9PTCBfc2hvd3NVUkxzSW5Ub29sVGlwczsKICAgICBCT09MIF9zZXJ2aWNlQ29udHJv bHNFbmFibGVkOwogICAgIEJPT0wgX2ltYWdlQ29udHJvbHNFbmFibGVkOwogICAgIEJPT0wgX3Jl cXVpcmVzVXNlckFjdGlvbkZvckVkaXRpbmdDb250cm9sc01hbmFnZXI7CiAjZW5kaWYKIAotI2lm IEVOQUJMRShBUFBMSUNBVElPTl9NQU5JRkVTVCkKLSAgICBSZXRhaW5QdHI8X1dLQXBwbGljYXRp b25NYW5pZmVzdD4gX2FwcGxpY2F0aW9uTWFuaWZlc3Q7Ci0jZW5kaWYKLQogI2lmIEVOQUJMRShB UFBMRV9QQVkpCiAgICAgQk9PTCBfYXBwbGVQYXlFbmFibGVkOwogI2VuZGlmCkBAIC0yMDYsNyAr MjAyLDYgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXQKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oTUFD KQotICAgIF9jcHVMaW1pdCA9IDA7CiAgICAgX3ByaW50c0JhY2tncm91bmRzID0gTk87CiAgICAg X3Jlc3BlY3RzSW1hZ2VPcmllbnRhdGlvbiA9IE5POwogICAgIF9zaG93c1VSTHNJblRvb2xUaXBz ID0gTk87CkBAIC0zNzMsNyArMzY4LDYgQEAgLSAoaWQpY29weVdpdGhab25lOihOU1pvbmUgKil6 b25lCiAgICAgY29uZmlndXJhdGlvbi0+X3N5c3RlbVByZXZpZXdFbmFibGVkID0gc2VsZi0+X3N5 c3RlbVByZXZpZXdFbmFibGVkOwogI2VuZGlmCiAjaWYgUExBVEZPUk0oTUFDKQotICAgIGNvbmZp Z3VyYXRpb24tPl9jcHVMaW1pdCA9IHNlbGYtPl9jcHVMaW1pdDsKICAgICBjb25maWd1cmF0aW9u LT5fdXNlckludGVyZmFjZURpcmVjdGlvblBvbGljeSA9IHNlbGYtPl91c2VySW50ZXJmYWNlRGly ZWN0aW9uUG9saWN5OwogICAgIGNvbmZpZ3VyYXRpb24tPl9zaG93c1VSTHNJblRvb2xUaXBzID0g c2VsZi0+X3Nob3dzVVJMc0luVG9vbFRpcHM7CiAgICAgY29uZmlndXJhdGlvbi0+X3NlcnZpY2VD b250cm9sc0VuYWJsZWQgPSBzZWxmLT5fc2VydmljZUNvbnRyb2xzRW5hYmxlZDsKQEAgLTM5MCw5 ICszODQsNiBAQCAtIChpZCljb3B5V2l0aFpvbmU6KE5TWm9uZSAqKXpvbmUKICNpZiBFTkFCTEUo QVBQTEVfUEFZKQogICAgIGNvbmZpZ3VyYXRpb24tPl9hcHBsZVBheUVuYWJsZWQgPSBzZWxmLT5f YXBwbGVQYXlFbmFibGVkOwogI2VuZGlmCi0jaWYgRU5BQkxFKEFQUExJQ0FUSU9OX01BTklGRVNU KQotICAgIGNvbmZpZ3VyYXRpb24tPl9hcHBsaWNhdGlvbk1hbmlmZXN0ID0gc2VsZi0+X2FwcGxp Y2F0aW9uTWFuaWZlc3Q7Ci0jZW5kaWYKICAgICBjb25maWd1cmF0aW9uLT5fbmVlZHNTdG9yYWdl QWNjZXNzRnJvbUZpbGVVUkxzUXVpcmsgPSBzZWxmLT5fbmVlZHNTdG9yYWdlQWNjZXNzRnJvbUZp bGVVUkxzUXVpcms7CiAKICAgICBjb25maWd1cmF0aW9uLT5fbWVkaWFDb250ZW50VHlwZXNSZXF1 aXJpbmdIYXJkd2FyZVN1cHBvcnQgPSBhZG9wdE5TKFtzZWxmLl9tZWRpYUNvbnRlbnRUeXBlc1Jl cXVpcmluZ0hhcmR3YXJlU3VwcG9ydCBjb3B5V2l0aFpvbmU6em9uZV0pOwpAQCAtODU4LDE4ICs4 NDksMTQgQEAgLSAodm9pZClfc2V0Q29udHJvbGxlZEJ5QXV0b21hdGlvbjooQk9PTAogCiAtIChf V0tBcHBsaWNhdGlvbk1hbmlmZXN0ICopX2FwcGxpY2F0aW9uTWFuaWZlc3QKIHsKLSNpZiBFTkFC TEUoQVBQTElDQVRJT05fTUFOSUZFU1QpCi0gICAgcmV0dXJuIF9hcHBsaWNhdGlvbk1hbmlmZXN0 LmdldCgpOwotI2Vsc2UKKyAgICBpZiAoYXV0byogbWFuaWZlc3QgPSBfcGFnZUNvbmZpZ3VyYXRp b24tPmFwcGxpY2F0aW9uTWFuaWZlc3QoKSkKKyAgICAgICAgcmV0dXJuIHdyYXBwZXIoKm1hbmlm ZXN0KTsKICAgICByZXR1cm4gbmlsOwotI2VuZGlmCiB9CiAKIC0gKHZvaWQpX3NldEFwcGxpY2F0 aW9uTWFuaWZlc3Q6KF9XS0FwcGxpY2F0aW9uTWFuaWZlc3QgKilhcHBsaWNhdGlvbk1hbmlmZXN0 CiB7Ci0jaWYgRU5BQkxFKEFQUExJQ0FUSU9OX01BTklGRVNUKQotICAgIF9hcHBsaWNhdGlvbk1h bmlmZXN0ID0gYXBwbGljYXRpb25NYW5pZmVzdDsKLSNlbmRpZgorICAgIF9wYWdlQ29uZmlndXJh dGlvbi0+c2V0QXBwbGljYXRpb25NYW5pZmVzdChhcHBsaWNhdGlvbk1hbmlmZXN0ID8gYXBwbGlj YXRpb25NYW5pZmVzdC0+X2FwcGxpY2F0aW9uTWFuaWZlc3QuZ2V0KCkgOiBudWxscHRyKTsKIH0K IAogI2lmIFBMQVRGT1JNKE1BQykKQEAgLTkyNSwxMiArOTEyLDEyIEBAIC0gKHZvaWQpX3NldFBh Z2VHcm91cDooV0tQYWdlR3JvdXBSZWYpcGEKIAogLSAodm9pZClfc2V0Q1BVTGltaXQ6KGRvdWJs ZSljcHVMaW1pdAogewotICAgIF9jcHVMaW1pdCA9IGNwdUxpbWl0OworICAgIF9wYWdlQ29uZmln dXJhdGlvbi0+c2V0Q1BVTGltaXQoY3B1TGltaXQpOwogfQogCiAtIChkb3VibGUpX2NwdUxpbWl0 CiB7Ci0gICAgcmV0dXJuIF9jcHVMaW1pdDsKKyAgICByZXR1cm4gX3BhZ2VDb25maWd1cmF0aW9u LT5jcHVMaW1pdCgpLnZhbHVlX29yKDApOwogfQogCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQo=