188580 2018-08-14 14:30:00 -0700 LayoutTest inspector/worker/debugger-pause.html sometimes times out 2020-01-19 23:26:52 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164833 https://bugs.webkit.org/show_bug.cgi?id=206285 InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1450101 0 joepeck 2018-08-14 14:30:00 -0700 LayoutTest inspector/worker/debugger-pause.html sometimes times out See bug 164833. > Test History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fworker%2Fdebugger-pause.html I'll create an event for when the worker's main resource gets set. 1450115 1 347115 joepeck 2018-08-14 15:10:45 -0700 Created attachment 347115 [PATCH] Proposed Fix 1450139 2 347115 mattbaker 2018-08-14 16:01:26 -0700 Comment on attachment 347115 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=347115&action=review r=me > Source/WebInspectorUI/UserInterface/Protocol/Target.js:79 > + this.dispatchEventToListeners(WI.Target.Event.MainResourceAdded, {resource}); Nit: I wouldn't bother including data for the event. A listener can just query Target.mainResource if needed. 1450768 3 347115 commit-queue 2018-08-16 11:41:36 -0700 Comment on attachment 347115 [PATCH] Proposed Fix Clearing flags on attachment: 347115 Committed r234945: <https://trac.webkit.org/changeset/234945> 1450769 4 commit-queue 2018-08-16 11:41:38 -0700 All reviewed patches have been landed. Closing bug. 1450770 5 webkit-bug-importer 2018-08-16 11:42:21 -0700 <rdar://problem/43390767> 347115 2018-08-14 15:10:45 -0700 2018-08-16 11:41:36 -0700 [PATCH] Proposed Fix wait-for-main-resource-1.patch text/plain 4518 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlOGJjYzBkMDA4Ni4uM2E0NGIxNmMzMTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxOC0wOC0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dFRlc3QgaW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1wYXVzZS5odG1sIHNvbWV0 aW1lcyB0aW1lcyBvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4ODU4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1wYXVzZS5odG1sOgorICAgICAgICAq IGluc3BlY3Rvci93b3JrZXIvcmVzb3VyY2VzL3dvcmtlci11dGlsaXRpZXMuanM6IEFkZGVkLgor ICAgICAgICAoVGVzdFBhZ2UucmVnaXN0ZXJJbml0aWFsaXplci53aW5kb3cuYXdhaXRUYXJnZXRN YWluUmVzb3VyY2UpOgorICAgICAgICAoVGVzdFBhZ2UucmVnaXN0ZXJJbml0aWFsaXplcik6Cisg ICAgICAgIFVzZSBhIG1vcmUgZGV0ZXJtaW5pc3RpYyB3YWl0IGZvciB0aGUgbWFpbiByZXNvdXJj ZS4KKwogMjAxOC0wOC0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFttYWNPUyBkZWJ1Z10gTGF5b3V0VGVzdCBpbnNwZWN0b3Ivd29ya2VyL3Jlc291 cmNlcy1pbi13b3JrZXIuaHRtbCBpcyBhIGZsYWt5IHRpbWVvdXQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvZGVidWdnZXItcGF1c2UuaHRtbCBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci93b3JrZXIvZGVidWdnZXItcGF1c2UuaHRtbAppbmRleCAwZGU1MTM0YTM0ZC4u OGY0NDI1ZTAzNjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvZGVi dWdnZXItcGF1c2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivd29ya2VyL2RlYnVn Z2VyLXBhdXNlLmh0bWwKQEAgLTMsNiArMyw3IEBACiA8aGVhZD4KIDxzY3JpcHQgc3JjPSIuLi8u Li9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvaW5zcGVjdG9yLXRlc3QuanMiPjwvc2Ny aXB0PgogPHNjcmlwdCBzcmM9Ii4uL2RlYnVnZ2VyL3Jlc291cmNlcy9sb2ctcGF1c2UtbG9jYXRp b24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy93b3JrZXItdXRpbGl0aWVz LmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CiBUZXN0UGFnZS5hbGxvd1VuY2F1Z2h0RXhjZXB0aW9u cyA9IHRydWU7CiBUZXN0UGFnZS5uZWVkVG9TYW5pdGl6ZVVuY2F1Z2h0RXhjZXB0aW9uVVJMcyA9 IHRydWU7CkBAIC0xMTEsOCArMTEyLDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIH0KICAg ICB9KTsKIAotICAgIC8vIFR1cm4gb25jZSB0byBlbnN1cmUgd29ya2VyVGFyZ2V0Lm1haW5SZXNv dXJjZSBpcyBsb2FkZWQuCi0gICAgUHJvbWlzZS5yZXNvbHZlKCkudGhlbigoKSA9PiB7CisgICAg YXdhaXRUYXJnZXRNYWluUmVzb3VyY2Uod29ya2VyVGFyZ2V0KS50aGVuKCgpID0+IHsKICAgICAg ICAgd2luZG93LmxvYWRMaW5lc0Zyb21Tb3VyY2VDb2RlKHdvcmtlclRhcmdldC5tYWluUmVzb3Vy Y2UpLnRoZW4oKCkgPT4gewogICAgICAgICAgICAgc3VpdGUucnVuVGVzdENhc2VzQW5kRmluaXNo KCk7CiAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3dvcmtl ci9yZXNvdXJjZXMvd29ya2VyLXV0aWxpdGllcy5qcyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci93 b3JrZXIvcmVzb3VyY2VzL3dvcmtlci11dGlsaXRpZXMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAuLmFlMTdhYTNjOTI0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL3dvcmtlci9yZXNvdXJjZXMvd29ya2VyLXV0aWxpdGllcy5qcwpAQCAt MCwwICsxLDcgQEAKK1Rlc3RQYWdlLnJlZ2lzdGVySW5pdGlhbGl6ZXIoKCkgPT4geworICAgIHdp bmRvdy5hd2FpdFRhcmdldE1haW5SZXNvdXJjZSA9IGZ1bmN0aW9uKHdvcmtlclRhcmdldCkgewor ICAgICAgICBpZiAod29ya2VyVGFyZ2V0Lm1haW5SZXNvdXJjZSkKKyAgICAgICAgICAgIHJldHVy biBQcm9taXNlLnJlc29sdmUoKTsKKyAgICAgICAgcmV0dXJuIHdvcmtlclRhcmdldC5hd2FpdEV2 ZW50KFdJLlRhcmdldC5FdmVudC5NYWluUmVzb3VyY2VBZGRlZCk7CisgICAgfQorfSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL0NoYW5nZUxvZwppbmRleCBlZjk0ZDRiNWU1MC4uNzFiOWY5NmY2YTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTE0ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBpbnNwZWN0 b3Ivd29ya2VyL2RlYnVnZ2VyLXBhdXNlLmh0bWwgc29tZXRpbWVzIHRpbWVzIG91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NTgwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1Byb3RvY29sL1RhcmdldC5qczoKKyAgICAgICAgKFdJLlRhcmdldC5wcm90b3R5cGUuZ2V0IG1h aW5SZXNvdXJjZSk6CisgICAgICAgIChXSS5UYXJnZXQucHJvdG90eXBlLnNldCBtYWluUmVzb3Vy Y2UpOgorICAgICAgICBEaXNwYXRjaCBhbiBldmVudCB3aGVuIHRoZSBNYWluIFJlc291cmNlIGlz IHNldC4KKwogMjAxOC0wOC0xMiAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+ CiAKICAgICAgICAgW21hY09TXSBDb2xvciB3ZWxscyBzaG91bGQgYXBwZWFyIHByZXNzZWQgd2hl biBwcmVzZW50aW5nIGEgY29sb3IgcGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9UYXJnZXQuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9UYXJnZXQuanMKaW5kZXggMmQ0Y2YxMzEwMGUu LjkyZDEzZmNmNWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Qcm90b2NvbC9UYXJnZXQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvUHJvdG9jb2wvVGFyZ2V0LmpzCkBAIC01Niw5ICs1Niw2IEBAIFdJLlRhcmdldCA9 IGNsYXNzIFRhcmdldCBleHRlbmRzIFdJLk9iamVjdAogICAgIGdldCBuYW1lKCkgeyByZXR1cm4g dGhpcy5fbmFtZTsgfQogICAgIHNldCBuYW1lKG5hbWUpIHsgdGhpcy5fbmFtZSA9IG5hbWU7IH0K IAotICAgIGdldCBtYWluUmVzb3VyY2UoKSB7IHJldHVybiB0aGlzLl9tYWluUmVzb3VyY2U7IH0K LSAgICBzZXQgbWFpblJlc291cmNlKHJlc291cmNlKSB7IHRoaXMuX21haW5SZXNvdXJjZSA9IHJl c291cmNlOyB9Ci0KICAgICBnZXQgdHlwZSgpIHsgcmV0dXJuIHRoaXMuX3R5cGU7IH0KICAgICBn ZXQgY29ubmVjdGlvbigpIHsgcmV0dXJuIHRoaXMuX2Nvbm5lY3Rpb247IH0KICAgICBnZXQgZXhl Y3V0aW9uQ29udGV4dCgpIHsgcmV0dXJuIHRoaXMuX2V4ZWN1dGlvbkNvbnRleHQ7IH0KQEAgLTY4 LDYgKzY1LDIwIEBAIFdJLlRhcmdldCA9IGNsYXNzIFRhcmdldCBleHRlbmRzIFdJLk9iamVjdAog CiAgICAgZ2V0IGRpc3BsYXlOYW1lKCkgeyByZXR1cm4gdGhpcy5fbmFtZTsgfQogCisgICAgZ2V0 IG1haW5SZXNvdXJjZSgpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5fbWFpblJlc291cmNl OworICAgIH0KKworICAgIHNldCBtYWluUmVzb3VyY2UocmVzb3VyY2UpCisgICAgeworICAgICAg ICBjb25zb2xlLmFzc2VydCghdGhpcy5fbWFpblJlc291cmNlKTsKKworICAgICAgICB0aGlzLl9t YWluUmVzb3VyY2UgPSByZXNvdXJjZTsKKworICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xp c3RlbmVycyhXSS5UYXJnZXQuRXZlbnQuTWFpblJlc291cmNlQWRkZWQsIHtyZXNvdXJjZX0pOwor ICAgIH0KKwogICAgIGFkZFJlc291cmNlKHJlc291cmNlKQogICAgIHsKICAgICAgICAgdGhpcy5f cmVzb3VyY2VDb2xsZWN0aW9uLmFkZChyZXNvdXJjZSk7CkBAIC05OCw2ICsxMDksNyBAQCBXSS5U YXJnZXQuVHlwZSA9IHsKIH07CiAKIFdJLlRhcmdldC5FdmVudCA9IHsKKyAgICBNYWluUmVzb3Vy Y2VBZGRlZDogInRhcmdldC1tYWluLXJlc291cmNlLWFkZGVkIiwKICAgICBSZXNvdXJjZUFkZGVk OiAidGFyZ2V0LXJlc291cmNlLWFkZGVkIiwKICAgICBTY3JpcHRBZGRlZDogInRhcmdldC1zY3Jp cHQtYWRkZWQiLAogfTsK